Commit Graph

406 Commits

Author SHA1 Message Date
Ilia Ross
ce07147547 Fix ACL path enforcement in File Manager
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-09-11 23:41:04 +02:00
Ilia Ross
0951ddfe87 Fix File Manager strict permission checks 2026-09-10 23:27:19 +02:00
Ilia Ross
75e793ca0f Fix Filemin paste to show real copy and move errors
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ Run cp and mv through backquote_logged and capture their stderr, so the actual command error is shown instead of an unrelated $! value.

https://github.com/webmin/webmin/issues/2834
2026-09-05 17:04:12 +02:00
KafamaG
02ca56139a Complete the Turkish module.info descriptions
Every module now has a reviewed desc_tr and longdesc_tr in
module.info.tr - 245 strings across 125 modules. Previously 37 were
reviewed, 194 came from module.info.tr.auto and 14 were missing
entirely (grub2, hardware-info, kea-dhcp, logviewer, nftables, systemd,
xterm), so those modules showed English titles in the Webmin menu.

The reviewed strings are removed from module.info.tr.auto, which now
holds only name_tr - the same split the de and ca translations use.
Thirty-six of those files became empty and are deleted.

Some of the machine text this replaces was wrong rather than just
clumsy:

  sarg          "Squid Report Generator" had become "Kalamar Rapor
                Oluşturucu" - the fish, not the proxy
  heartbeat     the product name was translated as "Kalp Atışı"
  cluster-cron  "Cron Jobs" had become "Cron İş İlanları" (job ads)
  proc          "renice" was translated as "rename"
  samba         "file and print shares" was split into "create a samba
                file" and "print the shares"
  exports, hpuxexports, sgiexports, inetd, init, mount, net
                each repeated the file path mid-sentence
  firewall,     the "(iptables)" and "(ip6tables)" qualifiers that
  firewall6     distinguish the two modules were dropped

Turkish capitalisation of English words was also wrong throughout
("İptables", "İnetd", "İscsitarget", "İnternet"), and three previously
reviewed strings were stored as double-encoded UTF-8 (cron/desc_tr,
mailboxes/desc_tr, mailboxes/longdesc_tr).

cluster-cron and ldap-server carried a stray desc_de_tr key - a German
key that had leaked into the Turkish file. It is removed.
2026-08-30 14:41:10 +03:00
KafamaG
fe34aa9a38 Translate ldap-client, dovecot, filemin and package-updates to Turkish
Adds complete lang/tr files for four more previously untranslated
modules and removes their machine-generated lang/tr.auto files:

  ldap-client      226 strings - NSS/PAM LDAP client setup and NSS switch
  dovecot          188 strings - Dovecot IMAP/POP3 server configuration
  filemin          185 strings - file manager UI
  package-updates  176 strings - package update checking and repositories

Product names are deliberately left untranslated where Turkish has no
established equivalent: "Novell Directory Services", "Active Directory",
"System Security Services", "Hesiod", "XFN", "VPOPMail", "Blastwave".
Protocol, format and command names (IMAP, POP3, LMTP, SASL, Maildir,
mbox, dbox, chmod, chown, chattr, setfacl, umask, tar.gz) also stay in
English, matching the rest of the Turkish translation.
2026-08-30 14:04:26 +03:00
Ilia Ross
99f35fa38a Fix to move URL download destination controls to global ACL 2026-07-14 02:52:36 +02:00
Ilia Ross
934073532f Fix to use the existing HTTP and FTP mode 7 callback 2026-07-14 02:27:10 +02:00
Ilia Ross
dae0bf373d Fix ACL page elements order and placement 2026-07-13 14:08:25 +02:00
Ilia Ross
1555224592 Fix to refactor download address checks to use callback bundles
ⓘ Extend HTTP and FTP download callbacks with destination validation while preserving legacy tracking callbacks and enforcing SSRF policy across redirects, proxies, caches, and direct/passive sockets.

https://github.com/webmin/webmin/pull/2789#discussion_r3567985773
2026-07-13 13:36:34 +02:00
Ilia Ross
d5b2a174c2 Fix to rely on defaultacl 2026-07-12 19:35:03 +02:00
Ilia Ross
1ca52c9a97 Add ACL controls for URL download destinations
Block non-public HTTP, HTTPS and FTP destinations by default in File Manager, Mailboxes and Upload and Download, with per-user IP/CIDR exceptions, redirect and proxy protection, cache isolation, and current-ACL enforcement for scheduled jobs.
2026-07-12 14:57:08 +02:00
Ilia Ross
04ae776e6a Fix to validate action paths
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Validate File Manager action name/file parameters as checked paths under the current directory and `allowed_paths` before operations, blocking traversal and symlink escapes.
2026-05-12 01:25:57 +02:00
Ilia Ross
7cab23a3ea Fix to validate upload paths before writing
* Note: Canonicalize and check uploaded file and directory-upload paths against `allowed_paths` before creating directories or writing files, preventing traversal outside the File Manager ACL sandbox.
2026-05-12 00:05:02 +02:00
Ilia Ross
948f5bfd77 Fix to make MML files editable
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2671
2026-04-21 21:16:55 +02:00
Ilia Ross
0e45e0bcbd Update translations consistency
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2655
2026-04-09 00:11:17 +02:00
Ilia Ross
bdb98c49c9 Fix language
https://github.com/webmin/webmin/issues/2655
2026-04-09 00:08:07 +02:00
Ilia Ross
9369441fc5 Fix to avoid auto-fill for URL auth
https://github.com/webmin/webmin/issues/2655
2026-04-09 00:07:08 +02:00
Ilia Ross
77e488b4b6 filemin: reindent and add function comments 2026-04-08 19:53:49 +02:00
Ilia Ross
26faad0d39 Fix regression in previous refactor
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-04-08 17:45:15 +02:00
Ilia Ross
886cf142db Fix indent (more) 2026-04-08 17:31:51 +02:00
Ilia Ross
d4439b445c Fix indent 2026-04-08 17:16:54 +02:00
Ilia Ross
5a336902f8 Add vars declarations 2026-04-08 17:09:16 +02:00
Jamie Cameron
b5b65f06b7 Factor out function to get allowed paths 2026-04-08 06:24:32 -07:00
Ilia Ross
8957333dca Fix not to quotemeta hardcoded flag #2159 2025-10-05 01:17:28 +03:00
Ilia Ross
695c78f631 Fix previously broken Farsi translations 2025-05-30 21:36:00 +03:00
Ilia Ross
62c02d1273 Add TOML as editable by default #2438 2025-03-20 03:23:33 +02:00
Ilia Ross
f880192526 Remove languages with 0% coverage
https://github.com/webmin/webmin/issues/2403#issuecomment-2652613588
2025-02-12 13:19:49 +02:00
MacSteini
5ea0cc6b42 Trailing Spaces Removal
Removed trailing spaces
2024-12-16 15:16:55 +00:00
MacSteini
64598e5f39 Blanks Removal
Removed blanks before or after the equal sign
2024-12-16 12:59:19 +00:00
MacSteini
df928c5487 Update de 2024-11-30 11:26:47 +00:00
MacSteini
6c573f0251 Updated de
Corrections (UTF-8, new lines at file end), amendments, updates
2024-11-30 11:24:13 +00:00
Ilia Ross
d82d31f92a Update translations (proftpd,filemin) 2024-11-29 15:12:53 +02:00
Ilia Ross
d2db00a5d1 Add ability to control strict user ownership check #2300 2024-11-28 21:14:58 +02:00
Ilia Ross
83457fe4c0 Fix to test if delete, rename, paste and save is allowed #2300 2024-11-28 00:48:54 +02:00
Ilia Ross
4a9ed9e8ab Update translations 2024-11-16 13:07:43 +02:00
Ilia Ross
a5be6dc02a Update Polish translations (File Manager) 2024-11-16 12:41:01 +02:00
MacSteini
a0da37ca08 Updated de 2024-10-07 15:08:23 +01:00
leangjia
0c408cf7e7 Updated Chinese translations.
Happy Mid-autumn Festival.
2024-09-11 14:27:37 +08:00
leangjia
1764671ac7 Delete the zh.auto 2024-09-03 18:18:44 +08:00
leangjia
d02615c0ab Updated Chinese translations filemin lang zh. 2024-09-03 14:14:05 +08:00
Jamie Cameron
da5c68a04f Add ACL option to set the allowed user based on the directory being accessed 2024-08-30 22:10:52 -07:00
Ilia Ross
6a521ea32c Fix some experimental MIME types are now recognized #2147 2024-05-05 23:28:01 +03:00
Ilia Ross
4e5da791e2 Fix to limit input to 4 numbers https://github.com/webmin/webmin/issues/2138#issuecomment-2079609477 [build] 2024-04-26 18:39:46 +03:00
Mr-Method
4126264a63 dev/translation_uk/filemin
translated with wbmtranslator 0.9.2 (fixed)
2024-04-17 01:47:59 +03:00
Ilia Ross
ef7dbb1f77 Fix to support hiding dot-files in File Manager 2023-09-29 00:21:50 +03:00
Ilia Ross
fbabecbe9e Fix support for new ZSTD and XZ formats 2023-09-24 22:12:59 +03:00
Ilia Ross
7706c0795e Add XZ and ZSTD compression ; add plain TAR archives 2023-09-24 21:21:08 +03:00
iliajie
c4fdb9524f Fix to revert accidentally stomped changes in PR #1910 2023-05-23 13:58:48 +03:00
iliajie
fc0efe9ed5 Revert "master-branch accidental merge"
This reverts commit 3996ff205f.
2023-05-22 12:31:12 +03:00
iliajie
1df55f32eb Add x-source-rpm image 2023-05-21 21:47:01 +03:00