Commit Graph

147 Commits

Author SHA1 Message Date
Jamie Cameron
6365b6bdcd German translation updates from Raymond Vetter 2017-06-01 23:16:52 -07:00
Jamie Cameron
f6320c27e2 Merge pull request #563 from qooob/patch-17
`en.UTF8` -> `en` for the upcoming 1.841 to satisfy compiler
2017-06-01 14:49:06 -04:00
Jamie Cameron
7b272988e8 Add missed error message 2017-05-31 22:28:14 -07:00
Jamie Cameron
2ee32e71cf Code cleanups 2017-05-31 18:52:38 -07:00
Jamie Cameron
5b0606c9fc Set correct ownership on compressed files 2017-05-31 15:05:20 -07:00
Jamie Cameron
06752583db Add some missing escaping 2017-05-31 14:43:10 -07:00
Jamie Cameron
0d1f01d511 Upload new files with correct ownership, and fix some formatting errors 2017-05-31 14:29:28 -07:00
Jamie Cameron
f93251569b Clean up code, and set correct owner on downloaded files 2017-05-30 21:56:39 -07:00
Jamie Cameron
40db0575f6 Create new files with same ownership as parent (and add some missing escaping) 2017-05-29 16:16:14 -07:00
Jamie Cameron
1a99e197dc Create new dirs with same ownership as parent 2017-05-29 16:07:03 -07:00
Jamie Cameron
01b0a01f90 Catalan updates from Jaume Badiella 2017-05-18 21:07:26 -07:00
Jamie Cameron
8ca3de3c28 Use safe write function, and simplify error handling 2017-05-16 23:16:46 -07:00
Jamie Cameron
817244241a Filename needs escaping 2017-05-16 23:11:36 -07:00
Ilia Rostovtsev
de2a5e9ff2 en.UTF8 -> en for the upcoming 1.841 to satisfy compiler 2017-05-16 18:19:07 +03:00
Jamie Cameron
ea69c0978b German translation updates from Raymond Vetter 2017-05-14 21:01:50 -07:00
Kay Marquardt
f814546239 adjust german translation 2017-05-14 15:09:54 +02:00
Kay Marquardt
191827e425 Create config.info.de.UTF-8 2017-05-14 15:08:38 +02:00
Kay Marquardt
9fef0d060b german translation 2017-05-14 15:06:06 +02:00
Kay Marquardt
acc9f93fef german translations converted from UTF-8 2017-05-14 14:03:38 +02:00
Kay Marquardt
add5d65a6b Merge branch 'patch-1' into patch-2 2017-05-12 22:54:42 +02:00
Kay Marquardt
55db94413b fix my typos 2017-05-12 22:52:51 +02:00
Kay Marquardt
f21e731422 adjust translations to autehtic-theme translations 2017-05-12 22:50:27 +02:00
Jamie Cameron
04c217c97a Prevent same allowed path being listed twice 2017-05-06 11:41:08 -07:00
Jamie Cameron
e787caf228 Fix path validation when saving files https://github.com/webmin/webmin/issues/548 2017-05-06 11:24:31 -07:00
Jamie Cameron
814cf262fe Merge pull request #547 from qooob/patch-16
Check for valid encoding
2017-05-05 10:07:39 -07:00
Ilia Rostovtsev
944b6d728c Check for valid encoding
There are cases when detected `$encoding_name` is not recognized by `decode()` subroutine leading to fatal error.
2017-05-04 15:39:09 +03:00
Ilia Rostovtsev
59b59b2e43 Let non-unicode users read files in their charset correctly + check for valid encoding
In case a user still have old, non-UTF8 setup, they still need to see files in their encoding correctly, thus without converting output to utf-8. The way it is now, breaks things.

Also, there are cases when detected `$encoding_name` is not recognized by `decode()` subroutine.
2017-05-04 15:36:42 +03:00
Jamie Cameron
77c84a7539 Handle case where encoding module is missing 2017-05-03 20:43:38 -07:00
Jamie Cameron
9716326acd Merge pull request #543 from qooob/patch-13
Make editor respect file's initial encoding: Viewer
2017-05-03 20:41:25 -07:00
Ilia Rostovtsev
85e80edf91 Make editor respect file's initial encoding: Saver
An addition to `edit_file.cgi` commit.
2017-05-02 13:26:30 +03:00
Ilia Rostovtsev
8e44c145b9 Make editor respect file's initial encoding: Viewer
This patch will make sure that user, will be able to READ files with different encodings properly and also, will be able to SAVE them without changing the initial encoding.

This awesomeness requires dependencies. However, RHEL has it installed by default but not Debian. New Webmin release should make sure to require/pull dependent packages:

For RHEL: `perl-Encode-Detect`
For Debian: `libencode-detect-perl`

P.S. We should no let user to set non-UTF8 locale anymore. All languages should be displayed unambiguously, like Google does, (Русский, svenska, Deutsche, English (United States) .. ).
2017-05-02 13:23:34 +03:00
Ilia Rostovtsev
b91a867744 For the future so user could choose encoding in file editor window
I think I did it correctly, theoretically looks good. I just don't know if `$in{'encoding'}` has to be escaped anyhow. Other than that, it seems ok, as when user passes encoding, it will tell the script to use one.
2017-05-01 20:49:17 +03:00
Ilia Rostovtsev
6bb5b79d80 Typo, missing ; 2017-05-01 20:12:29 +03:00
Ilia Rostovtsev
edd32a0819 Here is the fix for folks not using UTF-8 #52019
This is more like server side thing.

We expect that everything that is coming from the editor (CodeMirror) is always UTF-8 encoded. In case, global encoding is set to something different, then UTF-8, we must use the user encoding to properly encode the data and have correct file encoding after all.

[#52019](https://www.virtualmin.com/node/52019)
2017-05-01 20:04:27 +03:00
Jamie Cameron
0d251ff103 Merge pull request #536 from qooob/patch-9
To look consistent in Account Functions in Usermin
2017-04-25 17:10:22 -07:00
Jamie Cameron
801a71d172 Merge pull request #344 from qooob/patch-30
Respect module info
2017-04-25 16:55:24 -07:00
Ilia Rostovtsev
d5aac92059 To look consistent in Account Functions in Usermin
Just to beautify the string to look like the rest of them in `Account Functions`.
2017-04-25 14:10:19 +03:00
Jamie Cameron
cb2d221508 Merge pull request #476 from qooob/patch-2
Enable editor for .XSL files
2017-04-17 18:19:54 -07:00
Ilia Rostovtsev
2ff3afea6a path in bookmarks must be URI friendly 2017-04-16 09:37:49 +03:00
Jamie Cameron
34dbddd616 Check allowed paths in some more cases 2017-04-11 10:38:04 -07:00
Jamie Cameron
25a471e4ef simplify_path returns a new path 2017-04-10 15:23:34 -07:00
Jamie Cameron
0372fdcc2c German translation updates from Raymond Vetter 2017-03-26 09:37:54 -07:00
Jamie Cameron
4f1b8c0ae0 Add missing string 2017-03-20 17:00:22 -07:00
Jamie Cameron
d0b19dbb75 Fix more unescaped paths 2017-03-16 22:54:36 -07:00
Jamie Cameron
7fa58e88c1 Don't trust path elements 2017-03-15 23:22:47 -07:00
Jamie Cameron
c7a941c9af Fix bug where a sub-directory with the same name cannot be linked to 2017-03-10 19:05:07 -08:00
Jamie Cameron
47611a5fb7 German translation updates from Raymond Vetter 2017-03-08 22:16:20 -08:00
Jamie Cameron
2cf8380a52 Fix typo 2017-03-08 22:14:01 -08:00
Jamie Cameron
2b2b2d55e7 Clarifiy meaning of filemanger ACL 2017-03-08 22:08:11 -08:00
Jamie Cameron
dbd99caaee Path needs to be escaped in footer 2017-02-19 17:30:10 -08:00