Commit Graph

727 Commits

Author SHA1 Message Date
KafamaG
78b728a531 Merge branch 'master' into dev/translation_tr
#2829 landed on master and touched 173 of the same keys this branch
rewrites, which is where the conflicts came from.

Resolved by rule rather than by hand: for any key #2829 already fixed
and merged, master's value wins (54 keys); everything else keeps this
branch's version. That keeps the diff against master limited to what is
genuinely new here, and avoids re-editing work that is already upstream.

It also avoids a regression. This branch was cut before #2829, so it
still carried the old double-encoded UTF-8 in nine mailboxes strings
(confirm_warnallf, left_autoreply, left_folders, left_forward,
left_pass, left_sig, mail_fromfilter, mail_selread, mail_subfilter).
Taking master's value for those keeps them fixed. A mojibake scan over
the whole tree after the merge reports 0 remaining lines.

master also added acl/forgot_sudouser, which is translated here, so
lang/tr is still complete at 31,523 of 31,523 keys.
2026-08-31 09:51:50 +03:00
KafamaG
02ca56139a Complete the Turkish module.info descriptions
Every module now has a reviewed desc_tr and longdesc_tr in
module.info.tr - 245 strings across 125 modules. Previously 37 were
reviewed, 194 came from module.info.tr.auto and 14 were missing
entirely (grub2, hardware-info, kea-dhcp, logviewer, nftables, systemd,
xterm), so those modules showed English titles in the Webmin menu.

The reviewed strings are removed from module.info.tr.auto, which now
holds only name_tr - the same split the de and ca translations use.
Thirty-six of those files became empty and are deleted.

Some of the machine text this replaces was wrong rather than just
clumsy:

  sarg          "Squid Report Generator" had become "Kalamar Rapor
                Oluşturucu" - the fish, not the proxy
  heartbeat     the product name was translated as "Kalp Atışı"
  cluster-cron  "Cron Jobs" had become "Cron İş İlanları" (job ads)
  proc          "renice" was translated as "rename"
  samba         "file and print shares" was split into "create a samba
                file" and "print the shares"
  exports, hpuxexports, sgiexports, inetd, init, mount, net
                each repeated the file path mid-sentence
  firewall,     the "(iptables)" and "(ip6tables)" qualifiers that
  firewall6     distinguish the two modules were dropped

Turkish capitalisation of English words was also wrong throughout
("İptables", "İnetd", "İscsitarget", "İnternet"), and three previously
reviewed strings were stored as double-encoded UTF-8 (cron/desc_tr,
mailboxes/desc_tr, mailboxes/longdesc_tr).

cluster-cron and ldap-server carried a stray desc_de_tr key - a German
key that had leaked into the Turkish file. It is removed.
2026-08-30 14:41:10 +03:00
KafamaG
35069d3018 Fix placeholder, markup and encoding defects in existing Turkish files
A consistency check of every lang/tr against its lang/en turned up 58
lines that were wrong independently of the missing translations. All of
them are fixed here:

Missing or wrong $N placeholders (the value silently disappears from
the message at runtime, or the wrong value is shown):
  acl/cert_eca, acl/hide_desc, adsl-client/index_stopdesc,
  apache/reconfig_ever, apache/log_files, apache/log_files_l,
  bind8/log_manual, dhcpd/listl_lfnotcont, fdisk/mkfs_desc1,
  fdisk/fsck_desc1, fdisk/tunefs_desc, hpuxexports/save_ehost,
  inittab/log_rename, mysql/index_ever, mysql/index_version,
  mysql/log_perm_create, mysql/log_perm_delete, mysql/log_perm_modify,
  sendmail/index_epath, sendmail/index_startmsg, sendmail/asave_ematch,
  sendmail/mailers_efile, sendmail/generics_efile,
  webalizer/index_ewebalizer, webalizer/index_econf

  cron/env_ename carried a $1 that lang/en does not have, and its text
  described a different error than the key means.

  adsl-client/index_stopdesc and inittab/log_rename each repeated $1
  where $2 was meant, so both values printed the same string.

HTML markup that did not match lang/en:
  bind8/mass_desc, dhcpd/index_dhcpdnotfound, firewall/index_existing,
  inetd/index_applymsg, mysql/index_nomod, mysql/index_nomods,
  samba/esync_msg, samba/viewu_list, sendmail/trusts_desc,
  sendmail/mailers_desc2, sendmail/domains_desc, squid/clear_msgclear,
  status/proc_thresh

  Several of these were also truncated mid-sentence, dropping a whole
  sentence of the original text; those are now translated in full.

Encoding:
  mailboxes/confirm_warnf was stored as double-encoded UTF-8 and
  displayed as mojibake. It also used $1 twice instead of $1 and $2.

Trailing whitespace:
  proc/kill_term, kill_hup, kill_stop, kill_cont

Untranslated strings:
  fdisk/select_* device descriptions, mount/irix_mode0, irix_mode0cd,
  shorewall/tunnels_ipsec:noah

  bind8/mass_desc previously translated the literal configuration
  keywords master, slave, stub and forward into Turkish; they are now
  left in English, since they are values the user has to type.
2026-08-30 14:34:56 +03:00
KafamaG
43038d06b8 Complete the Turkish translation for the mysql module
Adds the 504 strings that mysql/lang/tr was missing, so the module is now
fully translated, and removes mysql/lang/tr.auto.

114 of the new strings are shared verbatim with the postgresql module and
reuse its translation; as elsewhere, reuse required the two lang/en values
to be byte-identical, which excluded 57 keys whose English differs.

MySQL identifiers stay in English: my.cnf, the [mysqld] section, MYSQL_PWD,
.my.cnf, InnoDB, MyISAM, mysql-bin, SQL mode, X509 and the compatibility
target names (ANSI, Oracle, DB2, MaxDB and so on).
2026-08-30 02:29:14 +03:00
KafamaG
666ff552fa Fix errors in Turkish (tr) language files
Corrects verifiable defects in the shipped Turkish translations across
25 modules. No .auto (machine-translated) files are touched.

Placeholder bugs (33 keys) - substitution variables were missing,
duplicated or renumbered relative to lang/en:

* fdisk/mkfs_desc1 used $1 twice, so the "all data will be permanently
  erased" confirmation named the filesystem type instead of the target
  device.
* apache/reconfig_ever linked to <a href='$1'> instead of $2, pointing
  the "module configuration" link at the version string.
* useradmin/export_eopen contained the Perl special variable $! rather
  than $1.
* adsl-client/index_stopdesc, inittab/log_rename, hpuxexports/save_ehost,
  mysql/log_perm_* and others repeated $1 where $2/$3 was intended.
* cron/env_ename referenced $1, which lang/en does not provide.

HTML markup bugs (19 keys) - tags were dropped or swapped, breaking
rendering or links:

* useradmin/batch_desc6 and batch_desc3 contained the literal strings
  "$batch_desc1" and "$batch_desc0" and rendered as plain text.
* bind8/mass_desc translated the literal named.conf keywords master,
  slave, stub and forward, which would lead users to enter invalid
  configuration values. These are now left untranslated.
* mysql/index_nomod, samba/esync_msg, squid/clear_msgclear and others
  lost <tt>/<b> pairs present in lang/en.

Encoding (10 keys) - mailboxes/lang/tr contained double-encoded UTF-8
(mojibake), e.g. "klasöründen" instead of "klasöründen".

Untranslated strings (96 keys) - htaccess-htpasswd/lang/tr was a verbatim
copy of lang/en and is now fully translated. Remaining English strings in
fdisk, mount, shorewall, webalizer, xinetd and firewall are translated.
Technical identifiers (LVM VG/LV, IPsec AH) are deliberately kept in
English.

All modified files are valid UTF-8, keep their original key order and
line count, and their placeholders now match lang/en exactly.
2026-08-30 01:20:42 +03:00
Ilia Ross
7f237871ba Add shared server section lookup
https://github.com/webmin/webmin/pull/2827#pullrequestreview-5047577760
2026-08-28 14:46:07 +02:00
Ilia Ross
4e6ba5229e Fix binary log retention limit on MariaDB 2026-08-28 02:46:40 +02:00
Ilia Ross
b3b81af34f Add MySQL binary log management
This PR adds a "Binary Logging" page to configure log format, file size and retention, rotate or purge logs, and support restore sessions that do not write back to binary logs.
2026-08-28 02:16:50 +02:00
Jamie Cameron
fd07e5040a Actually check ACL for starting and stopping mysql 2026-08-03 10:35:30 -07:00
Ilia Ross
a13461f9c1 Fix to respect global file ACLs for server-local imports
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ Centralize global file ACL checks for server-local reads and applies them to batch, LDAP batch, MySQL, and PostgreSQL local import and restore flows. Files are read under the configured `fileunix` identity and staged with the correct command-user ownership, preventing constrained Webmin users from bypassing `root`, `otherdirs`, or `fileunix`.

9ceffce70f (r191495975)
2026-07-07 12:39:35 +02:00
itamarperdomo
ed5bc3e4b6 Improve alpine mysql/mariadb default support
* The MySQL module in Alpine it lacks default values. This change
uses the necessary values ​​for the module to function.
* These values ​​work for any version of Alpine Linux from 3.8
to Edge, since MariaDB is and always has been the default package.
* The tools server package was included in the package instalation
* Missing changelog entries were included
2026-06-11 11:50:56 -04:00
Ilia Ross
413087ae84 Fix MariaDB create user auth plugin syntax
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Use MariaDB-compatible IDENTIFIED VIA ... USING PASSWORD(...) syntax when creating users with an explicit authentication plugin, while preserving default password creation and MySQL behavior.

https://forum.virtualmin.com/t/mariadb-syntax-change-on-rocky-10/137187
2026-05-13 02:20:42 +02:00
Ilia Ross
8eb0868574 Fix to install correct MariaDB config on Ubuntu 26.04
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-01 21:52:05 +02:00
Ilia Ross
f8bdac8e90 Add support for modern (Ubuntu 26.04) MariaDB
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Recognize mariadbd option groups and binaries in MySQL config, SSL, syslog, and safe-mode command discovery while preserving existing mysqld/mariadb compatibility.
2026-04-30 21:47:57 +02:00
Ilia Ross
68aab1c057 Fix to use proper API for ACL pages
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
[no-build]
2026-04-23 22:07:13 +02:00
Ilia Ross
3bd85ab407 Add multi-statement SQL script support when executing inline script
https://forum.virtualmin.com/t/edit-databases-sql-query-box-strange-behavior/136988

[no-build]
2026-04-14 23:02:15 +02:00
Jamie Cameron
19b0f187ba The [mysqld] section may be [mariadb]
https://github.com/webmin/webmin/issues/2650
2026-04-08 08:06:52 -07:00
Ilia Ross
2c82255179 Fix MySQL save handlers with parameterized SQL deletes (#8) 2026-03-10 17:29:17 +02:00
Ilia Ross
f10385417c Fix typo
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-02-27 12:09:25 +02:00
Ilia Ross
a0c023637f Fix to improve the message when socket auth is used 2026-01-10 20:44:59 +02:00
Ilia Ross
6721e13a6b Fix MariaDB version 10.3 already supports plugins 2026-01-10 20:31:47 +02:00
Jamie Cameron
8a8d1bc12f use has to be inside a string eval 2025-12-17 21:47:58 -08:00
Ilia Ross
03379b0052 Add ability to use correct driver depending on the database 2025-12-16 13:56:27 +02:00
Jamie Cameron
86a27eff18 Check for and use DBD::MariaBB as well
https://forum.virtualmin.com/t/webmin-2-6-not-available-yet/135883/45
2025-12-15 17:10:27 -08:00
Ilia Ross
f55515fdb0 Revert "Fix to support installing missing Perl modules using package manager"
This reverts commit 9bce05f48a.
2025-12-14 19:53:42 +02:00
Ilia Ross
ebefe283fd Revert "Add FreeBSD package names"
This reverts commit f4e573278d.
2025-12-14 19:53:33 +02:00
Ilia Ross
f4e573278d Add FreeBSD package names 2025-12-11 09:44:35 +02:00
Ilia Ross
9bce05f48a Fix to support installing missing Perl modules using package manager 2025-12-10 18:57:14 +02:00
Ilia Ross
00adb84d69 Revert "Fix to explicitly set no auto-reconnect"
This reverts commit 9ba627e461.
2025-12-09 00:53:48 +02:00
Ilia Ross
9ba627e461 Fix to explicitly set no auto-reconnect
https://forum.virtualmin.com/t/webmin-2-6-not-available-yet/135883/10?u=ilia
2025-12-07 15:04:42 +02:00
Ilia Ross
2051bfe6dc Fix button name consistency
[no-build]
2025-11-08 18:26:18 +02:00
Jamie Cameron
48c5fc2138 System variables use _, but command line variables use -
https://github.com/webmin/webmin/issues/2568
2025-10-12 21:47:40 -07:00
Jamie Cameron
f0f4f72d73 Add UI options for enabling the slow query log
https://github.com/webmin/webmin/issues/2560
2025-10-12 18:04:16 -07:00
Ilia Ross
4c6ffd19a4 Add support for MariaDB 15 in Debian 13 2025-09-04 00:56:45 +03:00
Ilia Ross
4c2fde6847 Fix to test if database supports account locking correctly 2025-08-13 21:20:25 +03:00
Ilia Ross
9065de316a Fix not to fail on MySQL 5.5
99889c1f30 (commitcomment-163892642)
2025-08-13 11:11:09 +03:00
Jamie Cameron
5aba173111 Support MariaBD version 12
https://github.com/webmin/webmin/issues/2522
2025-08-05 13:28:03 -07:00
Ilia Ross
da5b814d2b Fix query as the order matters
* Note: When "Show blob and text fields as" option is set to "Links to download" the download won't work if the sorting is active
2025-07-22 13:48:45 +03:00
Ilia Ross
187b7c72a8 Fix download link in MySQL rows
https://forum.virtualmin.com/t/mariadb-download-link-when-viewing-text-database-fields/134323/14
2025-07-22 13:05:39 +03:00
Ilia Ross
ac45266ee4 Add missing referenced variable 2025-06-29 22:28:42 +03:00
Ilia Ross
522aeb5264 Fix to consider ancient systems 2025-06-29 22:28:30 +03:00
Ilia Ross
f0e07518c9 Fix setting innodb_file_per_table option as it's always enabled by default 2025-06-21 22:45:17 +03:00
Jamie Cameron
d795fc7d60 Merge branch 'master' of github.com:webmin/webmin 2025-06-19 21:23:30 -07:00
Jamie Cameron
b397ece0ab Most options have moved away from set-variable
https://github.com/webmin/webmin/issues/2497
2025-06-19 21:21:47 -07:00
Ilia Ross
7c05368e8f Add UI API to mask sensitive text unless specifically hovered 2025-06-18 16:53:55 +03:00
Ilia Ross
695c78f631 Fix previously broken Farsi translations 2025-05-30 21:36:00 +03:00
Ilia Ross
0a0f0389c3 Fix checking account lock status #2484 2025-05-29 16:59:31 +03:00
Ilia Ross
833292c0d1 Add exported German language-neutral strings
https://github.com/webmin/webmin/discussions/2482
https://forum.virtualmin.com/t/on-the-rejection-of-gender-neutral-language/133527
2025-05-26 14:48:11 +03:00
Ilia Ross
532a8042c7 Fix to use German rules most people already accept 2/2
https://github.com/webmin/webmin/discussions/2482
2025-05-24 21:46:34 +03:00
Ilia Ross
501698ad4b Fix to use German rules most people already accept 1/2
https://github.com/webmin/webmin/discussions/2482
2025-05-24 20:43:25 +03:00