Compare commits

...

3 Commits

Author SHA1 Message Date
Nikhil Soni
47a9fce310 refactor(telemetrystore): drop app-side bulk-filtering override
Stop managing secondary_indices_enable_bulk_filtering from the app.
The ClickHouse#82283 workaround is fixed in 25.7+ (prod runs 25.12);
the setting is controlled server-side via ClickHouse profiles.

Assisted-by: Claude Opus 4.8
2026-09-15 19:24:11 +05:30
Nikhil Soni
130d168642 fix(telemetrystore): enable secondary_indices_enable_bulk_filtering
Wire the existing config field into the query hook instead of the
hardcoded override. The ClickHouse#82283 workaround is fixed in 25.7+
(prod runs 25.12), and keeping it a config knob lets it be flipped off
for older ClickHouse if ever needed.

Assisted-by: Claude Opus 4.8
2026-09-15 18:54:20 +05:30
Manika Malhotra
099e81202d chore(onboarding): update onboarding hint text (#12868)
<!--A few plain bullets saying what changed and why, for a reviewer
skimming it - not a wall of text, not a restatement of the diff, not
generated boilerplate.-->
#### Description

Changes onboarding hint text

<!--Reference issues using `Closes #issue-number` to enable automatic
closure on merge. -->
#### Issues closed by this PR

Closes https://github.com/SigNoz/growth-pod/issues/1382 

<!--If applicable, include screenshots or screen recordings that clearly
show the behavior before the change and the result after the change. -->
#### Screenshots / Screen Recordings

Before:

<img width="671" height="745" alt="Screenshot 2026-09-15 at 17 01 43"
src="https://github.com/user-attachments/assets/29f1759f-42d0-4382-816b-a6c53f94808c"
/>


After:
<img width="691" height="751" alt="Screenshot 2026-09-15 at 17 00 33"
src="https://github.com/user-attachments/assets/d07ca372-b62d-497d-9c9e-24252c96ddcf"
/>


<!--Anything reviewers should keep in mind while reviewing -->
#### Additional Information

<!--Please delete paragraphs that you did not use before submitting.-->
2026-09-15 12:15:34 +00:00
5 changed files with 10 additions and 14 deletions

View File

@@ -202,7 +202,6 @@ telemetrystore:
max_bytes_to_read: 0
max_result_rows: 0
ignore_data_skipping_indices: ""
secondary_indices_enable_bulk_filtering: false
##################### Prometheus #####################
prometheus:

View File

@@ -131,7 +131,7 @@ export function AboutSigNozQuestions({
<AntdInput.TextArea
className="discover-signoz-input"
placeholder={`e.g., googling "datadog alternative", a post on r/devops, from a friend/colleague, a LinkedIn post, ChatGPT, etc.`}
placeholder="e.g., I asked ChatGPT for Datadog alternatives, searched Google for “OpenTelemetry tools,” saw a Reddit or LinkedIn post, or heard about it from a colleague."
value={discoverSignoz}
autoFocus
rows={4}

View File

@@ -204,10 +204,12 @@ describe('OnboardingQuestionaire Component', () => {
await user.click(screen.getByRole('button', { name: /next/i }));
await expect(
screen.findByPlaceholderText(/e\.g\., googling/i, {}),
screen.findByPlaceholderText(/e\.g\., I asked ChatGPT/i, {}),
).resolves.toBeInTheDocument();
const discoverInput = screen.getByPlaceholderText(/e\.g\., googling/i);
const discoverInput = screen.getByPlaceholderText(
/e\.g\., I asked ChatGPT/i,
);
await user.type(discoverInput, 'Found via Google search');
const interestCheckbox = screen.getByLabelText(
@@ -256,11 +258,11 @@ describe('OnboardingQuestionaire Component', () => {
await user.click(screen.getByRole('button', { name: /next/i }));
await expect(
screen.findByPlaceholderText(/e\.g\., googling/i, {}),
screen.findByPlaceholderText(/e\.g\., I asked ChatGPT/i, {}),
).resolves.toBeInTheDocument();
await user.type(
screen.getByPlaceholderText(/e\.g\., googling/i),
screen.getByPlaceholderText(/e\.g\., I asked ChatGPT/i),
'Found via Google',
);
await user.click(screen.getByLabelText(/lowering observability costs/i));
@@ -297,7 +299,7 @@ describe('OnboardingQuestionaire Component', () => {
await user.click(screen.getByRole('button', { name: /next/i }));
await user.type(
await screen.findByPlaceholderText(/e\.g\., googling/i),
await screen.findByPlaceholderText(/e\.g\., I asked ChatGPT/i),
'Found via Google',
);
await user.click(screen.getByLabelText(/lowering observability costs/i));
@@ -329,11 +331,11 @@ describe('OnboardingQuestionaire Component', () => {
await user.click(screen.getByRole('button', { name: /next/i }));
await expect(
screen.findByPlaceholderText(/e\.g\., googling/i, {}),
screen.findByPlaceholderText(/e\.g\., I asked ChatGPT/i, {}),
).resolves.toBeInTheDocument();
await user.type(
screen.getByPlaceholderText(/e\.g\., googling/i),
screen.getByPlaceholderText(/e\.g\., I asked ChatGPT/i),
'Found via Google',
);
await user.click(screen.getByLabelText(/lowering observability costs/i));

View File

@@ -46,7 +46,6 @@ type QuerySettings struct {
MaxBytesToRead int `mapstructure:"max_bytes_to_read"`
MaxResultRows int `mapstructure:"max_result_rows"`
IgnoreDataSkippingIndices string `mapstructure:"ignore_data_skipping_indices"`
SecondaryIndicesEnableBulkFiltering bool `mapstructure:"secondary_indices_enable_bulk_filtering"`
}
func NewConfigFactory() factory.ConfigFactory {

View File

@@ -72,10 +72,6 @@ func (h *provider) BeforeQuery(ctx context.Context, _ *telemetrystore.QueryEvent
settings["result_overflow_mode"] = ctx.Value("result_overflow_mode")
}
// TODO(srikanthccv): enable it when the "Cannot read all data" issue is fixed
// https://github.com/ClickHouse/ClickHouse/issues/82283
settings["secondary_indices_enable_bulk_filtering"] = false
ctx = clickhouse.Context(ctx, clickhouse.WithSettings(settings))
return ctx
}