Compare commits

...

2 Commits

Author SHA1 Message Date
Nikhil Soni
47a9fce310 refactor(telemetrystore): drop app-side bulk-filtering override
Stop managing secondary_indices_enable_bulk_filtering from the app.
The ClickHouse#82283 workaround is fixed in 25.7+ (prod runs 25.12);
the setting is controlled server-side via ClickHouse profiles.

Assisted-by: Claude Opus 4.8
2026-09-15 19:24:11 +05:30
Nikhil Soni
130d168642 fix(telemetrystore): enable secondary_indices_enable_bulk_filtering
Wire the existing config field into the query hook instead of the
hardcoded override. The ClickHouse#82283 workaround is fixed in 25.7+
(prod runs 25.12), and keeping it a config knob lets it be flipped off
for older ClickHouse if ever needed.

Assisted-by: Claude Opus 4.8
2026-09-15 18:54:20 +05:30
3 changed files with 0 additions and 6 deletions

View File

@@ -202,7 +202,6 @@ telemetrystore:
max_bytes_to_read: 0
max_result_rows: 0
ignore_data_skipping_indices: ""
secondary_indices_enable_bulk_filtering: false
##################### Prometheus #####################
prometheus:

View File

@@ -46,7 +46,6 @@ type QuerySettings struct {
MaxBytesToRead int `mapstructure:"max_bytes_to_read"`
MaxResultRows int `mapstructure:"max_result_rows"`
IgnoreDataSkippingIndices string `mapstructure:"ignore_data_skipping_indices"`
SecondaryIndicesEnableBulkFiltering bool `mapstructure:"secondary_indices_enable_bulk_filtering"`
}
func NewConfigFactory() factory.ConfigFactory {

View File

@@ -72,10 +72,6 @@ func (h *provider) BeforeQuery(ctx context.Context, _ *telemetrystore.QueryEvent
settings["result_overflow_mode"] = ctx.Value("result_overflow_mode")
}
// TODO(srikanthccv): enable it when the "Cannot read all data" issue is fixed
// https://github.com/ClickHouse/ClickHouse/issues/82283
settings["secondary_indices_enable_bulk_filtering"] = false
ctx = clickhouse.Context(ctx, clickhouse.WithSettings(settings))
return ctx
}