chore: feature flag for dashboard v2

frontend/src/constants/features.ts

@@ -10,4 +10,5 @@ export enum FeatureKeys {
 	ONBOARDING_V3 = 'onboarding_v3',
 	DOT_METRICS_ENABLED = 'dot_metrics_enabled',
 	USE_JSON_BODY = 'use_json_body',
+	DASHBOARD_V2 = 'dashboard_v2',
 }

pkg/flagger/registry.go

@@ -10,6 +10,7 @@ var (
 	FeaturePutMetersInZeus   = featuretypes.MustNewName("put_meters_in_zeus")
 	FeatureUseMeterReporter  = featuretypes.MustNewName("use_meter_reporter")
 	FeatureUseJSONBody       = featuretypes.MustNewName("use_json_body")
+	FeatureDashboardV2       = featuretypes.MustNewName("dashboard_v2")
 )
 
 func MustNewRegistry() featuretypes.Registry {
@@ -70,6 +71,14 @@ func MustNewRegistry() featuretypes.Registry {
 			DefaultVariant: featuretypes.MustNewName("disabled"),
 			Variants:       featuretypes.NewBooleanVariants(),
 		},
+		&featuretypes.Feature{
+			Name:           FeatureDashboardV2,
+			Kind:           featuretypes.KindBoolean,
+			Stage:          featuretypes.StageExperimental,
+			Description:    "Controls whether dashboard v2 is enabled",
+			DefaultVariant: featuretypes.MustNewName("disabled"),
+			Variants:       featuretypes.NewBooleanVariants(),
+		},
 	)
 	if err != nil {
 		panic(err)

pkg/query-service/app/clickhouseReader/reader.go

@@ -1156,11 +1156,9 @@ func (r *ClickHouseReader) GetFlamegraphSpansForTrace(ctx context.Context, orgID
 		r.logger.Info("cache miss for getFlamegraphSpansForTrace", "traceID", traceID)
 
 		selectCols := "timestamp, duration_nano, span_id, trace_id, has_error, links as references, resource_string_service$$name, name, events"
-		selectFieldCols := req.GetSelectedFieldsSourceColumns()
-		if len(selectFieldCols) > 0 {
-			selectCols = fmt.Sprintf("%s, %s", selectCols, strings.Join(selectFieldCols, ", "))
+		if len(req.SelectFields) > 0 {
+			selectCols += ", attributes_string, attributes_number, attributes_bool, resources_string"
 		}
-
 		flamegraphQuery := fmt.Sprintf("SELECT %s FROM %s.%s WHERE trace_id=$1 and ts_bucket_start>=$2 and ts_bucket_start<=$3 ORDER BY timestamp ASC, name ASC", selectCols, r.TraceDB, r.traceTableName)
 
 		searchScanResponses, err := r.GetSpansForTrace(ctx, traceID, flamegraphQuery)

pkg/query-service/model/queryParams.go

@@ -346,45 +346,6 @@ type GetFlamegraphSpansForTraceParams struct {
 	SelectFields    []telemetrytypes.TelemetryFieldKey `json:"selectFields"`
 }
 
-func (r *GetFlamegraphSpansForTraceParams) GetSelectedFieldsSourceColumns() []string {
-	var needsAttrString, needsAttrNumber, needsAttrBool, needsResourceMap bool
-	for _, f := range r.SelectFields {
-		switch f.FieldContext {
-		case telemetrytypes.FieldContextAttribute:
-			switch f.FieldDataType {
-			case telemetrytypes.FieldDataTypeString:
-				needsAttrString = true
-			case telemetrytypes.FieldDataTypeFloat64, telemetrytypes.FieldDataTypeNumber, telemetrytypes.FieldDataTypeInt64:
-				needsAttrNumber = true
-			case telemetrytypes.FieldDataTypeBool:
-				needsAttrBool = true
-			default:
-				// Unknown type: AttributeValue searches all three maps, so we need all.
-				needsAttrString = true
-				needsAttrNumber = true
-				needsAttrBool = true
-			}
-		case telemetrytypes.FieldContextResource:
-			needsResourceMap = true
-		}
-	}
-
-	var cols []string
-	if needsAttrString {
-		cols = append(cols, "attributes_string")
-	}
-	if needsAttrNumber {
-		cols = append(cols, "attributes_number")
-	}
-	if needsAttrBool {
-		cols = append(cols, "attributes_bool")
-	}
-	if needsResourceMap {
-		cols = append(cols, "resources_string")
-	}
-	return cols
-}
-
 type SpanFilterParams struct {
 	TraceID            []string `json:"traceID"`
 	Status             []string `json:"status"`