Fix not to return short hostname unless set

* Amazon Linux doesn't have it available anywhere

CHANGELOG.md

@@ -1,7 +1,12 @@
 ## Changelog
 
-#### 2.102 (August, 2023)
+#### 2.102 (August 23, 2023)
 * Add support for Amazon Linux 2023
+* Fix a bug in Network Configuration module when parsing network size [sourceforge.net/discussion#55377]( https://sourceforge.net/p/webadmin/discussion/55377/thread/78e5aa05f3)
+* Fix Netplan related bugs in Network Configuration module
+* Fix Terminal focus bug
+* Fix to correctly compare Webmin semantic versions
+* Fix to suppress output from `monitor.pl` command [#1984](https://github.com/webmin/webmin/issues/1984)
 
 #### 2.101 (August 5, 2023)
 * Add support for reading gzipped email messages

bacula-backup/list.cgi

@@ -2,7 +2,7 @@
 # Returns a list of files and directories under some directory
 
 $trust_unknown_referers = 1;
-BEGIN { require './bacula-backup-lib.pl'; }
+require './bacula-backup-lib.pl';
 &ReadParse();
 
 # Input sanitization

firewalld/firewalld-lib.pl

@@ -501,18 +501,7 @@ return $? ? $out : undef;
 sub get_config_files
 {
 my $conf_dir = $config{'config_dir'} || '/etc/firewalld';
-my @conf_files;
-my @dirpath = ($conf_dir);
-eval "use File::Find;";
-if (!$@) {
-	find(sub {
-		my $file = $File::Find::name;
-		push(@conf_files, $file)
-			if (-f $file && $file =~ /\.(conf|xml)$/);
-		}, @dirpath);
-	}
-push(@conf_files, "$conf_dir/direct.xml");
-return @conf_files;
+return (glob("$conf_dir/*.xml"), glob("$conf_dir/*/*.xml"));
 }
 
 1;

makedebian.pl

@@ -458,7 +458,6 @@ foreach my $deb ("deb", "newkey/deb") {
 	# Run the actual build command
 	system("fakeroot dpkg --build $tmp_dir $deb/${product}_${ver}${rel}_all.deb") &&
 		die "dpkg failed";
-	#system("rm -rf $tmp_dir");
 	print "Wrote $deb/${product}_${ver}${rel}_all.deb\n";
 	$md5 = `md5sum $tarfile`;
 	$md5 =~ s/\s+.*\n//g;
@@ -521,6 +520,8 @@ EOF
 	unlink("sigs/${product}_${ver}${rel}_all.deb-sig.asc");
 	system("gpg --armor --output sigs/${product}_${ver}${rel}_all.deb-sig.asc --default-key $key --detach-sig $deb/${product}_${ver}${rel}_all.deb");
 	print "Wrote sigs/${product}_${ver}${rel}_all.deb-sig.asc\n";
+
+	system("rm -rf $diff_orig_dir $diff_new_dir");
 	}
 
 # read_file(file, &assoc, [&order], [lowercase])

miniserv.pl

@@ -1450,7 +1450,10 @@ alarm(0);
 # If a remote IP is given in a header (such as via a proxy), only use it
 # for logging unless trust_real_ip is set
 local $headerhost = $header{'x-forwarded-for'} ||
-		    $header{'x-real-ip'};
+		    $header{'x-real-ip'} ||
+		    $header{'true-client-ip'} ||
+		    $header{'cf-connecting-ip'} ||
+		    $header{'cf-connecting-ip6'};
 if ($headerhost) {
 	# Only real IPs are allowed
 	$headerhost = undef if (!&check_ipaddress($headerhost) &&

net/linux-lib.pl

@@ -525,7 +525,7 @@ return &has_command("ifup") &&
 	$gconfig{'os_version'} >= 5 ||
 	$gconfig{'os_type'} eq 'redhat-linux' &&
 	$gconfig{'os_version'} >= 13) &&
-       ($iface->{'name'} !~ /^(eth|em|eno|ens|enp|enx|lo|br)/ ||
+       ($iface->{'name'} !~ /^(eth|em|eno|ens|enp|enx|enX|lo|br)/ ||
  	$iface->{'name'} =~ /^(\S+)\.(\d+)/) &&
        $iface->{'virtual'} eq '';
 }
@@ -541,7 +541,7 @@ if ($name =~ /^(.*)\.(\d+)$/) {
 return "PPP" if ($name =~ /^ppp/);
 return "SLIP" if ($name =~ /^sl/);
 return "PLIP" if ($name =~ /^plip/);
-return "Ethernet" if ($name =~ /^eth|em|eno|ens|enp|enx|p\d+p\d+|vtnet/);
+return "Ethernet" if ($name =~ /^eth|em|eno|ens|enp|enx|enX|p\d+p\d+|vtnet/);
 return "Wireless Ethernet" if ($name =~ /^(wlan|ath)/);
 return "Arcnet" if ($name =~ /^arc/);
 return "Token Ring" if ($name =~ /^tr/);
@@ -803,7 +803,7 @@ return $? ? $out : undef;
 # Does some interface have an editable hardware address
 sub iface_hardware
 {
-return $_[0] =~ /^(eth|em|eno|ens|enp|enx)/;
+return $_[0] =~ /^(eth|em|eno|ens|enp|enx|enX)/;
 }
 
 # allow_interface_clash()

version

@@ -1 +1 @@
-2.101
+2.102

web-lib-funcs.pl

@@ -1698,7 +1698,9 @@ $err_caller = "$stack[1]->[1] (line $stack[1]->[2])"
 	if ($stack[1]->[1] && $stack[1]->[2]);
 if ($err_caller) {
 	$err_caller =~ s/$root_directory\///;
-	my $err_caller_ = &ui_help($err_caller);
+	my $err_caller_ =
+		$main::webmin_script_type =~ /^(cmd|cron)$/ ?
+			$err_caller : &ui_help($err_caller);
 	$msg = $msg ? "$msg $err_caller_" : $err_caller_;
 	push(@msg, $err_caller_);
 	}
@@ -4327,8 +4329,8 @@ if (!$main::get_system_hostname[$m]) {
 		if ($fromfile && ($m || $fromfile =~ /\./)) {
 			if ($m) {
 				$fromfile =~ s/\..*$//;
+				$main::get_system_hostname[$m] = $fromfile;
 				}
-			$main::get_system_hostname[$m] = $fromfile;
 			return $fromfile;
 			}