michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-09-23 05:50:39 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
25,723 Commits 7 Branches 97 Tags
dc0b2ff04e4f98d036ab1287be7ffe3db8568e97
Commit Graph

25723 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ilia Ross
dc0b2ff04e Fix comment 
For rebuild to trigger
 2026-09-20 16:18:31 +02:00
Jamie Cameron
a0a20063fa Call correct function to check file paths
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-09-19 21:01:05 -07:00
Jamie Cameron
ef22c05115 Merge pull request #2842 from webmin/dev/nginx-concurrency-fix
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details 
Fix concurrent Nginx configuration updates
 2026-09-19 17:41:56 -07:00
Jamie Cameron
1b029fb2c3 Merge pull request #2847 from webmin/dev/preserve-apache-comments 
Add Apache comment preservation
 2026-09-19 17:33:05 -07:00
Jamie Cameron
c5cf9242c7 Add missing param to -H flag
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
00~https://github.com/webmin/webmin/issues/284801~
 2026-09-18 20:43:31 -07:00
Jamie Cameron
08d9ef3cd0 Add checks for allowed .htaccess file path
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-09-18 16:57:34 -07:00
Jamie Cameron
5f020599de Reduce number of interations from 10 by default 
https://github.com/webmin/webmin/issues/2848
 2026-09-18 16:49:17 -07:00
Ilia Ross
c134426e2a Drop unused Nginx lock parent arg 2026-09-19 01:10:42 +02:00
Jamie Cameron
fa98ace56d Merge branch 'master' of github.com:webmin/webmin 2026-09-18 15:43:47 -07:00
Jamie Cameron
991840e890 Use my instead of local 2026-09-18 15:43:40 -07:00
Ilia Ross
a8a1b70015 Fix Nginx cache handling for caller-owned locks 2026-09-18 18:13:47 +02:00
Ilia Ross
afb0929dd9 Update Nginx lock discovery loop 
https://github.com/webmin/webmin/pull/2842#discussion_r4039699490
 2026-09-17 20:14:42 +02:00
Ilia Ross
1c80e8f298 Update Nginx lock loop comment 2026-09-17 03:24:37 +02:00
Ilia Ross
efe1dddca8 Fix to change Apache comments to use directive fields 
https://github.com/webmin/webmin/pull/2847#issuecomment-5705632150
 2026-09-17 01:46:50 +02:00
Jamie Cameron
beb843bb2b Merge pull request #2846 from webmin/dev/fix-nested-apache-directives
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
Fix nested Apache directive rewrites
 2026-09-16 15:39:40 -07:00
Ilia Ross
dcd929e7e3 Add Apache comment preservation 
This PR fixes full-line comments being removed when Webmin rewrites Apache configuration blocks.
 2026-09-17 00:07:52 +02:00
Ilia Ross
faaef530f2 Drop Apache comment preservation from this PR 2026-09-17 00:01:01 +02:00
Ilia Ross
3d27aca04a Fix nested Apache directive rewrites 
This PR fixes incorrect line numbers when Apache directives contain nested blocks.

It preserves comments during rewrites and correctly tracks every nested line.

This prevents Virtualmin from corrupting custom Apache configurations.

Fixes: https://github.com/virtualmin/virtualmin-gpl/issues/1153
 2026-09-16 23:00:38 +02:00
Jamie Cameron
b0e8115db7 Merge pull request #2844 from Deltaman-MWI/bind8-dmarc-pct-optional
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
bind8: allow the DMARC pct field to be left empty
 2026-09-15 16:56:40 -07:00
Deltaman-MWI
ee420bef24 Allow the DMARC pct field to be left empty in bind8 
RFC 9989 (DMARCbis) removes the pct tag, but the DMARC form validated
the percentage as mandatory and always assigned it, so every record
written through Webmin contained pct=.

Treat the field like the sp field directly below it: when it is empty,
delete the tag. Values 0-100 are still accepted and validated for
anyone who deliberately uses pct during a rollout. join_dmarc() already
skips tags with an empty value, so no change was needed there.

Fixes #2843

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-09-15 13:05:08 +02:00
Ilia Ross
9766789a94 Drop redundant Nginx lock error cleanup 2026-09-15 05:17:58 +02:00
Jamie Cameron
3eb7493989 Disallow multiple null-separate parameter values
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-09-14 19:40:24 -07:00
Ilia Ross
0c7fc411aa Fix to change Nginx lock check to use proper API 
https://github.com/webmin/webmin/pull/2842#discussion_r4010494535
 2026-09-15 01:37:46 +02:00
Ilia Ross
d3c0409f0e Update EAB fields to use placeholders
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-09-15 01:04:14 +02:00
Ilia Ross
f206cbb23a Fix concurrent Nginx configuration updates 
This PR fixes concurrent Nginx updates using stale config data.

It reloads the config after locking and safely handles nested locks and included files.
 2026-09-14 21:54:26 +02:00
Jamie Cameron
09e6a57f28 Merge pull request #2841 from webmin/dev/defer-ipv6-lookup
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
Fix IPv4 delays caused by IPv6 lookups
 2026-09-13 16:40:48 -07:00
Ilia Ross
8a20f7ea34 Fix socket tests without Socket6 2026-09-14 01:36:41 +02:00
Jamie Cameron
49019cb2db Make sure param values are quoted 2026-09-13 15:19:22 -07:00
Ilia Ross
267b6bc07f Fix IPv4 delays caused by IPv6 lookups 
This PR fixes delays when IPv6 DNS lookups stall otherwise working IPv4 connections.

The earlier changes ([04c74877](04c74877c3) and [8a6f7784](8a6f778410)) added fallback across available IPv4 and IPv6 addresses, which this PR preserves.

Resolving both families upfront appears to have been an implementation choice, yet now IPv6 is resolved only when no IPv4 connection succeeds.

Unit tests and real socket compatibility tests passed on Alma 10 and Debian 13.
 2026-09-13 23:49:36 +02:00
Ilia Ross
29f595dbdf Fix to change Software Packages file validation
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-09-13 12:55:28 +02:00
Ilia Ross
7242171885 Fix reboot-required detection on DNF systems
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
https://forum.virtualmin.com/t/137973
 2026-09-13 04:41:48 +02:00
Ilia Ross
afc256831c Fix TLS client certificate verification 
ⓘ Prevent certificate-chain errors from being overwritten while preserving password-login fallback for invalid optional certificates.

Reset verification state for every TLS handshake and add regression coverage.
 2026-09-13 03:17:13 +02:00
Ilia Ross
d4c14d8d5e Merge pull request #2835 from webmin/dev/nftables-remove-meta-config-layer
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details 
Cleanup meta-confg layer
 2026-09-13 01:35:52 +02:00
Ilia Ross
a06590c17e Fix to change nftables migration to prefix and validate tables 2026-09-13 01:34:46 +02:00
Ilia Ross
3291429123 Add follow up fixes for nftables config parsing, rewriting and apply 2026-09-12 22:57:21 +02:00
Ilia Ross
a840b54685 Fix arbitrary file reads in Software Packages 2026-09-12 20:09:28 +02:00
Ilia Ross
ce07147547 Fix ACL path enforcement in File Manager
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-09-11 23:41:04 +02:00
Ilia Ross
116d061c8a Fix to bump version number in changelog for upcoming release 2026-09-11 17:35:01 +02:00
Ilia Ross
2f4f017acf Fix module name validation in configuration pages 2026-09-11 17:34:17 +02:00
Jamie Cameron
806172bb90 Merge pull request #2839 from webmin/fix-2837-admin-detection
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
Fix admin detection when RPC is disabled
 2026-09-10 21:22:51 -07:00
Ilia Ross
fc5794b040 Fix Postfix map updates failing when CIDR tables are configured 2026-09-11 05:14:46 +02:00
Ilia Ross
0951ddfe87 Fix File Manager strict permission checks 2026-09-10 23:27:19 +02:00
Ilia Ross
90c048d4f7 Add SMART temperature polling regression tests #2838
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-09-10 05:09:19 +02:00
Ilia Ross
725362b9f0 Fix SMART temperature polling to skip self-test logs #2838 2026-09-10 05:08:59 +02:00
Ilia Ross
d7c7ba87cc Add regression tests 2026-09-10 04:31:18 +02:00
Ilia Ross
f197e6e886 Fix admin detection when RPC is disabled 
This PR stops treating `rpc=0` as a safe-user restriction, restoring File Manager ops and admin features for fully privileged accounts created with RPC disabled.

Preserve explicit `_safe` restrictions and product roles.

Regression tests and Perl syntax checks pass.

Fixes https://github.com/webmin/webmin/issues/2837
 2026-09-10 04:30:47 +02:00
Ilia Ross
10c328ef4d Fix ext4 quota detection for LABEL and UUID mounts 
Fixes https://forum.virtualmin.com/t/failed-to-turn-on-quotas-quotaon-using-on-dev-sda1-home-file-exist/137832
 2026-09-10 04:14:10 +02:00
Ilia Ross
1ee78eefb0 Fix to bump devel version for dependent packages to work in devel repo 2026-09-10 02:08:31 +02:00
Ilia Ross
a29cd271fc Fix default outlined toggle selected state 2026-09-10 01:42:48 +02:00
Ilia Ross
11d942a43b Fix to add support for stand alone toggles 2026-09-10 01:36:32 +02:00