Ilia Ross
c8a6a0f69a
Add label_html row option to ui_dl
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-09-30 16:53:05 +02:00
Jamie Cameron
8a09ca5342
Check again if user is editable before saving
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-09-29 17:50:49 -07:00
Jamie Cameron
abf05faa20
Merge branch 'master' of github.com:webmin/webmin
2026-09-29 17:46:39 -07:00
Jamie Cameron
47d2411e2b
Re-check that modified user attributes are still allowed for this Webmin user
2026-09-29 17:46:35 -07:00
Jamie Cameron
f98a6a31dc
Merge pull request #2858 from webmin/dev/fix-miniserv-config-cache
...
Fix stale miniserv configuration reads
2026-09-29 17:35:51 -07:00
Ilia Ross
6b7832acd0
Fix stale miniserv configuration reads
...
This PR fixes WebSocket routes being lost when miniserv configuration changes multiple times within one second.
Read `miniserv.conf` directly so locked updates use the current configuration.
The previous cache could reuse stale data because it compared modification times in whole seconds.
Add a regression test covering route additions and removals with an unchanged modification time.
2026-09-30 01:36:26 +02:00
Ilia Ross
e70bf0ffaa
Add get_unit_state to read fresh systemd unit properties
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-09-30 00:05:56 +02:00
Ilia Ross
9458057978
Fix start_unit reporting success when journalctl lookup follows a failed start
2026-09-29 22:24:52 +02:00
Ilia Ross
bbdd520807
Update CHANGELOG.md
...
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
[no-review] [no-build]
2026-09-28 13:47:57 +02:00
Ilia Ross
c85e0b8c50
Fix typo
...
[no-review] [no-build]
2026-09-28 13:45:42 +02:00
Jamie Cameron
d78dcb7625
Safer to match A-Z and a-z separately
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-09-27 20:30:59 -07:00
Jamie Cameron
8f79fbd0fd
Sanitize username for logging
2026-09-27 20:18:57 -07:00
Jamie Cameron
8c56e266d1
Revert "Sanitize username for logging"
...
This reverts commit 0055cccfef
2026-09-27 20:18:13 -07:00
Jamie Cameron
a68dacad64
Fix permissions
2026-09-27 20:11:34 -07:00
Jamie Cameron
cc0f8134da
Shorted line
2026-09-27 20:09:25 -07:00
Jamie Cameron
0055cccfef
Sanitize username for logging
2026-09-27 20:09:09 -07:00
Jamie Cameron
f9b818c0b0
Respect WEBMIN_CONFIG and WEBMIN_VAR if set by caller
...
https://github.com/webmin/webmin/issues/2856
2026-09-27 17:58:59 -07:00
Jamie Cameron
678c50ed3c
Merge branch 'master' of github.com:webmin/webmin
2026-09-27 08:45:05 -07:00
Jamie Cameron
da34454d9b
Merge pull request #2854 from webmin/dev/fix-dnf-check-update-failure
...
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Fix failed DNF update checks showing no updates
2026-09-24 21:16:50 -07:00
Ilia Ross
5a806c48c1
Fix DNF update test after check-update failure handling
2026-09-25 02:25:19 +02:00
Ilia Ross
9faa2b4323
Fix failed DNF update checks showing no updates
...
This PR fixes the Package Updates module reporting "no updates" when dnf check-update fails.
DNF prints its error to stderr and exits with status 1, but the module only read stdout, so a failed check looked like an empty list and was cached for hours. Users could go weeks or months without seeing that updates were blocked!
The module now checks the exit status. When a check fails, it keeps the last known list, shows the error on the module and refresh pages, and retries after 15 minutes instead of caching an empty result.
Scheduled checks email the failure instead of acting on the old list, and in new-only mode the failure is emailed once until a check succeeds again.
Fixes https://forum.virtualmin.com/t/no-warning-of-dnf-error-suppressing-update/138052
2026-09-25 02:10:53 +02:00
Ilia Ross
66f5f22320
Add grouping and metadata to multi-select lists
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-09-24 20:30:19 +02:00
Jamie Cameron
623a5f0fa0
Improve escaping of log fields
2026-09-23 20:46:03 -07:00
Ilia Ross
6dfaa54616
Add small and rounded badge options
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-09-22 18:14:39 +02:00
Ilia Ross
3a2b2b8671
Fix UI Demo module category
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-09-21 03:50:10 +02:00
Ilia Ross
fcd0f80ad9
Fix FTPS data session reuse
...
This patch fixes FTPS backups failing on servers that require TLS session reuse.
It reuses the control connection's TLS session for data uploads.
It adds coverage for an actual passive-mode upload and was verified against a live ProFTPD server.
https://github.com/webmin/webmin/issues/2849#issuecomment-5752478469
2026-09-21 00:58:14 +02:00
Ilia Ross
78d307aa77
Fix textbox width for backup server and path inputs
2026-09-20 23:50:49 +02:00
Ilia Ross
b0cca9edf2
Fix backup destination selector handling
...
This patch fixes the Backup Configuration destination selector by using the new select-based UI.
It keeps existing field names and backup behavior unchanged.
It also ensures browser downloads bypass AJAX and submit correctly.
2026-09-20 23:46:07 +02:00
Ilia Ross
eb93c7aac3
Fix to collect searches across allowed directories
...
290ab1aaea (r201223944)
2026-09-20 22:47:26 +02:00
Jamie Cameron
290ab1aaea
Fix support for multiple allowed directories
2026-09-20 13:26:28 -07:00
Ilia Ross
bfa733907e
Fix explicit FTPS backup negotiation
...
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2849#issuecomment-5751772604
2026-09-20 21:33:54 +02:00
Jamie Cameron
dedf55cba2
Make extra sure that search results are under allowed paths
2026-09-20 12:15:21 -07:00
Jamie Cameron
2402ed97d7
new version bump
2026-09-20 09:27:01 -07:00
Jamie Cameron
cc95d6285a
Ensure that old password is requested before new one is sent
2026-09-20 09:20:31 -07:00
Jamie Cameron
5a03eafaa8
Merge branch 'master' of github.com:webmin/webmin
2026-09-20 09:12:59 -07:00
Jamie Cameron
6a53df97ef
Ensure directory is at or under the chroot
2026-09-20 09:12:53 -07:00
Ilia Ross
1867e9a069
Update changelog
2026-09-20 18:11:44 +02:00
Jamie Cameron
dc558631ef
Don't create empty log file until all validation passes
2026-09-20 09:05:15 -07:00
Ilia Ross
6b80935024
Update changelog
...
[no-build] [no-review]
2026-09-20 17:54:42 +02:00
Ilia Ross
95c974edc4
Fix comments on skipped Apache conditionals
...
This patch fixes comments before skipped `IfModule`, `IfDefine`, and `IfVersion` blocks being attached to the next parsed directive.
For example:
```apache
# SSL-only settings
<IfModule mod_ssl.c>
SSLEngine on
</IfModule>
ServerName example.test
```
When `mod_ssl` was unavailable, Webmin attached `# SSL-only settings` to `ServerName`. Deleting `ServerName` could then remove the wrong line and produce:
```apache
# SSL-only settings
<IfModule mod_ssl.c>
SSLEngine on
```
This fix clears comments belonging to skipped conditionals. Deleting `ServerName` now leaves the complete `IfModule` block unchanged.
2026-09-20 17:22:17 +02:00
Ilia Ross
dc0b2ff04e
Fix comment
...
For rebuild to trigger
2026-09-20 16:18:31 +02:00
Jamie Cameron
a0a20063fa
Call correct function to check file paths
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-09-19 21:01:05 -07:00
Jamie Cameron
ef22c05115
Merge pull request #2842 from webmin/dev/nginx-concurrency-fix
...
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Fix concurrent Nginx configuration updates
2026-09-19 17:41:56 -07:00
Jamie Cameron
1b029fb2c3
Merge pull request #2847 from webmin/dev/preserve-apache-comments
...
Add Apache comment preservation
2026-09-19 17:33:05 -07:00
Jamie Cameron
c5cf9242c7
Add missing param to -H flag
...
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
00~https://github.com/webmin/webmin/issues/284801~
2026-09-18 20:43:31 -07:00
Jamie Cameron
08d9ef3cd0
Add checks for allowed .htaccess file path
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-09-18 16:57:34 -07:00
Jamie Cameron
5f020599de
Reduce number of interations from 10 by default
...
https://github.com/webmin/webmin/issues/2848
2026-09-18 16:49:17 -07:00
Ilia Ross
c134426e2a
Drop unused Nginx lock parent arg
2026-09-19 01:10:42 +02:00
Jamie Cameron
fa98ace56d
Merge branch 'master' of github.com:webmin/webmin
2026-09-18 15:43:47 -07:00
Jamie Cameron
991840e890
Use my instead of local
2026-09-18 15:43:40 -07:00
