Commit Graph

25092 Commits

Author SHA1 Message Date
Ilia Ross
6ed05b5e25 Add UI API to make div element 2026-05-20 13:54:23 +02:00
Jamie Cameron
93befb0a1a Merge branch 'master' of github.com:webmin/webmin
Some checks failed
Tests / prove (push) Has been cancelled
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-19 16:54:33 -07:00
Jamie Cameron
fc241dd8cd If extra logs were defined in the syslog module in the past but it is deprecated, move them over to the logviewer module
https://github.com/webmin/webmin/issues/2722
2026-05-19 16:53:47 -07:00
Ilia Ross
d26f4fb7f3 Merge pull request #2721 from swelljoe/fix-acl-bugs
Fixes minor bugs in acl surfaced by tests
2026-05-20 00:11:29 +02:00
Joe Cooper
28ba5883ef Make test match code more clearly 2026-05-19 16:59:34 -05:00
Ilia Ross
52d0382619 Fix regression and hide disabled default vhost files 2026-05-19 23:28:24 +02:00
Joe Cooper
1f8030a523 Also escape in clone path 2026-05-19 16:20:23 -05:00
Ilia Ross
d93fd6a4b6 Fix to harden vhost file handling
* Note: Resolve enabled-site link paths through ServerRoot and include disabled vhost file deletions in Apache config-test rollback coverage, with focused regressions.

https://github.com/webmin/webmin/actions/runs/26125036339/job/76836427985
2026-05-19 23:16:09 +02:00
Ilia Ross
a5be2f9d39 Add Debian-style sites-available file management to Apache
* Note: Bring the Apache module to parity with the Nginx module's Debian
sites-available/sites-enabled handling: list disabled vhost files
alongside active ones, toggle their state via symlink with apachectl
configtest rollback, and delete VirtualHost blocks from inactive files.
When Virtualmin manages a vhost, defer enable/disable to Virtualmin's
own forms instead of touching the symlink directly.

https://forum.virtualmin.com/t/enable-disable-toggle-buttons-in-ngnix-module/137238/4?u=ilia
2026-05-19 23:00:18 +02:00
Joe Cooper
8c2541fdc8 s/return undef/return/ 2026-05-19 15:43:45 -05:00
Joe Cooper
ef49236f6a Fixes minor bugs surfaced by tests 2026-05-19 15:13:33 -05:00
Ilia Ross
79adc13008 Fix to respect Virtualmin state for server files
Some checks failed
Tests / prove (push) Has been cancelled
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Use Virtualmin domain state for managed Nginx server files, block direct enable/disable toggles, and link users to the proper Virtualmin enable or disable action.

https://forum.virtualmin.com/t/enable-disable-toggle-buttons-in-ngnix-module/137238/4?u=ilia
2026-05-19 22:11:21 +02:00
Ilia Ross
3c20bd5a4f Merge pull request #2720 from swelljoe/acl-unit-tests
Some checks failed
Tests / prove (push) Has been cancelled
webmin.dev: webmin/webmin / build (push) Has been cancelled
Add some acl unit tests
2026-05-19 11:49:48 +02:00
Joe Cooper
78c9e8f2c5 Add some acl unit tests 2026-05-18 23:24:41 -05:00
Jamie Cameron
b2fec1756d Merge pull request #2716 from swelljoe/miniserv-tests-trois
Some checks failed
Tests / prove (push) Has been cancelled
webmin.dev: webmin/webmin / build (push) Has been cancelled
Even more unit tests for miniserv.pl
2026-05-18 20:30:47 -07:00
Ilia Ross
3e394323c7 Fix to validate manual config symlink targets
https://github.com/webmin/webmin/actions/runs/26066009981/job/76636877949
2026-05-19 01:40:08 +02:00
Ilia Ross
267f05ed73 Add raw config edit ACL and server shortcut
* Note: Gate manual Nginx config editing behind a dedicated ACL and add a per-server quick edit icon for the owning config file.
2026-05-19 01:16:19 +02:00
Ilia Ross
578a41769e Add ability to show pending apply state after config changes 2026-05-18 23:05:25 +02:00
Ilia Ross
1d03afbdd5 Fix lang 2026-05-18 22:17:29 +02:00
Ilia Ross
41b8be4ac7 Fix to drop testing code 2026-05-18 22:16:59 +02:00
Ilia Ross
251fef722d Add site state toggles and proxy-aware server list
https://github.com/webmin/webmin/issues/2688
2026-05-18 22:08:36 +02:00
Ilia Ross
c1ba586dba Merge pull request #2715 from swelljoe/test-all-prs
Some checks failed
Tests / prove (push) Has been cancelled
webmin.dev: webmin/webmin / build (push) Has been cancelled
Test all PRs
2026-05-18 18:33:35 +02:00
Ilia Ross
3c8e1d0089 Merge pull request #2714 from swelljoe/nftables-perlcritic-again
Make perlcritic happy again
2026-05-18 16:59:11 +02:00
Ilia Ross
b6025b2fc2 Fix to revert "Code Review Test: Fix language strings improp"
This reverts commit 42142f7a5f.
2026-05-18 14:53:43 +02:00
Ilia Ross
42142f7a5f Code Review Test: Fix language strings improp 2026-05-18 14:36:03 +02:00
Ilia Ross
256046ed1f Fix to use cleaned DEB staging tree for source tarball
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
https://github.com/webmin/webmin/pull/2708#issuecomment-4473625945
2026-05-18 10:56:46 +02:00
Joe Cooper
d1c6e8d3a3 Even more tests for miniserv.pl 2026-05-18 00:46:20 -05:00
Joe Cooper
d81eb13f22 Run tests on PR, add docs 2026-05-17 23:33:59 -05:00
Joe Cooper
ab37804ef9 Add docs for coverage 2026-05-17 23:17:15 -05:00
Joe Cooper
9eff352005 Make perlcritic happy again 2026-05-17 22:25:03 -05:00
Jamie Cameron
4bdb518493 Merge pull request #2712 from swelljoe/fix-password-crypt-sha512
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
Fix encrypt_sha512 so it doesn't always fall back to crypt
2026-05-17 18:41:40 -07:00
Joe Cooper
b658bdd3ed Remove comment noise about known bug in encrypt_sha512, as bug has been fixed by this PR 2026-05-17 19:30:38 -05:00
Joe Cooper
6458658bfb Fix encrypt_sha512 so it doesn't always fall back to crypt 2026-05-17 18:06:53 -05:00
Ilia Ross
c306818f50 Add PR code review workflow [no-build] 2026-05-18 00:49:32 +02:00
Ilia Ross
fa26f8699c Merge pull request #2709 from swelljoe/more-miniserv-tests
More miniserv.pl tests
2026-05-18 00:42:53 +02:00
Joe Cooper
b71c046596 More miniserv.pl tests 2026-05-17 17:28:21 -05:00
Ilia Ross
0216b7162f Code Review Test: Fix language strings bring back 2026-05-18 00:02:16 +02:00
Ilia Ross
d6d6b8806d Merge pull request #2708 from swelljoe/exclude-tests
Exclude t and xt from packages
2026-05-17 23:55:40 +02:00
Joe Cooper
9587d3d091 Exclude t and xt from packages 2026-05-17 16:24:19 -05:00
Ilia Ross
3b819eafb5 Merge pull request #2705 from swelljoe/miniserv-unit-tests
rename miniserv-http_error.t to miniserv.t, test all subs
2026-05-17 23:24:04 +02:00
Joe Cooper
49138dc5b5 Capture warnings, instead of silencing 2026-05-17 16:14:23 -05:00
Ilia Ross
21e3367a9c Code Review Test: Fix language strings improp 2026-05-17 21:39:06 +02:00
Ilia Ross
3f367adf8d Add code review SMTP secret [no-build]
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-17 20:45:20 +02:00
Ilia Ross
2d01675139 Fix reflected XSS in Webmin status messages
* Note: Escape the /webmin/ message parameter, strip restart redirect HTML to plain text, and harden filter_javascript().
2026-05-17 14:32:10 +02:00
Ilia Ross
e60d005ab0 Fix to enforce RPC-only users before module ACL check
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Block `rpc=3` users from normal Webmin UI before `init_config` marks module ACLs checked, while explicitly allowing RPC endpoints.

https://github.com/webmin/webmin/actions/runs/25971500591/job/76344191751

45292ea815
2026-05-17 00:55:15 +02:00
Ilia Ross
7d129ee5e1 Code Review Test: Fix back 2026-05-17 00:41:26 +02:00
Ilia Ross
14abf9f938 Code Review Test: Fix language strings (try more) 2026-05-17 00:39:42 +02:00
Ilia Ross
f508c58929 Code Review Test: Fix back 2026-05-17 00:38:19 +02:00
Ilia Ross
3cff366b1f Code Review Test: Fix language strings (try again)
This reverts commit e4b7e97848.
2026-05-17 00:34:57 +02:00
Ilia Ross
e4b7e97848 Revert "Code Review Test: Fix language strings"
This reverts commit 257fc2d87c.
2026-05-17 00:34:50 +02:00