michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-10-29 06:31:04 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
25,859 Commits 10 Branches 97 Tags
6c674def60ebe59fc415885cd60741bb2ec197fc
Commit Graph

25859 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jamie Cameron
6c674def60 Use standard function to split commands 2026-10-14 20:41:28 -07:00
Jamie Cameron
502a54b6df Windows is no longer supported, so drop all config-windows files
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-10-12 22:26:39 -07:00
Jamie Cameron
6fec16bbd2 Merge branch 'master' of github.com:webmin/webmin 2026-10-12 21:25:16 -07:00
Jamie Cameron
65de483f37 Use EHLO when sending mail with authentication or SSL 
https://github.com/webmin/webmin/issues/2879
 2026-10-12 21:17:11 -07:00
Ilia Ross
222a2fd31b Fix convert to JSON to support canonical flag for independent key sorting 2026-10-13 05:26:42 +02:00
Ilia Ross
2d014758a2 Fix Cron job input validation
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details 
This patch fixes unsafe validation of Cron job fields before crontab entries are created.

It rejects line breaks and invalid schedule, special-time, and date values that could add unexpected fields, commands, or environment variables.

It also adds tests for malicious inputs and valid schedules.

Additional improvements to accompany. c23b6b5b48.
 2026-10-12 23:13:34 +02:00
Jamie Cameron
01ce0a70d1 Make sure comments don't contain newlines
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-10-11 21:57:03 -07:00
Jamie Cameron
166cfefa28 If the sandbox flag is supported, use it when restoring a backup or executing an SQL file to prevent use of external commands 2026-10-11 19:42:24 -07:00
Jamie Cameron
3d0a9aeea8 Fix permissions check 2026-10-11 19:07:54 -07:00
Jamie Cameron
616547c26f Protect against creation of root-capable RPC users 2026-10-11 19:05:06 -07:00
Jamie Cameron
24db25a6c5 Harden checks for uid_def and gid_def params, and add proper translatable strings 2026-10-11 18:41:06 -07:00
Jamie Cameron
072bf2bda3 Support searching by hashed session ID 2026-10-11 18:03:51 -07:00
Jamie Cameron
8bc89757a7 Only log hashed session ID, so it cannot be used to login 2026-10-11 18:03:22 -07:00
Ilia Ross
02d2ce697f Update changelog
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-10-11 18:04:13 +02:00
Ilia Ross
bc9d7e67a8 Rebuild File Manager's non-Bootstrap interface on the core widgets 2026-10-11 17:57:36 +02:00
Ilia Ross
7b6c3b3857 Add dark color scheme for menus and dialogs to the standard theme 2026-10-11 17:56:47 +02:00
Ilia Ross
ba0d06743d Fix standard theme sort script dropping controls from table headings 2026-10-11 17:56:04 +02:00
Ilia Ross
759359db48 Add drop-down menu, dialog, breadcrumb and pager widgets to UI lib 2026-10-11 17:52:04 +02:00
Ilia Ross
31680372d2 Add menus tab to UI demo with menu, dialog, breadcrumb and pager examples 2026-10-11 17:46:56 +02:00
Ilia Ross
c23b6b5b48 Fix Cron environment variable ACL checks
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details 
This patch completes the ACL added in [17ba87cbc](https://github.com/webmin/webmin/commit/17ba87cbc).

That change protected only the edit and save pages.

Users without environment-variable access could still change variables through delete, bulk actions, and moves.

This applies the permission everywhere and hides blocked controls.

It also applies create and delete permissions to variables and prevents job and variable endpoints from being mixed.
 2026-10-11 15:31:06 +02:00
Ilia Ross
0f71dac9cf Fix one-time login session keys 
This patch fixes a regression from [42850e579](https://github.com/webmin/webmin/commit/42850e579).

That commit stopped miniserv from accepting raw session keys, but these helpers still stored them that way. They now store hashed keys, so one-time login links work again.
 2026-10-11 15:16:04 +02:00
Ilia Ross
6b78f7d8b5 Fix Filemin archive option handling 
Fixes a regression from [1e1f9982d](https://github.com/webmin/webmin/commit/1e1f9982d). That change put `--` in the wrong place for Zip, causing compression to fail.

Tar could still treat filenames as command options. This puts `--` in the correct place for both.
 2026-10-11 15:12:35 +02:00
Jamie Cameron
c57711a3b5 Add missing ACL check
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-10-10 16:01:11 -07:00
Jamie Cameron
6c008506d9 Add missing ACL check 2026-10-10 15:57:08 -07:00
Jamie Cameron
32d20fe18c If the DBM belongs to a user, open it with that user's permissions 2026-10-10 15:51:39 -07:00
Jamie Cameron
2259de1962 Fix errors in params to execute_before/after functions 2026-10-10 15:42:00 -07:00
Jamie Cameron
6873c65c42 If MySQL backups are being done as a non-root user, also run pre and post backup commands as that user 2026-10-10 15:37:12 -07:00
Jamie Cameron
f2b94348dc Use proper variables 2026-10-10 15:28:09 -07:00
Jamie Cameron
6fecd282b8 Merge branch 'master' of github.com:webmin/webmin 2026-10-10 15:20:05 -07:00
Jamie Cameron
1e1f9982d7 Properly handle filenames starting with - 2026-10-10 15:18:44 -07:00
Ilia Ross
19e86a9657 Fix to wrap bytebox 2026-10-10 23:53:43 +02:00
Jamie Cameron
42850e5795 We never store session IDs unhashed anymore, so remove this old fallback path
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-10-10 13:09:45 -07:00
Jamie Cameron
c8e06cb06c Add missing bracket 2026-10-10 10:39:43 -07:00
Jamie Cameron
2f8e484829 future changelog entry to give credit where credit is due 2026-10-10 10:28:07 -07:00
Jamie Cameron
17ba87cbc6 Add new ACL option to limit use of environment variables 2026-10-10 10:23:06 -07:00
Ilia Ross
1a88fcdb74 Fix Netplan command expectations in tests 2026-10-10 17:33:30 +02:00
Ilia Ross
34040bd0df Fix false symlink loop detection 
This patch fixes valid symlink paths being mistaken for loops by [c51f0ed4](https://github.com/webmin/webmin/commit/c51f0ed4).

It simplifies only the checked path prefix, preserving the unresolved remainder.

Original loop cases still stop quickly, while long valid chains remain supported.

I reproduced incorrect PHP selection in Virtualmin and WP Workbench, and GoAccess choosing its root log-creation branch instead of the domain-user helper.
 2026-10-10 16:51:51 +02:00
Jamie Cameron
89ab870924 Merge branch 'master' of github.com:webmin/webmin
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-10-09 21:11:54 -07:00
Jamie Cameron
bc87da9048 Make sure variable doesn't contain a new line 2026-10-09 21:11:45 -07:00
Jamie Cameron
f9cac4c4a4 Merge pull request #2873 from webmin/dev/fix-monitor-command-hosts 
Fix to show monitor hosts
 2026-10-09 21:06:56 -07:00
Jamie Cameron
c51f0ed465 Ensure uniqueness by simplifying the path being checked for repitition 2026-10-09 20:58:39 -07:00
Jamie Cameron
63a07308ab No need for extra brackets around a whole command 
https://github.com/webmin/webmin/issues/2875
 2026-10-09 20:53:28 -07:00
Ilia Ross
51cf5c0798 Fix to show monitor hosts 
This PR fixes confusing host and command options on the monitor page.

Now the host selector is always visible, even when only the local server is available.

Updated labels explain that checks run on the selected hosts and groups, while commands can run locally or on the host running the check.

Fixes: https://github.com/webmin/webmin/issues/2872
 2026-10-09 16:41:22 +02:00
Ilia Ross
270ef90703 Fix page spacing around hidden elements
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-10-09 16:15:57 +02:00
Ilia Ross
2bf3f4834c Fix extra spacing in action log details 2026-10-09 15:41:27 +02:00
Jamie Cameron
82e7e343f5 Adding logging and use proper rename function
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
2026-10-08 22:28:28 -07:00
Jamie Cameron
dea3af005f Merge branch 'master' of github.com:webmin/webmin
Some checks failed
Tests / prove (push) Has been cancelled
Details
Package and upload artifacts / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-10-08 21:26:25 -07:00
Jamie Cameron
b4c79b1348 Exit from resolve_links if a link goes back to itself 2026-10-08 21:25:31 -07:00
Ilia Ross
8f9663fd9c Add stat tile shapes and consistent spacing 2026-10-09 04:27:59 +02:00
Ilia Ross
3bb7eeb144 Fix UI action alignment and neutral colors 2026-10-09 03:22:15 +02:00