Commit Graph

25570 Commits

Author SHA1 Message Date
Jamie Cameron
670a22122f Don't reuse same key if size changed
Some checks are pending
Tests / prove (push) Waiting to run
Package and upload artifacts / build (push) Waiting to run
https://github.com/webmin/webmin/issues/2822
2026-08-24 21:53:12 -07:00
Jamie Cameron
7d73f9fc5f Preserve LE key size in the UI
https://github.com/webmin/webmin/issues/2822
2026-08-24 21:50:14 -07:00
Jamie Cameron
660dacb981 Merge pull request #2823 from webmin/dev/dnf-hold
Add DNF versionlock support to Package Updates
2026-08-24 16:27:08 -07:00
Ilia Ross
2ac67d82a4 Merge branch 'master' into dev/dnf-hold 2026-08-24 00:30:32 +02:00
Ilia Ross
16ee9f455a Fix PostgreSQL initialization to use SCRAM-SHA-256 auth by default
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
https://forum.virtualmin.com/t/postgresql-defautl-install-issues/137798/3?u=ilia
2026-08-24 00:29:52 +02:00
Ilia Ross
86d3b95f3b Update changelog 2026-08-23 23:13:35 +02:00
Ilia Ross
f01d65a26e Add DNF versionlock support to Package Updates
This PR adds DNF 4 and DNF 5 versionlock support to Package Updates, including listing, holding, unholding, and explicitly updating held packages.

DNF 4 requires the versionlock plugin to be installed, while DNF 5 supports versionlock natively.

Hold controls are shown only when the versionlock command is available.

It also previews DNF transactions before confirmation so users can see which packages will be installed or updated in the table, similar to APT.
2026-08-23 23:03:46 +02:00
Jamie Cameron
d16d9ea205 Merge pull request #2821 from webmin/dev/miniserv-logrotate
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Add an option to rotate Miniserv logs using logrotate
2026-08-21 21:47:19 -07:00
Ilia Ross
f7da47cd5e Update changelog 2026-08-22 01:19:22 +02:00
Ilia Ross
0660a18276 Add function to make vendor configs editable 2026-08-22 01:17:49 +02:00
Ilia Ross
6183a4006a Add an option to rotate Miniserv logs using logrotate
This PR adds the ability for the logging pages to hand the Miniserv access and error logs, and the Webmin actions log, to logrotate instead of having Miniserv periodically delete them. The generated section uses copy-truncate rotation, since Miniserv only reopens its error log when the file disappears.

The option only appears when the Log File Rotation module is available and configured correctly.
2026-08-22 01:03:48 +02:00
Ilia Ross
850cc1f498 Fix error log check on systems without systemd unit
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-08-21 21:24:23 +02:00
Ilia Ross
523853963e Add option to send Miniserv errors to the systemd journal
Add a Logging page to the Usermin Configuration module for the access-log settings, guarded by a new "log" ACL.

Also, Webmin and Usermin logging pages add new an "Error log destination" choice on systemd systems. Selecting the journal sets errorlog=- and installs a local StandardError=journal drop-in, leaving the packaged unit untouched.

https://forum.virtualmin.com/t/miniserv-webserver-log-growing-too-big-should-be-rotated/136562/10?u=ilia
2026-08-21 21:02:58 +02:00
Ilia Ross
3c26b2be3b Fix FQDN detection on systemd systems
ⓘ Do not return a short name from /etc/hostname when the full name is requested; resolve it with hostname -f first, honoring the no_hostname_f option, and otherwise fall back to the existing file-based logic.

Also check for /run/systemd/system instead of reading /proc/1/comm as it's much cheaper.

Fixes #2054
2026-08-21 19:37:47 +02:00
Ilia Ross
72f1e7dc32 Update labels for accuracy and clarity
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2.660
2026-08-21 02:05:17 +02:00
Ilia Ross
833059be3d Update changelog
[no-build] [no-review]
2026-08-21 01:49:08 +02:00
Ilia Ross
f658d34000 Update changelogs
[no-build] [no-review]
2026-08-21 01:47:40 +02:00
Ilia Ross
65e6226762 Add option to only email about newly available package updates
https://forum.virtualmin.com/t/can-we-make-security-updates-email-less-chatty/137796
2026-08-21 01:43:53 +02:00
Ilia Ross
3fa28e6820 Fix Bacula FileSet option indentation 2026-08-21 00:45:21 +02:00
Ilia Ross
cc62d46677 Fix parsing of Bacula sections opened with an equals sign
https://github.com/webmin/webmin/issues/2112#issuecomment-5362249697
2026-08-21 00:37:11 +02:00
Ilia Ross
fb790746cf Fix typo
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-08-20 20:19:50 +02:00
Ilia Ross
e9f08e588a Fix protected directory path validation 2026-08-20 20:19:43 +02:00
Ilia Ross
4876aaa7fd Fix users and groups file paths escaping the allowed directories
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ Only the .htaccess path was checked against the allowed directories. The users and groups file paths could be absolute and were saved unchecked, then written to later.

V2
2026-08-20 14:31:21 +02:00
Ilia Ross
09da9e6104 Fix unvalidated password file path in Nginx module
ⓘ The password file path was taken from the request without any check, so it could point at any file on the system, which was then read or written.

It is now checked against the allowed directories, the same way it already is when the path is first set.

W1 and V4
2026-08-20 14:24:03 +02:00
Jamie Cameron
e229746ba7 New version bump
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-08-19 20:14:03 -07:00
Jamie Cameron
1365b8a4a1 Merge pull request #2820 from webmin/dev/fix-bring-handling
Fix bridge handling for interfaces with arbitrary names
2026-08-19 20:06:55 -07:00
Ilia Ross
5a101c405e Fix bridge handling for interfaces with arbitrary names
This small PR fixes deletion of bridges with arbitrary names, like vmbr0, by honoring the boot config bridge flag instead of relying only on name patterns.

It also makes the Debian config parser treat any interface with bridge_ports as a bridge, which previously caused bridge options to be lost on re-save.
2026-08-20 04:53:02 +02:00
Ilia Ross
c171b6c27d Fix cron jobs table header to match merged move column 2026-08-20 04:23:31 +02:00
Ilia Ross
5395befcef Fix scheduled emails being sent to bogus address when no default destination is set 2026-08-20 03:27:56 +02:00
Ilia Ross
3eccc770dd Fix log email being sent to bogus address when no destination is set 2026-08-20 03:23:49 +02:00
Jamie Cameron
076f2eea33 Add name to default email if set 2026-08-19 18:18:51 -07:00
Jamie Cameron
331212f145 Merge branch 'master' of github.com:webmin/webmin 2026-08-19 18:08:18 -07:00
Jamie Cameron
2f9a12c008 Use destination email with name if configured 2026-08-19 18:08:10 -07:00
Ilia Ross
4ea55c4964 Update changelog
[no-build]
2026-08-20 02:31:30 +02:00
Jamie Cameron
508a7e3eab Add fields for real name for default destination 2026-08-19 17:29:47 -07:00
Jamie Cameron
0771c6bcd3 Merge pull request #2819 from webmin/dev/fix-useradmin-group-member-acl
Fix Users and Groups to honor user ACL in group member chooser
2026-08-19 17:03:51 -07:00
Ilia Ross
342fc4d12d Fix remaining raw HTML in Shorewall module to use ui-lib
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-08-19 22:49:07 +02:00
Ilia Ross
40a8d3a694 Fix Users and Groups to honor user ACL in group member chooser
This PR fixes the Users and Groups module to honor the "Unix users who can be edited" ACL when editing group members.

Before, the group edit form listed all system users in the members chooser and accepted any user on save, regardless of the ACL.

Now only editable users are offered, and adding or removing a non-editable user is rejected.

Fixes #2464
2026-08-19 20:30:34 +02:00
Jamie Cameron
ac9f655e22 Merge pull request #2818 from digitaldutch/master
Fix cron-lib.pl regex to also handle Debian 12 } brace syntax
2026-08-19 10:00:06 -07:00
Jan Derk
c6c1a7f5cc Fix cron-lib.pl regex to also handle Debian 12 } brace syntax
Fix daily cron jobs do now show up on Debian 12.

Regular expression now handles both ) and } line endings.

(Fixes issue webmin#2817)
2026-08-19 16:51:03 +02:00
Ilia Ross
32640a33d2 Version bump to 2.655 for devel installs to work
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-08-18 15:04:18 +02:00
Jamie Cameron
ae4b152d4f Merge branch 'master' of github.com:webmin/webmin
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-08-17 21:26:37 -07:00
Jamie Cameron
1d57df4422 strict/warnings compliance 2026-08-17 21:25:44 -07:00
Ilia Ross
0e0f7622b5 Fix Fail2Ban continuation lines to align under the directive value
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-08-18 00:12:19 +02:00
Ilia Ross
c27917e4a3 Fix Fail2Ban jail editor to correctly separate actions without params #2718 2026-08-18 00:11:00 +02:00
Ilia Ross
c7780ed2ae Update changelog 2026-08-17 23:35:11 +02:00
Ilia Ross
dde9d46b1e Fix patch command to restart Webmin instead of reloading 2026-08-17 23:30:17 +02:00
Ilia Ross
c76fda35ce Add support for applying multiple patches with patch command
ⓘ Allow passing several patch URLs or files at once, e.g. webmin patch url1 url2 url3. Patches are applied in the given order, stopping at the first failure, and Webmin is reloaded only once after all of them are applied.
2026-08-17 21:43:28 +02:00
Ilia Ross
77f78cdb75 Fix patch command to not leave .orig backup files
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ GNU patch keeps a .orig copy of the original file whenever a hunk applies with fuzz or offset, which is common when patching an installed release with a commit from the master branch. Pass --no-backup-if-mismatch, since backups are not needed.
2026-08-17 19:11:18 +02:00
Ilia Ross
aa3db4ddbf Fix patch command to apply with git inside another repository
ⓘ When GNU patch is not installed, git apply was run inside the module directory, and if the Webmin root itself was a git repository, git resolved paths relative to that root and silently skipped the patched files.

Limit repository discovery to the current directory and allow reduced context, similar to the default fuzz used by patch, so slightly drifted context lines no longer cause a rejection.
2026-08-17 19:06:25 +02:00