Commit Graph

120 Commits

Author SHA1 Message Date
Jamie Cameron
77c84a7539 Handle case where encoding module is missing 2017-05-03 20:43:38 -07:00
Jamie Cameron
9716326acd Merge pull request #543 from qooob/patch-13
Make editor respect file's initial encoding: Viewer
2017-05-03 20:41:25 -07:00
Ilia Rostovtsev
85e80edf91 Make editor respect file's initial encoding: Saver
An addition to `edit_file.cgi` commit.
2017-05-02 13:26:30 +03:00
Ilia Rostovtsev
8e44c145b9 Make editor respect file's initial encoding: Viewer
This patch will make sure that user, will be able to READ files with different encodings properly and also, will be able to SAVE them without changing the initial encoding.

This awesomeness requires dependencies. However, RHEL has it installed by default but not Debian. New Webmin release should make sure to require/pull dependent packages:

For RHEL: `perl-Encode-Detect`
For Debian: `libencode-detect-perl`

P.S. We should no let user to set non-UTF8 locale anymore. All languages should be displayed unambiguously, like Google does, (Русский, svenska, Deutsche, English (United States) .. ).
2017-05-02 13:23:34 +03:00
Ilia Rostovtsev
b91a867744 For the future so user could choose encoding in file editor window
I think I did it correctly, theoretically looks good. I just don't know if `$in{'encoding'}` has to be escaped anyhow. Other than that, it seems ok, as when user passes encoding, it will tell the script to use one.
2017-05-01 20:49:17 +03:00
Ilia Rostovtsev
6bb5b79d80 Typo, missing ; 2017-05-01 20:12:29 +03:00
Ilia Rostovtsev
edd32a0819 Here is the fix for folks not using UTF-8 #52019
This is more like server side thing.

We expect that everything that is coming from the editor (CodeMirror) is always UTF-8 encoded. In case, global encoding is set to something different, then UTF-8, we must use the user encoding to properly encode the data and have correct file encoding after all.

[#52019](https://www.virtualmin.com/node/52019)
2017-05-01 20:04:27 +03:00
Jamie Cameron
0d251ff103 Merge pull request #536 from qooob/patch-9
To look consistent in Account Functions in Usermin
2017-04-25 17:10:22 -07:00
Jamie Cameron
801a71d172 Merge pull request #344 from qooob/patch-30
Respect module info
2017-04-25 16:55:24 -07:00
Ilia Rostovtsev
d5aac92059 To look consistent in Account Functions in Usermin
Just to beautify the string to look like the rest of them in `Account Functions`.
2017-04-25 14:10:19 +03:00
Jamie Cameron
cb2d221508 Merge pull request #476 from qooob/patch-2
Enable editor for .XSL files
2017-04-17 18:19:54 -07:00
Ilia Rostovtsev
2ff3afea6a path in bookmarks must be URI friendly 2017-04-16 09:37:49 +03:00
Jamie Cameron
34dbddd616 Check allowed paths in some more cases 2017-04-11 10:38:04 -07:00
Jamie Cameron
25a471e4ef simplify_path returns a new path 2017-04-10 15:23:34 -07:00
Jamie Cameron
0372fdcc2c German translation updates from Raymond Vetter 2017-03-26 09:37:54 -07:00
Jamie Cameron
4f1b8c0ae0 Add missing string 2017-03-20 17:00:22 -07:00
Jamie Cameron
d0b19dbb75 Fix more unescaped paths 2017-03-16 22:54:36 -07:00
Jamie Cameron
7fa58e88c1 Don't trust path elements 2017-03-15 23:22:47 -07:00
Jamie Cameron
c7a941c9af Fix bug where a sub-directory with the same name cannot be linked to 2017-03-10 19:05:07 -08:00
Jamie Cameron
47611a5fb7 German translation updates from Raymond Vetter 2017-03-08 22:16:20 -08:00
Jamie Cameron
2cf8380a52 Fix typo 2017-03-08 22:14:01 -08:00
Jamie Cameron
2b2b2d55e7 Clarifiy meaning of filemanger ACL 2017-03-08 22:08:11 -08:00
Jamie Cameron
dbd99caaee Path needs to be escaped in footer 2017-02-19 17:30:10 -08:00
Jamie Cameron
54fc94e32b Fix XSS vulnerability in path 2017-02-19 17:28:39 -08:00
Jamie Cameron
207e0a6dce Catalan update from Jaume Badiella 2017-02-05 20:36:00 -08:00
Ilia Rostovtsev
81e89ae384 Make sure that new dropdown always visible
To make sure it doesn't happen.
https://github.com/qooob/authentic-theme/issues/660
2017-01-31 12:48:07 +03:00
Ilia Rostovtsev
f6634503dd Enable editor for .XSL files
https://github.com/qooob/authentic-theme/issues/629#issuecomment-271280127
2017-01-10 12:21:27 +03:00
Jamie Cameron
9449111200 permissions fixes 2017-01-02 13:19:38 -08:00
Ilia Rostovtsev
a84fe682b7 Missed dialogs for new 1.830 distro 2017-01-01 14:19:29 +03:00
Ilia Rostovtsev
bf7873b3e0 Unambiguous table header 2016-12-02 09:43:21 +03:00
Ilia Rostovtsev
e1fa75f314 Unambiguous table header 2016-12-02 09:43:01 +03:00
Ilia Rostovtsev
8aa6cc1c08 Unambiguous table header 2016-12-02 09:42:48 +03:00
Ilia Rostovtsev
f06acc1a92 Unambiguous table header 2016-12-02 09:42:33 +03:00
Ilia Rostovtsev
675e0f032a Unambiguous table header 2016-12-02 09:42:07 +03:00
Ilia Rostovtsev
917ff95a90 Unambiguous table header 2016-12-02 09:41:24 +03:00
Ilia Rostovtsev
c415c46b37 Unambiguous table header 2016-12-02 09:40:36 +03:00
Jamie Cameron
9bc5766fa1 Merge pull request #465 from qooob/master
SeLinux/attributes listing and control - Security strengthening/2
2016-11-30 13:51:41 -08:00
Ilia Rostovtsev
3b66f444f8 stat() -> lstat() seems better 2016-11-30 15:00:57 +03:00
Ilia Rostovtsev
75700873ff SeLinux/attributes listing and control - Security strengthening/2 2016-11-30 13:48:46 +03:00
Ilia Rostovtsev
86dfb7f686 SeLinux/attributes listing and control - Security strengthening/2 2016-11-30 13:47:06 +03:00
Ilia Rostovtsev
28c5b02c4a SeLinux/attributes listing and control - Security strengthening 2016-11-30 00:13:36 +03:00
Ilia Rostovtsev
5835afd971 SeLinux/attributes listing and control 2016-11-29 16:44:02 +03:00
Ilia Rostovtsev
ff0ba4822d SeLinux/attributes listing and control 2016-11-29 16:43:32 +03:00
Ilia Rostovtsev
df1334f3af SeLinux/attributes listing and control 2016-11-29 16:42:36 +03:00
Ilia Rostovtsev
7621053e6c SeLinux/attributes listing and control 2016-11-29 16:42:17 +03:00
Ilia Rostovtsev
21b431f59b SeLinux/attributes listing and control 2016-11-29 16:41:52 +03:00
Ilia Rostovtsev
5a47843eb6 SeLinux/attributes listing and control 2016-11-29 16:40:56 +03:00
Ilia Rostovtsev
cde06ff828 SeLinux/attributes listing and control 2016-11-29 16:40:17 +03:00
Ilia Rostovtsev
d438f002a9 SeLinux/attributes listing and control 2016-11-29 16:39:43 +03:00
Ilia Rostovtsev
aa0f31c93d SeLinux/attributes listing and control 2016-11-29 16:39:22 +03:00