Commit Graph

25213 Commits

Author SHA1 Message Date
Jamie Cameron
1445cd7641 Check permission to delete home dirs in batch operations 2026-06-14 13:29:54 -07:00
Jamie Cameron
804591f892 Merge branch 'master' of github.com:webmin/webmin
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-06-13 18:51:30 -07:00
Jamie Cameron
a56748a3fc Add support for IP-based lets encrypt certs, with version 5.3 of certbot 2026-06-13 18:49:12 -07:00
Jamie Cameron
854b8e8c2b Merge pull request #2759 from mckaygerhard/master-alpine-mysql-mariadb
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Improve alpine mysql/mariadb default support
2026-06-13 15:38:45 -07:00
Jamie Cameron
b0fbe87592 Merge pull request #2762 from webmin/dev/fix-systemd-unit
Don't fork. systemd prefers one process.
2026-06-13 15:33:41 -07:00
Joe Cooper
bf722a658d Ah, I guess keep 5 minute TimeoutStopSec 2026-06-13 15:59:45 -05:00
Joe Cooper
02bdfc20db Type simple for compat with old systems 2026-06-13 15:43:24 -05:00
Joe Cooper
7d6af20741 Don't need ExecStop if systemd is managing process directly 2026-06-13 15:42:53 -05:00
Герхард PICCORO Lenz McKAY
ebbbf7cecb Update CHANGELOG for software module on Alpine Linux
* Update CHANGELOG for software pointing that alpine linux mysql package is supported for sure since  v 3.16
2026-06-13 10:20:44 -04:00
Joe Cooper
da12554998 Don't fork. systemd prefers one process. 2026-06-13 05:34:03 -05:00
Jamie Cameron
84943943fc Merge pull request #2761 from webmin/dev/init-simplify
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Fix init module
2026-06-12 22:07:38 -07:00
Ilia Ross
8dd06e3c34 Add ability to hide services table if dedicated module is avail 2026-06-13 00:52:47 +02:00
Ilia Ross
8f8199a4bf Fix to simplify and show only systemd services 2026-06-13 00:14:08 +02:00
Ilia Ross
53c3ee1c5d Fix to show only related config options for current boot system 2026-06-12 23:59:36 +02:00
itamarperdomo
ed5bc3e4b6 Improve alpine mysql/mariadb default support
* The MySQL module in Alpine it lacks default values. This change
uses the necessary values ​​for the module to function.
* These values ​​work for any version of Alpine Linux from 3.8
to Edge, since MariaDB is and always has been the default package.
* The tools server package was included in the package instalation
* Missing changelog entries were included
2026-06-11 11:50:56 -04:00
Ilia Ross
2024a48acf Fix job name
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-06-10 20:11:24 +02:00
Jamie Cameron
db38923b20 Merge pull request #2753 from webmin/dev/add-alpine-initial-support
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Add minimal Alpine Linux compatibility
2026-06-08 21:17:38 -07:00
Ilia Ross
3215c0d0a3 Fix to rename OpenRC init template
ⓘ Rename webmin-gentoo-init to webmin-openrc-init and update setup/distribution references to use the generic OpenRC template name.
2026-06-08 12:24:28 +02:00
Ilia Ross
c11d67d989 Add support for alternate module descriptions
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-06-07 16:26:37 +02:00
Ilia Ross
6457a1d7d1 Fix missing install commands for Xterm.js
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-06-07 00:21:44 +02:00
Ilia Ross
91c9f6b4ce Update Xterm.js to fix Control-C on iPadOS/Safari terminals
The issue is a known xterm.js/iPadOS Safari hardware-keyboard bug where Ctrl+C may be reported like Enter/newline instead of terminal interrupt input; it has been fixed upstream in xterm.js.

https://github.com/xtermjs/xterm.js/issues/5721
2026-06-07 00:12:58 +02:00
Ilia Ross
ad06644617 Add minimal Alpine Linux compatibility
This PR adds baseline Alpine Linux support in Webmin with OS detection, APK package and update backend, OpenRC boot integration, ifupdown-style networking support and DHCPD defaults.

https://github.com/webmin/webmin/issues/2353
2026-06-06 23:11:25 +02:00
Jamie Cameron
ee50fa41cd Merge pull request #2752 from webmin/dev/fix-broken-renewals
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Fix LE renewal to schedule by elapsed interval
2026-06-06 08:37:54 -07:00
Ilia Ross
80497c60b9 Update comment 2026-06-06 12:59:44 +02:00
Ilia Ross
6026a20424 Fix LE renewal to schedule by elapsed interval
The Webmin SSL LE renewal setting is labeled as "Months between automatic renewal", but it was previously saved as a calendar-style cron month expression like `*/N`.

That is not the same as an elapsed renewal interval. Webmin’s cron matcher evaluates month schedules against calendar month numbers, so values like `*/5`, `*/12`, or values above `12` do not reliably mean “renew every N months”. This could cause uneven or dangerously late renewal timing.

This changes the renewal job to use Webmin cron’s elapsed `interval` support instead of calendar-month matching.

- Saves automatic renewal as `renew * 30 * 24 * 60 * 60` seconds.
- Clears the cron time fields so the scheduler uses the interval path only.
- Keeps `months => '*/N'` so the SSL UI can continue to display the saved renewal value.
- Resets the renewal timer only after a newly issued certificate.
- Preserves the existing renewal timer for settings-only saves.
- Migrates existing month-based Let's Encrypt renewal jobs during postinstall.
2026-06-06 00:22:19 +02:00
Ilia Ross
42a5838d9e Fix not to expect option saved in config
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-06-04 22:35:42 +02:00
Ilia Ross
e10b9eeb40 Fix to treat Dovecot add_config as a single file 2026-06-04 22:29:47 +02:00
Ilia Ross
1e5f3dbb83 Fix to create extra config file on save
https://github.com/virtualmin/virtualmin-gpl/issues/324#issuecomment-4619300683
2026-06-04 22:28:27 +02:00
Ilia Ross
e8a3d9d21b Fix to handle missing user input better
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
https://github.com/webmin/webmin/issues/2750
2026-06-04 11:36:41 +02:00
Jamie Cameron
4e6204f774 Merge branch 'master' of github.com:webmin/webmin 2026-06-03 22:33:55 -07:00
Jamie Cameron
95197bb0af Respect option to add new configs to a different file
https://github.com/virtualmin/virtualmin-gpl/issues/324
2026-06-03 22:33:47 -07:00
Ilia Ross
f7b8ef379f Fix terminal mode handling
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
ⓘ Avoid forcing xterm shell PTYs into IO::Stty raw/noecho mode, which can leave interactive shells with broken echo, line editing, and control-key behavior. Keep the existing stty logic for other PTY callers, but add an opt-out flag so xterm can let the shell manage terminal mode normally.

https://github.com/webmin/webmin/issues/2452
2026-06-03 18:43:53 +02:00
Jamie Cameron
758aa4a9f7 Merge pull request #2744 from webmin/dev/fix-stale-mb
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Fix stale mailbox entries after deleted or moved
2026-06-02 21:37:54 -07:00
Jamie Cameron
b2dc27c063 Merge pull request #2747 from webmin/dev/deb-nm
Fix to detect NetworkManager networking on Debian
2026-06-02 21:04:04 -07:00
Ilia Ross
8dfee31542 Fix not to hardcode colors
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-06-02 20:32:26 +02:00
Ilia Ross
a113309310 Add form grouped buttons API for responsive button
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-06-02 13:34:31 +02:00
Ilia Ross
6574373761 Fix to detect NetworkManager networking on Debian
ⓘ Prefer Netplan when Debian has Netplan YAML config, otherwise select the existing NetworkManager backend for Debian systems with saved NM connection profiles, with regression tests for backend selection.

https://github.com/webmin/webmin/issues/2559
2026-06-02 01:33:59 +02:00
Ilia Ross
b33b9fb0a0 Fix NetworkManager IPv6 DNS nameserver saving
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
https://github.com/webmin/webmin/issues/2559
2026-06-02 01:12:24 +02:00
Ilia Ross
8ef12b66d7 Add Lucky Mobile SMS carrier #2738
Some checks failed
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
2026-06-01 01:00:11 +02:00
Ilia Ross
8df083b054 Fix Bell Canada SMS gateway domain #2739 2026-06-01 00:58:41 +02:00
Ilia Ross
435d2db4c6 Fix to use stronger defaults for generated keys
https://github.com/webmin/webmin/issues/2728
2026-05-31 20:42:33 +02:00
Ilia Ross
57b1ae3b18 Fix PHP-FPM monitor for EL /etc/php.ini
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
* Note: Map the shared EL PHP configuration file /etc/php.ini to the php-fpm boot action when that service exists, so the PHP-FPM status monitor can resolve current status on Rocky/RHEL systems.

root@rocky9-pro:~# php-fpm -i | grep "Loaded Configuration File"
Loaded Configuration File => /etc/php.ini

https://github.com/webmin/webmin/issues/2599
2026-05-31 16:14:38 +02:00
Ilia Ross
1eb4eb85a7 Fix to check empty mail files before opening 2026-05-30 21:22:38 +02:00
Jamie Cameron
fd79acd840 Properly quote and escape commands
Some checks failed
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
2026-05-30 10:22:17 -07:00
Ilia Ross
034d0a09ce Fix to skip unusable Maildir entries
* Note: Ignore zero-byte or unreadable Maildir files when listing messages, log skipped entries, and treat cached zero-byte reads as missing to avoid blank rows and inflated counts.
2026-05-30 16:13:55 +02:00
Ilia Ross
184887d365 Fix to use direct ACL checks in Kea DHCP module
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
*Note: Removes Kea-specific ACL wrapper helpers and switches ACL editor/runtime checks to standard Webmin handling with direct supplied ACL values and get_module_acl checks.
2026-05-30 02:53:48 +02:00
Ilia Ross
111dcb5f21 Fix to preserve submodule context in Virtualmin flows
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
https://forum.virtualmin.com/t/editing-server-block-configure-nginx-website-does-not-reload-nginx/137282/16?u=ilia
2026-05-30 02:29:04 +02:00
Ilia Ross
7cf7d14f53 Fix module desc 2026-05-29 22:25:42 +02:00
Ilia Ross
c68d03b211 Fix stale mailbox entries after deleted or moved
Refresh stale Maildir and sorted mailbox indexes when messages disappear, avoid rendering missing messages, and keep IMAP sort indexes in sync with mailbox count changes.
2026-05-29 21:12:58 +02:00
Ilia Ross
35a7459950 Fix temp file delete path validation
Some checks failed
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-05-29 16:59:05 +02:00