Commit Graph

25001 Commits

Author SHA1 Message Date
Ilia Ross
0863d6ba7a Revert #2700 reverted but only fix exact bug
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
This reverts commit 0d3e3d9473, reversing
changes made to 236c5cf489.
2026-05-12 18:01:16 +02:00
Ilia Ross
d46c8f20d5 Fix escapes 2026-05-12 17:51:37 +02:00
Ilia Ross
0d3e3d9473 Merge pull request #2700 from webmin/revert-2698-nftables-perlcritic
Revert "perlcritic fixes"
2026-05-12 13:01:46 +02:00
Ilia Ross
084f7b7314 Revert "perlcritic fixes" 2026-05-12 13:00:03 +02:00
Jamie Cameron
236c5cf489 Merge pull request #2695 from swelljoe/minserv-as-module
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
Wrap miniserv.pl server loop in unless (caller) so we can require miniserv for unit testing
2026-05-11 19:38:06 -07:00
Jamie Cameron
99371ad462 Merge pull request #2698 from swelljoe/nftables-perlcritic
perlcritic fixes
2026-05-11 19:22:25 -07:00
Joe Cooper
a9aae79fcd perlcritic fixes 2026-05-11 20:37:30 -05:00
Ilia Ross
04ae776e6a Fix to validate action paths
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
* Note: Validate File Manager action name/file parameters as checked paths under the current directory and `allowed_paths` before operations, blocking traversal and symlink escapes.
2026-05-12 01:25:57 +02:00
Ilia Ross
7cab23a3ea Fix to validate upload paths before writing
* Note: Canonicalize and check uploaded file and directory-upload paths against `allowed_paths` before creating directories or writing files, preventing traversal outside the File Manager ACL sandbox.
2026-05-12 00:05:02 +02:00
Ilia Ross
04c33e77a4 Add optional pre and post scripts for scheduled package updates
https://forum.virtualmin.com/t/add-option-to-run-a-custom-command-following-all-scheduled-package-updates/136397
2026-05-11 22:06:20 +02:00
Ilia Ross
9dccd2cdce Add comments
[no-build]
2026-05-11 21:16:26 +02:00
Ilia Ross
1645cadc91 Fix stored passphrase file lookup
* Note: Make passphrase lookup use the same fallback path for full fingerprints, key IDs, and legacy generic passphrase files.

https://forum.virtualmin.com/t/usermin-gpg-encryption/136781/8?u=ilia
2026-05-11 21:14:12 +02:00
Jamie Cameron
2c8ff4ba15 Merge pull request #2692 from swelljoe/session-dbm
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
Prefer SHA over MD5 or crypt for session hash, other minor session tweaks
2026-05-10 22:03:47 -07:00
Joe Cooper
da0ff56ee0 Cleanup ASCII decorations 2026-05-10 23:04:08 -05:00
Joe Cooper
bf43c793d3 qualify the test name, since other files will get tests 2026-05-10 22:57:15 -05:00
Joe Cooper
46d571c6b5 Add http_error unit tests as useful example 2026-05-10 22:55:41 -05:00
Jamie Cameron
ce1ab74c6f Merge pull request #2694 from swelljoe/login-redirect-password
Remove login_redirect
2.641
2026-05-10 20:13:52 -07:00
Joe Cooper
4472f210b9 Wrap app in unless (caller) so we can require miniserv for unit testing 2026-05-10 22:11:21 -05:00
Joe Cooper
7aeb5e4dd7 Only create session key file when session=1 2026-05-10 20:57:09 -05:00
Joe Cooper
77d817357d Remove login_redirect 2026-05-10 20:52:09 -05:00
Jamie Cameron
350908ed56 changelog update 2026-05-10 17:56:11 -07:00
Jamie Cameron
94ac2ff7d7 New version bump 2026-05-10 17:46:56 -07:00
Jamie Cameron
a24e5371b7 Merge pull request #2691 from swelljoe/add-trusted-proxies
Add trusted_proxies config
2026-05-10 17:37:42 -07:00
Ilia Ross
0810083588 Fix skip hwclock when unavailable #2693
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-10 19:48:18 +02:00
Ilia Ross
2ec6cadbbd Fix not to print newly created module config dirs to stdout 2026-05-10 19:36:28 +02:00
Joe Cooper
4c3f7f5bd9 Omit needless words 2026-05-10 10:58:50 -05:00
Joe Cooper
1b5e48841a Don't fall back to weak session hash, use SHA instead 2026-05-10 03:36:07 -05:00
Joe Cooper
241abfe719 Add trusted_proxies config 2026-05-10 01:19:01 -05:00
Ilia Ross
f78413549b Fix Perl warning
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-10 01:51:40 +02:00
Ilia Ross
b53cce9084 Add logging option to execute command sub
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
299b10a0e8 (r184647207)
2026-05-08 12:31:16 +02:00
Ilia Ross
a92b52f502 Fix text variable typo
https://github.com/webmin/webmin/issues/2686
2026-05-08 11:48:13 +02:00
Jamie Cameron
c0c0cc323c Merge branch 'master' of github.com:webmin/webmin
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2.640
2026-05-06 20:14:54 -07:00
Jamie Cameron
da49c5b9b8 Safely quote slave param 2026-05-06 20:14:30 -07:00
Ilia Ross
5b5c3cc4b1 Fix sensor parsing on SoC hardware where the main chip includes the CPU
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
https://forum.virtualmin.com/t/cpu-temp-id-missing-dashboard/123096/9?u=ilia
2026-05-06 22:16:53 +02:00
Ilia Ross
f0b7f10b64 Fix Fail2Ban default jail options
https://forum.virtualmin.com/t/fail2ban-bug/137165
2026-05-06 19:59:57 +02:00
Ilia Ross
bdad9fd173 Update changelog
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
[no-build]
2026-05-05 23:49:21 +02:00
Ilia Ross
7e01b3eb44 Fix to set XDG runtime and D-Bus env in xterm shells
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2679
2026-05-05 09:41:45 +02:00
Ilia Ross
95fee0cc33 Add nice header generation for saved nftables rules
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-04 17:42:40 +02:00
Jamie Cameron
18a6fc3b53 Fix label
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-03 17:59:52 -07:00
Jamie Cameron
c38793c955 Fix permissions on CGIs 2026-05-03 17:57:24 -07:00
Ilia Ross
45376dee35 Update changelog 2026-05-04 01:29:06 +02:00
Ilia Ross
44ff20e5c6 Fix to perltidy new nftables module to convert spaces to tabs
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
2026-05-03 22:36:31 +02:00
Ilia Ross
159cc14dfc Add a warning message if any foreign firewall modules are detected 2026-05-03 21:39:28 +02:00
Ilia Ross
aa84044375 Add boot-time apply support for nftables rules
* Note: The boot action applies saved module-managed nftables tables, creates the needed wrapper, fixes executable permissions, and removes generated boot files when disabled.
2026-05-03 20:23:48 +02:00
Ilia Ross
02b5c9c121 Fix limit nftables header actions to index page 2026-05-03 19:25:38 +02:00
Ilia Ross
b5518df7bd Fix editable size 2026-05-03 19:13:24 +02:00
Ilia Ross
2c608b2c71 Fix to bump sets elements limit
[no-build]
2026-05-03 19:02:32 +02:00
Ilia Ross
d1523b9648 Add nftables profile ruleset helper
* Note: Add a reusable save_profile_ruleset() API for other modules (like Virtualmin Config), and.

Example:

foreign_require("nftables");
nftables::save_profile_ruleset('profile_virtualmin', 'virtualmin', '*');
2026-05-03 19:00:01 +02:00
Ilia Ross
9987b2d493 Update labels (again) 2026-05-03 18:52:31 +02:00
Ilia Ross
83eb3eeffc Fix to factor nftables profile ruleset generation into library 2026-05-03 18:41:57 +02:00