michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-03-20 16:50:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Use proper function to compare versions https://github.com/virtualmin/virtualmin-gpl/issues/641

Browse Source
This commit is contained in:
Jamie Cameron
2023-09-17 19:39:40 -07:00
parent aa6edf6c55
commit d8fa7f26af
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webmin/update.cgi
View File

@@ -35,7 +35,7 @@ foreach $url (@urls) {
my $nver = $u->[1];
$nver =~ s/^(\d+\.\d+)\..*$/$1/;
next if (%info && $info{'version'} &&
$info{'version'} >= $nver);
&compare_version_numbers($info{'version'}, $nver) >= 0);
if ($in{'show'}) {
# Just tell the user what would be done

3
webmin/webmin-lib.pl
View File

@@ -2458,7 +2458,8 @@ foreach my $u (@$allupdates) {
next if (!%info && !$missing);
# Skip if module has a version, and we already have it
next if (%info && $info{'version'} && $info{'version'} >= $nver);
next if (%info && $info{'version'} &&
&compare_version_numbers($info{'version'}, $nver) >= 0);
# Skip if not supported on this OS
my $osinfo = { 'os_support' => $u->[3] };