michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-10-28 14:11:03 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix global ACL cleanup when deleting groups

Browse Source 
This PR fixes deleted groups leaving their global ACL file behind.

It removes that file alongside the group's module ACL files. Recreating a group with the same name no longer restores its old global permissions.
This commit is contained in:
Ilia Ross
2026-10-23 20:28:25 +02:00
parent 1cade5b59e
commit ad2a1dc44a
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
acl/acl-lib.pl
View File

@@ -1183,7 +1183,9 @@ my $lref = &read_file_lines("$config_directory/webmin.groups");
@$lref = grep { !/^([^:]+):/ || $1 ne $groupname } @$lref;
&flush_file_lines();
&unlock_file("$config_directory/webmin.groups");
&unlink_file(map { "$config_directory/$_/$groupname.gacl" } &list_modules());
# Remove global permissions too, so reusing the name cannot revive old ACLs.
&unlink_file(map { "$config_directory/$_/$groupname.gacl" }
("", &list_modules()));
if ($miniserv{'userdb'}) {
# Also delete from group database