michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-05-04 22:30:33 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix file read security issue

Browse Source
This commit is contained in:
Jamie Cameron
2014-03-10 21:36:20 -07:00
parent 33ff76fe1c
commit 96405cec09
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
webalizer/CHANGELOG
View File

@@ -11,3 +11,4 @@ Added support for AWFFull, a drop in Webalizer replacement. It is used by defaul
---- Changes since 1.670 ----
Converted the UI to use the standard Webmin library.
Converted all code to be perl strict and warnings compliant.
Fixed a security issue that could allow a user without root access to view any file on the system.

16
webalizer/view_log.cgi
View File

@@ -30,16 +30,12 @@ $file =~ /\.\./ || $file =~ /\<|\>|\||\0/ && &error($text{'view_efile'});
my $lconf = &get_log_config($log) || &error($text{'view_elog'}." : $log");
my $full = $lconf->{'dir'}.$file;
my $fh;
open($fh, $full) || &error($text{'view_eopen'}." : $full");
my $data = &eval_as_unix_user($lconf->{'user'} || 'root',
sub { &read_file_contents($full) });
$data || &error($text{'view_eopen'}." : $full");
# Display file contents
if ($full =~ /\.(html|htm)$/i && !$config{'naked'}) {
my $data = "";
my $buf;
while(read($fh, $buf, 1024)) {
$data .= $buf;
}
close($fh);
$data =~ /<TITLE>(.*)<\/TITLE>/i;
my $title = $1;
$data =~ s/^[\000-\377]*<BODY.*>//i;
@@ -64,10 +60,6 @@ else {
$full =~ /\.(html|htm)$/i ? "text/html" :
"text/plain","\n";
print "\n";
my $buf;
while(read($fh, $buf, 1024)) {
print $buf;
}
close($fh);
print $data;
}