michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-03-20 16:50:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1931 from webmin/dev/fix-temp-dir-creation

Browse Source 
Fix to consider temp directory may exists with incorrect permissions
This commit is contained in:
Jamie Cameron
2023-06-22 15:48:37 -07:00
committed by GitHub
parent d3cdbbcc4b 0754367f48
commit 944400a136
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web-lib-funcs.pl
View File

@@ -406,14 +406,17 @@ else {
system("/bin/rm -rf ".
quotemeta($tmp_dir));
}
mkdir($tmp_dir, 0755) || (($mkdirerr = $!), next);
chown($<, $(, $tmp_dir);
chmod(0755, $tmp_dir);
# Directory may exist but has wrong permissions
if (!-d $tmp_dir) {
mkdir($tmp_dir, 0755) || (($mkdirerr = $!), next);
}
chown($<, $(, $tmp_dir) || (($mkdirerr = $!), next);
chmod(0755, $tmp_dir) || (($mkdirerr = $!), next);
}
if ($tries >= 10) {
my @st = lstat($tmp_dir);
$mkdirerr = $mkdirerr ? " : $mkdirerr" : "";
&error("Failed to create temp directory ".
&error("Failed to setup temp directory ".
$tmp_dir.$mkdirerr);
}
}