michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-05-04 22:30:33 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fixed XSS bugs

Browse Source
This commit is contained in:
Jamie Cameron
2007-05-17 17:14:12 +00:00
parent e8b4fe1fe3
commit 7351b39723
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG
View File

@@ -72,3 +72,4 @@ Added support for Slam64 Linux.
---- Changes since 1.340 ----
Added Redhat Enterprise release 5 support.
Requests to the /unauthenticated URL can never execute CGI programs, to provide an extra layer of security against URL escaping attacks.
Fixed XSS bugs in pam_login.cgi.

6
pam_login.cgi
View File

@@ -41,7 +41,7 @@ elsif ($in{'timed_out'}) {
print "$text{'pam_prefix'}\n";
print "<form action=$gconfig{'webprefix'}/pam_login.cgi method=post>\n";
print "<input type=hidden name=cid value='$in{'cid'}'>\n";
print "<input type=hidden name=cid value='",&quote_escape($in{'cid'}),"'>\n";
print "<table border width=40%>\n";
print "<tr $tb> <td><b>$text{'pam_header'}</b></td> </tr>\n";
@@ -58,7 +58,7 @@ else {
if ($in{'message'}) {
# Showing a message
print "<tr> <td colspan=2 align=center>",
$in{'message'},"</td> </tr>\n";
&html_escape($in{'message'}),"</td> </tr>\n";
print "<input type=hidden name=message value=1>\n";
}
else {
@@ -68,7 +68,7 @@ else {
"<tt>$host</tt>"),"</td> </tr>\n";
$pass = "type=password" if ($in{'password'});
print "<tr> <td><b>$in{'question'}</b></td>\n";
print "<tr> <td><b>",&html_escape($in{'question'}),"</b></td>\n";
print "<td><input name=answer $pass size=20></td> </tr>\n";
}