michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-05-04 22:30:33 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Always run commands in sub-shell, to catch missing binaries

Browse Source
This commit is contained in:
Jamie Cameron
2011-12-19 16:44:20 -08:00
parent 0a081d8803
commit 44e2293a87
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web-lib-funcs.pl
View File

@@ -5620,6 +5620,10 @@ $cmd =~ s/^\((.*)\)\s*$/$1/;
$cmd .= $and;
&additional_log('exec', undef, $cmd);
&webmin_debug_log('CMD', "cmd=$cmd") if ($gconfig{'debug_what_cmd'});
if ($realcmd !~ /;|\&\&|\|/) {
# Force run in shell, to get useful output if command doesn't exist
$realcmd = "($realcmd)";
}
return `$realcmd`;
}
@@ -5678,6 +5682,10 @@ if (&is_readonly_mode() && !$_[1]) {
}
my $realcmd = &translate_command($_[0]);
&webmin_debug_log('CMD', "cmd=$realcmd") if ($gconfig{'debug_what_cmd'});
if ($realcmd !~ /;|\&\&|\|/) {
# Force run in shell, to get useful output if command doesn't exist
$realcmd = "($realcmd)";
}
return `$realcmd`;
}