michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-03-11 05:12:03 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix IPsec up command injection via conn name (#3)

Browse Source
This commit is contained in:
Ilia Ross
2026-03-10 17:29:16 +02:00
parent 2c211e557e
commit 1a0aa44dba
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ipsec/up.cgi
View File

@@ -8,8 +8,15 @@ $| = 1;
$theme_no_table++;
&ui_print_header(undef, $text{'up_title'}, "");
# Validate connection name against configured connections
my @conf = &get_config();
my %ok_conns = map { $_->{'value'}, 1 }
grep { $_->{'name'} eq 'conn' && $_->{'value'} ne '%default' }
@conf;
$ok_conns{$in{'conn'}} || &error($text{'save_ename'});
# Try to connect
$cmd = "$config{'ipsec'} auto --up '$in{'conn'}'";
$cmd = "$config{'ipsec'} auto --up ".quotemeta($in{'conn'});
print "<b>",&text('up_cmd', "<tt>$cmd</tt>"),"</b>\n";
print "<pre>";
&foreign_require("proc", "proc-lib.pl");