predict: improve input aspect ratio match fast path

common/src/rtc-signaling.ts

@@ -298,7 +298,7 @@ export async function connectRTCSignalingClients(
     if (offerOptions?.offer && answerOptions?.offer)
         throw new Error('Both RTC clients have offers and can not negotiate. Consider implementing this in @scrypted/webrtc.');
 
-    if (offerOptions?.requiresOffer && answerOptions.requiresOffer)
+    if (offerOptions?.requiresOffer && answerOptions?.requiresOffer)
         throw new Error('Both RTC clients require offers and can not negotiate.');
 
     offerSetup.type = 'offer';

npm-install.sh

@@ -27,13 +27,6 @@ echo "sdk > npm run build"
 npm run build
 popd
 
-pushd external/HAP-NodeJS
-echo "external/HAP-NodeJS > npm install"
-npm install
-echo "external/HAP-NodeJS > npm run build"
-npm run build
-popd
-
 pushd external/werift
 echo "external/werift > npm install"
 npm install

plugins/coreml/package-lock.json

@@ -1,12 +1,12 @@
 {
    "name": "@scrypted/coreml",
-   "version": "0.1.8",
+   "version": "0.1.9",
    "lockfileVersion": 2,
    "requires": true,
    "packages": {
       "": {
          "name": "@scrypted/coreml",
-         "version": "0.1.8",
+         "version": "0.1.9",
          "devDependencies": {
             "@scrypted/sdk": "file:../../sdk"
          }

plugins/coreml/package.json

@@ -41,5 +41,5 @@
    "devDependencies": {
       "@scrypted/sdk": "file:../../sdk"
    },
-   "version": "0.1.8"
+   "version": "0.1.9"
 }

plugins/hikvision/README.md

@@ -41,7 +41,7 @@ The Channel number is the hundreds digit and (sub-)stream is ones digit:
 
 # Troubleshooting
 ## General
-* Not receiving motion alerts in the device's Scrypted event log? Check all of the following: **(1)** device has a motion detection grid drawn and enabled, **(2)** user or group access permissions of account used for device **(3)** do not use self-signed certs for HTTPS on the device, and **(4)** `CGI` and `ISAPI` integration protocol/service on device is enabled. 
+* Not receiving motion alerts in the device's Scrypted event log? Check all of the following: **(1)** device has a motion detection grid drawn and enabled, **(2)** user or group access permissions of account used for device **(3)** do not use self-signed certs for HTTPS on the device, **(4)** `CGI` and `ISAPI` integration protocol/service on device is enabled, and **(5)** that the authentication method on the device is set to "digest". 
 * If device has HTTPS enabled, try disabling HTTPS on the device to see if that resolves issue (do not use self-signed certs).
 * If device has enabled user lockout, max connections, concurrent requests, etc., try disabling and/or increasing to max allowed for troubleshooting.
 * Does your account (`Username`) have proper user and/or group permissions?  Try granting all permissions for testing. 

plugins/ring/package-lock.json

@@ -1,18 +1,18 @@
 {
    "name": "@scrypted/ring",
-   "version": "0.0.107",
+   "version": "0.0.109",
    "lockfileVersion": 3,
    "requires": true,
    "packages": {
       "": {
          "name": "@scrypted/ring",
-         "version": "0.0.107",
+         "version": "0.0.109",
          "dependencies": {
             "@koush/ring-client-api": "file:../../external/ring-client-api",
             "@scrypted/common": "file:../../common",
             "@scrypted/sdk": "file:../../sdk",
-            "@types/node": "^18.15.3",
-            "axios": "^1.3.4",
+            "@types/node": "^18.15.11",
+            "axios": "^1.3.5",
             "rxjs": "^7.8.0"
          },
          "optionalDependencies": {
@@ -42,14 +42,14 @@
          ],
          "devDependencies": {
             "@changesets/changelog-github": "^0.4.8",
-            "@changesets/cli": "^2.26.0",
+            "@changesets/cli": "^2.26.1",
             "@swc-node/register": "^1.6.2",
-            "turbo": "^1.8.2"
+            "turbo": "^1.8.5"
          }
       },
       "../../sdk": {
          "name": "@scrypted/sdk",
-         "version": "0.2.85",
+         "version": "0.2.86",
          "license": "ISC",
          "dependencies": {
             "@babel/preset-typescript": "^7.18.6",
@@ -148,9 +148,9 @@
          }
       },
       "node_modules/@types/node": {
-         "version": "18.15.3",
-         "resolved": "https://registry.npmjs.org/@types/node/-/node-18.15.3.tgz",
-         "integrity": "sha512-p6ua9zBxz5otCmbpb5D3U4B5Nanw6Pk3PPyX05xnxbB/fRv71N7CPmORg7uAD5P70T0xmx1pzAx/FUfa5X+3cw=="
+         "version": "18.15.11",
+         "resolved": "https://registry.npmjs.org/@types/node/-/node-18.15.11.tgz",
+         "integrity": "sha512-E5Kwq2n4SbMzQOn6wnmBjuK9ouqlURrcZDVfbo9ftDDTFt3nk7ZKK4GMOzoYgnpQJKcxwQw+lGaBvvlMo0qN/Q=="
       },
       "node_modules/@types/responselike": {
          "version": "1.0.0",
@@ -179,9 +179,9 @@
          "integrity": "sha512-Oei9OH4tRh0YqU3GxhX79dM/mwVgvbZJaSNaRk+bshkj0S5cfHcgYakreBjrHwatXKbz+IoIdYLxrKim2MjW0Q=="
       },
       "node_modules/axios": {
-         "version": "1.3.4",
-         "resolved": "https://registry.npmjs.org/axios/-/axios-1.3.4.tgz",
-         "integrity": "sha512-toYm+Bsyl6VC5wSkfkbbNB6ROv7KY93PEBBL6xyDczaIHasAiv4wPqQ/c4RjoQzipxRD2W5g21cOqQulZ7rHwQ==",
+         "version": "1.3.5",
+         "resolved": "https://registry.npmjs.org/axios/-/axios-1.3.5.tgz",
+         "integrity": "sha512-glL/PvG/E+xCWwV8S6nCHcrfg1exGx7vxyUIivIA1iL7BIh6bePylCfVHwp6k13ao7SATxB6imau2kqY+I67kw==",
          "dependencies": {
             "follow-redirects": "^1.15.0",
             "form-data": "^4.0.0",

plugins/ring/package.json

@@ -36,13 +36,13 @@
       "@koush/ring-client-api": "file:../../external/ring-client-api",
       "@scrypted/common": "file:../../common",
       "@scrypted/sdk": "file:../../sdk",
-      "@types/node": "^18.15.3",
-      "axios": "^1.3.4",
+      "@types/node": "^18.15.11",
+      "axios": "^1.3.5",
       "rxjs": "^7.8.0"
    },
    "optionalDependencies": {
       "got": "11.8.6",
       "socket.io-client": "^2.5.0"
    },
-   "version": "0.0.107"
+   "version": "0.0.109"
 }

plugins/ring/src/main.ts

@@ -2,6 +2,7 @@ import sdk, { Device, DeviceProvider, ScryptedDeviceBase, ScryptedDeviceType, Sc
 import { StorageSettings } from '@scrypted/sdk/storage-settings';
 import { RingLocationDevice } from './location';
 import { generateUuid, Location, RingBaseApi, RingRestClient } from './ring-client-api';
+import { sleep } from '@scrypted/common/src/sleep';
 
 const { deviceManager, mediaManager } = sdk;
 
@@ -19,12 +20,18 @@ class RingPlugin extends ScryptedDeviceBase implements DeviceProvider, Settings
         },
         email: {
             title: 'Email',
-            onPut: async () => this.clearTryDiscoverDevices(),
+            onPut: async () => {
+                if (await this.loginNextTick())
+                    this.clearTryDiscoverDevices();
+            },
         },
         password: {
             title: 'Password',
             type: 'password',
-            onPut: async () => this.clearTryDiscoverDevices(),
+            onPut: async () => {
+                if (await this.loginNextTick())
+                    this.clearTryDiscoverDevices();
+            },
         },
         loginCode: {
             title: 'Two Factor Code',
@@ -72,8 +79,18 @@ class RingPlugin extends ScryptedDeviceBase implements DeviceProvider, Settings
             this.settingsStorage.values.systemId = generateUuid();
     }
 
+    waiting = false;
+    async loginNextTick() {
+        if (this.waiting)
+            return false;
+        this.waiting = true;
+        await sleep(500);
+        this.waiting = false;
+        return true;
+    }
+
     async clearTryDiscoverDevices() {
-        this.settingsStorage.values.refreshToken = undefined;
+        this.settingsStorage.values.refreshToken = '';
         await this.discoverDevices();
         this.console.log('discovery completed successfully');
     }
@@ -192,7 +209,7 @@ class RingPlugin extends ScryptedDeviceBase implements DeviceProvider, Settings
         return this.devices.get(nativeId);
     }
 
-    async releaseDevice(id: string, nativeId: string): Promise<void> {}
+    async releaseDevice(id: string, nativeId: string): Promise<void> { }
 }
 
 export default RingPlugin;

plugins/tensorflow-lite/.vscode/settings.json

@@ -1,16 +1,16 @@
 
 {
     // docker installation
-    // "scrypted.debugHost": "koushik-windows",
-    // "scrypted.serverRoot": "/server",
+    "scrypted.debugHost": "koushik-ubuntu",
+    "scrypted.serverRoot": "/server",
 
     // pi local installation
     // "scrypted.debugHost": "192.168.2.119",
     // "scrypted.serverRoot": "/home/pi/.scrypted",
 
     // local checkout
-    "scrypted.debugHost": "127.0.0.1",
-    "scrypted.serverRoot": "/Users/koush/.scrypted",
+    // "scrypted.debugHost": "127.0.0.1",
+    // "scrypted.serverRoot": "/Users/koush/.scrypted",
     // "scrypted.debugHost": "koushik-windows",
     // "scrypted.serverRoot": "C:\\Users\\koush\\.scrypted",
 

plugins/tensorflow-lite/package-lock.json

@@ -1,12 +1,12 @@
 {
    "name": "@scrypted/tensorflow-lite",
-   "version": "0.1.8",
+   "version": "0.1.9",
    "lockfileVersion": 2,
    "requires": true,
    "packages": {
       "": {
          "name": "@scrypted/tensorflow-lite",
-         "version": "0.1.8",
+         "version": "0.1.9",
          "devDependencies": {
             "@scrypted/sdk": "file:../../sdk"
          }

plugins/tensorflow-lite/package.json

@@ -44,5 +44,5 @@
    "devDependencies": {
       "@scrypted/sdk": "file:../../sdk"
    },
-   "version": "0.1.8"
+   "version": "0.1.9"
 }

plugins/tensorflow-lite/src/predict/__init__.py

@@ -47,13 +47,6 @@ def parse_label_contents(contents: str):
             ret[row_number] = content.strip()
     return ret
 
-class RawImage:
-    jpegMediaObject: scrypted_sdk.MediaObject
-
-    def __init__(self, image: Image.Image):
-        self.image = image
-        self.jpegMediaObject = None
-
 def is_same_box(bb1, bb2, threshold = .7):
     r1 = from_bounding_box(bb1)
     r2 = from_bounding_box(bb2)
@@ -146,10 +139,6 @@ class PredictPlugin(DetectPlugin, scrypted_sdk.BufferConverter, scrypted_sdk.Set
     def getTriggerClasses(self) -> list[str]:
         return ['motion']
 
-    async def createMedia(self, data: RawImage) -> scrypted_sdk.MediaObject:
-        mo = await scrypted_sdk.mediaManager.createMediaObject(data, self.fromMimeType)
-        return mo
-
     def requestRestart(self):
         asyncio.ensure_future(scrypted_sdk.deviceManager.requestRestart())
 
@@ -226,15 +215,28 @@ class PredictPlugin(DetectPlugin, scrypted_sdk.BufferConverter, scrypted_sdk.Set
         settings = detection_session and detection_session.get('settings')
         src_size = videoFrame.width, videoFrame.height
         w, h = self.get_input_size()
+        input_aspect_ratio = w / h
         iw, ih = src_size
+        src_aspect_ratio = iw / ih
         ws = w / iw
         hs = h / ih
         s = max(ws, hs)
-        if ws == 1 and hs == 1:
+
+        # image is already correct aspect ratio, so it can be processed in a single pass.
+        if input_aspect_ratio == src_aspect_ratio:
             def cvss(point):
                 return point[0], point[1]
 
+            # aspect ratio matches, but image must be scaled.
+            resize = None
+            if ih != w:
+                resize = {
+                    'width': w,
+                    'height': h,
+                }
+
             data = await videoFrame.toBuffer({
+                'resize': resize,
                 'format': videoFrame.format or 'rgb',
             })
             image = await ensureRGBData(data, (w, h), videoFrame.format)

plugins/tensorflow/package-lock.json

@@ -1,12 +1,12 @@
 {
    "name": "@scrypted/tensorflow-lite",
-   "version": "0.1.8",
+   "version": "0.1.9",
    "lockfileVersion": 2,
    "requires": true,
    "packages": {
       "": {
          "name": "@scrypted/tensorflow-lite",
-         "version": "0.1.8",
+         "version": "0.1.9",
          "devDependencies": {
             "@scrypted/sdk": "file:../../sdk"
          }

plugins/tensorflow/package.json

@@ -41,5 +41,5 @@
    "devDependencies": {
       "@scrypted/sdk": "file:../../sdk"
    },
-   "version": "0.1.8"
+   "version": "0.1.9"
 }

sdk/types/scrypted_python/scrypted_sdk/other.py

@@ -1,6 +1,9 @@
 from __future__ import annotations
 from typing import AbstractSet, Any, Callable
-from typing_extensions import TypedDict
+try:
+    from typing import TypedDict
+except:
+    from typing_extensions import TypedDict
 
 SettingValue = str
 EventListener = Callable[[Any, Any, Any], None]

sdk/types/scrypted_python/scrypted_sdk/types.py

@@ -1,6 +1,9 @@
 from __future__ import annotations
 from enum import Enum
-from typing_extensions import TypedDict
+try:
+    from typing import TypedDict
+except:
+    from typing_extensions import TypedDict
 from typing import Any
 from typing import Callable
 

sdk/types/src/build.ts

@@ -256,7 +256,10 @@ class ${td.name}(TypedDict):
 
 const pythonTypes = `from __future__ import annotations
 from enum import Enum
-from typing_extensions import TypedDict
+try:
+    from typing import TypedDict
+except:
+    from typing_extensions import TypedDict
 from typing import Any
 from typing import Callable
 

server/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@scrypted/server",
-  "version": "0.7.46",
+  "version": "0.7.50",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@scrypted/server",
-      "version": "0.7.46",
+      "version": "0.7.50",
       "license": "ISC",
       "dependencies": {
         "@mapbox/node-pre-gyp": "^1.0.10",

server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scrypted/server",
-  "version": "0.7.46",
+  "version": "0.7.52",
   "description": "",
   "dependencies": {
     "@mapbox/node-pre-gyp": "^1.0.10",
@@ -72,7 +72,8 @@
     "prebeta": "npm version patch && git add package.json && npm run build && git commit -m prebeta",
     "beta": "npm publish --tag beta",
     "release": "npm publish",
-    "postrelease": "git tag v$npm_package_version && git push origin v$npm_package_version && npm version patch && git add package.json && npm run build && git commit -m postrelease",
+    "prepublish": "npm run build",
+    "postrelease": "git tag v$npm_package_version && git push origin v$npm_package_version && npm version patch && git add package.json && git commit -m postrelease",
     "docker": "scripts/github-workflow-publish-docker.sh"
   },
   "author": "",

server/python/plugin_remote.py

@@ -2,13 +2,12 @@ from __future__ import annotations
 
 import asyncio
 import gc
-import sys
 import os
 import platform
 import shutil
 import subprocess
+import sys
 import threading
-import concurrent.futures
 import time
 import traceback
 import zipfile
@@ -21,14 +20,23 @@ from os import sys
 from typing import Any, Optional, Set, Tuple
 
 import scrypted_python.scrypted_sdk.types
-from scrypted_python.scrypted_sdk import ScryptedStatic, PluginFork
-from scrypted_python.scrypted_sdk.types import Device, DeviceManifest, EventDetails, ScryptedInterfaceProperty, Storage
-from typing_extensions import TypedDict
-import rpc
-import rpc_reader
+from scrypted_python.scrypted_sdk import PluginFork, ScryptedStatic
+from scrypted_python.scrypted_sdk.types import (Device, DeviceManifest,
+                                                EventDetails,
+                                                ScryptedInterfaceProperty,
+                                                Storage)
+
+try:
+    from typing import TypedDict
+except:
+    from typing_extensions import TypedDict
+
+import hashlib
 import multiprocessing
 import multiprocessing.connection
-import hashlib
+
+import rpc
+import rpc_reader
 
 class SystemDeviceState(TypedDict):
     lastEventTime: int

server/python/rpc.py

@@ -1,8 +1,13 @@
-from asyncio.futures import Future
-from typing import Any, Callable, Dict, Mapping, List
-import traceback
 import inspect
-from typing_extensions import TypedDict
+import traceback
+from asyncio.futures import Future
+from typing import Any, Callable, Dict, List, Mapping
+
+try:
+    from typing import TypedDict
+except:
+    from typing_extensions import TypedDict
+
 import weakref
 
 jsonSerializable = set()

server/src/plugin/plugin-npm-dependencies.ts

@@ -9,6 +9,19 @@ import rimraf from "rimraf";
 import semver from 'semver';
 import { ensurePluginVolume } from "./plugin-volume";
 
+export function defaultNpmExec(args: string[], options: child_process.SpawnOptions) {
+    let npm = 'npm';
+    if (os.platform() === 'win32')
+        npm += '.cmd';
+    const cp = child_process.spawn(npm,  args, options);
+    return cp;
+}
+
+let npmExecFunction = defaultNpmExec;
+export function setNpmExecFunction(f: typeof npmExecFunction) {
+    npmExecFunction = f;
+}
+
 export function getPluginNodePath(name: string) {
     const pluginVolume = ensurePluginVolume(name);
     const nodeMajorVersion = semver.parse(process.version).major;
@@ -56,10 +69,7 @@ export async function installOptionalDependencies(console: Console, packageJson:
         mkdirp.sync(nodePrefix);
         fs.writeFileSync(packageJsonPath, JSON.stringify(reduced));
 
-        let npm = 'npm';
-        if (os.platform() === 'win32')
-            npm += '.cmd';
-        const cp = child_process.spawn(npm, ['--prefix', nodePrefix, 'install'], {
+        const cp = npmExecFunction(['--prefix', nodePrefix, 'install'], {
             cwd: nodePrefix,
             stdio: 'inherit',
         });