michael/scrypted
1
0
Fork 0
mirror of https://github.com/koush/scrypted.git synced 2026-09-16 00:30:38 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

server/rpc: fix yielded async generator leak https://github.com/koush/scrypted/issues/2121

Browse Source
This commit is contained in:
Koushik Dutta
2026-08-14 13:25:58 -07:00
parent f58c30072a
commit c74f5c82c0
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/src/rpc.ts
View File

@@ -357,6 +357,13 @@ export class RpcPeer {
return proxyProps?.next || 'next';
}
static getIteratorReturn(target: any): string | undefined {
if (!target[Symbol.asyncIterator])
return undefined;
const proxyProps = target[this.PROPERTY_PROXY_PROPERTIES]?.[Symbol.asyncIterator.toString()];
return proxyProps?.return || 'return';
}
static prepareProxyProperties(value: any) {
let props = value?.[RpcPeer.PROPERTY_PROXY_PROPERTIES];
if (!value[Symbol.asyncIterator])
@@ -760,7 +767,8 @@ export class RpcPeer {
throw new Error(`target ${target?.constructor?.name} does not have method ${rpcApply.method}`);
const isIteratorNext = RpcPeer.getIteratorNext(target) === rpcApply.method;
if (isIteratorNext)
const isIteratorReturn = RpcPeer.getIteratorReturn(target) === rpcApply.method;
if (isIteratorNext || isIteratorReturn)
this.yieldedAsyncIterators.delete(target);
value = await target[rpcApply.method](...args);