michael/scrypted
1
0
Fork 0
mirror of https://github.com/koush/scrypted.git synced 2026-05-05 22:00:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: refactor serviceKey undefined handling

Browse Source 
Check serviceKey directly after parsing instead of checking existing?.serviceKey.
This fixes a bug where key parsing failures would be silently ignored.
This commit is contained in:
Koushik Dutta
2026-04-02 12:45:17 -07:00
parent 65199ecdf7
commit 9cfa6ea58b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/cert.ts
View File

@@ -15,7 +15,7 @@ export interface SelfSignedCertificate {
};
export function createSelfSignedCertificate(existing?: SelfSignedCertificate): SelfSignedCertificate {
let serviceKey: ReturnType<typeof pki.privateKeyFromPem>;
let serviceKey: ReturnType<typeof pki.privateKeyFromPem> | undefined;
// check if existing key is usable
if (existing?.certificate && existing?.serviceKey && existing?.version === CURRENT_SELF_SIGNED_CERTIFICATE_VERSION) {
try {
@@ -30,7 +30,7 @@ export function createSelfSignedCertificate(existing?: SelfSignedCertificate): S
const certificate = pki.createCertificate();
if (existing?.serviceKey) {
if (serviceKey) {
certificate.publicKey = pki.rsa.setPublicKey(serviceKey.n, serviceKey.e);
}
else {