michael/scrypted
1
0
Fork 0
mirror of https://github.com/koush/scrypted.git synced 2026-05-16 10:20:23 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

security: require explicit address on all server listens

Browse Source
This commit is contained in:
Koushik Dutta
2024-07-25 18:33:16 -07:00
parent e9288bd4a1
commit 7d2df3af42
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/webrtc/src/rtp-forwarders.ts
View File

@@ -293,7 +293,7 @@ export async function startRtpForwarderProcess(console: Console, ffmpegInput: FF
}
});
const audioClient = await listenZeroSingleClient();
const audioClient = await listenZeroSingleClient('127.0.0.1');
let audioPipe: Writable;
killDeferred.promise.finally(() => audioClient.clientPromise.then(client => client.destroy()));
let rtspServer: RtspServer;
@@ -421,7 +421,7 @@ export async function startRtpForwarderProcess(console: Console, ffmpegInput: FF
// seems better to use udp for audio timing/chop.
const useUdp = rtspMode === 'udp';
const serverPort = await listenZeroSingleClient();
const serverPort = await listenZeroSingleClient('127.0.0.1');
args.push(
'-rtsp_transport',

4
server/src/listen-zero.ts
View File

@@ -7,13 +7,13 @@ export class ListenZeroSingleClientTimeoutError extends Error {
}
}
export async function listenZero(server: net.Server, hostname?: string) {
export async function listenZero(server: net.Server, hostname: string) {
server.listen(0, hostname);
await once(server, 'listening');
return (server.address() as net.AddressInfo).port;
}
export async function listenZeroSingleClient(hostname?: string, options?: net.ServerOpts, listenTimeout = 30000) {
export async function listenZeroSingleClient(hostname: string, options?: net.ServerOpts, listenTimeout = 30000) {
const server = new net.Server(options);
const port = await listenZero(server, hostname);