michael/scrypted
1
0
Fork 0
mirror of https://github.com/koush/scrypted.git synced 2026-09-26 13:40:39 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(homekit): decode Opus with libopus for HKSV recordings (#1617) (#2158)

Browse Source 
ffmpeg's native opus decoder mis-parses SILK in-band FEC (LBRR) frames
and outputs loud bursts of noise. Ring cameras send 60 ms SILK packets
with in-band FEC, so every HKSV recording transcoded from them to AAC
contained full-scale static. Force the libopus decoder when the
recording source audio is Opus; the plugin already depends on libopus
for live stream audio transcoding.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Armando Garcia
2026-09-23 20:36:30 -07:00
committed by GitHub
parent 8a682f102b
commit 5ed7603ff6
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/homekit/src/types/camera/camera-recording.ts
View File

@@ -176,6 +176,10 @@ export async function* handleFragmentsRequests(streamId: number, device: Scrypte
}
}
// ffmpeg's native opus decoder mis-parses SILK in-band FEC (LBRR) frames,
// which Ring cameras send, and outputs loud bursts of noise. libopus decodes them correctly.
if (audioCodec?.toLowerCase() === 'opus')
inputArguments.push('-c:a', 'libopus');
inputArguments.push(...ffmpegInput.inputArguments);
if (noAudio) {