update: Only restart containers when images change (#143)

* update: Only restart containers when images change

Use `up -d --pull always --build` instead of separate pull/build/down/up
steps. This avoids unnecessary container restarts when images haven't
changed.

* Update README.md

* docs: Update update command description across all docs

Reflect new behavior: only recreates containers if images changed.

* Update README.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

CLAUDE.md

@@ -138,7 +138,7 @@ CLI available as `cf` or `compose-farm`.
 | `stop`  | Stop services without removing containers (`docker compose stop`) |
 | `pull`  | Pull latest images |
 | `restart` | `down` + `up -d` |
-| `update` | `pull` + `build` + `down` + `up -d` |
+| `update` | Pull, build, recreate only if changed (`up -d --pull always --build`) |
 | `apply` | Make reality match config: migrate stacks + stop orphans. Use `--dry-run` to preview |
 | `compose` | Run any docker compose command on a stack (passthrough) |
 | `logs`  | Show stack logs |

README.md

@@ -370,7 +370,7 @@ The CLI is available as both `compose-farm` and the shorter `cf` alias.
 | `cf down <stack>` | Stop and remove stack containers |
 | `cf stop <stack>` | Stop stack without removing containers |
 | `cf restart <stack>` | down + up |
-| `cf update <stack>` | pull + build + down + up |
+| `cf update <stack>` | Pull, build, recreate only if changed |
 | `cf pull <stack>` | Pull latest images |
 | `cf logs -f <stack>` | Follow logs |
 | `cf ps` | Show status of all stacks |
@@ -403,7 +403,7 @@ cf pull --all
 # Restart (down + up)
 cf restart plex
 
-# Update (pull + build + down + up) - the end-to-end update command
+# Update (pull + build, only recreates containers if images changed)
 cf update --all
 
 # Update state from reality (discovers running stacks + captures digests)
@@ -475,8 +475,7 @@ Full `--help` output for each command. See the [Usage](#usage) table above for a
 │ pull           Pull latest images (docker compose pull).                     │
 │ restart        Restart stacks (down + up). With --service, restarts just     │
 │                that service.                                                 │
-│ update         Update stacks (pull + build + down + up). With --service,     │
-│                updates just that service.                                    │
+│ update         Update stacks. Only recreates containers if images changed.   │
 │ apply          Make reality match config (start, migrate, stop               │
 │                strays/orphans as needed).                                    │
 │ compose        Run any docker compose command on a stack.                    │
@@ -694,8 +693,7 @@ Full `--help` output for each command. See the [Usage](#usage) table above for a
 
  Usage: cf update [OPTIONS] [STACKS]...
 
- Update stacks (pull + build + down + up). With --service, updates just that
- service.
+ Update stacks. Only recreates containers if images changed.
 
 ╭─ Arguments ──────────────────────────────────────────────────────────────────╮
 │   stacks      [STACKS]...  Stacks to operate on                              │

docs/commands.md

@@ -15,7 +15,7 @@ The Compose Farm CLI is available as both `compose-farm` and the shorter alias `
 | | `down` | Stop stacks |
 | | `stop` | Stop services without removing containers |
 | | `restart` | Restart stacks (down + up) |
-| | `update` | Update stacks (pull + build + down + up) |
+| | `update` | Update stacks (only recreates if images changed) |
 | | `pull` | Pull latest images |
 | | `compose` | Run any docker compose command |
 | **Monitoring** | `ps` | Show stack status |
@@ -225,7 +225,7 @@ cf restart immich --service database
 
 ### cf update
 
-Update stacks (pull + build + down + up). With `--service`, updates just that service.
+Update stacks. Only recreates containers if images changed. With `--service`, updates just that service.
 
 <video autoplay loop muted playsinline>
   <source src="/assets/update.webm" type="video/webm">

docs/demos/cli/update.tape

@@ -1,5 +1,5 @@
 # Update Demo
-# Shows updating stacks (pull + build + down + up)
+# Shows updating stacks (only recreates containers if images changed)
 
 Output docs/assets/update.gif
 Output docs/assets/update.webm

docs/getting-started.md

@@ -329,7 +329,7 @@ cf apply
 
 ```bash
 cf update --all
-# Runs: pull + build + down + up for each stack
+# Only recreates containers if images changed
 ```
 
 ## Next Steps

src/compose_farm/cli/common.py

@@ -4,7 +4,6 @@ from __future__ import annotations
 
 import asyncio
 import contextlib
-import os
 from pathlib import Path
 from typing import TYPE_CHECKING, Annotated, TypeVar
 
@@ -69,21 +68,6 @@ ServiceOption = Annotated[
 _MISSING_PATH_PREVIEW_LIMIT = 2
 _STATS_PREVIEW_LIMIT = 3  # Max number of pending migrations to show by name
 
-# Environment variable to identify the web stack (for self-update ordering)
-CF_WEB_STACK = os.environ.get("CF_WEB_STACK", "")
-
-
-def sort_web_stack_last(stacks: list[str]) -> list[str]:
-    """Move the web stack to the end of the list.
-
-    When updating all stacks, the web UI stack (compose-farm) should be updated
-    last. Otherwise, the container restarts mid-process and cancels remaining
-    updates. The CF_WEB_STACK env var identifies the web stack.
-    """
-    if CF_WEB_STACK and CF_WEB_STACK in stacks:
-        return [s for s in stacks if s != CF_WEB_STACK] + [CF_WEB_STACK]
-    return stacks
-
 
 def format_host(host: str | list[str]) -> str:
     """Format a host value for display."""

src/compose_farm/cli/lifecycle.py

@@ -23,7 +23,6 @@ from compose_farm.cli.common import (
     maybe_regenerate_traefik,
     report_results,
     run_async,
-    sort_web_stack_last,
     validate_host_for_stack,
     validate_stacks,
 )
@@ -172,8 +171,6 @@ def restart(
         raw = True
         results = run_async(run_on_stacks(cfg, stack_list, f"restart {service}", raw=raw))
     else:
-        # Sort web stack last to avoid self-restart canceling remaining restarts
-        stack_list = sort_web_stack_last(stack_list)
         raw = len(stack_list) == 1
         results = run_async(run_sequential_on_stacks(cfg, stack_list, ["down", "up -d"], raw=raw))
     maybe_regenerate_traefik(cfg, results)
@@ -187,36 +184,17 @@ def update(
     service: ServiceOption = None,
     config: ConfigOption = None,
 ) -> None:
-    """Update stacks (pull + build + down + up). With --service, updates just that service."""
+    """Update stacks. Only recreates containers if images changed."""
     stack_list, cfg = get_stacks(stacks or [], all_stacks, config)
     if service:
         if len(stack_list) != 1:
             print_error("--service requires exactly one stack")
             raise typer.Exit(1)
-        # For service-level update: pull + build + stop + up (stop instead of down)
-        raw = True
-        results = run_async(
-            run_sequential_on_stacks(
-                cfg,
-                stack_list,
-                [
-                    f"pull --ignore-buildable {service}",
-                    f"build {service}",
-                    f"stop {service}",
-                    f"up -d {service}",
-                ],
-                raw=raw,
-            )
-        )
+        cmd = f"up -d --pull always --build {service}"
     else:
-        # Sort web stack last to avoid self-restart canceling remaining updates
-        stack_list = sort_web_stack_last(stack_list)
-        raw = len(stack_list) == 1
-        results = run_async(
-            run_sequential_on_stacks(
-                cfg, stack_list, ["pull --ignore-buildable", "build", "down", "up -d"], raw=raw
-            )
-        )
+        cmd = "up -d --pull always --build"
+    raw = len(stack_list) == 1
+    results = run_async(run_on_stacks(cfg, stack_list, cmd, raw=raw))
     maybe_regenerate_traefik(cfg, results)
     report_results(results)
 
@@ -333,11 +311,6 @@ def apply(  # noqa: C901, PLR0912, PLR0915 (multi-phase reconciliation needs the
         console.print(f"\n{MSG_DRY_RUN}")
         return
 
-    # Sort web stack last in each phase to avoid self-restart canceling remaining work
-    migrations = sort_web_stack_last(migrations)
-    missing = sort_web_stack_last(missing)
-    to_refresh = sort_web_stack_last(to_refresh)
-
     # Execute changes
     console.print()
     all_results = []

src/compose_farm/web/routes/actions.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import asyncio
+import os
 import uuid
 from typing import TYPE_CHECKING, Any
 
@@ -14,6 +15,9 @@ if TYPE_CHECKING:
 from compose_farm.web.deps import get_config
 from compose_farm.web.streaming import run_cli_streaming, run_compose_streaming, tasks
 
+# Environment variable to identify the web stack (for exclusion from bulk updates)
+CF_WEB_STACK = os.environ.get("CF_WEB_STACK", "")
+
 router = APIRouter(tags=["actions"])
 
 # Store task references to prevent garbage collection
@@ -96,7 +100,15 @@ async def pull_all() -> dict[str, Any]:
 
 @router.post("/update-all")
 async def update_all() -> dict[str, Any]:
-    """Update all stacks (pull + build + down + up)."""
+    """Update all stacks, excluding the web stack. Only recreates if images changed.
+
+    The web stack is excluded to prevent the UI from shutting down mid-operation.
+    Use 'cf update <web-stack>' manually to update the web UI.
+    """
     config = get_config()
-    task_id = _start_task(lambda tid: run_cli_streaming(config, ["update", "--all"], tid))
-    return {"task_id": task_id, "command": "update --all"}
+    # Get all stacks except the web stack to avoid self-shutdown
+    stacks = [s for s in config.stacks if s != CF_WEB_STACK]
+    if not stacks:
+        return {"task_id": "", "command": "update (no stacks)", "skipped": True}
+    task_id = _start_task(lambda tid: run_cli_streaming(config, ["update", *stacks], tid))
+    return {"task_id": task_id, "command": f"update {' '.join(stacks)}"}

src/compose_farm/web/static/app.js

@@ -608,7 +608,7 @@ function playFabIntro() {
             cmd('action', 'Apply', 'Make reality match config', dashboardAction('apply'), icons.check),
             cmd('action', 'Refresh', 'Update state from reality', dashboardAction('refresh'), icons.refresh_cw),
             cmd('action', 'Pull All', 'Pull latest images for all stacks', dashboardAction('pull-all'), icons.cloud_download),
-            cmd('action', 'Update All', 'Update all stacks', dashboardAction('update-all'), icons.refresh_cw),
+            cmd('action', 'Update All', 'Update all stacks except web', dashboardAction('update-all'), icons.refresh_cw),
             cmd('app', 'Theme', 'Change color theme', openThemePicker, icons.palette),
             cmd('app', 'Dashboard', 'Go to dashboard', nav('/'), icons.home),
             cmd('app', 'Live Stats', 'View all containers across hosts', nav('/live-stats'), icons.box),

src/compose_farm/web/templates/index.html

@@ -18,7 +18,7 @@
         {{ action_btn("Apply", "/api/apply", "primary", "Make reality match config", check()) }}
         {{ action_btn("Refresh", "/api/refresh", "outline", "Update state from reality", refresh_cw()) }}
         {{ action_btn("Pull All", "/api/pull-all", "outline", "Pull latest images for all stacks", cloud_download()) }}
-        {{ action_btn("Update All", "/api/update-all", "outline", "Update all stacks (pull + build + down + up)", rotate_cw()) }}
+        {{ action_btn("Update All", "/api/update-all", "outline", "Update all stacks except web (only restarts if changed)", rotate_cw()) }}
         <div class="tooltip" data-tip="Save compose-farm.yaml config file"><button id="save-config-btn" class="btn btn-outline">{{ save() }} Save Config</button></div>
     </div>
 

src/compose_farm/web/templates/stack.html

@@ -23,7 +23,7 @@
         {{ action_btn("Up", "/api/stack/" ~ name ~ "/up", "primary", "Start stack (docker compose up -d)", play()) }}
         {{ action_btn("Down", "/api/stack/" ~ name ~ "/down", "outline", "Stop stack (docker compose down)", square()) }}
         {{ action_btn("Restart", "/api/stack/" ~ name ~ "/restart", "secondary", "Restart stack (down + up)", rotate_cw()) }}
-        {{ action_btn("Update", "/api/stack/" ~ name ~ "/update", "accent", "Update to latest (pull + build + down + up)", download()) }}
+        {{ action_btn("Update", "/api/stack/" ~ name ~ "/update", "accent", "Update to latest (only restarts if changed)", download()) }}
 
         <div class="divider divider-horizontal mx-0"></div>
 

tests/test_cli_lifecycle.py

@@ -437,71 +437,3 @@ class TestDownOrphaned:
             )
 
         assert exc_info.value.exit_code == 1
-
-
-class TestSortWebStackLast:
-    """Tests for the sort_web_stack_last helper."""
-
-    def test_no_web_stack_env(self) -> None:
-        """When CF_WEB_STACK is not set, list is unchanged."""
-        from compose_farm.cli import common
-
-        original = common.CF_WEB_STACK
-        try:
-            common.CF_WEB_STACK = ""
-            stacks = ["a", "b", "c"]
-            result = common.sort_web_stack_last(stacks)
-            assert result == ["a", "b", "c"]
-        finally:
-            common.CF_WEB_STACK = original
-
-    def test_web_stack_not_in_list(self) -> None:
-        """When web stack is not in list, list is unchanged."""
-        from compose_farm.cli import common
-
-        original = common.CF_WEB_STACK
-        try:
-            common.CF_WEB_STACK = "webstack"
-            stacks = ["a", "b", "c"]
-            result = common.sort_web_stack_last(stacks)
-            assert result == ["a", "b", "c"]
-        finally:
-            common.CF_WEB_STACK = original
-
-    def test_web_stack_moved_to_end(self) -> None:
-        """When web stack is in list, it's moved to the end."""
-        from compose_farm.cli import common
-
-        original = common.CF_WEB_STACK
-        try:
-            common.CF_WEB_STACK = "webstack"
-            stacks = ["a", "webstack", "b", "c"]
-            result = common.sort_web_stack_last(stacks)
-            assert result == ["a", "b", "c", "webstack"]
-        finally:
-            common.CF_WEB_STACK = original
-
-    def test_web_stack_already_last(self) -> None:
-        """When web stack is already last, list is unchanged."""
-        from compose_farm.cli import common
-
-        original = common.CF_WEB_STACK
-        try:
-            common.CF_WEB_STACK = "webstack"
-            stacks = ["a", "b", "webstack"]
-            result = common.sort_web_stack_last(stacks)
-            assert result == ["a", "b", "webstack"]
-        finally:
-            common.CF_WEB_STACK = original
-
-    def test_empty_list(self) -> None:
-        """Empty list returns empty list."""
-        from compose_farm.cli import common
-
-        original = common.CF_WEB_STACK
-        try:
-            common.CF_WEB_STACK = "webstack"
-            result = common.sort_web_stack_last([])
-            assert result == []
-        finally:
-            common.CF_WEB_STACK = original

tests/test_operations.py

@@ -98,19 +98,18 @@ class TestMigrationCommands:
 class TestUpdateCommandSequence:
     """Tests for update command sequence."""
 
-    def test_update_command_sequence_includes_build(self) -> None:
-        """Update command should use pull --ignore-buildable and build."""
+    def test_update_command_uses_pull_always_and_build(self) -> None:
+        """Update command should use --pull always --build flags."""
         # This is a static check of the command sequence in lifecycle.py
         # The actual command sequence is defined in the update function
 
         source = inspect.getsource(lifecycle.update)
 
-        # Verify the command sequence includes pull --ignore-buildable
-        assert "pull --ignore-buildable" in source
-        # Verify build is included
-        assert '"build"' in source or "'build'" in source
-        # Verify the sequence is pull, build, down, up
-        assert "down" in source
+        # Verify the command uses --pull always (only recreates if image changed)
+        assert "--pull always" in source
+        # Verify --build is included for buildable services
+        assert "--build" in source
+        # Verify up -d is used
         assert "up -d" in source