mirror of
https://github.com/SigNoz/signoz.git
synced 2026-02-03 08:33:26 +00:00
* feat(authz): initial commit for migrating rbac to openfga * feat(authz): make the role updates idempotant * feat(authz): split role module into role and grant * feat(authz): some naming changes * feat(authz): integrate the grant module * feat(authz): add support for migrating existing user role * feat(authz): add support for migrating existing user role * feat(authz): figure out the * selector * feat(authz): merge main * feat(authz): merge main * feat(authz): address couple of todos * feat(authz): address couple of todos * feat(authz): fix tests and revert public dashboard change * feat(authz): fix tests and revert public dashboard change * feat(authz): add open api spec * feat(authz): add open api spec * feat(authz): add api key changes and missing migration * feat(authz): split role into getter and setter * feat(authz): add integration tests for authz register * feat(authz): add more tests for user invite and delete * feat(authz): update user tests * feat(authz): rename grant to granter * feat(authz): address review comments * feat(authz): address review comments * feat(authz): address review comments * feat(authz): add the migration for existing roles * feat(authz): go mod tidy * feat(authz): fix integration tests * feat(authz): handle community changes * feat(authz): handle community changes * feat(authz): role selectors for open claims * feat(authz): role selectors for open claims * feat(authz): prevent duplicate entries for changelog * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration
341 lines
11 KiB
Go
341 lines
11 KiB
Go
package openfgaauthz
|
|
|
|
import (
|
|
"context"
|
|
"strconv"
|
|
"sync"
|
|
|
|
authz "github.com/SigNoz/signoz/pkg/authz"
|
|
"github.com/SigNoz/signoz/pkg/errors"
|
|
"github.com/SigNoz/signoz/pkg/types/authtypes"
|
|
"github.com/SigNoz/signoz/pkg/valuer"
|
|
|
|
"github.com/SigNoz/signoz/pkg/factory"
|
|
"github.com/SigNoz/signoz/pkg/sqlstore"
|
|
openfgav1 "github.com/openfga/api/proto/openfga/v1"
|
|
openfgapkgtransformer "github.com/openfga/language/pkg/go/transformer"
|
|
openfgapkgserver "github.com/openfga/openfga/pkg/server"
|
|
"google.golang.org/protobuf/encoding/protojson"
|
|
)
|
|
|
|
var (
|
|
openfgaDefaultStore = valuer.NewString("signoz")
|
|
)
|
|
|
|
type provider struct {
|
|
config authz.Config
|
|
settings factory.ScopedProviderSettings
|
|
openfgaSchema []openfgapkgtransformer.ModuleFile
|
|
openfgaServer *openfgapkgserver.Server
|
|
storeID string
|
|
modelID string
|
|
mtx sync.RWMutex
|
|
stopChan chan struct{}
|
|
}
|
|
|
|
func NewProviderFactory(sqlstore sqlstore.SQLStore, openfgaSchema []openfgapkgtransformer.ModuleFile) factory.ProviderFactory[authz.AuthZ, authz.Config] {
|
|
return factory.NewProviderFactory(factory.MustNewName("openfga"), func(ctx context.Context, ps factory.ProviderSettings, config authz.Config) (authz.AuthZ, error) {
|
|
return newOpenfgaProvider(ctx, ps, config, sqlstore, openfgaSchema)
|
|
})
|
|
}
|
|
|
|
func newOpenfgaProvider(ctx context.Context, settings factory.ProviderSettings, config authz.Config, sqlstore sqlstore.SQLStore, openfgaSchema []openfgapkgtransformer.ModuleFile) (authz.AuthZ, error) {
|
|
scopedProviderSettings := factory.NewScopedProviderSettings(settings, "github.com/SigNoz/signoz/pkg/authz/openfgaauthz")
|
|
|
|
store, err := NewSQLStore(sqlstore)
|
|
if err != nil {
|
|
scopedProviderSettings.Logger().DebugContext(ctx, "failed to initialize sqlstore for authz")
|
|
return nil, err
|
|
}
|
|
|
|
// setup the openfga server
|
|
opts := []openfgapkgserver.OpenFGAServiceV1Option{
|
|
openfgapkgserver.WithDatastore(store),
|
|
openfgapkgserver.WithLogger(NewLogger(scopedProviderSettings.Logger())),
|
|
openfgapkgserver.WithContextPropagationToDatastore(true),
|
|
}
|
|
openfgaServer, err := openfgapkgserver.NewServerWithOpts(opts...)
|
|
if err != nil {
|
|
scopedProviderSettings.Logger().DebugContext(ctx, "failed to create authz server")
|
|
return nil, err
|
|
}
|
|
|
|
return &provider{
|
|
config: config,
|
|
settings: scopedProviderSettings,
|
|
openfgaServer: openfgaServer,
|
|
openfgaSchema: openfgaSchema,
|
|
mtx: sync.RWMutex{},
|
|
stopChan: make(chan struct{}),
|
|
}, nil
|
|
}
|
|
|
|
func (provider *provider) Start(ctx context.Context) error {
|
|
storeId, err := provider.getOrCreateStore(ctx, openfgaDefaultStore.StringValue())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
modelID, err := provider.getOrCreateModel(ctx, storeId)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
provider.mtx.Lock()
|
|
provider.modelID = modelID
|
|
provider.storeID = storeId
|
|
provider.mtx.Unlock()
|
|
|
|
<-provider.stopChan
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) Stop(ctx context.Context) error {
|
|
provider.openfgaServer.Close()
|
|
close(provider.stopChan)
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) Check(ctx context.Context, tupleReq *openfgav1.TupleKey) error {
|
|
storeID, modelID := provider.getStoreIDandModelID()
|
|
checkResponse, err := provider.openfgaServer.Check(
|
|
ctx,
|
|
&openfgav1.CheckRequest{
|
|
StoreId: storeID,
|
|
AuthorizationModelId: modelID,
|
|
TupleKey: &openfgav1.CheckRequestTupleKey{
|
|
User: tupleReq.User,
|
|
Relation: tupleReq.Relation,
|
|
Object: tupleReq.Object,
|
|
},
|
|
})
|
|
if err != nil {
|
|
return errors.Newf(errors.TypeInternal, authtypes.ErrCodeAuthZUnavailable, "authorization server is unavailable").WithAdditional(err.Error())
|
|
}
|
|
|
|
if !checkResponse.Allowed {
|
|
return errors.Newf(errors.TypeForbidden, authtypes.ErrCodeAuthZForbidden, "subject %s cannot %s object %s", tupleReq.User, tupleReq.Relation, tupleReq.Object)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) BatchCheck(ctx context.Context, tupleReq []*openfgav1.TupleKey) error {
|
|
storeID, modelID := provider.getStoreIDandModelID()
|
|
batchCheckItems := make([]*openfgav1.BatchCheckItem, 0)
|
|
for idx, tuple := range tupleReq {
|
|
batchCheckItems = append(batchCheckItems, &openfgav1.BatchCheckItem{
|
|
TupleKey: &openfgav1.CheckRequestTupleKey{
|
|
User: tuple.User,
|
|
Relation: tuple.Relation,
|
|
Object: tuple.Object,
|
|
},
|
|
// the batch check response is map[string] keyed by correlationID.
|
|
CorrelationId: strconv.Itoa(idx),
|
|
})
|
|
}
|
|
|
|
checkResponse, err := provider.openfgaServer.BatchCheck(
|
|
ctx,
|
|
&openfgav1.BatchCheckRequest{
|
|
StoreId: storeID,
|
|
AuthorizationModelId: modelID,
|
|
Checks: batchCheckItems,
|
|
})
|
|
if err != nil {
|
|
return errors.Newf(errors.TypeInternal, authtypes.ErrCodeAuthZUnavailable, "authorization server is unavailable").WithAdditional(err.Error())
|
|
}
|
|
|
|
for _, checkResponse := range checkResponse.Result {
|
|
if checkResponse.GetAllowed() {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
return errors.Newf(errors.TypeForbidden, authtypes.ErrCodeAuthZForbidden, "none of the subjects are allowed for requested access")
|
|
|
|
}
|
|
|
|
func (provider *provider) CheckWithTupleCreation(ctx context.Context, claims authtypes.Claims, orgID valuer.UUID, _ authtypes.Relation, _ authtypes.Typeable, _ []authtypes.Selector, roleSelectors []authtypes.Selector) error {
|
|
subject, err := authtypes.NewSubject(authtypes.TypeableUser, claims.UserID, orgID, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
tuples, err := authtypes.TypeableRole.Tuples(subject, authtypes.RelationAssignee, roleSelectors, orgID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = provider.BatchCheck(ctx, tuples)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) CheckWithTupleCreationWithoutClaims(ctx context.Context, orgID valuer.UUID, _ authtypes.Relation, _ authtypes.Typeable, _ []authtypes.Selector, roleSelectors []authtypes.Selector) error {
|
|
subject, err := authtypes.NewSubject(authtypes.TypeableAnonymous, authtypes.AnonymousUser.String(), orgID, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
tuples, err := authtypes.TypeableRole.Tuples(subject, authtypes.RelationAssignee, roleSelectors, orgID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = provider.BatchCheck(ctx, tuples)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) Write(ctx context.Context, additions []*openfgav1.TupleKey, deletions []*openfgav1.TupleKey) error {
|
|
if len(additions) == 0 && len(deletions) == 0 {
|
|
return nil
|
|
}
|
|
|
|
storeID, modelID := provider.getStoreIDandModelID()
|
|
deletionTuplesWithoutCondition := make([]*openfgav1.TupleKeyWithoutCondition, len(deletions))
|
|
for idx, tuple := range deletions {
|
|
deletionTuplesWithoutCondition[idx] = &openfgav1.TupleKeyWithoutCondition{User: tuple.User, Object: tuple.Object, Relation: tuple.Relation}
|
|
}
|
|
|
|
_, err := provider.openfgaServer.Write(ctx, &openfgav1.WriteRequest{
|
|
StoreId: storeID,
|
|
AuthorizationModelId: modelID,
|
|
Writes: func() *openfgav1.WriteRequestWrites {
|
|
if len(additions) == 0 {
|
|
return nil
|
|
}
|
|
return &openfgav1.WriteRequestWrites{
|
|
TupleKeys: additions,
|
|
OnDuplicate: "ignore",
|
|
}
|
|
}(),
|
|
Deletes: func() *openfgav1.WriteRequestDeletes {
|
|
if len(deletionTuplesWithoutCondition) == 0 {
|
|
return nil
|
|
}
|
|
return &openfgav1.WriteRequestDeletes{
|
|
TupleKeys: deletionTuplesWithoutCondition,
|
|
OnMissing: "ignore",
|
|
}
|
|
}(),
|
|
})
|
|
|
|
return err
|
|
}
|
|
|
|
func (provider *provider) ListObjects(ctx context.Context, subject string, relation authtypes.Relation, typeable authtypes.Typeable) ([]*authtypes.Object, error) {
|
|
storeID, modelID := provider.getStoreIDandModelID()
|
|
response, err := provider.openfgaServer.ListObjects(ctx, &openfgav1.ListObjectsRequest{
|
|
StoreId: storeID,
|
|
AuthorizationModelId: modelID,
|
|
User: subject,
|
|
Relation: relation.StringValue(),
|
|
Type: typeable.Type().StringValue(),
|
|
})
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, errors.TypeInternal, authtypes.ErrCodeAuthZUnavailable, "cannot list objects for subject %s with relation %s for type %s", subject, relation.StringValue(), typeable.Type().StringValue())
|
|
}
|
|
|
|
return authtypes.MustNewObjectsFromStringSlice(response.Objects), nil
|
|
}
|
|
|
|
func (provider *provider) getOrCreateStore(ctx context.Context, name string) (string, error) {
|
|
stores, err := provider.openfgaServer.ListStores(ctx, &openfgav1.ListStoresRequest{})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
for _, store := range stores.GetStores() {
|
|
if store.GetName() == name {
|
|
return store.Id, nil
|
|
}
|
|
}
|
|
|
|
store, err := provider.openfgaServer.CreateStore(ctx, &openfgav1.CreateStoreRequest{Name: name})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return store.Id, nil
|
|
}
|
|
|
|
func (provider *provider) getOrCreateModel(ctx context.Context, storeID string) (string, error) {
|
|
schema, err := openfgapkgtransformer.TransformModuleFilesToModel(provider.openfgaSchema, "1.1")
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
authorisationModels, err := provider.openfgaServer.ReadAuthorizationModels(ctx, &openfgav1.ReadAuthorizationModelsRequest{StoreId: storeID})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
for _, authModel := range authorisationModels.GetAuthorizationModels() {
|
|
equal, err := provider.isModelEqual(schema, authModel)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if equal {
|
|
return authModel.Id, nil
|
|
}
|
|
}
|
|
|
|
authorizationModel, err := provider.openfgaServer.WriteAuthorizationModel(ctx, &openfgav1.WriteAuthorizationModelRequest{
|
|
StoreId: storeID,
|
|
TypeDefinitions: schema.TypeDefinitions,
|
|
SchemaVersion: schema.SchemaVersion,
|
|
Conditions: schema.Conditions,
|
|
})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return authorizationModel.AuthorizationModelId, nil
|
|
}
|
|
|
|
// the language model doesn't have any equality check
|
|
// https://github.com/openfga/language/blob/main/pkg/go/transformer/module-to-model_test.go#L38
|
|
func (provider *provider) isModelEqual(expected *openfgav1.AuthorizationModel, actual *openfgav1.AuthorizationModel) (bool, error) {
|
|
// we need to initialize a new model since the model extracted from schema doesn't have id
|
|
expectedAuthModel := openfgav1.AuthorizationModel{
|
|
SchemaVersion: expected.SchemaVersion,
|
|
TypeDefinitions: expected.TypeDefinitions,
|
|
Conditions: expected.Conditions,
|
|
}
|
|
expectedAuthModelBytes, err := protojson.Marshal(&expectedAuthModel)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
actualAuthModel := openfgav1.AuthorizationModel{
|
|
SchemaVersion: actual.SchemaVersion,
|
|
TypeDefinitions: actual.TypeDefinitions,
|
|
Conditions: actual.Conditions,
|
|
}
|
|
actualAuthModelBytes, err := protojson.Marshal(&actualAuthModel)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
return string(expectedAuthModelBytes) == string(actualAuthModelBytes), nil
|
|
|
|
}
|
|
|
|
func (provider *provider) getStoreIDandModelID() (string, string) {
|
|
provider.mtx.RLock()
|
|
defer provider.mtx.RUnlock()
|
|
|
|
storeID := provider.storeID
|
|
modelID := provider.modelID
|
|
|
|
return storeID, modelID
|
|
}
|