Merge branch 'main' into nv/distr-query

.github/CODEOWNERS

@@ -302,8 +302,3 @@ go.mod @therealpandey
 /frontend/.storybook/ @H4ad
 /frontend/src/storybook/ @H4ad
 /.claude/skills/signoz-page-story/ @H4ad
-
-## AI Assistant
-/frontend/src/container/AIAssistant/ @SigNoz/nerve @SigNoz/frontend-maintainers
-/frontend/src/hooks/aiAssistant/ @SigNoz/nerve @SigNoz/frontend-maintainers
-/frontend/src/pages/AIAssistantPage/ @SigNoz/nerve @SigNoz/frontend-maintainers

.github/workflows/e2eci.yaml

@@ -2,9 +2,6 @@ name: e2eci
 
 on:
   pull_request:
-  merge_group:
-    types:
-      - checks_requested
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -16,12 +13,8 @@ jobs:
     outputs:
       e2e: ${{ steps.changes.outputs.e2e }}
     steps:
-      - name: merge-queue-pass
-        if: github.event_name == 'merge_group'
-        run: echo "::notice::Merge queue run. E2E already gated the PR, so the required e2e check auto-passes."
       - name: changes
         id: changes
-        if: github.event_name == 'pull_request'
         env:
           GH_TOKEN: ${{ github.token }}
           PR_NUMBER: ${{ github.event.pull_request.number }}

docs/api/openapi.yml

@@ -2205,10 +2205,10 @@ components:
       type: object
     CloudintegrationtypesAWSConnectionArtifact:
       properties:
-        cliCommand:
+        connectionUrl:
           type: string
       required:
-      - cliCommand
+      - connectionUrl
       type: object
     CloudintegrationtypesAWSIntegrationConfig:
       properties:
@@ -2364,8 +2364,11 @@ components:
       properties:
         cliCommand:
           type: string
+        cloudPowerShellCommand:
+          type: string
       required:
       - cliCommand
+      - cloudPowerShellCommand
       type: object
     CloudintegrationtypesAzureIntegrationConfig:
       properties:
@@ -9562,9 +9565,9 @@ components:
     Querybuildertypesv5AggregationMeta:
       properties:
         buckets:
-          description: The ascending upper bounds of the value bands, set only for
-            heatmap results; each point then carries one count per bound plus a trailing
-            overflow count in values.
+          description: The ascending upper bounds of the value buckets, set for heatmap
+            and distribution results; each point then carries one count per bound
+            plus a trailing overflow count in values.
           items:
             format: double
             type: number
@@ -9719,6 +9722,56 @@ components:
           nullable: true
           type: array
       type: object
+    Querybuildertypesv5Distribution:
+      properties:
+        counts:
+          description: One count per bound in meta.buckets plus a trailing overflow
+            count, summed over every step of the requested time range.
+          items:
+            format: double
+            type: number
+          nullable: true
+          type: array
+        labels:
+          description: The group-by field values that identify this distribution.
+          items:
+            $ref: '#/components/schemas/Querybuildertypesv5Label'
+          type: array
+      type: object
+    Querybuildertypesv5DistributionAggregation:
+      properties:
+        alias:
+          description: The alias of the aggregation, or the internal name __result_N,
+            with N its index, when no alias was given.
+          type: string
+        distributions:
+          description: One distribution per group-by combination.
+          items:
+            $ref: '#/components/schemas/Querybuildertypesv5Distribution'
+          nullable: true
+          type: array
+        index:
+          description: The zero-based position of the aggregation in the query.
+          type: integer
+        meta:
+          allOf:
+          - $ref: '#/components/schemas/Querybuildertypesv5AggregationMeta'
+          description: Display metadata for the aggregation, including the bucket
+            upper bounds the counts are positional against.
+      type: object
+    Querybuildertypesv5DistributionData:
+      properties:
+        aggregations:
+          description: One entry per aggregation of the query. The order is not guaranteed;
+            match entries to aggregations by index.
+          items:
+            $ref: '#/components/schemas/Querybuildertypesv5DistributionAggregation'
+          nullable: true
+          type: array
+        queryName:
+          description: The name of the query that produced this result.
+          type: string
+      type: object
     Querybuildertypesv5ExecStats:
       description: 'Execution cost of the request: rows and bytes scanned and execution
         time. A measure of cost, not of whether data exists.'
@@ -10542,10 +10595,12 @@ components:
       - $ref: '#/components/schemas/Querybuildertypesv5TimeSeriesData'
       - $ref: '#/components/schemas/Querybuildertypesv5ScalarData'
       - $ref: '#/components/schemas/Querybuildertypesv5RawData'
+      - $ref: '#/components/schemas/Querybuildertypesv5DistributionData'
       properties:
         results:
           description: 'One result per enabled query, typed by the request type: TimeSeriesData
-            for time_series, ScalarData for scalar and RawData for raw requests.'
+            for time_series and heatmap, ScalarData for scalar, RawData for raw and
+            DistributionData for distribution requests.'
           items: {}
           nullable: true
           type: array
@@ -10735,8 +10790,9 @@ components:
       type: object
     Querybuildertypesv5QueryRangeResponse:
       description: 'Response from the v5 query range endpoint. The data.results array
-        contains typed results depending on the requestType: TimeSeriesData for time_series,
-        ScalarData for scalar, or RawData for raw requests.'
+        contains typed results depending on the requestType: TimeSeriesData for time_series
+        and heatmap, ScalarData for scalar, RawData for raw, or DistributionData for
+        distribution requests.'
       properties:
         data:
           allOf:
@@ -10833,6 +10889,7 @@ components:
       - raw_stream
       - trace
       - heatmap
+      - distribution
       type: string
     Querybuildertypesv5ScalarData:
       properties:
@@ -10944,8 +11001,8 @@ components:
           format: double
           type: number
         values:
-          description: The per-band counts for heatmap results, in the order of meta.buckets
-            plus a trailing overflow count.
+          description: The per-bucket counts for heatmap results, in the order of
+            meta.buckets plus a trailing overflow count.
           items:
             format: double
             type: number

docs/contributing/go/abstractions.md

@@ -28,7 +28,7 @@ func ConvertConfig(src ExternalConfig) (InternalConfig, error)
 // Over this:
 type ConfigAdapter struct { ... }
 func NewConfigAdapter(src ExternalConfig) *ConfigAdapter
-func (adapter *ConfigAdapter) ToInternal() (InternalConfig, error)
+func (a *ConfigAdapter) ToInternal() (InternalConfig, error)
 ```
 
 The two-step version is only justified when `ConfigAdapter` has multiple distinct consumers that use it in different ways.
@@ -66,10 +66,10 @@ A method on a structured type should not strip meaning from the structure it bel
 
 ```go
 // Problematic: callers cannot distinguish how items were related.
-func (order *Order) AllLineItems() []LineItem { ... }
+func (o *Order) AllLineItems() []LineItem { ... }
 
 // Better: the validation logic operates on the full structure.
-func ValidateOrder(order *Order) error { ... }
+func ValidateOrder(o *Order) error { ... }
 ```
 
 Public methods shape how a type is used. Once a lossy accessor exists, callers will depend on it, and the lost information becomes unrecoverable at those call sites.

docs/contributing/go/dslfilteringtosql.md

@@ -74,7 +74,7 @@ The `*Visitor` passed in provides everything needed to build predicates. Use the
 In the simplest case, keys map straight to columns and the resolver is a switch. The doc's running example, an imaginary `sample_entity` table:
 
 ```go
-func (resolver sampleEntityFieldResolver) ResolveComparison(v *sqlcompiler.Visitor, key string, operation qbtypesv5.FilterOperator, ctx *grammar.ComparisonContext) string {
+func (r sampleEntityFieldResolver) ResolveComparison(v *sqlcompiler.Visitor, key string, operation qbtypesv5.FilterOperator, ctx *grammar.ComparisonContext) string {
 	switch key {
 	case "created_by":
 		return v.BuildStringOperation(v.Sb, ctx, operation, "sample_entity.created_by", key)

docs/contributing/go/handler.md

@@ -82,7 +82,7 @@ In the module implementation, implement the new method. A typical implementation
 - Uses the `render` package to write responses or errors
 
 ```go
-func (handler *handler) CreateThing(rw http.ResponseWriter, req *http.Request) {
+func (h *handler) CreateThing(rw http.ResponseWriter, req *http.Request) {
     // Extract authentication and organization context from req.Context()
     claims, err := authtypes.ClaimsFromContext(req.Context())
     if err != nil {
@@ -98,7 +98,7 @@ func (handler *handler) CreateThing(rw http.ResponseWriter, req *http.Request) {
     }
     
     // Call module functions
-    out, err := handler.module.CreateThing(req.Context(), claims.OrgID, &in)
+    out, err := h.module.CreateThing(req.Context(), claims.OrgID, &in)
     if err != nil {
         render.Error(rw, err)
         return

docs/contributing/go/packages.md

@@ -59,8 +59,7 @@ Follow these rules:
 
 ### Unexported symbols
 
-- Struct receivers: the lowercase name of the role the type plays, the same on every method of the type (`provider`, `module`, `handler`, `store`, `middleware`, `migration`). Never one or two characters: `c`, `h`, `m` say nothing at the call site and collide with local variables.
-- When the receiver name would shadow an imported package, alias the import, not the receiver (`pkghandler "github.com/SigNoz/signoz/pkg/http/handler"` with a `handler` receiver).
+- Struct receivers: one or two characters (`c`, `f`, `br`).
 - Helper functions: descriptive lowercase names (`parseToken`, `buildQuery`).
 
 ### Constants

docs/contributing/go/service.md

@@ -70,16 +70,16 @@ The instrumentation SDK (`pkg/instrumentation/sdk.go`) is idle while running but
 ```go
 // pkg/instrumentation/sdk.go
 
-func (sdk *SDK) Start(ctx context.Context) error {
-    <-sdk.startCh
+func (i *SDK) Start(ctx context.Context) error {
+    <-i.startCh
     return nil
 }
 
-func (sdk *SDK) Stop(ctx context.Context) error {
-    close(sdk.startCh)
+func (i *SDK) Stop(ctx context.Context) error {
+    close(i.startCh)
     return errors.Join(
-        sdk.sdk.Shutdown(ctx),
-        sdk.meterProviderShutdownFunc(ctx),
+        i.sdk.Shutdown(ctx),
+        i.meterProviderShutdownFunc(ctx),
     )
 }
 ```
@@ -197,8 +197,8 @@ A standalone service only has the `factory.Service` lifecycle i.e it does not se
         }
     }
 
-    func (service *service) Start(ctx context.Context) error { ... }
-    func (service *service) Stop(ctx context.Context) error { ... }
+    func (s *service) Start(ctx context.Context) error { ... }
+    func (s *service) Stop(ctx context.Context) error { ... }
     ```
 
 ### Provider that is also a service

docs/contributing/go/types.md

@@ -17,7 +17,7 @@ Two rules shape how the core type behaves:
     func NewGettableAuthDomainFromAuthDomain(d *AuthDomain, info *AuthNProviderInfo) *GettableAuthDomain
 
     // Receiver form
-    func (maintenance *PlannedMaintenanceWithRules) ToPlannedMaintenance() *PlannedMaintenance
+    func (m *PlannedMaintenanceWithRules) ToPlannedMaintenance() *PlannedMaintenance
     ```
 - **`X` can double as the storage row** when the DB shape would be identical. `Channel` embeds `bun.BaseModel` directly, and there is no `StorableChannel`. This is the preferred shape when it works.
 
@@ -175,10 +175,10 @@ The rules that make the envelope work:
 
     ```go
     // Domain invariants: every write path re-runs these.
-    func (entity *X) Validate() error { ... }
+    func (x *X) Validate() error { ... }
 
     // Request-shape-only: checks that do not apply once the value is persisted.
-    func (postable *PostableX) Validate() error { ... }
+    func (p *PostableX) Validate() error { ... }
     ```
 - **Type aliases, not wrappers**, when two shapes are identical. `type GettableChannels = []*Channel` is correct because it adds no semantics beyond the underlying type.
 - **Serialization tags** follow [handler.md](handler.md): `required:"true"` means the JSON key must be present, `nullable:"true"` is required on any slice or map that may serialize as `null`, and types with a fixed value set must implement `Enum() []any`.

ee/modules/cloudintegration/implcloudintegration/implcloudprovider/awscloudprovider.go

@@ -2,6 +2,8 @@ package implcloudprovider
 
 import (
 	"context"
+	"fmt"
+	"net/url"
 	"sort"
 
 	"github.com/SigNoz/signoz/pkg/modules/cloudintegration"
@@ -16,14 +18,29 @@ func NewAWSCloudProvider(defStore cloudintegrationtypes.ServiceDefinitionStore)
 	return &awscloudprovider{serviceDefinitions: defStore}, nil
 }
 
+// TODO: move URL construction logic to cloudintegrationtypes and add unit tests for it.
 func (provider *awscloudprovider) GetConnectionArtifact(ctx context.Context, account *cloudintegrationtypes.Account, req *cloudintegrationtypes.GetConnectionArtifactRequest) (*cloudintegrationtypes.ConnectionArtifact, error) {
-	connectionArtifact, err := cloudintegrationtypes.NewAWSConnectionArtifact(account.ID, req.Config.AgentVersion, req.Credentials, req.Config.AWS.DeploymentRegion)
-	if err != nil {
-		return nil, err
-	}
+	baseURL := fmt.Sprintf(cloudintegrationtypes.CloudFormationQuickCreateBaseURL.StringValue(), req.Config.AWS.DeploymentRegion)
+	u, _ := url.Parse(baseURL)
+
+	q := u.Query()
+	q.Set("region", req.Config.AWS.DeploymentRegion)
+	u.Fragment = "/stacks/quickcreate"
+
+	u.RawQuery = q.Encode()
+
+	q = u.Query()
+	q.Set("stackName", cloudintegrationtypes.AgentCloudFormationBaseStackName.StringValue())
+	q.Set("templateURL", fmt.Sprintf(cloudintegrationtypes.AgentCloudFormationTemplateS3Path.StringValue(), req.Config.AgentVersion))
+	q.Set("param_SigNozIntegrationAgentVersion", req.Config.AgentVersion)
+	q.Set("param_SigNozApiUrl", req.Credentials.SigNozAPIURL)
+	q.Set("param_SigNozApiKey", req.Credentials.SigNozAPIKey)
+	q.Set("param_SigNozAccountId", account.ID.StringValue())
+	q.Set("param_IngestionUrl", req.Credentials.IngestionURL)
+	q.Set("param_IngestionKey", req.Credentials.IngestionKey)
 
 	return &cloudintegrationtypes.ConnectionArtifact{
-		AWS: connectionArtifact,
+		AWS: cloudintegrationtypes.NewAWSConnectionArtifact(u.String() + "?&" + q.Encode()), // this format is required by AWS
 	}, nil
 }
 

frontend/.storybook/preview.tsx

@@ -143,12 +143,7 @@ const preview: Preview = {
 						'Logs',
 						['Explorer', 'Live Tail', 'Pipelines', 'Settings'],
 						'Traces',
-						[
-							'Explorer',
-							['Overview', 'Span Drawer'],
-							'Trace Details',
-							'Funnel Details',
-						],
+						['Explorer', 'Trace Details', 'Funnel Details'],
 						'Metrics',
 						['Explorer'],
 						'Infrastructure',

frontend/package.json

@@ -80,7 +80,7 @@
     "crypto-js": "4.2.0",
     "d3-hierarchy": "3.1.2",
     "dayjs": "^1.10.7",
-    "dompurify": "3.4.17",
+    "dompurify": "3.4.15",
     "event-source-polyfill": "1.0.31",
     "eventemitter3": "5.0.1",
     "history": "4.10.1",
@@ -200,17 +200,17 @@
     "oxfmt": "0.73.0",
     "oxlint": "1.88.0",
     "oxlint-tsgolint": "7.0.2004",
-    "postcss": "8.5.32",
+    "postcss": "8.5.26",
     "postcss-scss": "4.0.9",
     "react-resizable": "3.0.4",
     "redux-mock-store": "1.5.4",
     "sass": "1.97.3",
-    "sharp": "0.35.5",
+    "sharp": "0.35.4",
     "storybook": "10.6.3",
     "stylelint": "17.15.0",
     "svgo": "4.1.0",
     "ts-jest": "29.4.15",
-    "typescript-plugin-css-modules": "5.3.0",
+    "typescript-plugin-css-modules": "5.2.0",
     "use-sync-external-store": "1.6.0",
     "vite-plugin-checker": "0.12.0",
     "vite-plugin-compression": "0.5.1",

frontend/pnpm-workspace.yaml

@@ -37,9 +37,9 @@ overrides:
  cookie@<0.7.0: '>=0.7.1 <1'
  # via: @grafana/data@11.6.15 (3.4.0/3.2.4 exact);
  #      @monaco-editor/react > monaco-editor@0.55.1 (3.2.7 exact)
- # remove: blocked. The direct dep is already on 3.4.17, but @grafana/data
+ # remove: blocked. The direct dep is already on 3.4.15, but @grafana/data
  #         (latest 13.1.0) and monaco-editor (latest 0.55.1) still pin vulnerable versions
- dompurify@<=3.4.16: '>=3.4.17 <4'
+ dompurify@<=3.4.12: '>=3.4.13 <4'
  # via: rolldown-vite@7.3.1 (esbuild ^0.27.0); ts-jest@29.4.9 (~0.27.4)
  # remove: blocked on rolldown-vite (7.3.1 is latest, still ^0.27.0);
  #         orval >=8.20.0 and ts-jest >=29.4.11 already fixed on their side
@@ -60,10 +60,17 @@ overrides:
  #      @commitlint/cli > @commitlint/load > cosmiconfig@9 (^4.1.0)
  # remove: blocked, both consumers cap js-yaml at ^4 and only 4.3.2 carries the fix
  'js-yaml@>=4.0.0 <4.3.2': '>=4.3.2 <5'
+ # via: typescript-plugin-css-modules@5.2.0 (less ^4.2.0) > less@4.4.0 (image-size ~0.5.0)
+ # remove: bump typescript-plugin-css-modules once it floors less itself; image-size has
+ #         no patched release at all, so dropping the dep is the only fix — less@4.5.0 did
+ less@<4.5.0: '>=4.5.0 <5'
+ # via: direct dep postcss (nanoid ^3.3.17)
+ # remove: blocked — postcss 8.5.26 (latest) caps nanoid at ^3, fix landed in 3.3.18
+ nanoid@<3.3.18: '>=3.3.18 <4'
  # via: react-syntax-highlighter@15.5.0 (prismjs ^1.27.0 + refractor@3 ~1.27.0 tilde-pinned)
  # remove: bump react-syntax-highlighter to >=16.1.1 (prismjs ^1.30.0, refractor@5)
  prismjs@<1.30.0: '>=1.30.0 <2'
- # via: typescript-plugin-css-modules@5.3.0 > postcss-modules-local-by-default@4.2.0
+ # via: typescript-plugin-css-modules@5.2.0 > postcss-modules-local-by-default@4.2.0
  #      (postcss-selector-parser ^7.0.0)
  # remove: blocked, 4.2.0 is latest and the range is open, so the floor is what pulls the fix
  postcss-selector-parser@>=7.1.0 <7.1.3: '>=7.1.3 <8'

frontend/src/api/generated/services/sigNoz.schemas.ts

@@ -3936,7 +3936,7 @@ export interface CloudintegrationtypesAWSConnectionArtifactDTO {
 	/**
 	 * @type string
 	 */
-	cliCommand: string;
+	connectionUrl: string;
 }
 
 export interface CloudintegrationtypesAWSLogsCollectionStrategyDTO {
@@ -4146,6 +4146,10 @@ export interface CloudintegrationtypesAzureConnectionArtifactDTO {
 	 * @type string
 	 */
 	cliCommand: string;
+	/**
+	 * @type string
+	 */
+	cloudPowerShellCommand: string;
 }
 
 export interface CloudintegrationtypesAzureLogsCollectionStrategyDTO {
@@ -6937,6 +6941,7 @@ export enum Querybuildertypesv5RequestTypeDTO {
 	raw_stream = 'raw_stream',
 	trace = 'trace',
 	heatmap = 'heatmap',
+	distribution = 'distribution',
 }
 /**
  * The query kind.
@@ -10973,7 +10978,7 @@ export interface Querybuildertypesv5TimeSeriesValueDTO {
 	value?: number;
 	/**
 	 * @type array
-	 * @description The per-band counts for heatmap results, in the order of meta.buckets plus a trailing overflow count.
+	 * @description The per-bucket counts for heatmap results, in the order of meta.buckets plus a trailing overflow count.
 	 */
 	values?: number[];
 }
@@ -11594,7 +11599,7 @@ export interface PromotetypesPostableIndexMaterializedPathsDTO {
 export interface Querybuildertypesv5AggregationMetaDTO {
 	/**
 	 * @type array
-	 * @description The ascending upper bounds of the value bands, set only for heatmap results; each point then carries one count per bound plus a trailing overflow count in values.
+	 * @description The ascending upper bounds of the value buckets, set for heatmap and distribution results; each point then carries one count per bound plus a trailing overflow count in values.
 	 */
 	buckets?: number[];
 	/**
@@ -11715,6 +11720,54 @@ export interface Querybuildertypesv5ColumnDescriptorDTO {
 	unit?: string;
 }
 
+export interface Querybuildertypesv5DistributionDTO {
+	/**
+	 * @type array,null
+	 * @description One count per bound in meta.buckets plus a trailing overflow count, summed over every step of the requested time range.
+	 */
+	counts?: number[] | null;
+	/**
+	 * @type array
+	 * @description The group-by field values that identify this distribution.
+	 */
+	labels?: Querybuildertypesv5LabelDTO[];
+}
+
+export interface Querybuildertypesv5DistributionAggregationDTO {
+	/**
+	 * @type string
+	 * @description The alias of the aggregation, or the internal name __result_N, with N its index, when no alias was given.
+	 */
+	alias?: string;
+	/**
+	 * @type array,null
+	 * @description One distribution per group-by combination.
+	 */
+	distributions?: Querybuildertypesv5DistributionDTO[] | null;
+	/**
+	 * @type integer
+	 * @description The zero-based position of the aggregation in the query.
+	 */
+	index?: number;
+	/**
+	 * @description Display metadata for the aggregation, including the bucket upper bounds the counts are positional against.
+	 */
+	meta?: Querybuildertypesv5AggregationMetaDTO;
+}
+
+export interface Querybuildertypesv5DistributionDataDTO {
+	/**
+	 * @type array,null
+	 * @description One entry per aggregation of the query. The order is not guaranteed; match entries to aggregations by index.
+	 */
+	aggregations?: Querybuildertypesv5DistributionAggregationDTO[] | null;
+	/**
+	 * @type string
+	 * @description The name of the query that produced this result.
+	 */
+	queryName?: string;
+}
+
 /**
  * The step interval in seconds that was used for each query, keyed by query name.
  */
@@ -11970,21 +12023,28 @@ export type Querybuildertypesv5QueryDataDTO =
 	| (Querybuildertypesv5TimeSeriesDataDTO & {
 			/**
 			 * @type array,null
-			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series, ScalarData for scalar and RawData for raw requests.
+			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series and heatmap, ScalarData for scalar, RawData for raw and DistributionData for distribution requests.
 			 */
 			results?: unknown[] | null;
 	  })
 	| (Querybuildertypesv5ScalarDataDTO & {
 			/**
 			 * @type array,null
-			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series, ScalarData for scalar and RawData for raw requests.
+			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series and heatmap, ScalarData for scalar, RawData for raw and DistributionData for distribution requests.
 			 */
 			results?: unknown[] | null;
 	  })
 	| (Querybuildertypesv5RawDataDTO & {
 			/**
 			 * @type array,null
-			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series, ScalarData for scalar and RawData for raw requests.
+			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series and heatmap, ScalarData for scalar, RawData for raw and DistributionData for distribution requests.
+			 */
+			results?: unknown[] | null;
+	  })
+	| (Querybuildertypesv5DistributionDataDTO & {
+			/**
+			 * @type array,null
+			 * @description One result per enabled query, typed by the request type: TimeSeriesData for time_series and heatmap, ScalarData for scalar, RawData for raw and DistributionData for distribution requests.
 			 */
 			results?: unknown[] | null;
 	  });
@@ -12118,7 +12178,7 @@ export interface Querybuildertypesv5QueryRangeRequestDTO {
 }
 
 /**
- * Response from the v5 query range endpoint. The data.results array contains typed results depending on the requestType: TimeSeriesData for time_series, ScalarData for scalar, or RawData for raw requests.
+ * Response from the v5 query range endpoint. The data.results array contains typed results depending on the requestType: TimeSeriesData for time_series and heatmap, ScalarData for scalar, RawData for raw, or DistributionData for distribution requests.
  */
 export interface Querybuildertypesv5QueryRangeResponseDTO {
 	/**

frontend/src/components/DetailsPanel/DetailsPanelDrawer.module.scss

@@ -1,17 +0,0 @@
-.drawer {
-	overflow: hidden;
-	border-color: var(--l2-border);
-	background: var(--l2-background);
-	box-shadow: -4px 10px 16px 2px var(--l1-shadow);
-
-	&:focus,
-	&:focus-visible {
-		outline: none;
-	}
-}
-
-.body {
-	display: flex;
-	flex-direction: column;
-	height: 100%;
-}

frontend/src/components/DetailsPanel/DetailsPanelDrawer.styles.scss

@@ -0,0 +1,7 @@
+.details-panel-drawer {
+	&__body {
+		display: flex;
+		flex-direction: column;
+		height: 100%;
+	}
+}

frontend/src/components/DetailsPanel/DetailsPanelDrawer.tsx

@@ -1,15 +1,12 @@
-import { Drawer, DrawerContent } from '@signozhq/ui/drawer';
-import cx from 'classnames';
-import { AnimatePresence } from 'motion/react';
+import { DrawerWrapper } from '@signozhq/ui/drawer';
 
-import styles from './DetailsPanelDrawer.module.scss';
+import './DetailsPanelDrawer.styles.scss';
 
 interface DetailsPanelDrawerProps {
 	isOpen: boolean;
 	onClose: () => void;
 	children: React.ReactNode;
 	className?: string;
-	testId?: string;
 }
 
 function DetailsPanelDrawer({
@@ -17,41 +14,22 @@ function DetailsPanelDrawer({
 	onClose,
 	children,
 	className,
-	testId,
 }: DetailsPanelDrawerProps): JSX.Element {
 	return (
-		<Drawer
+		<DrawerWrapper
 			open={isOpen}
 			onOpenChange={(open): void => {
 				if (!open) {
 					onClose();
 				}
 			}}
-			modal={false}
+			direction="right"
+			showOverlay={false}
+			className={`details-panel-drawer ${className || ''}`}
 		>
-			<AnimatePresence>
-				{isOpen && (
-					<DrawerContent
-						forceMount
-						direction="right"
-						width="extra-wide"
-						showOverlay={false}
-						// Outside presses are left to the page, which knows what counts as inside.
-						onInteractOutside={(e): void => e.preventDefault()}
-						className={cx(styles.drawer, className)}
-						testId={testId}
-					>
-						<div className={styles.body}>{children}</div>
-					</DrawerContent>
-				)}
-			</AnimatePresence>
-		</Drawer>
+			<div className="details-panel-drawer__body">{children}</div>
+		</DrawerWrapper>
 	);
 }
 
-DetailsPanelDrawer.defaultProps = {
-	className: undefined,
-	testId: undefined,
-};
-
 export default DetailsPanelDrawer;

frontend/src/components/InputWithLabel/InputWithLabel.tsx

@@ -18,7 +18,6 @@ function InputWithLabel({
 	className,
 	closeIcon,
 	disabled,
-	sanitize,
 }: {
 	label: string;
 	initialValue?: string | number | null;
@@ -30,17 +29,14 @@ function InputWithLabel({
 	className?: string;
 	closeIcon?: React.ReactNode;
 	disabled?: boolean;
-	/** Rewrites the typed value before it is shown and reported. */
-	sanitize?: (value: string) => string;
 }): JSX.Element {
 	const [inputValue, setInputValue] = useState<string>(
 		initialValue ? initialValue.toString() : '',
 	);
 
 	const handleChange = (e: React.ChangeEvent<HTMLInputElement>): void => {
-		const value = sanitize ? sanitize(e.target.value) : e.target.value;
-		setInputValue(value);
-		onChange?.(value);
+		setInputValue(e.target.value);
+		onChange?.(e.target.value);
 	};
 
 	return (
@@ -82,7 +78,6 @@ InputWithLabel.defaultProps = {
 	initialValue: undefined,
 	className: undefined,
 	closeIcon: undefined,
-	sanitize: undefined,
 };
 
 export default InputWithLabel;

frontend/src/components/OverflowBadges/ItemBadge.tsx

@@ -1,17 +0,0 @@
-import type { ReactNode } from 'react';
-import { Badge } from '@signozhq/ui/badge';
-
-interface ItemBadgeProps {
-	children: ReactNode;
-	testId?: string;
-}
-
-function ItemBadge({ children, testId }: ItemBadgeProps): JSX.Element {
-	return (
-		<Badge textTransform="none" variant="solid" color="secondary" testId={testId}>
-			{children}
-		</Badge>
-	);
-}
-
-export default ItemBadge;

frontend/src/components/OverflowBadges/OverflowBadges.module.scss

@@ -1,32 +0,0 @@
-.badges {
-	position: relative;
-	display: flex;
-	align-items: center;
-	gap: var(--spacing-2);
-	min-width: 0;
-	overflow: hidden;
-	white-space: nowrap;
-}
-
-.overflow {
-	flex-shrink: 0;
-	--badge-max-width: none;
-}
-
-/* Lays every badge out at its natural width, off-screen, to size the visible row. */
-.measure {
-	position: absolute;
-	top: 0;
-	left: 0;
-	display: flex;
-	width: max-content;
-	visibility: hidden;
-	pointer-events: none;
-}
-
-.extraBadges {
-	display: flex;
-	flex-wrap: wrap;
-	gap: var(--spacing-2);
-	max-width: 320px;
-}

frontend/src/components/OverflowBadges/OverflowBadges.tsx

@@ -1,75 +0,0 @@
-import { type CSSProperties, useRef } from 'react';
-import { Tooltip } from '@signozhq/ui/tooltip';
-
-import ItemBadge from './ItemBadge';
-import type { OverflowBadgeItem } from './types';
-import { useOverflowBadgesLayout } from './useOverflowBadgesLayout';
-
-import styles from './OverflowBadges.module.scss';
-
-interface OverflowBadgesProps {
-	items: OverflowBadgeItem[];
-}
-
-/**
- * A row of badges: as many as fit the width inline, the rest revealed on hover
- * of a "+N" badge. A lone badge too wide to fit truncates instead.
- */
-function OverflowBadges({ items }: OverflowBadgesProps): JSX.Element {
-	const containerRef = useRef<HTMLDivElement>(null);
-	const measureRef = useRef<HTMLDivElement>(null);
-	const { visibleCount, firstMaxWidth, isMeasuring } = useOverflowBadgesLayout(
-		items,
-		containerRef,
-		measureRef,
-	);
-
-	const visible = items.slice(0, visibleCount);
-	const extra = items.slice(visibleCount);
-	// The app sets `--badge-max-width` globally, which outranks Badge's `maxWidth` prop.
-	const containerStyle =
-		firstMaxWidth === undefined
-			? undefined
-			: ({ '--badge-max-width': `${firstMaxWidth}px` } as CSSProperties);
-
-	return (
-		<div ref={containerRef} className={styles.badges} style={containerStyle}>
-			{visible.map(({ key, label }) => (
-				<ItemBadge key={key} testId="overflow-badges-item">
-					{label}
-				</ItemBadge>
-			))}
-			{extra.length > 0 && (
-				<Tooltip
-					side="bottom"
-					title={
-						<div className={styles.extraBadges}>
-							{extra.map(({ key, label }) => (
-								<ItemBadge key={key}>{label}</ItemBadge>
-							))}
-						</div>
-					}
-				>
-					{/* Stop the click so the "+N" badge doesn't trigger the row's click. */}
-					<span
-						role="presentation"
-						className={styles.overflow}
-						onClick={(e): void => e.stopPropagation()}
-					>
-						<ItemBadge testId="overflow-badges-more">+{extra.length}</ItemBadge>
-					</span>
-				</Tooltip>
-			)}
-			{isMeasuring && (
-				<div ref={measureRef} className={styles.measure} aria-hidden>
-					{items.map(({ key, label }) => (
-						<ItemBadge key={key}>{label}</ItemBadge>
-					))}
-					<ItemBadge>+{items.length}</ItemBadge>
-				</div>
-			)}
-		</div>
-	);
-}
-
-export default OverflowBadges;

frontend/src/components/OverflowBadges/__tests__/OverflowBadges.test.tsx

@@ -1,74 +0,0 @@
-import { render, screen } from 'tests/test-utils';
-
-import OverflowBadges from '../OverflowBadges';
-import { computeOverflowBadgesLayout } from '../utils';
-
-const items = ['alpha', 'beta', 'gamma', 'delta'].map((label) => ({
-	key: label,
-	label,
-}));
-
-describe('computeOverflowBadgesLayout', () => {
-	it('fits as many badges as the width allows, keeping room for +N', () => {
-		// 50 + 4 + 50 + 4 + 30 (+N) = 138 fits; a third badge would not.
-		expect(
-			computeOverflowBadgesLayout(140, 4, [50, 50, 50, 50], 30),
-		).toStrictEqual({ visibleCount: 2 });
-	});
-
-	it('shows every badge without +N when all fit', () => {
-		expect(computeOverflowBadgesLayout(200, 4, [50, 50, 50], 30)).toStrictEqual({
-			visibleCount: 3,
-		});
-	});
-
-	it('truncates the first badge when even it does not fit', () => {
-		expect(computeOverflowBadgesLayout(100, 4, [300, 50], 30)).toStrictEqual({
-			visibleCount: 1,
-			firstMaxWidth: 66,
-		});
-	});
-
-	it('gives a lone too-wide badge the full width', () => {
-		expect(computeOverflowBadgesLayout(100, 4, [300], 30)).toStrictEqual({
-			visibleCount: 1,
-			firstMaxWidth: 100,
-		});
-	});
-
-	it('returns visibleCount 0 when badgeWidths is empty', () => {
-		expect(computeOverflowBadgesLayout(100, 4, [], 30)).toStrictEqual({
-			visibleCount: 0,
-		});
-	});
-});
-
-describe('OverflowBadges', () => {
-	afterEach(() => {
-		jest.restoreAllMocks();
-	});
-
-	it('collapses the badges that do not fit into +N', () => {
-		jest.spyOn(HTMLElement.prototype, 'clientWidth', 'get').mockReturnValue(160);
-		jest
-			.spyOn(Element.prototype, 'getBoundingClientRect')
-			.mockReturnValue({ width: 50 } as DOMRect);
-
-		render(<OverflowBadges items={items} />);
-
-		expect(screen.getAllByTestId('overflow-badges-item')).toHaveLength(2);
-		expect(screen.getByTestId('overflow-badges-more')).toHaveTextContent('+2');
-	});
-
-	it('omits +N when every badge fits', () => {
-		jest.spyOn(HTMLElement.prototype, 'clientWidth', 'get').mockReturnValue(1000);
-		jest
-			.spyOn(Element.prototype, 'getBoundingClientRect')
-			.mockReturnValue({ width: 50 } as DOMRect);
-
-		render(<OverflowBadges items={items} />);
-
-		expect(screen.getAllByTestId('overflow-badges-item')).toHaveLength(4);
-		expect(screen.queryByTestId('overflow-badges-more')).not.toBeInTheDocument();
-	});
-});

frontend/src/components/OverflowBadges/types.ts

@@ -1,20 +0,0 @@
-import type { Key, ReactNode } from 'react';
-
-export interface OverflowBadgeItem {
-	key: Key;
-	label: ReactNode;
-}
-
-export interface OverflowBadgesLayout {
-	visibleCount: number;
-	/** Set when even the first badge does not fit and must truncate. */
-	firstMaxWidth?: number;
-}
-
-export interface OverflowBadgesMeasurement {
-	/** The items these widths were measured for. */
-	itemsKey: string;
-	badgeWidths: number[];
-	overflowWidth: number;
-	gap: number;
-}

frontend/src/components/OverflowBadges/useOverflowBadgesLayout.ts

@@ -1,71 +0,0 @@
-import { type RefObject, useLayoutEffect, useMemo, useState } from 'react';
-
-import type {
-	OverflowBadgeItem,
-	OverflowBadgesLayout,
-	OverflowBadgesMeasurement,
-} from './types';
-import { computeOverflowBadgesLayout } from './utils';
-
-/**
- * Fits the badges to the container's width, re-fitting on resize. Badge widths
- * are measured once per set of items, from a measuring row holding every badge
- * at its natural width followed by "+N", rendered only while `isMeasuring`.
- */
-export function useOverflowBadgesLayout(
-	items: OverflowBadgeItem[],
-	containerRef: RefObject<HTMLElement>,
-	measureRef: RefObject<HTMLElement>,
-): OverflowBadgesLayout & { isMeasuring: boolean } {
-	const itemsKey = items.map((item) => String(item.key)).join('\u0000');
-	const [measurement, setMeasurement] =
-		useState<OverflowBadgesMeasurement | null>(null);
-	const [available, setAvailable] = useState(0);
-	const isMeasuring = items.length > 0 && measurement?.itemsKey !== itemsKey;
-
-	useLayoutEffect(() => {
-		const container = containerRef.current;
-		const measure = measureRef.current;
-		if (!isMeasuring || !container || !measure) {
-			return;
-		}
-		// Rounded up so sub-pixel widths never add up past the container.
-		const badgeWidths = Array.from(measure.children, (el) =>
-			Math.ceil(el.getBoundingClientRect().width),
-		);
-		const overflowWidth = badgeWidths.pop() ?? 0;
-		setMeasurement({
-			itemsKey,
-			badgeWidths,
-			overflowWidth,
-			gap: parseFloat(getComputedStyle(container).columnGap) || 0,
-		});
-	}, [isMeasuring, itemsKey, containerRef, measureRef]);
-
-	useLayoutEffect(() => {
-		const container = containerRef.current;
-		if (!container) {
-			return undefined;
-		}
-		const update = (): void => setAvailable(container.clientWidth);
-		update();
-		const observer = new ResizeObserver(update);
-		observer.observe(container);
-		return (): void => observer.disconnect();
-	}, [containerRef]);
-
-	const layout = useMemo(
-		(): OverflowBadgesLayout =>
-			isMeasuring || !measurement || available === 0
-				? { visibleCount: items.length }
-				: computeOverflowBadgesLayout(
-						available,
-						measurement.gap,
-						measurement.badgeWidths,
-						measurement.overflowWidth,
-					),
-		[isMeasuring, measurement, available, items.length],
-	);
-
-	return { ...layout, isMeasuring };
-}

frontend/src/components/OverflowBadges/utils.ts

@@ -1,33 +0,0 @@
-import type { OverflowBadgesLayout } from './types';
-
-/**
- * How many badges fit `available` px, keeping room for the "+N" badge while any
- * are left out. Always shows at least one, capped to truncate when too wide.
- */
-export const computeOverflowBadgesLayout = (
-	available: number,
-	gap: number,
-	badgeWidths: number[],
-	overflowWidth: number,
-): OverflowBadgesLayout => {
-	if (badgeWidths.length === 0) {
-		return { visibleCount: 0 };
-	}
-
-	let used = 0;
-	let visibleCount = 0;
-	for (let i = 0; i < badgeWidths.length; i++) {
-		const next = used + (i > 0 ? gap : 0) + badgeWidths[i];
-		const reserve = i < badgeWidths.length - 1 ? gap + overflowWidth : 0;
-		if (next + reserve > available) {
-			break;
-		}
-		used = next;
-		visibleCount++;
-	}
-	if (visibleCount > 0) {
-		return { visibleCount };
-	}
-	const reserve = badgeWidths.length > 1 ? gap + overflowWidth : 0;
-	return { visibleCount: 1, firstMaxWidth: Math.max(available - reserve, 0) };
-};

frontend/src/components/QueryBuilderV2/QueryV2/QueryAddOns/QueryAddOns.tsx

@@ -26,7 +26,6 @@ import {
 	RAW_QUERY_FIELDS,
 	resolveQueryBuilderFields,
 } from '../../queryBuilderFields.utils';
-import { parseLimit, sanitizeLimit } from '../../utils';
 
 import BucketOptions from './BucketOptions/BucketOptions';
 import HavingFilter from './HavingFilter/HavingFilter';
@@ -279,7 +278,7 @@ function QueryAddOns({
 
 	const handleChangeLimit = useCallback(
 		(value: string) => {
-			handleChangeQueryData('limit', parseLimit(value));
+			handleChangeQueryData('limit', Number(value) || null);
 		},
 		[handleChangeQueryData],
 	);
@@ -375,7 +374,6 @@ function QueryAddOns({
 									label="Limit"
 									type="number"
 									onChange={handleChangeLimit}
-									sanitize={sanitizeLimit}
 									initialValue={query?.limit ?? undefined}
 									placeholder={placeholderOf(QueryBuilderField.Limit)}
 									onClose={(): void => handleRemoveView(QueryBuilderField.Limit)}

frontend/src/components/QueryBuilderV2/QueryV2/__tests__/QueryV2.test.tsx

@@ -25,8 +25,6 @@ import {
 import '@testing-library/jest-dom';
 
 import { QueryBuilderV2 } from '../../QueryBuilderV2';
-import { QueryBuilderV2Provider } from '../../QueryBuilderV2Context';
-import { QueryV2 } from '../QueryV2';
 
 // Local mocks for domain-specific heavy child components
 jest.mock(
@@ -251,7 +249,11 @@ describe('QueryBuilderV2 + QueryV2 - base render', () => {
 
 	describe('query actions menu', () => {
 		const openQueryActions = async (): Promise<void> => {
-			await userEvent.click(screen.getAllByTestId('query-actions')[0]);
+			const trigger = document.querySelector(
+				'.query-actions-container [aria-haspopup="menu"]',
+			) as HTMLElement;
+			expect(trigger).toBeInTheDocument();
+			await userEvent.click(trigger);
 		};
 
 		it('Clone calls cloneQuery with the query', async () => {
@@ -259,7 +261,7 @@ describe('QueryBuilderV2 + QueryV2 - base render', () => {
 
 			await openQueryActions();
 			await userEvent.click(
-				await screen.findByTestId('query-actions-item-clone-query'),
+				await screen.findByRole('menuitem', { name: 'Clone' }),
 			);
 
 			expect(baseQBContext.cloneQuery).toHaveBeenCalledTimes(1);
@@ -273,44 +275,41 @@ describe('QueryBuilderV2 + QueryV2 - base render', () => {
 			render(<QueryBuilderV2 panelType={PANEL_TYPES.TABLE} version="v4" />);
 
 			await openQueryActions();
-			await screen.findByTestId('query-actions-item-clone-query');
+			await screen.findByRole('menuitem', { name: 'Clone' });
 
 			expect(
-				screen.queryByTestId('query-actions-item-delete-query'),
+				screen.queryByRole('menuitem', { name: 'Delete' }),
 			).not.toBeInTheDocument();
 		});
 
 		it('shows Delete with more than one query and deletes on click', async () => {
-			const [queryA] = (baseQBContext.currentQuery as Query).builder.queryData;
+			const currentQueryBase = baseQBContext.currentQuery as Query;
+			const [queryA] = currentQueryBase.builder.queryData;
+			mockedUseQueryBuilder.mockReturnValue({
+				...baseQBContext,
+				currentQuery: {
+					...currentQueryBase,
+					builder: {
+						...currentQueryBase.builder,
+						queryData: [queryA, { ...queryA, queryName: 'B', legend: 'B' }],
+					},
+				},
+			});
 			const handleDeleteQuery = jest.fn();
 			mockedUseQueryOperations.mockReturnValue({
 				...mockedUseQueryOperations({} as Parameters<UseQueryOperations>[0]),
 				handleDeleteQuery,
 			});
 
-			render(
-				<QueryBuilderV2Provider>
-					<QueryV2
-						index={0}
-						query={queryA}
-						version="v4"
-						isAvailableToDisable={false}
-						isMultiQueryAllowed
-						queriesCount={2}
-						onSignalSourceChange={jest.fn()}
-						signalSourceChangeEnabled={false}
-						savePreviousQuery={false}
-					/>
-				</QueryBuilderV2Provider>,
-			);
+			render(<QueryBuilderV2 panelType={PANEL_TYPES.TABLE} version="v4" />);
 
 			await openQueryActions();
 			await userEvent.click(
-				await screen.findByTestId('query-actions-item-delete-query'),
+				await screen.findByRole('menuitem', { name: 'Delete' }),
 			);
 
 			expect(handleDeleteQuery).toHaveBeenCalledTimes(1);
-		}, 15000);
+		});
 	});
 
 	it('fx button is disabled when functions already exist', () => {

frontend/src/components/QueryBuilderV2/__tests__/QueryAddOns.test.tsx

@@ -169,15 +169,8 @@ describe('QueryAddOns', () => {
 		expect(screen.getByTestId('limit-content')).toBeInTheDocument();
 		expect(input.value).toBe('5');
 
-		const user = userEvent.setup();
-		await user.clear(input);
-		await user.type(input, '10');
-		expect(mockHandleChangeQueryData).toHaveBeenLastCalledWith('limit', 10);
-
-		await user.clear(input);
-		await user.type(input, '-5');
-		expect(input.value).toBe('5');
-		expect(mockHandleChangeQueryData).toHaveBeenLastCalledWith('limit', 5);
+		fireEvent.change(input, { target: { value: '10' } });
+		expect(mockHandleChangeQueryData).toHaveBeenCalledWith('limit', 10);
 	});
 
 	it.each([

frontend/src/components/QueryBuilderV2/__tests__/utils.test.ts

@@ -12,62 +12,10 @@ import {
 	convertExpressionToFilters,
 	convertFiltersToExpression,
 	convertFiltersToExpressionWithExistingQuery,
-	convertHavingToExpression,
 	formatValueForExpression,
-	parseLimit,
 	removeKeysFromExpression,
-	sanitizeLimit,
 } from '../utils';
 
-describe('convertHavingToExpression', () => {
-	it.each([
-		['COUNT()', 'count() > 5'],
-		['COUNT_DISTINCT(service.name)', 'count_distinct(service.name) > 5'],
-		['P99(duration_nano)', 'p99(duration_nano) > 5'],
-		['SUM(http.Request.Size)', 'sum(http.Request.Size) > 5'],
-		['count()', 'count() > 5'],
-	])('references %s by its lower-case function', (columnName, expected) => {
-		expect(
-			convertHavingToExpression([{ columnName, op: '>', value: 5 }]),
-		).toStrictEqual({ expression: expected });
-	});
-
-	it('joins several conditions and formats list values', () => {
-		expect(
-			convertHavingToExpression([
-				{ columnName: 'COUNT()', op: '>', value: 5 },
-				{ columnName: 'COUNT()', op: 'NOT IN', value: [1, 2] },
-			]),
-		).toStrictEqual({ expression: 'count() > 5 AND count() NOT IN [1, 2]' });
-	});
-});
-
-describe('sanitizeLimit', () => {
-	it.each([
-		['10', '10'],
-		['-10', '10'],
-		['2.5', '25'],
-		['1e3', '13'],
-		['', ''],
-	])('sanitizes %j to %j', (value, expected) => {
-		expect(sanitizeLimit(value)).toBe(expected);
-	});
-});
-
-describe('parseLimit', () => {
-	it.each([
-		['10', 10],
-		['1', 1],
-		['', null],
-		['0', null],
-		['-5', null],
-		['2.5', null],
-		['abc', null],
-	])('parses %j as %j', (value, expected) => {
-		expect(parseLimit(value)).toBe(expected);
-	});
-});
-
 describe('convertFiltersToExpression', () => {
 	beforeEach(() => {
 		jest.clearAllMocks();

frontend/src/components/QueryBuilderV2/utils.ts

@@ -840,16 +840,6 @@ export const appendAndClause = (
 	return hasTopLevelOr ? `(${base}) AND ${clause}` : `${base} AND ${clause}`;
 };
 
-/** Strips everything but digits, so a limit input can't hold a sign or decimal. */
-export const sanitizeLimit = (value: string): string =>
-	value.replace(/\D/g, '');
-
-/** A query or formula limit: a positive integer, otherwise none. */
-export const parseLimit = (value: string): number | null => {
-	const limit = Number(value);
-	return Number.isInteger(limit) && limit > 0 ? limit : null;
-};
-
 /**
  * Convert old having format to new having format
  * @param having - Array of old having objects with columnName, op, and value
@@ -881,14 +871,7 @@ export const convertHavingToExpression = (
 				formattedValue = String(value);
 			}
 
-			// The old having filter upper-cased the function (`COUNT()`); v5 only
-			// resolves the aggregation's own lower-case expression.
-			const reference = columnName.replace(
-				/^\s*([A-Za-z_]\w*)\(/,
-				(_, fn: string) => `${fn.toLowerCase()}(`,
-			);
-
-			return `${reference} ${op} ${formattedValue}`;
+			return `${columnName} ${op} ${formattedValue}`;
 		})
 		.filter((expression) => expression !== ''); // Remove empty expressions
 

frontend/src/components/TanStackTableView/TanStackHeaderRow.tsx

@@ -4,7 +4,6 @@ import type {
 	TouchEvent as ReactTouchEvent,
 } from 'react';
 import { useCallback, useMemo } from 'react';
-import { flushSync } from 'react-dom';
 import {
 	ArrowDown,
 	ArrowUp,
@@ -32,7 +31,7 @@ type TanStackHeaderRowProps<TData = unknown> = {
 	onRemoveColumn?: (columnId: string) => void;
 	orderBy?: SortState | null;
 	onSort?: (sort: SortState | null) => void;
-	/** The fill column and any after it cannot be resized */
+	/** Last column cannot be resized */
 	isLastColumn?: boolean;
 };
 
@@ -90,19 +89,6 @@ function TanStackHeaderRow<TData>({
 	): void => {
 		event.preventDefault();
 		event.stopPropagation();
-		// TanStack starts the drag from the configured size, which an auto or
-		// redistributed column does not render at.
-		const renderedWidth = Math.round(
-			event.currentTarget.closest('th')?.getBoundingClientRect().width ?? 0,
-		);
-		if (header && renderedWidth > 0 && renderedWidth !== header.getSize()) {
-			flushSync(() => {
-				header.getContext().table.setColumnSizing((sizing) => ({
-					...sizing,
-					[header.column.id]: renderedWidth,
-				}));
-			});
-		}
 		resizeHandler?.(event);
 	};
 	const {

frontend/src/components/TanStackTableView/TanStackTable.tsx

@@ -53,11 +53,7 @@ import { useFlatItems } from './useFlatItems';
 import { useResetScroll } from './useResetScroll';
 import { useRowKeyData } from './useRowKeyData';
 import { useTableParams } from './useTableParams';
-import {
-	buildPageSizeItems,
-	buildTanstackColumnDef,
-	getFillColumnIndex,
-} from './utils';
+import { buildPageSizeItems, buildTanstackColumnDef } from './utils';
 import { VirtuosoTableColGroup } from './VirtuosoTableColGroup';
 
 import tableStyles from './TanStackTable.module.scss';
@@ -432,9 +428,6 @@ function TanStackTableInner<TData, TItemKey = string>(
 	);
 
 	const tableHeader = useCallback(() => {
-		const fillColumnIndex = getFillColumnIndex(
-			flatHeaders.map((header) => columnsById.get(header.id)),
-		);
 		return (
 			<DndContext
 				sensors={sensors}
@@ -460,7 +453,7 @@ function TanStackTableInner<TData, TItemKey = string>(
 									canRemoveColumn={canRemoveColumn}
 									orderBy={orderBy}
 									onSort={setOrderBy}
-									isLastColumn={index >= fillColumnIndex}
+									isLastColumn={index === flatHeaders.length - 1}
 								/>
 							);
 						})}

frontend/src/components/TanStackTableView/VirtuosoTableColGroup.tsx

@@ -1,7 +1,7 @@
 import type { Table } from '@tanstack/react-table';
 
 import type { TableColumnDef } from './types';
-import { getColumnWidthStyle, getFillColumnIndex } from './utils';
+import { getColumnWidthStyle } from './utils';
 
 export function VirtuosoTableColGroup<TData>({
 	columns,
@@ -13,9 +13,6 @@ export function VirtuosoTableColGroup<TData>({
 	const visibleTanstackColumns = table.getVisibleFlatColumns();
 	const columnDefsById = new Map(columns.map((c) => [c.id, c]));
 	const columnSizing = table.getState().columnSizing;
-	const fillColumnIndex = getFillColumnIndex(
-		visibleTanstackColumns.map((c) => columnDefsById.get(c.id)),
-	);
 
 	return (
 		<colgroup>
@@ -25,7 +22,7 @@ export function VirtuosoTableColGroup<TData>({
 					return <col key={tanstackCol.id} />;
 				}
 				const persistedWidth = columnSizing[tanstackCol.id];
-				const isLastColumn = index === fillColumnIndex;
+				const isLastColumn = index === visibleTanstackColumns.length - 1;
 				return (
 					<col
 						key={tanstackCol.id}

frontend/src/components/TanStackTableView/__tests__/TanStackTableColumnFill.test.tsx

@@ -1,51 +0,0 @@
-import { screen } from '@testing-library/react';
-
-import type { TableColumnDef } from '../types';
-import { defaultColumns, renderTanStackTable, type TestRow } from './testUtils';
-
-jest.mock('hooks/useDarkMode', () => ({
-	useIsDarkMode: (): boolean => false,
-}));
-
-const actionsColumn: TableColumnDef<TestRow> = {
-	id: 'actions',
-	header: 'Actions',
-	cell: (): string => 'act',
-	width: { fixed: '96px', passLastColumnFill: true },
-};
-
-const colWidths = (container: HTMLElement): string[] =>
-	Array.from(container.querySelectorAll('colgroup col')).map(
-		(col) => (col as HTMLElement).style.width,
-	);
-
-const isResizable = (headerText: string): boolean =>
-	Boolean(
-		screen
-			.getByText(headerText)
-			.closest('th')
-			?.querySelector('[title="Drag to resize column"]'),
-	);
-
-describe('TanStackTable column fill', () => {
-	it('fills and locks the last column by default', () => {
-		const { container } = renderTanStackTable();
-
-		expect(colWidths(container).at(-1)).toBe('100%');
-		expect(isResizable('Name')).toBe(true);
-		expect(isResizable('Value')).toBe(false);
-	});
-
-	it('hands the fill to the previous column when the last passes it on', () => {
-		const { container } = renderTanStackTable({
-			props: { columns: [...defaultColumns, actionsColumn] },
-		});
-
-		const widths = colWidths(container);
-		expect(widths.at(-2)).toBe('100%');
-		expect(widths.at(-1)).toBe('96px');
-		expect(isResizable('Name')).toBe(true);
-		expect(isResizable('Value')).toBe(false);
-		expect(isResizable('Actions')).toBe(false);
-	});
-});

frontend/src/components/TanStackTableView/__tests__/utils.test.ts

@@ -1,28 +0,0 @@
-import type { TableColumnDef } from '../types';
-import { getFillColumnIndex } from '../utils';
-
-const column = (
-	id: string,
-	width?: TableColumnDef<unknown>['width'],
-): TableColumnDef<unknown> => ({
-	id,
-	header: id,
-	cell: (): null => null,
-	width,
-});
-
-describe('getFillColumnIndex', () => {
-	it('fills the last column by default', () => {
-		expect(getFillColumnIndex([column('a'), column('b')])).toBe(1);
-	});
-
-	it('fills the previous column when the last passes it on', () => {
-		expect(
-			getFillColumnIndex([
-				column('a'),
-				column('b'),
-				column('actions', { fixed: '96px', passLastColumnFill: true }),
-			]),
-		).toBe(1);
-	});
-});

frontend/src/components/TanStackTableView/types.ts

@@ -74,8 +74,6 @@ export type TableColumnDef<
 		default?: number | string;
 		max?: number | string;
 		ignoreLastColumnFill?: boolean;
-		/** When last, hand the fill to the previous column instead of taking it. */
-		passLastColumnFill?: boolean;
 	};
 };
 

frontend/src/components/TanStackTableView/useRowNavigation.ts

@@ -1,38 +0,0 @@
-import { useCallback } from 'react';
-
-export type UseRowNavigationParams<TData> = {
-	rows: TData[];
-	activeIndex: number;
-	onNavigate: (row: TData, index: number) => void;
-};
-
-export type UseRowNavigationResult = {
-	goToPrev: () => void;
-	goToNext: () => void;
-	isPrevDisabled: boolean;
-	isNextDisabled: boolean;
-};
-
-/** Steps the active row through the loaded rows; stops at either end. */
-export function useRowNavigation<TData>({
-	rows,
-	activeIndex,
-	onNavigate,
-}: UseRowNavigationParams<TData>): UseRowNavigationResult {
-	const isPrevDisabled = activeIndex <= 0;
-	const isNextDisabled = activeIndex < 0 || activeIndex >= rows.length - 1;
-
-	const goToPrev = useCallback((): void => {
-		if (!isPrevDisabled) {
-			onNavigate(rows[activeIndex - 1], activeIndex - 1);
-		}
-	}, [isPrevDisabled, onNavigate, rows, activeIndex]);
-
-	const goToNext = useCallback((): void => {
-		if (!isNextDisabled) {
-			onNavigate(rows[activeIndex + 1], activeIndex + 1);
-		}
-	}, [isNextDisabled, onNavigate, rows, activeIndex]);
-
-	return { goToPrev, goToNext, isPrevDisabled, isNextDisabled };
-}

frontend/src/components/TanStackTableView/utils.ts

@@ -63,19 +63,6 @@ export const getColumnWidthStyle = <TData>(
 	};
 };
 
-/**
- * Index of the column that fills spare width: the last one, or the one before
- * it when the last sets `width.passLastColumnFill`.
- */
-export const getFillColumnIndex = <TData>(
-	columns: (TableColumnDef<TData> | undefined)[],
-): number => {
-	const lastIndex = columns.length - 1;
-	return columns[lastIndex]?.width?.passLastColumnFill
-		? lastIndex - 1
-		: lastIndex;
-};
-
 const isSkeletonRow = (row: unknown): boolean => {
 	const r = row as Record<string, unknown>;
 	return typeof r?.id === 'string' && r.id.startsWith('skeleton-');

frontend/src/constants/localStorage.ts

@@ -46,5 +46,4 @@ export enum LOCALSTORAGE {
 	DASHBOARDS_LIST_VIEWS = 'DASHBOARDS_LIST_VIEWS',
 	DASHBOARD_V2_PANEL_COLUMN_WIDTHS = 'DASHBOARD_V2_PANEL_COLUMN_WIDTHS',
 	LLM_ATTRIBUTE_MAPPING_TEST_SPAN = 'LLM_ATTRIBUTE_MAPPING_TEST_SPAN',
-	TRACES_SPAN_DRAWER_ENABLED = 'TRACES_SPAN_DRAWER_ENABLED',
 }

frontend/src/container/AIAssistant/components/ActionsSection/ActionsSection.tsx

@@ -26,7 +26,6 @@ import {
 } from 'api/ai-assistant/chat';
 import ROUTES from 'constants/routes';
 import { QueryParams } from 'constants/query';
-import { buildExplorerNavigationUrl } from 'utils/buildExplorerNavigationUrl';
 import { openInNewTab } from 'utils/navigation';
 import {
 	ArchiveRestore,
@@ -48,10 +47,6 @@ import { AIAssistantEvents, SuggestedPromptCategory } from '../../events';
 import { useAIAssistantAnalyticsContext } from '../../hooks/useAIAssistantAnalyticsContext';
 import { useAIAssistantStore } from '../../store/useAIAssistantStore';
 
-import {
-	getPanelTypeForRequestType,
-	requestTypeFromActionQuery,
-} from './utils/getPanelTypeForRequestType';
 import { openSavedViewByKey } from './utils/openSavedView';
 import {
 	isSavedViewOpenAction,
@@ -338,11 +333,6 @@ function applyFilter(action: MessageActionDTO, deps: ApplyFilterDeps): void {
 		);
 		return;
 	}
-	// Read before toUrlCompositeQuery, which drops the requestType envelope.
-	const panelType = getPanelTypeForRequestType(
-		requestTypeFromActionQuery(action.query),
-		action.signal,
-	);
 	const normalized = withDerivedFilterExpressions(urlQuery as unknown as Query);
 	// eslint-disable-next-line no-console
 	console.log('[apply_filter] normalized', normalized);
@@ -352,9 +342,7 @@ function applyFilter(action: MessageActionDTO, deps: ApplyFilterDeps): void {
 		normalized.builder.queryData.forEach((q, i) => {
 			deps.handleSetQueryData(i, q);
 		});
-		deps.redirectWithQueryBuilderData(normalized, {
-			[QueryParams.panelTypes]: panelType,
-		});
+		deps.redirectWithQueryBuilderData(normalized);
 		return;
 	}
 	const base = explorerRouteForSignal(action.signal);
@@ -365,10 +353,8 @@ function applyFilter(action: MessageActionDTO, deps: ApplyFilterDeps): void {
 	}
 	// eslint-disable-next-line no-console
 	console.log('[apply_filter] off-page → navigate', base);
-	const url = buildExplorerNavigationUrl(base, normalized, {
-		[QueryParams.panelTypes]: panelType,
-	});
-	navigate(url);
+	const encoded = encodeURIComponent(JSON.stringify(normalized));
+	navigate(`${base}?${QueryParams.compositeQuery}=${encoded}`);
 }
 
 /** Picks the right rollback API call for a given action kind. */
@@ -627,7 +613,6 @@ export default function ActionsSection({
 							disabled={isSuccess}
 							loading={isLoading}
 							aria-label={action.label}
-							testId={`ai-action-chip-${action.kind}`}
 							prefix={icon}
 						>
 							<span className={styles.chipLabel}>{action.label}</span>

frontend/src/container/AIAssistant/components/ActionsSection/__tests__/ActionsSection.test.tsx

@@ -1,16 +1,7 @@
 import { undoExecution } from 'api/ai-assistant/chat';
 import type { MessageActionDTO } from 'api/ai-assistant/sigNozAIAssistantAPI.schemas';
-import {
-	ApplyFilterSignalDTO,
-	MessageActionKindDTO,
-} from 'api/ai-assistant/sigNozAIAssistantAPI.schemas';
-import { Querybuildertypesv5RequestTypeDTO } from 'api/generated/services/sigNoz.schemas';
-import { QueryParams } from 'constants/query';
-import { PANEL_TYPES } from 'constants/queryBuilder';
-import ROUTES from 'constants/routes';
-import { getCurrentLocation } from 'lib/router/navigation';
+import { MessageActionKindDTO } from 'api/ai-assistant/sigNozAIAssistantAPI.schemas';
 import { render, screen, userEvent, waitFor } from 'tests/test-utils';
-import { QueryBuilderContextType } from 'types/common/queryBuilder';
 
 import ActionsSection from '../ActionsSection';
 
@@ -37,37 +28,6 @@ function renderUndoChip(): HTMLElement {
 	return screen.getByRole('button', { name: 'Undo change' });
 }
 
-// Labels differ per test: auto-applied filters are deduped module-wide by label.
-function countByServiceAction(label: string): MessageActionDTO {
-	return {
-		kind: MessageActionKindDTO.apply_filter,
-		label,
-		signal: ApplyFilterSignalDTO.logs,
-		query: {
-			requestType: Querybuildertypesv5RequestTypeDTO.scalar,
-			compositeQuery: {
-				queries: [
-					{
-						type: 'builder_query',
-						spec: {
-							name: 'A',
-							signal: 'logs',
-							aggregations: [{ expression: 'count()' }],
-							groupBy: [{ name: 'service.name' }],
-						},
-					},
-				],
-			},
-		},
-	};
-}
-
-function currentPanelTypesParam(): string | null {
-	return new URLSearchParams(getCurrentLocation().search).get(
-		QueryParams.panelTypes,
-	);
-}
-
 describe('ActionsSection rollback chip', () => {
 	beforeEach(() => {
 		mockUndo.mockReset();
@@ -121,52 +81,3 @@ describe('ActionsSection rollback chip', () => {
 		).resolves.toBeInTheDocument();
 	});
 });
-
-describe('ActionsSection apply_filter', () => {
-	it('opens the explorer in the Table view when the chip is clicked from another page', async () => {
-		const user = userEvent.setup({ pointerEventsCheck: 0 });
-		render(
-			<ActionsSection
-				actions={[countByServiceAction('Open in Logs Explorer')]}
-				messageId="message-1"
-			/>,
-			undefined,
-			{ initialRoute: ROUTES.HOME },
-		);
-
-		await user.click(screen.getByTestId('ai-action-chip-apply_filter'));
-
-		await waitFor(() =>
-			expect(getCurrentLocation().pathname).toBe(ROUTES.LOGS_EXPLORER),
-		);
-		expect(currentPanelTypesParam()).toBe(JSON.stringify(PANEL_TYPES.TABLE));
-	});
-
-	it('switches the open explorer to the Table view when applied on it', async () => {
-		const redirectWithQueryBuilderData = jest.fn() as jest.MockedFunction<
-			QueryBuilderContextType['redirectWithQueryBuilderData']
-		>;
-		const handleSetQueryData = jest.fn() as jest.MockedFunction<
-			QueryBuilderContextType['handleSetQueryData']
-		>;
-		render(
-			<ActionsSection
-				actions={[countByServiceAction('Apply on Logs Explorer')]}
-				messageId="message-2"
-			/>,
-			undefined,
-			{
-				initialRoute: ROUTES.LOGS_EXPLORER,
-				queryBuilderOverrides: { redirectWithQueryBuilderData, handleSetQueryData },
-			},
-		);
-
-		await waitFor(() =>
-			expect(redirectWithQueryBuilderData).toHaveBeenCalledTimes(1),
-		);
-		expect(redirectWithQueryBuilderData).toHaveBeenCalledWith(
-			expect.objectContaining({ builder: expect.anything() }),
-			{ [QueryParams.panelTypes]: PANEL_TYPES.TABLE },
-		);
-	});
-});

frontend/src/container/AIAssistant/components/ActionsSection/utils/__tests__/getPanelTypeForRequestType.test.ts

@@ -1,106 +0,0 @@
-import { ApplyFilterSignalDTO } from 'api/ai-assistant/sigNozAIAssistantAPI.schemas';
-import { Querybuildertypesv5RequestTypeDTO } from 'api/generated/services/sigNoz.schemas';
-import { PANEL_TYPES } from 'constants/queryBuilder';
-
-import {
-	getPanelTypeForRequestType,
-	requestTypeFromActionQuery,
-} from '../getPanelTypeForRequestType';
-
-describe('getPanelTypeForRequestType', () => {
-	it.each([
-		[
-			Querybuildertypesv5RequestTypeDTO.scalar,
-			ApplyFilterSignalDTO.logs,
-			PANEL_TYPES.TABLE,
-		],
-		[
-			Querybuildertypesv5RequestTypeDTO.time_series,
-			ApplyFilterSignalDTO.logs,
-			PANEL_TYPES.TIME_SERIES,
-		],
-		[
-			Querybuildertypesv5RequestTypeDTO.raw,
-			ApplyFilterSignalDTO.logs,
-			PANEL_TYPES.LIST,
-		],
-		[
-			Querybuildertypesv5RequestTypeDTO.trace,
-			ApplyFilterSignalDTO.traces,
-			PANEL_TYPES.TRACE,
-		],
-		[
-			Querybuildertypesv5RequestTypeDTO.trace,
-			ApplyFilterSignalDTO.logs,
-			PANEL_TYPES.LIST,
-		],
-		[
-			Querybuildertypesv5RequestTypeDTO.trace,
-			ApplyFilterSignalDTO.metrics,
-			PANEL_TYPES.LIST,
-		],
-	])('maps %s on the %s signal to the %s view', (requestType, signal, view) => {
-		expect(getPanelTypeForRequestType(requestType, signal)).toBe(view);
-	});
-
-	it.each([
-		undefined,
-		null,
-		'',
-		Querybuildertypesv5RequestTypeDTO.raw_stream,
-		Querybuildertypesv5RequestTypeDTO.heatmap,
-		'distribution',
-		'nonsense',
-		'toString',
-		'constructor',
-		42,
-		{},
-	])(
-		'falls back to the List view for unmapped or invalid requestType (%p)',
-		(value) => {
-			expect(getPanelTypeForRequestType(value, ApplyFilterSignalDTO.traces)).toBe(
-				PANEL_TYPES.LIST,
-			);
-		},
-	);
-});
-
-describe('requestTypeFromActionQuery', () => {
-	it('reads the requestType envelope field and returns undefined when absent', () => {
-		expect(
-			requestTypeFromActionQuery({
-				requestType: 'scalar',
-				schemaVersion: 'v5',
-				compositeQuery: { queries: [] },
-			}),
-		).toBe('scalar');
-		expect(requestTypeFromActionQuery({})).toBeUndefined();
-		expect(requestTypeFromActionQuery(null)).toBeUndefined();
-		expect(requestTypeFromActionQuery(undefined)).toBeUndefined();
-	});
-
-	it('maps a grouped count() payload to the Table view', () => {
-		const query = {
-			requestType: 'scalar',
-			schemaVersion: 'v5',
-			compositeQuery: {
-				queries: [
-					{
-						type: 'builder_query',
-						spec: {
-							signal: 'logs',
-							aggregations: [{ expression: 'count()' }],
-							groupBy: [{ name: 'service.name' }],
-						},
-					},
-				],
-			},
-		};
-		expect(
-			getPanelTypeForRequestType(
-				requestTypeFromActionQuery(query),
-				ApplyFilterSignalDTO.logs,
-			),
-		).toBe(PANEL_TYPES.TABLE);
-	});
-});

frontend/src/container/AIAssistant/components/ActionsSection/utils/getPanelTypeForRequestType.ts

@@ -1,30 +0,0 @@
-import {
-	ApplyFilterSignalDTO,
-	type MessageActionDTOQuery,
-} from 'api/ai-assistant/sigNozAIAssistantAPI.schemas';
-import { Querybuildertypesv5RequestTypeDTO } from 'api/generated/services/sigNoz.schemas';
-import { PANEL_TYPES } from 'constants/queryBuilder';
-
-export function getPanelTypeForRequestType(
-	requestType: unknown,
-	signal: ApplyFilterSignalDTO,
-): PANEL_TYPES {
-	switch (requestType) {
-		case Querybuildertypesv5RequestTypeDTO.scalar:
-			return PANEL_TYPES.TABLE;
-		case Querybuildertypesv5RequestTypeDTO.time_series:
-			return PANEL_TYPES.TIME_SERIES;
-		case Querybuildertypesv5RequestTypeDTO.trace:
-			return signal === ApplyFilterSignalDTO.traces
-				? PANEL_TYPES.TRACE
-				: PANEL_TYPES.LIST;
-		default:
-			return PANEL_TYPES.LIST;
-	}
-}
-
-export function requestTypeFromActionQuery(
-	query: MessageActionDTOQuery | undefined,
-): unknown {
-	return query?.requestType;
-}

frontend/src/container/Integrations/CloudIntegration/AlertMessage.tsx

@@ -15,7 +15,14 @@ function AlertMessage({
 				<Callout
 					title={
 						<div className="cloud-account-setup-form__alert-message">
-							<Spin indicator={<LoaderCircle size={14} className="animate-spin" />} />
+							<Spin
+								indicator={
+									<LoaderCircle
+										size={14}
+										className="anticon anticon-loading anticon-spin ant-spin-dot"
+									/>
+								}
+							/>
 							Waiting for connection, retrying in{' '}
 							<span className="retry-time">10</span> secs...
 						</div>

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/AddNewAccount/CloudAccountSetupModal.style.scss

@@ -12,13 +12,6 @@
 		overflow: hidden;
 	}
 
-	&__footer {
-		display: flex;
-		align-items: center;
-		justify-content: space-between;
-		width: 100%;
-	}
-
 	&__content {
 		flex: 1;
 		overflow-y: auto;
@@ -151,6 +144,52 @@
 		}
 	}
 
+	.cloud-account-setup-form__code-block-tabs {
+		padding: 8px;
+		border-radius: 4px;
+		border: 1px solid var(--l2-border);
+		background: var(--l2-background);
+
+		&-header {
+			display: flex;
+			flex-direction: column;
+			gap: 12px;
+
+			margin-bottom: 12px;
+
+			&-title {
+				color: var(--l1-foreground);
+				font-size: 14px;
+				font-weight: 500;
+				line-height: 20px;
+				letter-spacing: -0.07px;
+			}
+
+			&-description {
+				color: var(--l2-foreground);
+				font-size: 12px;
+				font-weight: 400;
+				line-height: 18px;
+				letter-spacing: -0.06px;
+			}
+		}
+
+		[role='tablist'] {
+			gap: 8px !important;
+		}
+
+		[role='tabpanel'] {
+			padding: 0 !important;
+		}
+
+		[data-slot='tabs-item'] {
+			padding: 4px 24px !important;
+			border: none !important;
+			background-color: transparent !important;
+			font-size: 12px !important;
+		}
+	}
+
 	@keyframes cloud-account-setup-accordion-reveal {
 		from {
 			opacity: 0;

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/AddNewAccount/CloudAccountSetupModal.tsx

@@ -1,15 +1,15 @@
 import { useCallback } from 'react';
+import { Color } from '@signozhq/design-tokens';
 import { Button } from '@signozhq/ui/button';
 import { DrawerWrapper } from '@signozhq/ui/drawer';
 import { useIntegrationModal } from 'hooks/integration/aws/useIntegrationModal';
+import { SquareArrowOutUpRight } from '@signozhq/icons';
 
 import {
 	ActiveViewEnum,
 	IntegrationModalProps,
 	ModalStateEnum,
 } from '../../../HeroSection/types';
-import CloseSetupConfirm from '../../CloseSetupConfirm/CloseSetupConfirm';
-import { useCloseSetupConfirm } from '../../CloseSetupConfirm/useCloseSetupConfirm';
 import { RegionForm } from '../RegionForm/RegionForm';
 
 import './CloudAccountSetupModal.style.scss';
@@ -24,24 +24,22 @@ function CloudAccountSetupModal({
 		activeView,
 		selectedRegions,
 		includeAllRegions,
-		isGeneratingCommand,
-		connectionCommand,
+		isGeneratingUrl,
 		setSelectedRegions,
 		setIncludeAllRegions,
 		handleRegionSelect,
 		handleSubmit,
 		handleClose,
 		setActiveView,
+		accountId,
 		handleRegionChange,
 		connectionParams,
 		isConnectionParamsLoading,
-		checkConnectionAgain,
+		handleConnectionSuccess,
+		handleConnectionTimeout,
+		handleConnectionError,
 	} = useIntegrationModal({ onClose });
 
-	const { isConfirmOpen, setIsConfirmOpen, requestClose } = useCloseSetupConfirm(
-		{ shouldConfirm: Boolean(connectionCommand), onClose: handleClose },
-	);
-
 	const renderContent = useCallback(() => {
 		return (
 			<div className="cloud-account-setup-modal__content">
@@ -52,12 +50,15 @@ function CloudAccountSetupModal({
 					includeAllRegions={includeAllRegions}
 					onRegionSelect={handleRegionSelect}
 					onSubmit={handleSubmit}
-					connectionCommand={connectionCommand}
+					accountId={accountId}
 					handleRegionChange={handleRegionChange}
 					connectionParams={connectionParams}
 					isConnectionParamsLoading={isConnectionParamsLoading}
 					setSelectedRegions={setSelectedRegions}
 					setIncludeAllRegions={setIncludeAllRegions}
+					onConnectionSuccess={handleConnectionSuccess}
+					onConnectionTimeout={handleConnectionTimeout}
+					onConnectionError={handleConnectionError}
 				/>
 			</div>
 		);
@@ -68,50 +69,38 @@ function CloudAccountSetupModal({
 		includeAllRegions,
 		handleRegionSelect,
 		handleSubmit,
-		connectionCommand,
+		accountId,
 		handleRegionChange,
 		connectionParams,
 		isConnectionParamsLoading,
 		setSelectedRegions,
 		setIncludeAllRegions,
+		handleConnectionSuccess,
+		handleConnectionTimeout,
+		handleConnectionError,
 	]);
 
 	const footer = (
 		<div className="cloud-account-setup-modal__footer">
 			<Button
+				disabledTooltip={
+					selectedRegions.length === 0
+						? 'Select at least one region'
+						: 'Waiting for the account to connect'
+				}
 				size="md"
-				variant="outlined"
-				color="secondary"
-				onClick={requestClose}
-				testId="aws-cancel-btn"
+				variant="solid"
+				color="primary"
+				prefix={<SquareArrowOutUpRight size={17} color={Color.BG_VANILLA_100} />}
+				onClick={handleSubmit}
+				testId="aws-launch-cfn-btn"
+				disabled={
+					selectedRegions.length === 0 || modalState === ModalStateEnum.WAITING
+				}
+				loading={isLoading || isGeneratingUrl}
 			>
-				Cancel
+				Launch Cloud Formation Template
 			</Button>
-			{!connectionCommand && (
-				<Button
-					disabledTooltip="Select at least one region"
-					size="md"
-					variant="solid"
-					color="primary"
-					onClick={handleSubmit}
-					disabled={selectedRegions.length === 0}
-					loading={isLoading || isGeneratingCommand}
-					testId="aws-generate-command-btn"
-				>
-					Generate Command
-				</Button>
-			)}
-			{modalState === ModalStateEnum.ERROR && connectionCommand && (
-				<Button
-					size="md"
-					variant="solid"
-					color="primary"
-					onClick={checkConnectionAgain}
-					testId="aws-check-connection-btn"
-				>
-					Check Again
-				</Button>
-			)}
 		</div>
 	);
 
@@ -124,17 +113,22 @@ function CloudAccountSetupModal({
 		const viewConfigs = {
 			[ActiveViewEnum.FORM]: {
 				title: 'Add AWS Account',
-				okText: 'Generate Command',
+				okText: (
+					<div className="cloud-account-setup-form__submit-button-content">
+						Launch Cloud Formation Template{' '}
+						<SquareArrowOutUpRight size={17} color={Color.BG_VANILLA_100} />
+					</div>
+				),
 				onOk: handleSubmit,
 				disabled:
-					isLoading || isGeneratingCommand || modalState === ModalStateEnum.WAITING,
+					isLoading || isGeneratingUrl || modalState === ModalStateEnum.WAITING,
 				cancelButtonProps: { style: { display: 'none' } },
 			},
 			[ActiveViewEnum.SELECT_REGIONS]: {
 				title: 'Which regions do you want to monitor?',
 				okText: `Confirm Selection (${getSelectedRegionsCount()})`,
 				onOk: (): void => setActiveView(ActiveViewEnum.FORM),
-				isLoading: isLoading || isGeneratingCommand,
+				isLoading: isLoading || isGeneratingUrl,
 				cancelButtonProps: { style: { display: 'block' } },
 				disabled: false,
 			},
@@ -146,7 +140,7 @@ function CloudAccountSetupModal({
 		handleSubmit,
 		getSelectedRegionsCount,
 		isLoading,
-		isGeneratingCommand,
+		isGeneratingUrl,
 		activeView,
 		setActiveView,
 	]);
@@ -155,32 +149,23 @@ function CloudAccountSetupModal({
 
 	const handleDrawerOpenChange = (open: boolean): void => {
 		if (!open) {
-			requestClose();
+			handleClose();
 		}
 	};
 
 	return (
-		<>
-			<DrawerWrapper
-				open={true}
-				className="cloud-account-setup-modal"
-				onOpenChange={handleDrawerOpenChange}
-				direction="right"
-				showCloseButton
-				title={modalConfig.title}
-				width="wide"
-				footer={footer}
-			>
-				{renderContent()}
-			</DrawerWrapper>
-			<CloseSetupConfirm
-				providerName="AWS"
-				testIdPrefix="aws"
-				open={isConfirmOpen}
-				onOpenChange={setIsConfirmOpen}
-				onConfirm={handleClose}
-			/>
-		</>
+		<DrawerWrapper
+			open={true}
+			className="cloud-account-setup-modal"
+			onOpenChange={handleDrawerOpenChange}
+			direction="right"
+			showCloseButton
+			title={modalConfig.title}
+			width="wide"
+			footer={footer}
+		>
+			{renderContent()}
+		</DrawerWrapper>
 	);
 }
 

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/IntegrateNowFormSections.tsx

@@ -11,9 +11,11 @@ import { RegionSelector } from './RegionForm/RegionSelector';
 function RegionDeploymentSection({
 	regions,
 	handleRegionChange,
+	isFormDisabled,
 }: {
 	regions: Region[];
 	handleRegionChange: (value: string) => void;
+	isFormDisabled: boolean;
 }): JSX.Element {
 	return (
 		<div className="cloud-account-setup-form__form-group">
@@ -34,6 +36,7 @@ function RegionDeploymentSection({
 					suffixIcon={<ChevronDown size={16} color={Color.BG_VANILLA_400} />}
 					className="cloud-account-setup-form__select integrations-select"
 					onChange={handleRegionChange}
+					disabled={isFormDisabled}
 					getPopupContainer={popupContainer}
 				>
 					{regions.flatMap((region) =>

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/RegionForm/RegionForm.tsx

@@ -1,8 +1,14 @@
+import { useRef } from 'react';
 import { Form } from 'antd';
-import { RegionFormProps } from 'container/Integrations/HeroSection/types';
+import { useGetAccount } from 'api/generated/services/cloudintegration';
+import cx from 'classnames';
+import { INTEGRATION_TYPES } from 'container/Integrations/constants';
+import {
+	ModalStateEnum,
+	RegionFormProps,
+} from 'container/Integrations/HeroSection/types';
 import { regions } from 'utils/regions';
 
-import AgentSetupCommand from '../../AgentSetupCommand/AgentSetupCommand';
 import AlertMessage from '../../AlertMessage';
 import {
 	ComplianceNote,
@@ -16,13 +22,56 @@ export function RegionForm({
 	modalState,
 	selectedRegions,
 	onSubmit,
-	connectionCommand,
+	accountId,
 	handleRegionChange,
 	connectionParams,
 	isConnectionParamsLoading,
 	setSelectedRegions,
 	setIncludeAllRegions,
+	onConnectionSuccess,
+	onConnectionTimeout,
+	onConnectionError,
 }: RegionFormProps): JSX.Element {
+	const startTimeRef = useRef(Date.now());
+	const refetchInterval = 10 * 1000;
+	const errorTimeout = 10 * 60 * 1000;
+
+	const { isLoading: isAccountStatusLoading } = useGetAccount(
+		{
+			cloudProvider: INTEGRATION_TYPES.AWS,
+			id: accountId ?? '',
+		},
+		{
+			query: {
+				refetchInterval,
+				enabled: !!accountId && modalState === ModalStateEnum.WAITING,
+				onSuccess: (response) => {
+					const isConnected =
+						Boolean(response.data.providerAccountId) &&
+						response.data.removedAt === null;
+
+					if (isConnected) {
+						const cloudAccountId =
+							response.data.providerAccountId ?? response.data.id;
+
+						onConnectionSuccess({
+							cloudAccountId,
+							status: response.data.agentReport,
+						});
+					} else if (Date.now() - startTimeRef.current >= errorTimeout) {
+						onConnectionTimeout({ id: accountId });
+					}
+				},
+				onError: () => {
+					onConnectionError();
+				},
+			},
+		},
+	);
+
+	const isFormDisabled =
+		modalState === ModalStateEnum.WAITING || isAccountStatusLoading;
+
 	return (
 		<Form
 			form={form}
@@ -30,30 +79,28 @@ export function RegionForm({
 			layout="vertical"
 			onFinish={onSubmit}
 		>
-			{connectionCommand ? (
-				<AgentSetupCommand
-					description="Run this command in AWS CloudShell, or in a terminal where the AWS CLI is signed in to the account you want to monitor. It contains your SigNoz keys, so do not share it."
-					command={connectionCommand}
-					testId="aws-agent-command"
+			<div
+				className={cx(`cloud-account-setup-form__content`, {
+					disabled: isFormDisabled,
+				})}
+			>
+				<RegionDeploymentSection
+					regions={regions}
+					handleRegionChange={handleRegionChange}
+					isFormDisabled={isFormDisabled}
 				/>
-			) : (
-				<div className="cloud-account-setup-form__content">
-					<RegionDeploymentSection
-						regions={regions}
-						handleRegionChange={handleRegionChange}
-					/>
-					<MonitoringRegionsSection
-						selectedRegions={selectedRegions}
-						setSelectedRegions={setSelectedRegions}
-						setIncludeAllRegions={setIncludeAllRegions}
-					/>
-					<ComplianceNote />
-					<RenderConnectionFields
-						isConnectionParamsLoading={isConnectionParamsLoading}
-						connectionParams={connectionParams}
-					/>
-				</div>
-			)}
+				<MonitoringRegionsSection
+					selectedRegions={selectedRegions}
+					setSelectedRegions={setSelectedRegions}
+					setIncludeAllRegions={setIncludeAllRegions}
+				/>
+				<ComplianceNote />
+				<RenderConnectionFields
+					isConnectionParamsLoading={isConnectionParamsLoading}
+					connectionParams={connectionParams}
+					isFormDisabled={isFormDisabled}
+				/>
+			</div>
 
 			<div className="cloud-account-setup-form__alert">
 				<AlertMessage modalState={modalState} />

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/RegionForm/RenderConnectionParams.tsx

@@ -5,9 +5,11 @@ import { CloudintegrationtypesCredentialsDTO } from 'api/generated/services/sigN
 function RenderConnectionFields({
 	isConnectionParamsLoading,
 	connectionParams,
+	isFormDisabled,
 }: {
 	isConnectionParamsLoading?: boolean;
 	connectionParams?: CloudintegrationtypesCredentialsDTO | null;
+	isFormDisabled?: boolean;
 }): JSX.Element | null {
 	if (
 		isConnectionParamsLoading ||
@@ -27,7 +29,7 @@ function RenderConnectionFields({
 					label="Ingestion URL"
 					rules={[{ required: true, message: 'Please enter ingestion URL' }]}
 				>
-					<Input placeholder="Enter ingestion URL" />
+					<Input placeholder="Enter ingestion URL" disabled={isFormDisabled} />
 				</Form.Item>
 			)}
 			{!connectionParams?.ingestionKey && (
@@ -36,7 +38,7 @@ function RenderConnectionFields({
 					label="Ingestion Key"
 					rules={[{ required: true, message: 'Please enter ingestion key' }]}
 				>
-					<Input placeholder="Enter ingestion key" />
+					<Input placeholder="Enter ingestion key" disabled={isFormDisabled} />
 				</Form.Item>
 			)}
 			{!connectionParams?.sigNozApiUrl && (
@@ -45,7 +47,7 @@ function RenderConnectionFields({
 					label="SigNoz API URL"
 					rules={[{ required: true, message: 'Please enter SigNoz API URL' }]}
 				>
-					<Input placeholder="Enter SigNoz API URL" />
+					<Input placeholder="Enter SigNoz API URL" disabled={isFormDisabled} />
 				</Form.Item>
 			)}
 			{!connectionParams?.sigNozApiKey && (
@@ -54,7 +56,7 @@ function RenderConnectionFields({
 					label="SigNoz API KEY"
 					rules={[{ required: true, message: 'Please enter SigNoz API Key' }]}
 				>
-					<Input placeholder="Enter SigNoz API Key" />
+					<Input placeholder="Enter SigNoz API Key" disabled={isFormDisabled} />
 				</Form.Item>
 			)}
 		</Form.Item>
@@ -63,6 +65,7 @@ function RenderConnectionFields({
 
 RenderConnectionFields.defaultProps = {
 	connectionParams: null,
+	isFormDisabled: false,
 	isConnectionParamsLoading: false,
 };
 

frontend/src/container/Integrations/CloudIntegration/AmazonWebServices/__tests__/CloudAccountSetupModal.test.tsx

@@ -1,168 +0,0 @@
-import { ComponentProps } from 'react';
-import { render, screen, userEvent, waitFor } from 'tests/test-utils';
-import { rest, server } from 'mocks-server/server';
-import { RestRequest } from 'msw';
-import type logEvent from '../../../../../api/common/logEvent';
-
-import CloudAccountSetupModal from '../AddNewAccount/CloudAccountSetupModal';
-
-// `useIntegrationModal` imports logEvent by relative path, which the
-// jest.config moduleNameMapper (keyed on the `api/common/logEvent` alias) does
-// not intercept, so mock the resolved module directly.
-jest.mock('../../../../../api/common/logEvent', () => ({
-	__esModule: true,
-	default: jest.fn() as jest.MockedFunction<typeof logEvent>,
-}));
-
-// The form flow drives antd selects and typing, which outruns the 5s default on CI.
-jest.setTimeout(15_000);
-
-type OnClose = ComponentProps<typeof CloudAccountSetupModal>['onClose'];
-
-const mockOnClose = (): jest.MockedFunction<OnClose> =>
-	jest.fn() as jest.MockedFunction<OnClose>;
-
-const AWS_CREDENTIALS_URL =
-	'http://localhost/api/v1/cloud_integrations/aws/credentials';
-const AWS_ACCOUNTS_URL =
-	'http://localhost/api/v1/cloud_integrations/aws/accounts';
-const ACCOUNT_ID = 'ci-aws-1234';
-
-const credentials = {
-	sigNozApiUrl: 'https://signoz.example.com',
-	sigNozApiKey: 'signoz-api-key',
-	ingestionUrl: 'https://ingest.example.com',
-	ingestionKey: 'ingestion-key',
-};
-
-const cliCommand = `curl -fsSL 'https://signoz.io/foundry.sh' | bash -s -- cloudintegration aws cloudformation --region 'us-east-1'`;
-
-const mockApi = ({ failFirstPoll = false } = {}): {
-	createAccountPayload: unknown;
-	pollCount: () => number;
-} => {
-	let polls = 0;
-	const api = {
-		createAccountPayload: null as unknown,
-		pollCount: (): number => polls,
-	};
-
-	server.use(
-		rest.get(AWS_CREDENTIALS_URL, (_req, res, ctx) =>
-			res(ctx.status(200), ctx.json({ status: 'success', data: credentials })),
-		),
-		rest.post(AWS_ACCOUNTS_URL, async (req: RestRequest, res, ctx) => {
-			api.createAccountPayload = await req.json();
-			return res(
-				ctx.status(201),
-				ctx.json({
-					status: 'success',
-					data: { id: ACCOUNT_ID, connectionArtifact: { aws: { cliCommand } } },
-				}),
-			);
-		}),
-		rest.get(`${AWS_ACCOUNTS_URL}/${ACCOUNT_ID}`, (_req, res, ctx) => {
-			polls += 1;
-			if (failFirstPoll && polls === 1) {
-				return res(ctx.status(500), ctx.json({ status: 'error' }));
-			}
-			return res(
-				ctx.status(200),
-				ctx.json({
-					status: 'success',
-					data: {
-						id: ACCOUNT_ID,
-						providerAccountId: null,
-						agentReport: null,
-						removedAt: null,
-					},
-				}),
-			);
-		}),
-	);
-
-	return api;
-};
-
-describe('AWS CloudAccountSetupModal', () => {
-	it('creates the account and shows its setup command', async () => {
-		const api = mockApi();
-		const openSpy = jest.spyOn(window, 'open').mockImplementation(() => null);
-		const user = userEvent.setup();
-		const onClose = mockOnClose();
-
-		render(<CloudAccountSetupModal onClose={onClose} />);
-
-		await user.click(await screen.findByRole('combobox'));
-		await user.click(await screen.findByText('US East (N. Virginia)'));
-		await user.click(await screen.findByRole('checkbox', { name: /us-east-1/i }));
-		await user.click(screen.getByTestId('aws-generate-command-btn'));
-
-		await waitFor(() => {
-			expect(screen.getByTestId('aws-agent-command')).toHaveTextContent(
-				cliCommand,
-			);
-		});
-
-		expect(api.createAccountPayload).toStrictEqual({
-			config: { aws: { deploymentRegion: 'us-east-1', regions: ['us-east-1'] } },
-			credentials,
-		});
-		expect(
-			screen.queryByTestId('aws-generate-command-btn'),
-		).not.toBeInTheDocument();
-		expect(screen.queryAllByRole('combobox')).toHaveLength(0);
-		expect(screen.getByText(/waiting for connection/i)).toBeInTheDocument();
-		expect(openSpy).not.toHaveBeenCalled();
-
-		openSpy.mockRestore();
-
-		await user.click(screen.getByTestId('aws-cancel-btn'));
-		await user.click(await screen.findByTestId('aws-continue-setup-btn'));
-		await waitFor(() => {
-			expect(
-				screen.queryByTestId('aws-continue-setup-btn'),
-			).not.toBeInTheDocument();
-		});
-		expect(onClose).not.toHaveBeenCalled();
-
-		await user.click(screen.getByTestId('aws-cancel-btn'));
-		await user.click(await screen.findByTestId('aws-close-setup-btn'));
-		expect(onClose).toHaveBeenCalledTimes(1);
-	});
-
-	it('closes without asking before a setup command exists', async () => {
-		mockApi();
-		const user = userEvent.setup();
-		const onClose = mockOnClose();
-
-		render(<CloudAccountSetupModal onClose={onClose} />);
-
-		await user.click(await screen.findByTestId('aws-cancel-btn'));
-
-		expect(onClose).toHaveBeenCalledTimes(1);
-		expect(screen.queryByTestId('aws-close-setup-btn')).not.toBeInTheDocument();
-	});
-
-	it('resumes polling with Check Again after the connection check fails', async () => {
-		const api = mockApi({ failFirstPoll: true });
-		const user = userEvent.setup();
-
-		render(<CloudAccountSetupModal onClose={mockOnClose()} />);
-
-		await user.click(await screen.findByRole('combobox'));
-		await user.click(await screen.findByText('US East (N. Virginia)'));
-		await user.click(await screen.findByRole('checkbox', { name: /us-east-1/i }));
-		await user.click(screen.getByTestId('aws-generate-command-btn'));
-
-		await user.click(await screen.findByTestId('aws-check-connection-btn'));
-
-		await waitFor(() => expect(api.pollCount()).toBe(2));
-
-		await screen.findByText(/waiting for connection/i);
-		expect(
-			screen.queryByTestId('aws-check-connection-btn'),
-		).not.toBeInTheDocument();
-		expect(screen.getByTestId('aws-agent-command')).toHaveTextContent(cliCommand);
-	});
-});

frontend/src/container/Integrations/CloudIntegration/AzureCloudServices/AddNewAccount/CloudAccountSetupModal.tsx

@@ -1,10 +1,23 @@
-import { useCallback, useState } from 'react';
-import { ChevronDown, ChevronRight, LoaderCircle } from '@signozhq/icons';
+import { useCallback, useRef, useState } from 'react';
+import { Color } from '@signozhq/design-tokens';
+import {
+	ChevronDown,
+	ChevronRight,
+	LoaderCircle,
+	SquareArrowOutUpRight,
+} from '@signozhq/icons';
 import { Button } from '@signozhq/ui/button';
 import { Callout } from '@signozhq/ui/callout';
 import { DrawerWrapper } from '@signozhq/ui/drawer';
+import { Tabs } from '@signozhq/ui/tabs';
 import { Form, Select, Spin } from 'antd';
-import { AZURE_REGIONS } from 'container/Integrations/constants';
+import { useGetAccount } from 'api/generated/services/cloudintegration';
+import { CloudintegrationtypesAccountDTO } from 'api/generated/services/sigNoz.schemas';
+import CodeBlock from 'components/CodeBlock/CodeBlock';
+import {
+	AZURE_REGIONS,
+	INTEGRATION_TYPES,
+} from 'container/Integrations/constants';
 import {
 	IntegrationModalProps,
 	ModalStateEnum,
@@ -12,13 +25,15 @@ import {
 import { popupContainer } from 'utils/selectPopupContainer';
 
 import { useIntegrationModal } from '../../../../../hooks/integration/azure/useIntegrationModal';
-import AgentSetupCommand from '../../AgentSetupCommand/AgentSetupCommand';
-import CloseSetupConfirm from '../../CloseSetupConfirm/CloseSetupConfirm';
-import { useCloseSetupConfirm } from '../../CloseSetupConfirm/useCloseSetupConfirm';
 import RenderConnectionFields from '../../AmazonWebServices/RegionForm/RenderConnectionParams';
 
 import '../../AmazonWebServices/AddNewAccount/CloudAccountSetupModal.style.scss';
 
+const AZURE_CLI_DESC =
+	'Paste the following command if you have Azure CLI setup locally on your machine or use BASH CloudShell on Azure portal with above mentioned permissions.';
+const AZURE_POWERSHELL_DESC =
+	'Paste the following command in PowerShell CloudShell on Azure portal, you can switch to PowerShell on Azure portal.';
+
 function CloudAccountSetupModal({
 	onClose,
 }: IntegrationModalProps): JSX.Element {
@@ -26,19 +41,53 @@ function CloudAccountSetupModal({
 		form,
 		modalState,
 		isLoading,
-		connectionCommand,
+		accountId,
+		connectionCommands,
 		handleSubmit,
 		handleClose,
 		connectionParams,
 		isConnectionParamsLoading,
-		checkConnectionAgain,
+		handleConnectionSuccess,
+		handleConnectionTimeout,
+		handleConnectionError,
 	} = useIntegrationModal({ onClose });
 
-	const { isConfirmOpen, setIsConfirmOpen, requestClose } = useCloseSetupConfirm(
-		{ shouldConfirm: Boolean(connectionCommand), onClose: handleClose },
-	);
+	const startTimeRef = useRef(Date.now());
+	const refetchInterval = 10 * 1000;
+	const errorTimeout = 10 * 60 * 1000;
 
 	const [isHowItWorksOpen, setIsHowItWorksOpen] = useState(true);
+	const [activeTab, setActiveTab] = useState('cli');
+
+	useGetAccount(
+		{
+			cloudProvider: INTEGRATION_TYPES.AZURE,
+			id: accountId ?? '',
+		},
+		{
+			query: {
+				enabled: Boolean(accountId) && modalState === ModalStateEnum.WAITING,
+				refetchInterval,
+				select: (response): CloudintegrationtypesAccountDTO => response.data,
+				onSuccess: (account) => {
+					const isConnected =
+						Boolean(account.providerAccountId) && account.removedAt === null;
+
+					if (isConnected) {
+						handleConnectionSuccess({
+							cloudAccountId: account.providerAccountId ?? account.id,
+							status: account.agentReport,
+						});
+					} else if (Date.now() - startTimeRef.current >= errorTimeout) {
+						handleConnectionTimeout({ id: accountId });
+					}
+				},
+				onError: () => {
+					handleConnectionError();
+				},
+			},
+		},
+	);
 
 	const renderAlert = useCallback((): JSX.Element | null => {
 		if (modalState === ModalStateEnum.WAITING) {
@@ -47,7 +96,14 @@ function CloudAccountSetupModal({
 					<Callout
 						title={
 							<div className="cloud-account-setup-form__alert-message">
-								<Spin indicator={<LoaderCircle size={14} className="animate-spin" />} />
+								<Spin
+									indicator={
+										<LoaderCircle
+											size={14}
+											className="anticon anticon-loading anticon-spin ant-spin-dot"
+										/>
+									}
+								/>
 								Waiting for Azure account connection, retrying in{' '}
 								<span className="retry-time">10</span> secs...
 							</div>
@@ -80,233 +136,234 @@ function CloudAccountSetupModal({
 
 	const footer = (
 		<div className="cloud-account-setup-modal__footer">
-			<Button
-				size="md"
-				variant="outlined"
-				color="secondary"
-				onClick={requestClose}
-				testId="azure-cancel-btn"
-			>
-				Cancel
-			</Button>
-			{!connectionCommand && (
+			{modalState === ModalStateEnum.FORM && (
 				<Button
 					size="md"
 					variant="solid"
 					color="primary"
+					prefix={<SquareArrowOutUpRight size={17} color={Color.BG_VANILLA_100} />}
 					onClick={handleSubmit}
 					loading={isLoading}
-					testId="azure-generate-command-btn"
 				>
-					Generate Command
-				</Button>
-			)}
-			{modalState === ModalStateEnum.ERROR && connectionCommand && (
-				<Button
-					size="md"
-					variant="solid"
-					color="primary"
-					onClick={checkConnectionAgain}
-					testId="azure-check-connection-btn"
-				>
-					Check Again
+					Generate Azure Setup Commands
 				</Button>
 			)}
 		</div>
 	);
 
 	return (
-		<>
-			<DrawerWrapper
-				open={true}
-				className="cloud-account-setup-modal"
-				onOpenChange={(open): void => {
-					if (!open) {
-						requestClose();
-					}
-				}}
-				direction="right"
-				showCloseButton
-				title="Add Azure Account"
-				width="wide"
-				footer={footer}
-			>
-				<div className="cloud-account-setup-modal__content">
-					<div className="cloud-account-setup-prerequisites">
-						<div className="cloud-account-setup-prerequisites__title">
-							Prerequisites
-						</div>
-
-						<ul className="cloud-account-setup-prerequisites__list">
-							<li className="cloud-account-setup-prerequisites__list-item">
-								<span className="cloud-account-setup-prerequisites__list-item-bullet">
-									—
-								</span>{' '}
-								<span className="cloud-account-setup-prerequisites__list-item-text">
-									Ensure that you&apos;re logged in to the Azure workspace which you want
-									to monitor.
-								</span>
-							</li>
-							<li className="cloud-account-setup-prerequisites__list-item">
-								<span className="cloud-account-setup-prerequisites__list-item-bullet">
-									—
-								</span>{' '}
-								<span className="cloud-account-setup-prerequisites__list-item-text">
-									Ensure that you either have the{' '}
-									<span className="cloud-account-setup-prerequisites__list-item-highlight">
-										Owner
-									</span>{' '}
-									role OR
-								</span>
-							</li>
-							<li className="cloud-account-setup-prerequisites__list-item">
-								<span className="cloud-account-setup-prerequisites__list-item-bullet">
-									—
-								</span>{' '}
-								<span className="cloud-account-setup-prerequisites__list-item-text">
-									Both the{' '}
-									<span className="cloud-account-setup-prerequisites__list-item-highlight">
-										Contributor
-									</span>{' '}
-									and{' '}
-									<span className="cloud-account-setup-prerequisites__list-item-highlight">
-										user access admin
-									</span>{' '}
-									roles
-								</span>
-							</li>
-						</ul>
+		<DrawerWrapper
+			open={true}
+			className="cloud-account-setup-modal"
+			onOpenChange={(open): void => {
+				if (!open) {
+					handleClose();
+				}
+			}}
+			direction="right"
+			showCloseButton
+			title="Add Azure Account"
+			width="wide"
+			footer={footer}
+		>
+			<div className="cloud-account-setup-modal__content">
+				<div className="cloud-account-setup-prerequisites">
+					<div className="cloud-account-setup-prerequisites__title">
+						Prerequisites
 					</div>
 
-					<div className="cloud-account-setup-how-it-works-accordion">
-						<div
-							className={`cloud-account-setup-how-it-works-accordion__title ${
-								isHowItWorksOpen ? 'open' : ''
-							}`}
-						>
-							<Button
-								size="md"
-								variant="link"
-								color="secondary"
-								icon
-								aria-label="How it works"
-								onClick={(): void => setIsHowItWorksOpen(!isHowItWorksOpen)}
-							>
-								{isHowItWorksOpen ? <ChevronDown /> : <ChevronRight />}
-							</Button>
-
-							<span className="cloud-account-setup-how-it-works-accordion__title-text">
-								How it works?
+					<ul className="cloud-account-setup-prerequisites__list">
+						<li className="cloud-account-setup-prerequisites__list-item">
+							<span className="cloud-account-setup-prerequisites__list-item-bullet">
+								—
+							</span>{' '}
+							<span className="cloud-account-setup-prerequisites__list-item-text">
+								Ensure that you&apos;re logged in to the Azure workspace which you want
+								to monitor.
 							</span>
+						</li>
+						<li className="cloud-account-setup-prerequisites__list-item">
+							<span className="cloud-account-setup-prerequisites__list-item-bullet">
+								—
+							</span>{' '}
+							<span className="cloud-account-setup-prerequisites__list-item-text">
+								Ensure that you either have the{' '}
+								<span className="cloud-account-setup-prerequisites__list-item-highlight">
+									Owner
+								</span>{' '}
+								role OR
+							</span>
+						</li>
+						<li className="cloud-account-setup-prerequisites__list-item">
+							<span className="cloud-account-setup-prerequisites__list-item-bullet">
+								—
+							</span>{' '}
+							<span className="cloud-account-setup-prerequisites__list-item-text">
+								Both the{' '}
+								<span className="cloud-account-setup-prerequisites__list-item-highlight">
+									Contributor
+								</span>{' '}
+								and{' '}
+								<span className="cloud-account-setup-prerequisites__list-item-highlight">
+									user access admin
+								</span>{' '}
+								roles
+							</span>
+						</li>
+					</ul>
+				</div>
+
+				<div className="cloud-account-setup-how-it-works-accordion">
+					<div
+						className={`cloud-account-setup-how-it-works-accordion__title ${
+							isHowItWorksOpen ? 'open' : ''
+						}`}
+					>
+						<Button
+							size="md"
+							variant="link"
+							color="secondary"
+							icon
+							aria-label="How it works"
+							onClick={(): void => setIsHowItWorksOpen(!isHowItWorksOpen)}
+						>
+							{isHowItWorksOpen ? <ChevronDown /> : <ChevronRight />}
+						</Button>
+
+						<span className="cloud-account-setup-how-it-works-accordion__title-text">
+							How it works?
+						</span>
+					</div>
+					{isHowItWorksOpen && (
+						<div className="cloud-account-setup-how-it-works-accordion__description">
+							<div className="cloud-account-setup-how-it-works-accordion__description-item">
+								SigNoz will create new resource-group to manage the resources required
+								for this integration. The following steps will create a User-Assigned
+								Managed Identity with the necessary permissions and follows the
+								Principle of Least Privilege.
+							</div>
+							<div className="cloud-account-setup-how-it-works__description-item">
+								Once the Integration template is deployed, you can enable the services
+								you want to monitor right here in Signoz dashboard.
+							</div>
 						</div>
-						{isHowItWorksOpen && (
-							<div className="cloud-account-setup-how-it-works-accordion__description">
-								<div className="cloud-account-setup-how-it-works-accordion__description-item">
-									SigNoz will create new resource-group to manage the resources required
-									for this integration. The following steps will create a User-Assigned
-									Managed Identity with the necessary permissions and follows the
-									Principle of Least Privilege.
-								</div>
-								<div className="cloud-account-setup-how-it-works__description-item">
-									Once the Integration template is deployed, you can enable the services
-									you want to monitor right here in Signoz dashboard.
+					)}
+				</div>
+
+				<Form
+					form={form}
+					className="cloud-account-setup-form"
+					layout="vertical"
+					initialValues={{ resourceGroups: [] }}
+				>
+					<div className="cloud-account-setup-form__content">
+						<div className="cloud-account-setup-form__form-group">
+							<div className="cloud-account-setup-form__title">
+								Where should we deploy the SigNoz collector resources?
+							</div>
+							<div className="cloud-account-setup-form__description">
+								Choose the Azure region for deployment.
+							</div>
+							<Form.Item
+								name="region"
+								rules={[{ required: true, message: 'Please select a region' }]}
+								className="cloud-account-setup-form__form-item"
+							>
+								<Select
+									placeholder="e.g. East US"
+									options={AZURE_REGIONS.map((region) => ({
+										label: `${region.label} (${region.value})`,
+										value: region.value,
+									}))}
+									getPopupContainer={popupContainer}
+									disabled={modalState === ModalStateEnum.WAITING}
+								/>
+							</Form.Item>
+						</div>
+
+						<div className="cloud-account-setup-form__form-group">
+							<div className="cloud-account-setup-form__title">
+								Which resource groups do you want to monitor?
+							</div>
+							<div className="cloud-account-setup-form__description">
+								Add one or more Azure resource group names.
+							</div>
+							<Form.Item
+								name="resourceGroups"
+								rules={[
+									{
+										required: true,
+										type: 'array',
+										min: 1,
+										message: 'Please add at least one resource group',
+									},
+								]}
+								className="cloud-account-setup-form__form-item"
+							>
+								<Select
+									mode="tags"
+									placeholder="e.g. prod-platform-rg"
+									tokenSeparators={[',']}
+									disabled={modalState === ModalStateEnum.WAITING}
+								/>
+							</Form.Item>
+						</div>
+
+						<RenderConnectionFields
+							isConnectionParamsLoading={isConnectionParamsLoading}
+							connectionParams={connectionParams}
+							isFormDisabled={modalState === ModalStateEnum.WAITING}
+						/>
+
+						{connectionCommands && (
+							<div className="cloud-account-setup-form__code-block-tabs-container">
+								<div className="cloud-account-setup-form__code-block-tabs-header">
+									<div className="cloud-account-setup-form__code-block-tabs-header-title">
+										Deploy Agent
+									</div>
+									<div className="cloud-account-setup-form__code-block-tabs-header-description">
+										{activeTab === 'cli' ? AZURE_CLI_DESC : AZURE_POWERSHELL_DESC}
+									</div>
 								</div>
+								<Tabs
+									orientation="horizontal"
+									alignment="start"
+									className="cloud-account-setup-form__code-block-tabs"
+									items={[
+										{
+											key: 'cli',
+											label: 'CLI',
+											children: <CodeBlock code={connectionCommands?.cliCommand || ''} />,
+										},
+										{
+											key: 'powershell',
+											label: 'PowerShell',
+											children: (
+												<CodeBlock
+													code={connectionCommands?.cloudPowerShellCommand || ''}
+												/>
+											),
+										},
+									]}
+									value={activeTab}
+									onChange={(key): void => setActiveTab(key)}
+									variant="primary"
+								/>
+							</div>
+						)}
+
+						{renderAlert()}
+
+						{modalState === ModalStateEnum.WAITING && (
+							<div className="cloud-account-setup-status-message">
+								After running the command, return here and wait for automatic connection
+								detection.
 							</div>
 						)}
 					</div>
-
-					<Form
-						form={form}
-						className="cloud-account-setup-form"
-						layout="vertical"
-						initialValues={{ resourceGroups: [] }}
-					>
-						<div className="cloud-account-setup-form__content">
-							{connectionCommand ? (
-								<AgentSetupCommand
-									description="Run this command in Azure Cloud Shell (Bash), or in a terminal where the Azure CLI is signed in to the subscription you want to monitor. It contains your SigNoz keys, so do not share it."
-									command={connectionCommand}
-									testId="azure-agent-command"
-								/>
-							) : (
-								<>
-									<div className="cloud-account-setup-form__form-group">
-										<div className="cloud-account-setup-form__title">
-											Where should we deploy the SigNoz collector resources?
-										</div>
-										<div className="cloud-account-setup-form__description">
-											Choose the Azure region for deployment.
-										</div>
-										<Form.Item
-											name="region"
-											rules={[{ required: true, message: 'Please select a region' }]}
-											className="cloud-account-setup-form__form-item"
-										>
-											<Select
-												placeholder="e.g. East US"
-												options={AZURE_REGIONS.map((region) => ({
-													label: `${region.label} (${region.value})`,
-													value: region.value,
-												}))}
-												getPopupContainer={popupContainer}
-											/>
-										</Form.Item>
-									</div>
-
-									<div className="cloud-account-setup-form__form-group">
-										<div className="cloud-account-setup-form__title">
-											Which resource groups do you want to monitor?
-										</div>
-										<div className="cloud-account-setup-form__description">
-											Add one or more Azure resource group names.
-										</div>
-										<Form.Item
-											name="resourceGroups"
-											rules={[
-												{
-													required: true,
-													type: 'array',
-													min: 1,
-													message: 'Please add at least one resource group',
-												},
-											]}
-											className="cloud-account-setup-form__form-item"
-										>
-											<Select
-												mode="tags"
-												placeholder="e.g. prod-platform-rg"
-												tokenSeparators={[',']}
-											/>
-										</Form.Item>
-									</div>
-
-									<RenderConnectionFields
-										isConnectionParamsLoading={isConnectionParamsLoading}
-										connectionParams={connectionParams}
-									/>
-								</>
-							)}
-
-							{renderAlert()}
-
-							{modalState === ModalStateEnum.WAITING && (
-								<div className="cloud-account-setup-status-message">
-									After running the command, return here and wait for automatic
-									connection detection.
-								</div>
-							)}
-						</div>
-					</Form>
-				</div>
-			</DrawerWrapper>
-			<CloseSetupConfirm
-				providerName="Azure"
-				testIdPrefix="azure"
-				open={isConfirmOpen}
-				onOpenChange={setIsConfirmOpen}
-				onConfirm={handleClose}
-			/>
-		</>
+				</Form>
+			</div>
+		</DrawerWrapper>
 	);
 }
 

frontend/src/container/Integrations/CloudIntegration/AzureCloudServices/__tests__/CloudAccountSetupModal.test.tsx

@@ -1,175 +0,0 @@
-import { ComponentProps } from 'react';
-import { render, screen, userEvent, waitFor } from 'tests/test-utils';
-import { rest, server } from 'mocks-server/server';
-import { RestRequest } from 'msw';
-import type logEvent from '../../../../../api/common/logEvent';
-
-import CloudAccountSetupModal from '../AddNewAccount/CloudAccountSetupModal';
-
-// `useIntegrationModal` imports logEvent by relative path, which the
-// jest.config moduleNameMapper (keyed on the `api/common/logEvent` alias) does
-// not intercept, so mock the resolved module directly.
-jest.mock('../../../../../api/common/logEvent', () => ({
-	__esModule: true,
-	default: jest.fn() as jest.MockedFunction<typeof logEvent>,
-}));
-
-// The form flow drives antd selects and typing, which outruns the 5s default on CI.
-jest.setTimeout(15_000);
-
-type OnClose = ComponentProps<typeof CloudAccountSetupModal>['onClose'];
-
-const mockOnClose = (): jest.MockedFunction<OnClose> =>
-	jest.fn() as jest.MockedFunction<OnClose>;
-
-const AZURE_CREDENTIALS_URL =
-	'http://localhost/api/v1/cloud_integrations/azure/credentials';
-const AZURE_ACCOUNTS_URL =
-	'http://localhost/api/v1/cloud_integrations/azure/accounts';
-const ACCOUNT_ID = 'ci-azure-1234';
-
-const credentials = {
-	sigNozApiUrl: 'https://signoz.example.com',
-	sigNozApiKey: 'signoz-api-key',
-	ingestionUrl: 'https://ingest.example.com',
-	ingestionKey: 'ingestion-key',
-};
-
-const cliCommand = `curl -fsSL 'https://signoz.io/foundry.sh' | bash -s -- cloudintegration azure bicep --region 'australiaeast'`;
-
-const mockApi = ({ failFirstPoll = false } = {}): {
-	createAccountPayload: unknown;
-	pollCount: () => number;
-} => {
-	let polls = 0;
-	const api = {
-		createAccountPayload: null as unknown,
-		pollCount: (): number => polls,
-	};
-
-	server.use(
-		rest.get(AZURE_CREDENTIALS_URL, (_req, res, ctx) =>
-			res(ctx.status(200), ctx.json({ status: 'success', data: credentials })),
-		),
-		rest.post(AZURE_ACCOUNTS_URL, async (req: RestRequest, res, ctx) => {
-			api.createAccountPayload = await req.json();
-			return res(
-				ctx.status(201),
-				ctx.json({
-					status: 'success',
-					data: { id: ACCOUNT_ID, connectionArtifact: { azure: { cliCommand } } },
-				}),
-			);
-		}),
-		rest.get(`${AZURE_ACCOUNTS_URL}/${ACCOUNT_ID}`, (_req, res, ctx) => {
-			polls += 1;
-			if (failFirstPoll && polls === 1) {
-				return res(ctx.status(500), ctx.json({ status: 'error' }));
-			}
-			return res(
-				ctx.status(200),
-				ctx.json({
-					status: 'success',
-					data: {
-						id: ACCOUNT_ID,
-						providerAccountId: null,
-						agentReport: null,
-						removedAt: null,
-					},
-				}),
-			);
-		}),
-	);
-
-	return api;
-};
-
-describe('Azure CloudAccountSetupModal', () => {
-	it('creates the account and shows its setup command', async () => {
-		const api = mockApi();
-		const user = userEvent.setup();
-		const onClose = mockOnClose();
-
-		render(<CloudAccountSetupModal onClose={onClose} />);
-
-		const [region, resourceGroups] = await screen.findAllByRole('combobox');
-		await user.click(region);
-		await user.click(await screen.findByText('Australia East (australiaeast)'));
-		await user.type(resourceGroups, 'prod-platform-rg{Enter}');
-		await user.click(screen.getByTestId('azure-generate-command-btn'));
-
-		await waitFor(() => {
-			expect(screen.getByTestId('azure-agent-command')).toHaveTextContent(
-				cliCommand,
-			);
-		});
-
-		expect(api.createAccountPayload).toStrictEqual({
-			config: {
-				azure: {
-					deploymentRegion: 'australiaeast',
-					resourceGroups: ['prod-platform-rg'],
-				},
-			},
-			credentials,
-		});
-		expect(
-			screen.queryByTestId('azure-generate-command-btn'),
-		).not.toBeInTheDocument();
-		expect(screen.queryAllByRole('combobox')).toHaveLength(0);
-		expect(
-			screen.getByText(/waiting for azure account connection/i),
-		).toBeInTheDocument();
-
-		await user.click(screen.getByTestId('azure-cancel-btn'));
-		await user.click(await screen.findByTestId('azure-continue-setup-btn'));
-		await waitFor(() => {
-			expect(
-				screen.queryByTestId('azure-continue-setup-btn'),
-			).not.toBeInTheDocument();
-		});
-		expect(onClose).not.toHaveBeenCalled();
-
-		await user.click(screen.getByTestId('azure-cancel-btn'));
-		await user.click(await screen.findByTestId('azure-close-setup-btn'));
-		expect(onClose).toHaveBeenCalledTimes(1);
-	});
-
-	it('closes without asking before a setup command exists', async () => {
-		mockApi();
-		const user = userEvent.setup();
-		const onClose = mockOnClose();
-
-		render(<CloudAccountSetupModal onClose={onClose} />);
-
-		await user.click(await screen.findByTestId('azure-cancel-btn'));
-
-		expect(onClose).toHaveBeenCalledTimes(1);
-		expect(screen.queryByTestId('azure-close-setup-btn')).not.toBeInTheDocument();
-	});
-
-	it('resumes polling with Check Again after the connection check fails', async () => {
-		const api = mockApi({ failFirstPoll: true });
-		const user = userEvent.setup();
-
-		render(<CloudAccountSetupModal onClose={mockOnClose()} />);
-
-		const [region, resourceGroups] = await screen.findAllByRole('combobox');
-		await user.click(region);
-		await user.click(await screen.findByText('Australia East (australiaeast)'));
-		await user.type(resourceGroups, 'prod-platform-rg{Enter}');
-		await user.click(screen.getByTestId('azure-generate-command-btn'));
-
-		await user.click(await screen.findByTestId('azure-check-connection-btn'));
-
-		await waitFor(() => expect(api.pollCount()).toBe(2));
-
-		await screen.findByText(/waiting for azure account connection/i);
-		expect(
-			screen.queryByTestId('azure-check-connection-btn'),
-		).not.toBeInTheDocument();
-		expect(screen.getByTestId('azure-agent-command')).toHaveTextContent(
-			cliCommand,
-		);
-	});
-});

frontend/src/container/Integrations/CloudIntegration/CloseSetupConfirm/CloseSetupConfirm.tsx

@@ -1,59 +0,0 @@
-import { Button } from '@signozhq/ui/button';
-import { DialogWrapper } from '@signozhq/ui/dialog';
-import { Typography } from '@signozhq/ui/typography';
-
-interface CloseSetupConfirmProps {
-	/** Provider name as shown in the title, e.g. `AWS`. */
-	providerName: string;
-	/** Prefix for the dialog's test ids, e.g. `aws`. */
-	testIdPrefix: string;
-	open: boolean;
-	onOpenChange: (open: boolean) => void;
-	onConfirm: () => void;
-}
-
-function CloseSetupConfirm({
-	providerName,
-	testIdPrefix,
-	open,
-	onOpenChange,
-	onConfirm,
-}: CloseSetupConfirmProps): JSX.Element {
-	return (
-		<DialogWrapper
-			open={open}
-			onOpenChange={onOpenChange}
-			title={`Close ${providerName} agent setup?`}
-			testId={`${testIdPrefix}-close-setup-confirm`}
-			footer={
-				<>
-					<Button
-						size="md"
-						variant="solid"
-						color="highlight-danger"
-						onClick={onConfirm}
-						testId={`${testIdPrefix}-close-setup-btn`}
-					>
-						Close Setup
-					</Button>
-					<Button
-						size="md"
-						variant="solid"
-						color="primary"
-						onClick={(): void => onOpenChange(false)}
-						testId={`${testIdPrefix}-continue-setup-btn`}
-					>
-						Continue Setup
-					</Button>
-				</>
-			}
-		>
-			<Typography>
-				The agent has not connected yet. If you close now, you will have to start
-				the installation process again with a new setup command.
-			</Typography>
-		</DialogWrapper>
-	);
-}
-
-export default CloseSetupConfirm;

frontend/src/container/Integrations/CloudIntegration/CloseSetupConfirm/useCloseSetupConfirm.ts

@@ -1,30 +0,0 @@
-import { useCallback, useState } from 'react';
-
-interface UseCloseSetupConfirmProps {
-	/** True once closing would lose a pending setup, i.e. a setup command exists. */
-	shouldConfirm: boolean;
-	onClose: () => void;
-}
-
-interface UseCloseSetupConfirm {
-	isConfirmOpen: boolean;
-	setIsConfirmOpen: (open: boolean) => void;
-	requestClose: () => void;
-}
-
-export function useCloseSetupConfirm({
-	shouldConfirm,
-	onClose,
-}: UseCloseSetupConfirmProps): UseCloseSetupConfirm {
-	const [isConfirmOpen, setIsConfirmOpen] = useState(false);
-
-	const requestClose = useCallback((): void => {
-		if (shouldConfirm) {
-			setIsConfirmOpen(true);
-			return;
-		}
-		onClose();
-	}, [shouldConfirm, onClose]);
-
-	return { isConfirmOpen, setIsConfirmOpen, requestClose };
-}

frontend/src/container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/AgentSetup/AgentSetup.module.scss

@@ -3,7 +3,3 @@
 	align-items: center;
 	gap: var(--spacing-4);
 }
-
-.mono {
-	composes: mono from '../shared.module.scss';
-}

frontend/src/container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/AgentSetup/AgentSetup.tsx

@@ -6,7 +6,6 @@ import { ModalStateEnum } from 'container/Integrations/HeroSection/types';
 import { useAgentAccountSetup } from 'hooks/integration/gcp/useAgentAccountSetup';
 import { useForm } from 'react-hook-form';
 
-import AgentSetupCommand from 'container/Integrations/CloudIntegration/AgentSetupCommand/AgentSetupCommand';
 import ConnectionMethodSelector from '../ConnectionMethodSelector';
 import ConnectionSecretsFields from '../ConnectionSecretsFields';
 import { AGENT_SETUP_GUIDE, DEFAULT_SETUP_FORM_VALUES } from '../constants';
@@ -16,6 +15,7 @@ import SetupDrawerFooter from '../SetupDrawerFooter';
 import SetupGuideCallout from '../SetupGuideCallout';
 import { GcpSetupFormValues } from '../types';
 import { usePrefillCredentials } from '../usePrefillCredentials';
+import AgentSetupCommand from './AgentSetupCommand';
 
 import styles from './AgentSetup.module.scss';
 
@@ -67,15 +67,8 @@ function AgentSetup({
 			{connectionCommand ? (
 				<>
 					<AgentSetupCommand
-						description={
-							<>
-								Run this command in Google Cloud Shell, or in a terminal where gcloud is
-								signed in to <span className={styles.mono}>{commandProjectId}</span>. It
-								contains your SigNoz keys, so do not share it.
-							</>
-						}
+						deploymentProjectId={commandProjectId}
 						command={connectionCommand}
-						testId="gcp-agent-command"
 					/>
 					{modalState === ModalStateEnum.WAITING && (
 						<Callout

frontend/src/container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/AgentSetup/AgentSetupCommand.module.scss

@@ -10,6 +10,10 @@
 	gap: var(--spacing-3);
 }
 
+.mono {
+	composes: mono from '../shared.module.scss';
+}
+
 // CodeBlock renders the copy button's wrapper first and the highlighted code last;
 // the code theme sets the block's margin and padding inline, hence !important.
 .command {

frontend/src/container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/AgentSetup/AgentSetupCommand.tsx

@@ -1,28 +1,27 @@
-import { ReactNode } from 'react';
 import { Typography } from '@signozhq/ui/typography';
 import CodeBlock from 'components/CodeBlock/CodeBlock';
 
 import styles from './AgentSetupCommand.module.scss';
 
 interface AgentSetupCommandProps {
-	description: ReactNode;
+	deploymentProjectId: string;
 	command: string;
-	testId: string;
 }
 
 function AgentSetupCommand({
-	description,
+	deploymentProjectId,
 	command,
-	testId,
 }: AgentSetupCommandProps): JSX.Element {
 	return (
-		<div className={styles.commands} data-testid={testId}>
+		<div className={styles.commands} data-testid="gcp-agent-command">
 			<div className={styles.commandsHead}>
 				<Typography.Text weight="bold" size="base">
 					Deploy the SigNoz agent
 				</Typography.Text>
 				<Typography.Text as="p" size="small" color="muted">
-					{description}
+					Run this command in Google Cloud Shell, or in a terminal where gcloud is
+					signed in to <span className={styles.mono}>{deploymentProjectId}</span>. It
+					contains your SigNoz keys, so do not share it.
 				</Typography.Text>
 			</div>
 			<CodeBlock language="bash" code={command} className={styles.command} />

frontend/src/container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/CloudAccountSetupDrawer.tsx

@@ -1,9 +1,10 @@
 import { useState } from 'react';
+import { Button } from '@signozhq/ui/button';
+import { DialogWrapper } from '@signozhq/ui/dialog';
+import { Typography } from '@signozhq/ui/typography';
 import { CloudintegrationtypesGCPConnectionMethodDTO } from 'api/generated/services/sigNoz.schemas';
 import { IntegrationModalProps } from 'container/Integrations/HeroSection/types';
 
-import CloseSetupConfirm from '../../CloseSetupConfirm/CloseSetupConfirm';
-import { useCloseSetupConfirm } from '../../CloseSetupConfirm/useCloseSetupConfirm';
 import AgentSetup from './AgentSetup/AgentSetup';
 import ManualSetup from './ManualSetup/ManualSetup';
 import SetupDrawerLayout from './SetupDrawerLayout';
@@ -17,9 +18,15 @@ function CloudAccountSetupDrawer({
 		);
 	// Set once the agent command exists; closing after that loses the pending setup.
 	const [hasGeneratedCommand, setHasGeneratedCommand] = useState(false);
-	const { isConfirmOpen, setIsConfirmOpen, requestClose } = useCloseSetupConfirm(
-		{ shouldConfirm: hasGeneratedCommand, onClose },
-	);
+	const [isCloseConfirmOpen, setIsCloseConfirmOpen] = useState(false);
+
+	const requestClose = (): void => {
+		if (hasGeneratedCommand) {
+			setIsCloseConfirmOpen(true);
+			return;
+		}
+		onClose();
+	};
 
 	return (
 		<>
@@ -42,13 +49,39 @@ function CloudAccountSetupDrawer({
 					)
 				}
 			</SetupDrawerLayout>
-			<CloseSetupConfirm
-				providerName="GCP"
-				testIdPrefix="gcp"
-				open={isConfirmOpen}
-				onOpenChange={setIsConfirmOpen}
-				onConfirm={onClose}
-			/>
+			<DialogWrapper
+				open={isCloseConfirmOpen}
+				onOpenChange={setIsCloseConfirmOpen}
+				title="Close GCP agent setup?"
+				testId="gcp-close-setup-confirm"
+				footer={
+					<>
+						<Button
+							size="md"
+							variant="solid"
+							color="highlight-danger"
+							onClick={onClose}
+							testId="gcp-close-setup-btn"
+						>
+							Close Setup
+						</Button>
+						<Button
+							size="md"
+							variant="solid"
+							color="primary"
+							onClick={(): void => setIsCloseConfirmOpen(false)}
+							testId="gcp-continue-setup-btn"
+						>
+							Continue Setup
+						</Button>
+					</>
+				}
+			>
+				<Typography>
+					The agent has not connected yet. If you close now, you will have to start
+					the installation process again with a new setup command.
+				</Typography>
+			</DialogWrapper>
 		</>
 	);
 }

frontend/src/container/Integrations/HeroSection/types.ts

@@ -20,12 +20,18 @@ export interface RegionFormProps {
 	includeAllRegions: boolean;
 	onRegionSelect: () => void;
 	onSubmit: () => Promise<void>;
-	connectionCommand: string | null;
+	accountId?: string;
 	handleRegionChange: (value: string) => void;
 	connectionParams?: CloudintegrationtypesCredentialsDTO;
 	isConnectionParamsLoading?: boolean;
 	setSelectedRegions: Dispatch<SetStateAction<string[]>>;
 	setIncludeAllRegions: Dispatch<SetStateAction<boolean>>;
+	onConnectionSuccess: (payload: {
+		cloudAccountId: string;
+		status?: unknown;
+	}) => void;
+	onConnectionTimeout: (payload: { id?: string }) => void;
+	onConnectionError: () => void;
 }
 
 export interface IntegrationModalProps {

frontend/src/container/PlannedDowntime/PlannedDowntime.module.scss

@@ -121,6 +121,13 @@
 	font-size: 13px;
 }
 
+.badges {
+	display: flex;
+	gap: var(--spacing-2);
+	overflow: hidden;
+	white-space: nowrap;
+}
+
 .timeText {
 	display: inline-block;
 	white-space: nowrap;

frontend/src/container/PlannedDowntime/PlannedDowntime.tsx

@@ -5,7 +5,6 @@ import React, {
 	useMemo,
 	useState,
 } from 'react';
-import { useAppLocation } from 'lib/router/useAppLocation';
 import { navigate } from 'lib/router/navigation';
 import { Plus, Search } from '@signozhq/icons';
 import { Button } from '@signozhq/ui/button';
@@ -54,7 +53,6 @@ export function PlannedDowntime(): JSX.Element {
 		data: alertsData,
 		isError,
 		isLoading,
-		isFetching: isFetchingAlerts,
 	} = useListRules({
 		query: { cacheTime: 0 },
 	});
@@ -62,7 +60,6 @@ export function PlannedDowntime(): JSX.Element {
 	const [form] = Form.useForm();
 	const { user } = useAppContext();
 	const { showErrorModal } = useErrorModal();
-	const location = useAppLocation();
 	const urlQuery = useUrlQuery();
 
 	const [initialValues, setInitialValues] =
@@ -86,31 +83,20 @@ export function PlannedDowntime(): JSX.Element {
 		}
 	}, [form, isOpen]);
 
-	const [searchValue, setSearchValue] = React.useState<string>(() => {
-		const searchFromUrlQuery = urlQuery.get('search');
-		if (searchFromUrlQuery) {
-			return searchFromUrlQuery;
-		}
-		const search =
-			(typeof window !== 'undefined' && window.location.search) ||
-			location.search ||
-			'';
-		return new URLSearchParams(search).get('search') || '';
-	});
+	const [searchValue, setSearchValue] = React.useState<string>(
+		urlQuery.get('search') || '',
+	);
 	const [deleteData, setDeleteData] = useState<{ id: string; name: string }>();
 	const [isEditMode, setEditMode] = useState<boolean>(false);
 
 	const updateUrlWithSearch = useDebouncedFn((value) => {
-		const nextSearch = value as string;
-		const search =
-			(typeof window !== 'undefined' && window.location.search) || location.search;
-		const params = new URLSearchParams(search);
-		if (nextSearch) {
-			params.set('search', nextSearch);
+		const searchValue = value as string;
+		if (searchValue) {
+			urlQuery.set('search', searchValue);
 		} else {
-			params.delete('search');
+			urlQuery.delete('search');
 		}
-		const url = `/alerts?${params.toString()}`;
+		const url = `/alerts?${urlQuery.toString()}`;
 		navigate(url, { replace: true });
 	}, 300);
 
@@ -141,11 +127,9 @@ export function PlannedDowntime(): JSX.Element {
 
 	const canEdit = user?.role !== USER_ROLES.VIEWER;
 	const { formatTimezoneAdjustedTimestamp } = useTimezone();
-	const isAlertsLoading = isLoading || (!alertsData && isFetchingAlerts);
 	const columns = React.useMemo(
-		() =>
-			getPlannedDowntimeColumns(formatTimezoneAdjustedTimestamp, isAlertsLoading),
-		[formatTimezoneAdjustedTimestamp, isAlertsLoading],
+		() => getPlannedDowntimeColumns(formatTimezoneAdjustedTimestamp),
+		[formatTimezoneAdjustedTimestamp],
 	);
 
 	const handleCreate = useCallback((): void => {
@@ -220,7 +204,7 @@ export function PlannedDowntime(): JSX.Element {
 				<div className={styles.commandHeader}>
 					<div className={styles.headingBlock}>
 						<Typography.Title className={styles.title}>
-							All planned downtimes
+							Planned Downtime
 						</Typography.Title>
 						<span className={styles.countPill}>{totalDowntimes}</span>
 					</div>
@@ -242,7 +226,7 @@ export function PlannedDowntime(): JSX.Element {
 						disabledTooltip="You need edit permissions to create a planned downtime"
 						testId="planned-downtime-create"
 					>
-						New Downtime
+						New downtime
 					</Button>
 					<TextToolTip
 						text="More details on how to schedule planned downtime"

frontend/src/container/PlannedDowntime/__test__/PlannedDowntime.test.tsx

@@ -10,7 +10,8 @@ import {
 	AlertmanagertypesRepeatTypeDTO,
 } from 'api/generated/services/sigNoz.schemas';
 import type { ErrorType } from 'api/generatedAPIInstance';
-import { mockAppLocation, mockNavigate } from 'tests/router-mocks';
+import { mockLocation } from 'container/RoutingPolicies/__tests__/testUtils';
+import { mockAppLocation } from 'tests/router-mocks';
 import { render, userEvent } from 'tests/test-utils';
 import { USER_ROLES } from 'types/roles';
 
@@ -101,6 +102,8 @@ const mockDowntimeQueryResult: Partial<DowntimeQueryResult> = {
 
 let mockUrlQuery: URLSearchParams;
 
+mockAppLocation({ pathname: '/alerts' });
+
 jest.mock('hooks/useUrlQuery', () => ({
 	__esModule: true,
 	default: (): URLSearchParams => mockUrlQuery,
@@ -124,44 +127,29 @@ jest.mock('api/generated/services/downtimeschedules', () => ({
 		isLoading: false,
 	}),
 }));
-
-let mockRulesState: {
-	data?: { data: Array<{ id: number | string; alert: string }> };
-	isError: boolean;
-	isLoading: boolean;
-	isFetching: boolean;
-} = {
-	data: { data: [] },
-	isError: false,
-	isLoading: false,
-	isFetching: false,
-};
-
 jest.mock('api/generated/services/rules', () => ({
-	useListRules: (): typeof mockRulesState => mockRulesState,
+	useListRules: (): {
+		data: { data: [] };
+		isError: false;
+		isLoading: false;
+	} => ({
+		data: { data: [] },
+		isError: false,
+		isLoading: false,
+	}),
 }));
 
 describe('PlannedDowntime Component', () => {
 	beforeEach(() => {
 		jest.clearAllMocks();
 		mockUrlQuery = new URLSearchParams();
-		mockAppLocation({
-			pathname: '/alerts',
-			search: '',
-		});
-		mockDowntimeQueryResult.data = MOCK_DOWNTIME_RESPONSE;
-		mockRulesState = {
-			data: { data: [] },
-			isError: false,
-			isLoading: false,
-			isFetching: false,
-		};
+		mockLocation('/alerts');
 	});
 
 	it('renders the header, search and create action', () => {
 		renderPage();
 
-		expect(screen.getByText('All planned downtimes')).toBeInTheDocument();
+		expect(screen.getByText('Planned Downtime')).toBeInTheDocument();
 		expect(screen.getByTestId(SEARCH_TEST_ID)).toBeInTheDocument();
 		expect(screen.getByTestId(CREATE_TEST_ID)).toHaveAttribute(
 			'aria-disabled',
@@ -205,14 +193,14 @@ describe('PlannedDowntime Component', () => {
 		expect(screen.getByText(MOCK_DOWNTIME_3_NAME)).toBeInTheDocument();
 	});
 
-	it('shows the key schedule details, timezone and duration, and hides secondary columns by default', async () => {
+	it('shows the key schedule details and hides secondary columns by default', async () => {
 		renderPage();
 
 		await screen.findByText(MOCK_DOWNTIME_1_NAME);
 		expect(screen.getByText(/\(Asia\/Kolkata\)$/)).toBeInTheDocument();
 		expect(screen.getByText('Weekly on Mon · 2h')).toBeInTheDocument();
-		expect(screen.getAllByText('Asia/Kolkata').length).toBeGreaterThan(0);
-		expect(screen.getAllByText('2h').length).toBeGreaterThan(0);
+		expect(screen.queryByText('Asia/Kolkata')).not.toBeInTheDocument();
+		expect(screen.queryByText('2h')).not.toBeInTheDocument();
 		expect(screen.queryByText('Database maintenance')).not.toBeInTheDocument();
 		expect(screen.queryByText('creator@signoz.io')).not.toBeInTheDocument();
 		expect(screen.queryByText('editor@signoz.io')).not.toBeInTheDocument();
@@ -231,9 +219,7 @@ describe('PlannedDowntime Component', () => {
 			'Downtime',
 			'Status',
 			'Schedule',
-			'Timezone',
 			'Repeats',
-			'Duration',
 			'Alerts Silenced',
 		]);
 	});
@@ -304,116 +290,4 @@ describe('PlannedDowntime Component', () => {
 		await screen.findByText(MOCK_DOWNTIME_1_NAME);
 		expect(screen.queryByTestId('downtime-actions-1')).not.toBeInTheDocument();
 	});
-
-	it('preserves existing query parameters such as sort and pagination when typing in search (Bug 54)', async () => {
-		jest.useFakeTimers();
-		mockAppLocation({
-			pathname: '/alerts',
-			search:
-				'?tab=Configuration&subTab=planned-downtime&orderBy=name&order=asc&page=2&limit=20',
-		});
-		const navigateSpy = mockNavigate();
-
-		renderPage();
-
-		fireEvent.change(screen.getByTestId(SEARCH_TEST_ID), {
-			target: { value: 'query' },
-		});
-
-		jest.advanceTimersByTime(350);
-
-		expect(navigateSpy).toHaveBeenCalled();
-		const callArg = navigateSpy.mock.calls[0][0];
-		expect(callArg).toContain('tab=Configuration');
-		expect(callArg).toContain('subTab=planned-downtime');
-		expect(callArg).toContain('orderBy=name');
-		expect(callArg).toContain('order=asc');
-		expect(callArg).toContain('page=2');
-		expect(callArg).toContain('limit=20');
-		expect(callArg).toContain('search=query');
-
-		jest.useRealTimers();
-	});
-
-	it('shows skeleton while alert rules are loading for scoped downtime (Bug 56)', async () => {
-		mockRulesState = {
-			data: undefined,
-			isError: false,
-			isLoading: true,
-			isFetching: true,
-		};
-		const scopedDowntime = createMockDowntime({
-			id: 'scoped-1',
-			name: 'Scoped Downtime Loading',
-			schedule: buildSchedule({ startTime: MOCK_DATE_1 }),
-			alertIds: ['rule-1'],
-		});
-		mockDowntimeQueryResult.data = {
-			data: [scopedDowntime],
-			status: 'success',
-		};
-
-		renderPage();
-
-		await screen.findByText('Scoped Downtime Loading');
-		expect(screen.getByTestId('alerts-silenced-skeleton')).toBeInTheDocument();
-		expect(screen.queryByText('All alert rules')).not.toBeInTheDocument();
-	});
-
-	it('shows "Unknown rule" when scoped rule IDs cannot be resolved (Bug 56)', async () => {
-		mockRulesState = {
-			data: { data: [] },
-			isError: false,
-			isLoading: false,
-			isFetching: false,
-		};
-		const scopedDowntime = createMockDowntime({
-			id: 'scoped-2',
-			name: 'Scoped Downtime Deleted Rule',
-			schedule: buildSchedule({ startTime: MOCK_DATE_1 }),
-			alertIds: ['deleted-rule-id'],
-		});
-		mockDowntimeQueryResult.data = {
-			data: [scopedDowntime],
-			status: 'success',
-		};
-
-		renderPage();
-
-		await screen.findByText('Scoped Downtime Deleted Rule');
-		expect(screen.getByText('Unknown rule')).toBeInTheDocument();
-		expect(screen.queryByText('All alert rules')).not.toBeInTheDocument();
-	});
-
-	it('shows resolved alert rule name when scoped rule ID exists', async () => {
-		mockRulesState = {
-			data: {
-				data: [
-					{
-						id: 'rule-42',
-						alert: 'Disk Space High',
-					} as any,
-				],
-			},
-			isError: false,
-			isLoading: false,
-			isFetching: false,
-		};
-		const scopedDowntime = createMockDowntime({
-			id: 'scoped-3',
-			name: 'Scoped Downtime Resolved',
-			schedule: buildSchedule({ startTime: MOCK_DATE_1 }),
-			alertIds: ['rule-42'],
-		});
-		mockDowntimeQueryResult.data = {
-			data: [scopedDowntime],
-			status: 'success',
-		};
-
-		renderPage();
-
-		await screen.findByText('Scoped Downtime Resolved');
-		expect(screen.getByText('Disk Space High')).toBeInTheDocument();
-		expect(screen.queryByText('All alert rules')).not.toBeInTheDocument();
-	});
 });

frontend/src/container/PlannedDowntime/table.config.tsx

@@ -1,8 +1,6 @@
 import { Badge } from '@signozhq/ui/badge';
-import { Skeleton } from '@signozhq/ui/skeleton';
 import { AlertmanagertypesMaintenanceStatusDTO } from 'api/generated/services/sigNoz.schemas';
 import type { TableColumnDef } from 'components/TanStackTableView';
-import OverflowBadges from 'components/OverflowBadges/OverflowBadges';
 import TanStackTable from 'components/TanStackTableView';
 import { DATE_TIME_FORMATS } from 'constants/dateTimeFormats';
 import { toRelativeTime } from 'pages/AlertList/NotificationChannels/utils/relativeTime';
@@ -33,11 +31,8 @@ const STATUS_BADGE: Record<
 	},
 };
 
-const COLUMN_WIDTH = { default: 'auto', min: '120px' };
-
 export function getPlannedDowntimeColumns(
 	formatTimezoneAdjustedTimestamp: (date: string, format: string) => string,
-	isAlertsLoading?: boolean,
 ): TableColumnDef<DowntimeSchedulesTableData>[] {
 	const textCell = (value: string | undefined): JSX.Element => (
 		<TanStackTable.Text title={value || undefined}>
@@ -71,7 +66,7 @@ export function getPlannedDowntimeColumns(
 			id: 'name',
 			header: 'Downtime',
 			accessorKey: 'name',
-			width: COLUMN_WIDTH,
+			width: { default: '100%', min: '200px' },
 			enableSort: true,
 			enableResize: true,
 			enableRemove: false,
@@ -89,7 +84,7 @@ export function getPlannedDowntimeColumns(
 			id: 'status',
 			header: 'Status',
 			accessorKey: 'status',
-			width: COLUMN_WIDTH,
+			width: { default: '110px', min: '100px' },
 			enableSort: true,
 			enableResize: true,
 			enableMove: false,
@@ -108,7 +103,7 @@ export function getPlannedDowntimeColumns(
 			id: 'window',
 			header: 'Schedule',
 			accessorFn: (row) => row.schedule?.startTime,
-			width: COLUMN_WIDTH,
+			width: { default: '340px', min: '220px' },
 			enableSort: true,
 			enableResize: true,
 			enableMove: false,
@@ -118,7 +113,8 @@ export function getPlannedDowntimeColumns(
 			id: 'timezone',
 			header: 'Timezone',
 			accessorFn: (row) => row.schedule?.timezone,
-			width: COLUMN_WIDTH,
+			width: { default: '130px', min: '110px' },
+			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
 			enableMove: false,
@@ -128,7 +124,7 @@ export function getPlannedDowntimeColumns(
 			id: 'repeats',
 			header: 'Repeats',
 			accessorFn: (row) => row.schedule?.recurrence?.repeatType,
-			width: COLUMN_WIDTH,
+			width: { default: '180px', min: '120px' },
 			enableSort: false,
 			enableResize: true,
 			enableMove: false,
@@ -138,7 +134,8 @@ export function getPlannedDowntimeColumns(
 			id: 'duration',
 			header: 'Duration',
 			accessorFn: (row) => row.schedule?.recurrence?.duration,
-			width: COLUMN_WIDTH,
+			width: { default: '110px', min: '90px' },
+			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
 			enableMove: false,
@@ -149,46 +146,42 @@ export function getPlannedDowntimeColumns(
 			id: 'alertsSilenced',
 			header: 'Alerts Silenced',
 			accessorKey: 'alertIds',
-			width: COLUMN_WIDTH,
+			width: { default: '200px', min: '140px' },
 			enableSort: false,
 			enableResize: true,
 			enableMove: false,
-			cell: ({ row }): JSX.Element => {
-				const hasScopedAlerts = Boolean(row.alertIds && row.alertIds.length > 0);
-				if (!hasScopedAlerts) {
-					return (
-						<Badge textTransform="none" variant="solid" color="secondary">
-							All alert rules
-						</Badge>
-					);
-				}
-
-				if (isAlertsLoading) {
-					return (
-						<Skeleton.Input
-							testId="alerts-silenced-skeleton"
-							active
-							size="small"
-							style={{ width: 100, height: 22 }}
-						/>
-					);
-				}
-
-				return (
-					<OverflowBadges
-						items={row.alertOptions.map((alert) => ({
-							key: String(alert.value),
-							label: alert.label,
-						}))}
-					/>
-				);
-			},
+			cell: ({ row }): JSX.Element =>
+				row.alertOptions.length ? (
+					<div
+						className={styles.badges}
+						title={row.alertOptions
+							.flatMap((alert) =>
+								typeof alert.label === 'string' ? [alert.label] : [],
+							)
+							.join(', ')}
+					>
+						{row.alertOptions.map((alert) => (
+							<Badge
+								key={alert.value}
+								textTransform="none"
+								variant="solid"
+								color="secondary"
+							>
+								{alert.label}
+							</Badge>
+						))}
+					</div>
+				) : (
+					<Badge textTransform="none" variant="solid" color="secondary">
+						All alert rules
+					</Badge>
+				),
 		},
 		{
 			id: 'description',
 			header: 'Description',
 			accessorKey: 'description',
-			width: COLUMN_WIDTH,
+			width: { default: '200px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
@@ -199,7 +192,7 @@ export function getPlannedDowntimeColumns(
 			id: 'createdBy',
 			header: 'Created By',
 			accessorKey: 'createdBy',
-			width: COLUMN_WIDTH,
+			width: { default: '180px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
@@ -210,7 +203,7 @@ export function getPlannedDowntimeColumns(
 			id: 'createdAt',
 			header: 'Created At',
 			accessorKey: 'createdAt',
-			width: COLUMN_WIDTH,
+			width: { default: '150px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: true,
 			enableResize: true,
@@ -221,7 +214,7 @@ export function getPlannedDowntimeColumns(
 			id: 'updatedBy',
 			header: 'Updated By',
 			accessorKey: 'updatedBy',
-			width: COLUMN_WIDTH,
+			width: { default: '180px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
@@ -232,7 +225,7 @@ export function getPlannedDowntimeColumns(
 			id: 'updatedAt',
 			header: 'Updated At',
 			accessorKey: 'updatedAt',
-			width: COLUMN_WIDTH,
+			width: { default: '150px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: true,
 			enableResize: true,

frontend/src/container/PlannedDowntime/usePlannedDowntimeTable.ts

@@ -5,6 +5,7 @@ import type { SortState } from 'components/TanStackTableView/types';
 import { useCalculatedPageSize } from 'components/TanStackTableView/useCalculatedPageSize';
 import { useTableParams } from 'components/TanStackTableView/useTableParams';
 
+import { getAlertOptionsFromIds } from './PlannedDowntimeutils';
 import { DowntimeAlertOption, DowntimeSchedulesTableData } from './types';
 
 export const PLANNED_DOWNTIME_QUERY_PARAMS = {
@@ -71,38 +72,16 @@ function usePlannedDowntimeTable(
 
 	const filteredDowntimes = useMemo(() => {
 		const search = searchValue.toLowerCase();
-		const alertOptionsMap = new Map<string, DowntimeAlertOption>();
-		alertOptions.forEach((option) => {
-			if (option?.value != null) {
-				alertOptionsMap.set(String(option.value), option);
-			}
-		});
-
 		return downtimes
 			.filter(
 				(downtime) =>
 					downtime.name.toLowerCase().includes(search) ||
 					downtime.id === searchValue,
 			)
-			.map((downtime) => {
-				const resolvedAlertOptions: DowntimeAlertOption[] = (
-					downtime.alertIds || []
-				).map((id) => {
-					const found = alertOptionsMap.get(String(id));
-					if (found) {
-						return found;
-					}
-					return {
-						label: 'Unknown rule',
-						value: id,
-					};
-				});
-
-				return {
-					...downtime,
-					alertOptions: resolvedAlertOptions,
-				};
-			});
+			.map((downtime) => ({
+				...downtime,
+				alertOptions: getAlertOptionsFromIds(downtime.alertIds || [], alertOptions),
+			}));
 	}, [downtimes, alertOptions, searchValue]);
 
 	const pagedDowntimes = useMemo(() => {

frontend/src/container/QueryBuilder/components/Formula/Formula.tsx

@@ -2,7 +2,6 @@ import { ChangeEvent, useCallback, useMemo, useState } from 'react';
 import { Col, Input, Row, Select } from 'antd';
 import InputWithLabel from 'components/InputWithLabel/InputWithLabel';
 import BucketOptions from 'components/QueryBuilderV2/QueryV2/QueryAddOns/BucketOptions/BucketOptions';
-import { parseLimit, sanitizeLimit } from 'components/QueryBuilderV2/utils';
 import { LEGEND } from 'constants/global';
 import { PANEL_TYPES } from 'constants/queryBuilder';
 // ** Hooks
@@ -172,8 +171,7 @@ export function Formula({
 								<InputWithLabel
 									label="Limit"
 									type="number"
-									onChange={(value): void => handleChangeLimit(parseLimit(value))}
-									sanitize={sanitizeLimit}
+									onChange={(value): void => handleChangeLimit(Number(value))}
 									initialValue={formula?.limit ?? undefined}
 									placeholder="Enter limit"
 								/>

frontend/src/container/RoutingPolicies/RoutingPolicies.module.scss

@@ -121,6 +121,13 @@
 	font-size: 13px;
 }
 
+.badges {
+	display: flex;
+	gap: var(--spacing-2);
+	overflow: hidden;
+	white-space: nowrap;
+}
+
 .timeText {
 	display: inline-block;
 	white-space: nowrap;

frontend/src/container/RoutingPolicies/RoutingPolicies.tsx

@@ -102,7 +102,7 @@ function RoutingPolicies(): JSX.Element {
 				<div className={styles.commandHeader}>
 					<div className={styles.headingBlock}>
 						<Typography.Title className={styles.title}>
-							All routing policies
+							Routing Policies
 						</Typography.Title>
 						<span className={styles.countPill}>{routingPoliciesData.length}</span>
 					</div>
@@ -124,7 +124,7 @@ function RoutingPolicies(): JSX.Element {
 						disabledTooltip="You need edit permissions to create a routing policy"
 						testId="routing-policies-create"
 					>
-						New Routing Policy
+						New routing policy
 					</Button>
 					<TextToolTip
 						text="More details on how to configure routing policies"

frontend/src/container/RoutingPolicies/__tests__/RoutingPolicies.test.tsx

@@ -50,7 +50,7 @@ describe('RoutingPolicies', () => {
 
 	it('should render components properly', () => {
 		render(<RoutingPolicies />);
-		expect(screen.getByText('All routing policies')).toBeInTheDocument();
+		expect(screen.getByText('Routing Policies')).toBeInTheDocument();
 		expect(screen.getByTestId(SEARCH_TEST_ID)).toBeInTheDocument();
 		expect(screen.getByTestId(CREATE_TEST_ID)).toBeInTheDocument();
 		expect(screen.getByTestId('routing-policy-list')).toBeInTheDocument();

frontend/src/container/RoutingPolicies/__tests__/RoutingPoliciesList.test.tsx

@@ -71,7 +71,7 @@ describe('RoutingPolicyList', () => {
 		const resizable = Array.from(document.querySelectorAll('th'))
 			.filter((th) => th.querySelector('[title="Drag to resize column"]'))
 			.map((th) => th.textContent?.trim());
-		expect(resizable).toStrictEqual(['Routing Policy', 'Channels', 'Expression']);
+		expect(resizable).toStrictEqual(['Routing Policy', 'Expression', 'Channels']);
 	});
 
 	it('opens the policy on row click', async () => {

frontend/src/container/RoutingPolicies/__tests__/useRoutingPolicies.test.tsx

@@ -202,39 +202,6 @@ describe('useRoutingPolicies', () => {
 		expect(callArg).toContain('search=test+search');
 	});
 
-	it('should preserve existing query parameters such as sort and pagination when updating search (Bug 54)', async () => {
-		const { result } = renderHookWithWrapper(
-			'/alerts?tab=Configuration&subTab=routing-policies',
-		);
-		// nuqs writes sort and pagination to the URL before the router location catches up
-		window.history.replaceState(
-			null,
-			'',
-			'/alerts?tab=Configuration&subTab=routing-policies&orderBy=name&order=asc&page=2&limit=20',
-		);
-
-		try {
-			act(() => {
-				result.current.setSearchTerm('policy');
-			});
-
-			await waitFor(() => {
-				expect(mockNavigate).toHaveBeenCalled();
-			});
-		} finally {
-			window.history.replaceState(null, '', '/');
-		}
-
-		const callArg = mockNavigate.mock.calls[0][0];
-		expect(callArg).toContain('tab=Configuration');
-		expect(callArg).toContain('subTab=routing-policies');
-		expect(callArg).toContain('orderBy=name');
-		expect(callArg).toContain('order=asc');
-		expect(callArg).toContain('page=2');
-		expect(callArg).toContain('limit=20');
-		expect(callArg).toContain('search=policy');
-	});
-
 	it('should remove search param from URL when search is cleared', async () => {
 		const { result } = renderHookWithWrapper('/alerts?search=existing');
 

frontend/src/container/RoutingPolicies/table.config.tsx

@@ -1,5 +1,5 @@
+import { Badge } from '@signozhq/ui/badge';
 import type { TableColumnDef } from 'components/TanStackTableView';
-import OverflowBadges from 'components/OverflowBadges/OverflowBadges';
 import TanStackTable from 'components/TanStackTableView';
 import { DATE_TIME_FORMATS } from 'constants/dateTimeFormats';
 import { toRelativeTime } from 'pages/AlertList/NotificationChannels/utils/relativeTime';
@@ -7,8 +7,6 @@ import { toRelativeTime } from 'pages/AlertList/NotificationChannels/utils/relat
 import styles from './RoutingPolicies.module.scss';
 import { RoutingPolicy } from './types';
 
-const COLUMN_WIDTH = { default: 'auto', min: '120px' };
-
 export function getRoutingPolicyColumns(
 	formatTimezoneAdjustedTimestamp: (date: string, format: string) => string,
 ): TableColumnDef<RoutingPolicy>[] {
@@ -44,7 +42,7 @@ export function getRoutingPolicyColumns(
 			id: 'name',
 			header: 'Routing Policy',
 			accessorKey: 'name',
-			width: COLUMN_WIDTH,
+			width: { default: '100%', min: '220px' },
 			enableSort: true,
 			enableResize: true,
 			enableRemove: false,
@@ -58,31 +56,11 @@ export function getRoutingPolicyColumns(
 				</TanStackTable.Text>
 			),
 		},
-		{
-			id: 'channels',
-			header: 'Channels',
-			accessorKey: 'channels',
-			width: COLUMN_WIDTH,
-			enableSort: false,
-			enableResize: true,
-			enableMove: false,
-			cell: ({ row }): JSX.Element =>
-				row.channels?.length ? (
-					<OverflowBadges
-						items={row.channels.map((channel) => ({
-							key: channel,
-							label: channel,
-						}))}
-					/>
-				) : (
-					<TanStackTable.Text>-</TanStackTable.Text>
-				),
-		},
 		{
 			id: 'expression',
 			header: 'Expression',
 			accessorKey: 'expression',
-			width: COLUMN_WIDTH,
+			width: { default: '260px', min: '160px' },
 			enableSort: false,
 			enableResize: true,
 			enableMove: false,
@@ -92,11 +70,37 @@ export function getRoutingPolicyColumns(
 				</TanStackTable.Text>
 			),
 		},
+		{
+			id: 'channels',
+			header: 'Channels',
+			accessorKey: 'channels',
+			width: { default: '220px', min: '140px' },
+			enableSort: false,
+			enableResize: true,
+			enableMove: false,
+			cell: ({ row }): JSX.Element =>
+				row.channels?.length ? (
+					<div className={styles.badges} title={row.channels.join(', ')}>
+						{row.channels.map((channel) => (
+							<Badge
+								key={channel}
+								textTransform="none"
+								variant="solid"
+								color="secondary"
+							>
+								{channel}
+							</Badge>
+						))}
+					</div>
+				) : (
+					<TanStackTable.Text>-</TanStackTable.Text>
+				),
+		},
 		{
 			id: 'createdBy',
 			header: 'Created By',
 			accessorKey: 'createdBy',
-			width: COLUMN_WIDTH,
+			width: { default: '180px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
@@ -107,7 +111,7 @@ export function getRoutingPolicyColumns(
 			id: 'createdAt',
 			header: 'Created At',
 			accessorKey: 'createdAt',
-			width: COLUMN_WIDTH,
+			width: { default: '150px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: true,
 			enableResize: true,
@@ -118,7 +122,7 @@ export function getRoutingPolicyColumns(
 			id: 'updatedBy',
 			header: 'Updated By',
 			accessorKey: 'updatedBy',
-			width: COLUMN_WIDTH,
+			width: { default: '180px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: false,
 			enableResize: true,
@@ -129,7 +133,7 @@ export function getRoutingPolicyColumns(
 			id: 'updatedAt',
 			header: 'Updated At',
 			accessorKey: 'updatedAt',
-			width: COLUMN_WIDTH,
+			width: { default: '150px', min: '120px' },
 			defaultVisibility: false,
 			enableSort: true,
 			enableResize: true,

frontend/src/container/RoutingPolicies/useRoutingPolicies.ts

@@ -1,6 +1,5 @@
 import { useCallback, useMemo, useState } from 'react';
 import { useQueryClient } from 'react-query';
-import { useAppLocation } from 'lib/router/useAppLocation';
 import { navigate } from 'lib/router/navigation';
 import { toast } from '@signozhq/ui/sonner';
 import { GetRoutingPoliciesResponse } from 'api/routingPolicies/getRoutingPolicies';
@@ -31,20 +30,9 @@ import './styles.scss';
 function useRoutingPolicies(): UseRoutingPoliciesReturn {
 	const queryClient = useQueryClient();
 	const urlQuery = useUrlQuery();
-	const location = useAppLocation();
 
 	// Local state
-	const [searchTerm, setSearchTerm] = useState(() => {
-		const searchFromUrlQuery = urlQuery.get('search');
-		if (searchFromUrlQuery) {
-			return searchFromUrlQuery;
-		}
-		const search =
-			(typeof window !== 'undefined' && window.location.search) ||
-			location.search ||
-			'';
-		return new URLSearchParams(search).get('search') || '';
-	});
+	const [searchTerm, setSearchTerm] = useState(urlQuery.get('search') || '');
 	const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false);
 	const [policyDetailsModalState, setPolicyDetailsModalState] =
 		useState<PolicyDetailsModalState>({
@@ -56,15 +44,12 @@ function useRoutingPolicies(): UseRoutingPoliciesReturn {
 
 	const updateUrlWithSearch = useDebouncedFn((value) => {
 		const searchValue = value as string;
-		const search =
-			(typeof window !== 'undefined' && window.location.search) || location.search;
-		const params = new URLSearchParams(search);
 		if (searchValue) {
-			params.set('search', searchValue);
+			urlQuery.set('search', searchValue);
 		} else {
-			params.delete('search');
+			urlQuery.delete('search');
 		}
-		const url = `/alerts?${params.toString()}`;
+		const url = `/alerts?${urlQuery.toString()}`;
 		navigate(url, { replace: true });
 	}, 300);
 

frontend/src/container/TracesExplorer/ListView/ListView.module.scss

@@ -6,7 +6,3 @@
 	height: calc(100vh - 240px);
 	min-height: 400px;
 }
-
-.drawerScope {
-	display: contents;
-}

frontend/src/container/TracesExplorer/ListView/__tests__/SpanDrawerNavigation.test.tsx

@@ -1,113 +0,0 @@
-import remove from 'api/browser/localstorage/remove';
-import set from 'api/browser/localstorage/set';
-import { LOCALSTORAGE } from 'constants/localStorage';
-import { server } from 'mocks-server/server';
-import { screen, userEvent, waitFor, within } from 'tests/test-utils';
-import { mockSuccess, mockTraceSummary, renderListView } from './testUtils';
-
-// globalTime starts with loading:true, which gates the list query. Force just that
-// slice's loading to false so the query fires; every other selector is untouched.
-jest.mock('react-redux', () => {
-	const actual = jest.requireActual('react-redux');
-	return {
-		...actual,
-		useSelector: (selector: (state: unknown) => unknown): unknown => {
-			const result = actual.useSelector(selector);
-			if (result && typeof result === 'object' && 'loading' in result) {
-				return { ...result, loading: false };
-			}
-			return result;
-		},
-	};
-});
-
-// List columns come from the options menu (server-synced preferences). Pin them
-// so the expected columns render, independent of that API.
-jest.mock('container/OptionsMenu/useOptionsMenu', () => ({
-	__esModule: true,
-	default: (): unknown => ({
-		options: {
-			selectColumns: [
-				{ name: 'service.name', fieldContext: 'resource' },
-				{ name: 'name', fieldContext: 'span' },
-				{ name: 'duration_nano', fieldContext: 'span' },
-				{ name: 'http_method', fieldContext: 'span' },
-				{ name: 'response_status_code', fieldContext: 'span' },
-				{ name: 'http.route', fieldContext: 'attribute' },
-				{ name: 'cache.hit', fieldContext: 'attribute' },
-			],
-		},
-		config: { addColumn: { onRemove: jest.fn() } },
-	}),
-}));
-
-describe('Traces ListView - span drawer navigation', () => {
-	beforeEach(() => {
-		set(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED, 'true');
-		mockSuccess();
-		mockTraceSummary({});
-	});
-
-	afterEach(() => {
-		remove(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED);
-		server.resetHandlers();
-	});
-
-	it('opens the clicked span and steps through rows with the arrow keys', async () => {
-		const user = userEvent.setup();
-		renderListView();
-
-		await user.click(await screen.findByText('HTTP GET'));
-
-		const drawer = await screen.findByTestId('span-details-drawer');
-		expect(within(drawer).getByText('HTTP GET')).toBeInTheDocument();
-		expect(within(drawer).getByTestId('span-details-trace-id')).toHaveTextContent(
-			'0000000000000000344ded1387b08a7e',
-		);
-
-		await user.keyboard('{ArrowDown}');
-		await expect(
-			within(drawer).findByText('authenticate_check_db'),
-		).resolves.toBeInTheDocument();
-
-		await user.keyboard('{ArrowUp}');
-		await expect(
-			within(drawer).findByText('HTTP GET'),
-		).resolves.toBeInTheDocument();
-	});
-
-	it('closes the drawer', async () => {
-		const user = userEvent.setup();
-		renderListView();
-
-		await user.click(await screen.findByText('HTTP GET'));
-		await screen.findByTestId('span-details-drawer');
-
-		await user.click(screen.getByTestId('span-drawer-close'));
-
-		await waitFor(() =>
-			expect(screen.queryByTestId('span-details-drawer')).not.toBeInTheDocument(),
-		);
-	});
-
-	it('stays open on a press in the drawer or the list, and closes on one outside', async () => {
-		const user = userEvent.setup();
-		renderListView();
-
-		await user.click(await screen.findByText('HTTP GET'));
-		const drawer = await screen.findByTestId('span-details-drawer');
-
-		await user.click(drawer);
-		// Hovering re-renders the row, so the press needs a fresh query.
-		await user.hover(screen.getByText('authenticate_check_db'));
-		await user.click(screen.getByText('authenticate_check_db'));
-		await expect(
-			within(drawer).findByText('authenticate_check_db'),
-		).resolves.toBeInTheDocument();
-
-		await user.click(document.body);
-		await waitFor(() =>
-			expect(screen.queryByTestId('span-details-drawer')).not.toBeInTheDocument(),
-		);
-	});
-});

frontend/src/container/TracesExplorer/ListView/__tests__/SpanDrawerTraceBounds.test.tsx

@@ -1,192 +0,0 @@
-import remove from 'api/browser/localstorage/remove';
-import set from 'api/browser/localstorage/set';
-import { LOCALSTORAGE } from 'constants/localStorage';
-import { server } from 'mocks-server/server';
-import { rest } from 'msw';
-import { screen, userEvent, waitFor, within } from 'tests/test-utils';
-import { QueryRangeRequestV5 } from 'types/api/v5/queryRange';
-import {
-	FIVE_MINUTES_IN_MS,
-	listResponse,
-	listRows,
-	mockSuccess,
-	mockTraceSummary,
-	QUERY_RANGE_URL,
-	renderListView,
-	TraceBounds,
-} from './testUtils';
-
-// globalTime starts with loading:true, which gates the list query. Force just that
-// slice's loading to false so the query fires; every other selector is untouched.
-jest.mock('react-redux', () => {
-	const actual = jest.requireActual('react-redux');
-	return {
-		...actual,
-		useSelector: (selector: (state: unknown) => unknown): unknown => {
-			const result = actual.useSelector(selector);
-			if (result && typeof result === 'object' && 'loading' in result) {
-				return { ...result, loading: false };
-			}
-			return result;
-		},
-	};
-});
-
-// List columns come from the options menu (server-synced preferences). Pin them
-// so the expected columns render, independent of that API.
-jest.mock('container/OptionsMenu/useOptionsMenu', () => ({
-	__esModule: true,
-	default: (): unknown => ({
-		options: {
-			selectColumns: [
-				{ name: 'service.name', fieldContext: 'resource' },
-				{ name: 'name', fieldContext: 'span' },
-				{ name: 'duration_nano', fieldContext: 'span' },
-				{ name: 'http_method', fieldContext: 'span' },
-				{ name: 'response_status_code', fieldContext: 'span' },
-				{ name: 'http.route', fieldContext: 'attribute' },
-				{ name: 'cache.hit', fieldContext: 'attribute' },
-			],
-		},
-		config: { addColumn: { onRemove: jest.fn() } },
-	}),
-}));
-
-describe('Traces ListView - span drawer trace bounds', () => {
-	beforeEach(() => {
-		set(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED, 'true');
-		mockSuccess();
-		mockTraceSummary({});
-	});
-
-	afterEach(() => {
-		remove(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED);
-		server.resetHandlers();
-	});
-
-	it('requests span logs over whole milliseconds', async () => {
-		const logsRequests: QueryRangeRequestV5[] = [];
-		server.use(
-			rest.post(QUERY_RANGE_URL, async (req, res, ctx) => {
-				const body = await req.json<QueryRangeRequestV5>();
-				const spec = body.compositeQuery.queries[0]?.spec;
-				if (spec && 'signal' in spec && spec.signal === 'logs') {
-					logsRequests.push(body);
-					// No logs, so no context queries follow to outlive the test.
-					return res(ctx.status(200), ctx.json(listResponse([])));
-				}
-				return res(ctx.status(200), ctx.json(listResponse(listRows)));
-			}),
-		);
-		const user = userEvent.setup();
-		renderListView();
-
-		// Its 790.94939 ms duration makes the span window end mid-millisecond.
-		await user.click(await screen.findByText('authenticate_check_db'));
-
-		await waitFor(() => expect(logsRequests.length).toBeGreaterThan(0));
-		logsRequests.forEach(({ start, end }) => {
-			expect(Number.isInteger(start)).toBe(true);
-			expect(Number.isInteger(end)).toBe(true);
-		});
-	});
-
-	it('reads the trace bounds from the trace summary', async () => {
-		const bounds: TraceBounds = {
-			'0000000000000000344ded1387b08a7e': {
-				start: Date.parse('2024-07-19T08:39:58.700Z'),
-				end: Date.parse('2024-07-19T08:39:58.900Z'),
-			},
-			a364a8e15af3e9a8c866e0528db8b637: {
-				start: Date.parse('2024-07-19T08:39:59.900Z'),
-				end: Date.parse('2024-07-19T08:40:01.000Z'),
-			},
-		};
-		mockTraceSummary(bounds);
-		const logsRequests: {
-			traceId: string;
-			isTraceWide: boolean;
-			start: number;
-			end: number;
-		}[] = [];
-		server.use(
-			rest.post(QUERY_RANGE_URL, async (req, res, ctx) => {
-				const body = await req.json<QueryRangeRequestV5>();
-				const spec = body.compositeQuery.queries[0]?.spec;
-				if (spec && 'signal' in spec && spec.signal === 'logs') {
-					const traceId =
-						Object.keys(bounds).find((id) => spec.filter?.expression?.includes(id)) ??
-						'';
-					// The payload carries the window in µs.
-					logsRequests.push({
-						traceId,
-						isTraceWide: !spec.filter?.expression?.includes('span_id'),
-						start: body.start / 1e3,
-						end: body.end / 1e3,
-					});
-					return res(ctx.status(200), ctx.json(listResponse([])));
-				}
-				return res(ctx.status(200), ctx.json(listResponse(listRows)));
-			}),
-		);
-		const user = userEvent.setup();
-		renderListView();
-
-		await user.click(await screen.findByText('HTTP GET'));
-		const drawer = await screen.findByTestId('span-details-drawer');
-		await expect(
-			within(drawer).findByText(/of total exec time/),
-		).resolves.toBeInTheDocument();
-
-		// The next span is in another trace, so it needs that trace's bounds.
-		// Both its span logs and its trace-wide check must land before the test ends.
-		await user.keyboard('{ArrowDown}');
-		await waitFor(() =>
-			expect(
-				logsRequests
-					.filter(({ traceId }) => traceId === 'a364a8e15af3e9a8c866e0528db8b637')
-					.map(({ isTraceWide }) => isTraceWide),
-			).toStrictEqual(expect.arrayContaining([false, true])),
-		);
-
-		// Logs wait for the bounds: no request ever goes out with another window.
-		logsRequests.forEach(({ traceId, start, end }) => {
-			expect(start).toBe(bounds[traceId].start - FIVE_MINUTES_IN_MS);
-			expect(end).toBe(bounds[traceId].end + FIVE_MINUTES_IN_MS);
-		});
-	});
-
-	it('speaks only for the span when the trace has no summary', async () => {
-		const logsFilters: string[] = [];
-		server.use(
-			rest.post(QUERY_RANGE_URL, async (req, res, ctx) => {
-				const body = await req.json<QueryRangeRequestV5>();
-				const spec = body.compositeQuery.queries[0]?.spec;
-				if (spec && 'signal' in spec && spec.signal === 'logs') {
-					logsFilters.push(spec.filter?.expression ?? '');
-					return res(ctx.status(200), ctx.json(listResponse([])));
-				}
-				return res(ctx.status(200), ctx.json(listResponse(listRows)));
-			}),
-		);
-		const user = userEvent.setup();
-		renderListView();
-
-		await user.click(await screen.findByText('HTTP GET'));
-		const drawer = await screen.findByTestId('span-details-drawer');
-
-		await user.click(within(drawer).getByRole('tab', { name: /logs/i }));
-		await expect(
-			within(drawer).findByText('No logs found for this span.'),
-		).resolves.toBeInTheDocument();
-		// Checked once the 404 has settled; before it, exec time is absent anyway.
-		expect(
-			within(drawer).queryByText(/of total exec time/),
-		).not.toBeInTheDocument();
-		// No trace-wide check: every logs request is scoped to the span.
-		expect(logsFilters.length).toBeGreaterThan(0);
-		logsFilters.forEach((expression) => {
-			expect(expression).toContain('span_id');
-		});
-	});
-});

frontend/src/container/TracesExplorer/ListView/__tests__/testUtils.tsx

@@ -1,110 +0,0 @@
-import { ENVIRONMENT } from 'constants/env';
-import { initialQueriesMap, PANEL_TYPES } from 'constants/queryBuilder';
-import { server } from 'mocks-server/server';
-import { rest } from 'msw';
-import { VirtuosoMockContext } from 'react-virtuoso';
-import { render } from 'tests/test-utils';
-import { Query } from 'types/api/queryBuilder/queryBuilderData';
-
-import ListView from '../index';
-
-const BASE_URL = ENVIRONMENT.baseURL;
-export const QUERY_RANGE_URL = `${BASE_URL}/api/v5/query_range`;
-
-export const listRows = [
-	{
-		timestamp: '2024-07-19T08:39:58.735245Z',
-		data: {
-			name: 'HTTP GET',
-			duration_nano: 55306000,
-			http_method: 'GET',
-			response_status_code: '200',
-			span_id: '772c4d29dd9076ac',
-			trace_id: '0000000000000000344ded1387b08a7e',
-			attributes: { 'http.route': '/api/cart', 'cache.hit': false },
-			resource: { 'service.name': 'frontend' },
-		},
-	},
-	{
-		timestamp: '2024-07-19T08:39:59.949129915Z',
-		data: {
-			name: 'authenticate_check_db',
-			duration_nano: 790949390,
-			// empty status fields to assert the "-" cell
-			http_method: '',
-			response_status_code: '',
-			span_id: '5704353737b6778e',
-			trace_id: 'a364a8e15af3e9a8c866e0528db8b637',
-			attributes: {},
-			resource: { 'service.name': 'demo-app' },
-		},
-	},
-];
-
-export const listResponse = (rows: unknown[]): Record<string, unknown> => ({
-	data: { type: 'raw', data: { results: [{ queryName: 'A', rows }] } },
-});
-
-export const TRACE_SUMMARY_URL = `${BASE_URL}/api/v1/traces/:traceId/summary`;
-export const FIVE_MINUTES_IN_MS = 5 * 60 * 1000;
-
-export type TraceBounds = Record<string, { start: number; end: number }>;
-
-// Traces missing from `bounds` get a 404, like a trace with no summary row.
-export const mockTraceSummary = (bounds: TraceBounds): void => {
-	server.use(
-		rest.get(TRACE_SUMMARY_URL, (req, res, ctx) => {
-			const traceBounds = bounds[req.params.traceId as string];
-			if (!traceBounds) {
-				return res(ctx.status(404), ctx.json({ status: 'error' }));
-			}
-			return res(
-				ctx.status(200),
-				ctx.json({
-					status: 'success',
-					data: {
-						startTimestampMillis: traceBounds.start,
-						endTimestampMillis: traceBounds.end,
-						hasMissingSpans: false,
-						rootServiceEntryPoint: '',
-						rootServiceName: '',
-						rootSpanStatusCode: '',
-						totalErrorSpansCount: 0,
-						totalSpansCount: 1,
-					},
-				}),
-			);
-		}),
-	);
-};
-
-export const mockSuccess = (rows: unknown[] = listRows): void => {
-	server.use(
-		rest.post(QUERY_RANGE_URL, (_req, res, ctx) =>
-			res(ctx.status(200), ctx.json(listResponse(rows))),
-		),
-	);
-};
-
-export const renderListView = (
-	stagedQuery: Query = initialQueriesMap.traces,
-): ReturnType<typeof render> =>
-	render(
-		<VirtuosoMockContext.Provider value={{ viewportHeight: 500, itemHeight: 54 }}>
-			<ListView
-				isFilterApplied={false}
-				setWarning={jest.fn()}
-				setIsLoadingQueries={jest.fn()}
-			/>
-		</VirtuosoMockContext.Provider>,
-		{},
-		{
-			initialRoute: '/traces-explorer',
-			queryBuilderOverrides: {
-				panelType: PANEL_TYPES.LIST,
-				stagedQuery,
-				currentQuery: stagedQuery,
-				redirectWithQueryBuilderData: jest.fn(),
-			} as any,
-		},
-	);

frontend/src/container/TracesExplorer/ListView/index.data.test.tsx

@@ -1,20 +1,17 @@
+import { ENVIRONMENT } from 'constants/env';
 import {
 	initialQueriesMap,
 	initialQueryBuilderFormTraceOperatorValues,
+	PANEL_TYPES,
 } from 'constants/queryBuilder';
 import { server } from 'mocks-server/server';
 import { rest } from 'msw';
-import { screen } from 'tests/test-utils';
+import { VirtuosoMockContext } from 'react-virtuoso';
+import { render, screen } from 'tests/test-utils';
 import { Query } from 'types/api/queryBuilder/queryBuilderData';
 import { QueryRangeRequestV5 } from 'types/api/v5/queryRange';
 
-import {
-	listResponse,
-	listRows,
-	mockSuccess,
-	QUERY_RANGE_URL,
-	renderListView,
-} from './__tests__/testUtils';
+import ListView from './index';
 
 // globalTime starts with loading:true, which gates the list query. Force just that
 // slice's loading to false so the query fires; every other selector is untouched.
@@ -52,6 +49,74 @@ jest.mock('container/OptionsMenu/useOptionsMenu', () => ({
 	}),
 }));
 
+const BASE_URL = ENVIRONMENT.baseURL;
+const QUERY_RANGE_URL = `${BASE_URL}/api/v5/query_range`;
+
+const listRows = [
+	{
+		timestamp: '2024-07-19T08:39:58.735245Z',
+		data: {
+			name: 'HTTP GET',
+			duration_nano: 55306000,
+			http_method: 'GET',
+			response_status_code: '200',
+			span_id: '772c4d29dd9076ac',
+			trace_id: '0000000000000000344ded1387b08a7e',
+			attributes: { 'http.route': '/api/cart', 'cache.hit': false },
+			resource: { 'service.name': 'frontend' },
+		},
+	},
+	{
+		timestamp: '2024-07-19T08:39:59.949129915Z',
+		data: {
+			name: 'authenticate_check_db',
+			duration_nano: 790949390,
+			// empty status fields to assert the "-" cell
+			http_method: '',
+			response_status_code: '',
+			span_id: '5704353737b6778e',
+			trace_id: 'a364a8e15af3e9a8c866e0528db8b637',
+			attributes: {},
+			resource: { 'service.name': 'demo-app' },
+		},
+	},
+];
+
+const listResponse = (rows: unknown[]): Record<string, unknown> => ({
+	data: { type: 'raw', data: { results: [{ queryName: 'A', rows }] } },
+});
+
+const mockSuccess = (rows: unknown[] = listRows): void => {
+	server.use(
+		rest.post(QUERY_RANGE_URL, (_req, res, ctx) =>
+			res(ctx.status(200), ctx.json(listResponse(rows))),
+		),
+	);
+};
+
+const renderListView = (
+	stagedQuery: Query = initialQueriesMap.traces,
+): ReturnType<typeof render> =>
+	render(
+		<VirtuosoMockContext.Provider value={{ viewportHeight: 500, itemHeight: 54 }}>
+			<ListView
+				isFilterApplied={false}
+				setWarning={jest.fn()}
+				setIsLoadingQueries={jest.fn()}
+			/>
+		</VirtuosoMockContext.Provider>,
+		{},
+		{
+			initialRoute: '/traces-explorer',
+			queryBuilderOverrides: {
+				panelType: PANEL_TYPES.LIST,
+				stagedQuery,
+				currentQuery: stagedQuery,
+				redirectWithQueryBuilderData: jest.fn(),
+			} as any,
+		},
+	);
+
 describe('Traces ListView - Data Loaded', () => {
 	afterEach(() => {
 		server.resetHandlers();

frontend/src/container/TracesExplorer/ListView/index.tsx

@@ -29,8 +29,6 @@ import { useOptionsMenu } from 'container/OptionsMenu';
 import { CustomTimeType } from 'container/TopNav/DateTimeSelectionV2/types';
 import TraceExplorerControls from 'container/TracesExplorer/Controls';
 import { getListViewQuery } from 'container/TracesExplorer/explorerUtils';
-import SpanDrawer from 'container/TracesExplorer/SpanDrawer/SpanDrawer';
-import { useSpanDrawer } from 'container/TracesExplorer/SpanDrawer/useSpanDrawer';
 import { useGetQueryRange } from 'hooks/queryBuilder/useGetQueryRange';
 import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
 import { Pagination } from 'hooks/queryPagination';
@@ -204,8 +202,6 @@ function ListView({
 		[queryTableData],
 	);
 
-	const { tableProps, drawerProps, onPressInside } = useSpanDrawer(rows);
-
 	const handleColumnOrderChange = useCallback(
 		(cols: TableColumnDef<TracesTableRow>[]): void => {
 			config?.addColumn?.onReorder(cols.map((c) => c.id));
@@ -257,26 +253,20 @@ function ListView({
 				/>
 			</div>
 
-			{/* A press in the table or the drawer (a portal) keeps the drawer open. */}
-			<div className={styles.drawerScope} onPointerDownCapture={onPressInside}>
-				<TracesTable
-					data={rows}
-					columns={columns}
-					columnStorageKey={LOCALSTORAGE.TRACES_LIST_COLUMNS}
-					panelType="LIST"
-					getRowHref={getTraceLink}
-					{...tableProps}
-					isLoading={isLoading}
-					isFetching={isFetching}
-					isError={isError}
-					error={error}
-					isFilterApplied={isFilterApplied}
-					onColumnOrderChange={handleColumnOrderChange}
-					onColumnRemove={config?.addColumn?.onRemove}
-				/>
-
-				{drawerProps && <SpanDrawer {...drawerProps} />}
-			</div>
+			<TracesTable
+				data={rows}
+				columns={columns}
+				columnStorageKey={LOCALSTORAGE.TRACES_LIST_COLUMNS}
+				panelType="LIST"
+				getRowHref={getTraceLink}
+				isLoading={isLoading}
+				isFetching={isFetching}
+				isError={isError}
+				error={error}
+				isFilterApplied={isFilterApplied}
+				onColumnOrderChange={handleColumnOrderChange}
+				onColumnRemove={config?.addColumn?.onRemove}
+			/>
 		</div>
 	);
 }

frontend/src/container/TracesExplorer/SpanDrawer/SpanDrawer.tsx

@@ -1,112 +0,0 @@
-import { useMemo } from 'react';
-import { Button } from '@signozhq/ui/button';
-import { ButtonGroup } from '@signozhq/ui/button-group';
-import { ChevronDown, ChevronUp, CornerUpRight } from '@signozhq/icons';
-import { useGetTraceSummary } from 'api/generated/services/tracedetail';
-import { HeaderAction } from 'components/DetailsPanel';
-import type { UseRowNavigationResult } from 'components/TanStackTableView/useRowNavigation';
-import { getTraceLink } from 'container/TracesExplorer/ListView/utils';
-import { TracesTableRow } from 'container/TracesExplorer/TracesTable/getFieldColumn';
-import { SpanDetailVariant } from 'pages/TraceDetailsV3/SpanDetailsPanel/constants';
-import SpanDetailsPanel from 'pages/TraceDetailsV3/SpanDetailsPanel/SpanDetailsPanel';
-import { openInNewTab } from 'utils/navigation';
-
-import { useArrowKeyNavigation } from './useArrowKeyNavigation';
-import { toSpanV3 } from './utils';
-
-export type SpanDrawerProps = {
-	row: TracesTableRow | null;
-	onClose: () => void;
-	navigation: UseRowNavigationResult;
-};
-
-function SpanDrawer({
-	row,
-	onClose,
-	navigation,
-}: SpanDrawerProps): JSX.Element {
-	const { goToPrev, goToNext, isPrevDisabled, isNextDisabled } = navigation;
-	const isOpen = row !== null;
-
-	useArrowKeyNavigation({ enabled: isOpen, onPrev: goToPrev, onNext: goToNext });
-
-	const panelState = useMemo(
-		() => ({ isOpen, open: (): void => {}, close: onClose }),
-		[isOpen, onClose],
-	);
-
-	const headerActions = useMemo((): HeaderAction[] => {
-		if (!row) {
-			return [];
-		}
-		return [
-			{
-				key: 'view-full-trace',
-				component: (
-					<Button
-						variant="outlined"
-						color="secondary"
-						size="md"
-						prefix={<CornerUpRight />}
-						onClick={(): void => openInNewTab(getTraceLink(row))}
-						testId="span-drawer-view-full-trace"
-					>
-						View full trace
-					</Button>
-				),
-			},
-			{
-				key: 'nav',
-				component: (
-					<ButtonGroup
-						variant="outlined"
-						color="secondary"
-						size="md"
-						testId="span-drawer-nav"
-						items={[
-							{
-								value: 'prev',
-								icon: <ChevronUp />,
-								ariaLabel: 'Previous span',
-								onClick: goToPrev,
-								disabled: isPrevDisabled,
-								disabledTooltip: 'No previous span on this page',
-							},
-							{
-								value: 'next',
-								icon: <ChevronDown />,
-								ariaLabel: 'Next span',
-								onClick: goToNext,
-								disabled: isNextDisabled,
-								disabledTooltip: 'No next span on this page',
-							},
-						]}
-					/>
-				),
-			},
-		];
-	}, [row, goToPrev, goToNext, isPrevDisabled, isNextDisabled]);
-
-	const span = useMemo(() => (row ? toSpanV3(row) : undefined), [row]);
-
-	const traceId = span?.trace_id ?? '';
-	const { data: traceSummary, isLoading: isTraceBoundsLoading } =
-		useGetTraceSummary(
-			{ traceID: traceId },
-			{ query: { enabled: !!traceId, retry: false } },
-		);
-
-	return (
-		<SpanDetailsPanel
-			panelState={panelState}
-			selectedSpan={span}
-			variant={SpanDetailVariant.DRAWER}
-			headerActions={headerActions}
-			traceStartTime={traceSummary?.data?.startTimestampMillis}
-			traceEndTime={traceSummary?.data?.endTimestampMillis}
-			isTraceBoundsLoading={isTraceBoundsLoading}
-		/>
-	);
-}
-
-export default SpanDrawer;

frontend/src/container/TracesExplorer/SpanDrawer/__tests__/useArrowKeyNavigation.test.ts

@@ -1,39 +0,0 @@
-import { renderHook } from 'tests/test-utils';
-
-import { useArrowKeyNavigation } from '../useArrowKeyNavigation';
-
-const pressArrowDown = ({ handled }: { handled: boolean }): void => {
-	const event = new KeyboardEvent('keydown', {
-		key: 'ArrowDown',
-		bubbles: true,
-		cancelable: true,
-	});
-	if (handled) {
-		event.preventDefault();
-	}
-	document.body.dispatchEvent(event);
-};
-
-describe('useArrowKeyNavigation', () => {
-	it('steps to the next span on ArrowDown', () => {
-		const onNext = jest.fn() as jest.MockedFunction<() => void>;
-		renderHook(() =>
-			useArrowKeyNavigation({ enabled: true, onPrev: jest.fn(), onNext }),
-		);
-
-		pressArrowDown({ handled: false });
-
-		expect(onNext).toHaveBeenCalledTimes(1);
-	});
-
-	it('ignores a key that a focused menu already handled', () => {
-		const onNext = jest.fn() as jest.MockedFunction<() => void>;
-		renderHook(() =>
-			useArrowKeyNavigation({ enabled: true, onPrev: jest.fn(), onNext }),
-		);
-
-		pressArrowDown({ handled: true });
-
-		expect(onNext).not.toHaveBeenCalled();
-	});
-});

frontend/src/container/TracesExplorer/SpanDrawer/__tests__/useSpanDrawer.test.ts

@@ -1,35 +0,0 @@
-import { act, renderHook } from 'tests/test-utils';
-import remove from 'api/browser/localstorage/remove';
-import set from 'api/browser/localstorage/set';
-import { LOCALSTORAGE } from 'constants/localStorage';
-import { TracesTableRow } from 'container/TracesExplorer/TracesTable/getFieldColumn';
-
-import { useSpanDrawer } from '../useSpanDrawer';
-
-const rows: TracesTableRow[] = [{ id: 'span-a' }, { id: 'span-b' }];
-
-describe('useSpanDrawer', () => {
-	beforeEach(() => {
-		set(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED, 'true');
-	});
-
-	afterEach(() => {
-		remove(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED);
-	});
-
-	it('does not reopen a span that a refetch dropped and a later one brings back', () => {
-		const { result, rerender } = renderHook(
-			({ current }: { current: TracesTableRow[] }) => useSpanDrawer(current),
-			{ initialProps: { current: rows } },
-		);
-
-		act(() => result.current.tableProps.onRowClick?.(rows[1]));
-		expect(result.current.drawerProps?.row).toBe(rows[1]);
-
-		rerender({ current: [rows[0]] });
-		expect(result.current.drawerProps?.row).toBeNull();
-
-		rerender({ current: rows });
-		expect(result.current.drawerProps?.row).toBeNull();
-	});
-});

frontend/src/container/TracesExplorer/SpanDrawer/__tests__/utils.test.ts

@@ -1,74 +0,0 @@
-import { toSpanV3 } from '../utils';
-
-describe('toSpanV3', () => {
-	const row = {
-		id: '772c4d29dd9076ac',
-		span_id: '772c4d29dd9076ac',
-		timestamp: '2024-07-19T08:39:58.735Z',
-		resource: { 'service.name': 'frontend' },
-		events: [
-			{
-				name: 'exception',
-				timeUnixNano: 1721378398735000000,
-				attributes: { 'exception.type': 'Error' },
-			},
-		],
-		links: [{ traceId: 'a364a8e15af3e9a8', spanId: '5704353737b6778e' }],
-	};
-
-	it('reshapes a list row into the span the details panel reads', () => {
-		const span = toSpanV3(row);
-
-		expect(span.timestamp).toBe(Date.UTC(2024, 6, 19, 8, 39, 58, 735));
-		expect(span['service.name']).toBe('frontend');
-		expect(span.events).toStrictEqual([
-			{
-				name: 'exception',
-				timeUnixNano: 1721378398735000000,
-				attributeMap: { 'exception.type': 'Error' },
-				isError: false,
-			},
-		]);
-		expect((span as unknown as { references: unknown }).references).toStrictEqual(
-			row.links,
-		);
-	});
-
-	it('drops the parent from the linked spans', () => {
-		const link = { traceId: 'a364a8e15af3e9a8', spanId: '5704353737b6778e' };
-		const parent = { traceId: '1f2e3d4c5b6a7980', spanId: '0aa1bb2cc3dd4ee5' };
-		const span = toSpanV3({
-			...row,
-			trace_id: parent.traceId,
-			parent_span_id: parent.spanId,
-			links: [parent, link, { ...parent, traceId: link.traceId }],
-		});
-
-		expect((span as unknown as { references: unknown }).references).toStrictEqual(
-			[link, { ...parent, traceId: link.traceId }],
-		);
-	});
-
-	it('drops the empty parent ref of a root span', () => {
-		const span = toSpanV3({
-			...row,
-			trace_id: 'a364a8e15af3e9a8',
-			parent_span_id: '',
-			links: [{ traceId: 'a364a8e15af3e9a8' }],
-		});
-
-		expect((span as unknown as { references: unknown }).references).toStrictEqual(
-			[],
-		);
-	});
-
-	it('defaults missing events, links and service name', () => {
-		const span = toSpanV3({ id: 'x', timestamp: row.timestamp });
-
-		expect(span.events).toStrictEqual([]);
-		expect(span['service.name']).toBe('');
-		expect((span as unknown as { references: unknown }).references).toStrictEqual(
-			[],
-		);
-	});
-});

frontend/src/container/TracesExplorer/SpanDrawer/useArrowKeyNavigation.ts

@@ -1,46 +0,0 @@
-import { useEffect } from 'react';
-
-const EDITABLE_TARGET = 'input, textarea, [contenteditable="true"], .cm-editor';
-
-type UseArrowKeyNavigationParams = {
-	enabled: boolean;
-	onPrev: () => void;
-	onNext: () => void;
-};
-
-export function useArrowKeyNavigation({
-	enabled,
-	onPrev,
-	onNext,
-}: UseArrowKeyNavigationParams): void {
-	useEffect(() => {
-		if (!enabled) {
-			return undefined;
-		}
-
-		const handleKeyDown = (e: KeyboardEvent): void => {
-			// A focused menu or listbox already used the key.
-			if (e.defaultPrevented) {
-				return;
-			}
-			if (e.altKey || e.ctrlKey || e.metaKey || e.shiftKey) {
-				return;
-			}
-			if (e.target instanceof Element && e.target.closest(EDITABLE_TARGET)) {
-				return;
-			}
-			if (e.key === 'ArrowUp') {
-				e.preventDefault();
-				onPrev();
-			} else if (e.key === 'ArrowDown') {
-				e.preventDefault();
-				onNext();
-			}
-		};
-
-		document.addEventListener('keydown', handleKeyDown);
-		return (): void => {
-			document.removeEventListener('keydown', handleKeyDown);
-		};
-	}, [enabled, onPrev, onNext]);
-}

frontend/src/container/TracesExplorer/SpanDrawer/useSpanDrawer.ts

@@ -1,87 +0,0 @@
-import { PointerEvent, useCallback, useEffect, useMemo, useState } from 'react';
-import { useRowNavigation } from 'components/TanStackTableView/useRowNavigation';
-import { TracesTableRow } from 'container/TracesExplorer/TracesTable/getFieldColumn';
-import type { TracesTableProps } from 'container/TracesExplorer/TracesTable/TracesTable';
-import { useCloseOnOutsidePress } from 'hooks/useCloseOnOutsidePress';
-
-import type { SpanDrawerProps } from './SpanDrawer';
-import { isSpanDrawerEnabled } from './utils';
-
-type ActiveSpan = { id: string; index: number };
-
-type UseSpanDrawerResult = {
-	tableProps: Pick<
-		TracesTableProps,
-		'onRowClick' | 'isRowActive' | 'activeRowIndex'
-	>;
-	/** Null while the drawer flag is off. */
-	drawerProps: SpanDrawerProps | null;
-	/** `onPointerDownCapture` for the area a press keeps the drawer open in. */
-	onPressInside: (event: PointerEvent) => void;
-};
-
-export function useSpanDrawer(rows: TracesTableRow[]): UseSpanDrawerResult {
-	const [isEnabled] = useState(isSpanDrawerEnabled);
-	// The index lets navigation step past a duplicate span; the id survives a refetch.
-	const [activeSpan, setActiveSpan] = useState<ActiveSpan | null>(null);
-
-	const activeRowIndex = useMemo(() => {
-		if (!activeSpan) {
-			return -1;
-		}
-		return rows[activeSpan.index]?.id === activeSpan.id
-			? activeSpan.index
-			: rows.findIndex((row) => row.id === activeSpan.id);
-	}, [rows, activeSpan]);
-
-	const isRowActive = useCallback(
-		(row: TracesTableRow): boolean => row === rows[activeRowIndex],
-		[rows, activeRowIndex],
-	);
-
-	const handleNavigate = useCallback(
-		(row: TracesTableRow, index: number): void => {
-			setActiveSpan({ id: row.id, index });
-		},
-		[],
-	);
-
-	const selectRow = useCallback(
-		(row: TracesTableRow): void => handleNavigate(row, rows.indexOf(row)),
-		[handleNavigate, rows],
-	);
-
-	const clearActiveSpan = useCallback((): void => setActiveSpan(null), []);
-
-	// A refetch can drop the open span; forget it so a later page can't reopen it.
-	useEffect(() => {
-		if (activeSpan && activeRowIndex === -1) {
-			setActiveSpan(null);
-		}
-	}, [activeSpan, activeRowIndex]);
-
-	const onPressInside = useCloseOnOutsidePress(
-		isEnabled && activeRowIndex !== -1,
-		clearActiveSpan,
-	);
-
-	const navigation = useRowNavigation({
-		rows,
-		activeIndex: activeRowIndex,
-		onNavigate: handleNavigate,
-	});
-
-	if (!isEnabled) {
-		return { tableProps: {}, drawerProps: null, onPressInside };
-	}
-
-	return {
-		tableProps: { onRowClick: selectRow, isRowActive, activeRowIndex },
-		drawerProps: {
-			row: rows[activeRowIndex] ?? null,
-			onClose: clearActiveSpan,
-			navigation,
-		},
-		onPressInside,
-	};
-}

frontend/src/container/TracesExplorer/SpanDrawer/utils.ts

@@ -1,46 +0,0 @@
-import get from 'api/browser/localstorage/get';
-import { LOCALSTORAGE } from 'constants/localStorage';
-import { TracesTableRow } from 'container/TracesExplorer/TracesTable/getFieldColumn';
-import { SpanV3 } from 'types/api/trace/getTraceV3';
-
-/** Off by default; set `TRACES_SPAN_DRAWER_ENABLED` to `true` in localStorage to try it. */
-export const isSpanDrawerEnabled = (): boolean =>
-	get(LOCALSTORAGE.TRACES_SPAN_DRAWER_ENABLED) === 'true';
-
-type ListSpanEvent = {
-	name: string;
-	timeUnixNano: number;
-	attributes?: Record<string, string>;
-	isError?: boolean;
-};
-
-type ListSpanLink = { traceId: string; spanId: string };
-
-/**
- * The list API returns a span in a different shape from the trace API the
- * details panel was built on: an ISO timestamp, `attributes` on events, and
- * `links` in place of `references`.
- */
-export const toSpanV3 = (row: TracesTableRow): SpanV3 => {
-	const resource = (row.resource ?? {}) as Record<string, string>;
-	const events = (row.events ?? []) as ListSpanEvent[];
-	const links = (row.links ?? []) as ListSpanLink[];
-
-	return {
-		...row,
-		timestamp: new Date(row.timestamp as string).getTime(),
-		'service.name': resource['service.name'] ?? '',
-		events: events.map(({ attributes, isError, ...event }) => ({
-			...event,
-			attributeMap: attributes ?? {},
-			isError: isError ?? false,
-		})),
-		// The list API drops `refType`, so the parent ref is matched by id. A root
-		// span's parent ref has no span id.
-		references: links.filter(
-			(link) =>
-				!!link.spanId &&
-				(link.spanId !== row.parent_span_id || link.traceId !== row.trace_id),
-		),
-	} as unknown as SpanV3;
-};

frontend/src/container/TracesExplorer/TracesTable/TracesTable.tsx

@@ -24,10 +24,6 @@ export type TracesTableProps = {
 	panelType: PanelTypeKeys;
 	/** Builds the trace-detail href for a row; drives row click + cmd/ctrl-click. */
 	getRowHref: (row: TracesTableRow) => string;
-	/** Replaces the default row click, which opens the trace detail page. */
-	onRowClick?: (row: TracesTableRow) => void;
-	isRowActive?: (row: TracesTableRow) => boolean;
-	activeRowIndex?: number;
 	isLoading: boolean;
 	isFetching: boolean;
 	isError: boolean;
@@ -45,9 +41,6 @@ function TracesTable({
 	respectColumnOrder = false,
 	panelType,
 	getRowHref,
-	onRowClick,
-	isRowActive,
-	activeRowIndex,
 	isLoading,
 	isFetching,
 	isError,
@@ -64,13 +57,9 @@ function TracesTable({
 
 	const handleRowClick = useCallback(
 		(row: TracesTableRow): void => {
-			if (onRowClick) {
-				onRowClick(row);
-				return;
-			}
 			navigate(getRowHref(row));
 		},
-		[onRowClick, navigate, getRowHref],
+		[navigate, getRowHref],
 	);
 
 	const handleRowClickNewTab = useCallback(
@@ -108,8 +97,6 @@ function TracesTable({
 						onColumnRemove={onColumnRemove}
 						onRowClick={handleRowClick}
 						onRowClickNewTab={handleRowClickNewTab}
-						isRowActive={isRowActive}
-						activeRowIndex={activeRowIndex}
 						getRowTestId={(row): string => `traces-table-row-${row.id}`}
 						testId={`traces-table-${panelType.toLowerCase()}`}
 					/>
@@ -122,9 +109,6 @@ function TracesTable({
 TracesTable.defaultProps = {
 	columnStorageKey: undefined,
 	respectColumnOrder: false,
-	onRowClick: undefined,
-	isRowActive: undefined,
-	activeRowIndex: undefined,
 	onColumnOrderChange: undefined,
 	onColumnRemove: undefined,
 	cellTypographySize: 'medium',

frontend/src/hooks/__tests__/useCloseOnOutsidePress.test.tsx

@@ -1,107 +0,0 @@
-import { createPortal } from 'react-dom';
-import { render, screen, userEvent } from 'tests/test-utils';
-
-import { useCloseOnOutsidePress } from '../useCloseOnOutsidePress';
-
-function Harness({
-	enabled = true,
-	onClose,
-}: {
-	enabled?: boolean;
-	onClose: () => void;
-}): JSX.Element {
-	const onPressInside = useCloseOnOutsidePress(enabled, onClose);
-	return (
-		<>
-			<div onPointerDownCapture={onPressInside}>
-				<button type="button" data-testid="inside">
-					inside
-				</button>
-				<button
-					type="button"
-					data-testid="inside-stops"
-					onPointerDown={(e): void => e.stopPropagation()}
-				>
-					inside, stops propagation
-				</button>
-				{createPortal(
-					<button type="button" data-testid="inside-portal">
-						portal
-					</button>,
-					document.body,
-				)}
-			</div>
-			<button type="button" data-testid="outside">
-				outside
-			</button>
-			<button
-				type="button"
-				data-testid="outside-stops"
-				onPointerDown={(e): void => e.stopPropagation()}
-			>
-				outside, stops propagation
-			</button>
-		</>
-	);
-}
-
-const flush = (): Promise<void> =>
-	new Promise((resolve) => {
-		setTimeout(resolve);
-	});
-
-describe('useCloseOnOutsidePress', () => {
-	it('closes on a press outside', async () => {
-		const onClose = jest.fn() as jest.MockedFunction<() => void>;
-		render(<Harness onClose={onClose} />);
-
-		await userEvent.click(screen.getByTestId('outside'));
-		await flush();
-
-		expect(onClose).toHaveBeenCalledTimes(1);
-	});
-
-	it('stays open on a press inside, portals included', async () => {
-		const onClose = jest.fn() as jest.MockedFunction<() => void>;
-		render(<Harness onClose={onClose} />);
-
-		await userEvent.click(screen.getByTestId('inside'));
-		await userEvent.click(screen.getByTestId('inside-portal'));
-		await flush();
-
-		expect(onClose).not.toHaveBeenCalled();
-	});
-
-	it('closes when the outside element stops propagation', async () => {
-		const onClose = jest.fn() as jest.MockedFunction<() => void>;
-		render(<Harness onClose={onClose} />);
-
-		await userEvent.click(screen.getByTestId('outside-stops'));
-		await flush();
-
-		expect(onClose).toHaveBeenCalledTimes(1);
-	});
-
-	it('closes on the first outside press after an inside press stops propagation', async () => {
-		const onClose = jest.fn() as jest.MockedFunction<() => void>;
-		render(<Harness onClose={onClose} />);
-
-		await userEvent.click(screen.getByTestId('inside-stops'));
-		await flush();
-		expect(onClose).not.toHaveBeenCalled();
-
-		await userEvent.click(screen.getByTestId('outside'));
-		await flush();
-		expect(onClose).toHaveBeenCalledTimes(1);
-	});
-
-	it('does nothing while disabled', async () => {
-		const onClose = jest.fn() as jest.MockedFunction<() => void>;
-		render(<Harness enabled={false} onClose={onClose} />);
-
-		await userEvent.click(screen.getByTestId('outside'));
-		await flush();
-
-		expect(onClose).not.toHaveBeenCalled();
-	});
-});

frontend/src/hooks/__tests__/useDebouncedFunction.test.ts

@@ -1,43 +0,0 @@
-import { renderHook } from '@testing-library/react';
-
-import useDebouncedFn from '../useDebouncedFunction';
-
-describe('useDebouncedFn', () => {
-	beforeEach(() => {
-		jest.useFakeTimers();
-	});
-
-	afterEach(() => {
-		jest.useRealTimers();
-	});
-
-	it('should debounce function execution', () => {
-		const callback = jest.fn();
-		const { result } = renderHook(() => useDebouncedFn(callback, 300));
-
-		result.current('first');
-		result.current('second');
-
-		expect(callback).not.toHaveBeenCalled();
-
-		jest.advanceTimersByTime(299);
-		expect(callback).not.toHaveBeenCalled();
-
-		jest.advanceTimersByTime(1);
-		expect(callback).toHaveBeenCalledTimes(1);
-		expect(callback).toHaveBeenCalledWith('second');
-	});
-
-	it('should cancel pending execution when unmounted (Bug 55)', () => {
-		const callback = jest.fn();
-		const { result, unmount } = renderHook(() => useDebouncedFn(callback, 300));
-
-		result.current('pending');
-		expect(callback).not.toHaveBeenCalled();
-
-		unmount();
-
-		jest.advanceTimersByTime(500);
-		expect(callback).not.toHaveBeenCalled();
-	});
-});

frontend/src/hooks/integration/aws/useIntegrationModal.ts

@@ -14,10 +14,9 @@ import {
 	GetConnectionCredentialsQueryResult,
 	invalidateListAccounts,
 	useCreateAccount,
-	useGetConnectionCredentials,
 } from 'api/generated/services/cloudintegration';
+import { useGetConnectionCredentials } from 'api/generated/services/cloudintegration';
 import {
-	CloudintegrationtypesAccountDTO,
 	CloudintegrationtypesCredentialsDTO,
 	CloudintegrationtypesPostableAccountDTO,
 } from 'api/generated/services/sigNoz.schemas';
@@ -30,7 +29,6 @@ import useAxiosError from 'hooks/useAxiosError';
 import { regions } from 'utils/regions';
 
 import logEvent from '../../../api/common/logEvent';
-import { useAgentConnectionPolling } from '../useAgentConnectionPolling';
 
 interface UseIntegrationModalProps {
 	onClose: () => void;
@@ -44,8 +42,7 @@ interface UseIntegrationModal {
 	activeView: ActiveViewEnum;
 	selectedRegions: string[];
 	includeAllRegions: boolean;
-	isGeneratingCommand: boolean;
-	connectionCommand: string | null;
+	isGeneratingUrl: boolean;
 	setSelectedRegions: Dispatch<SetStateAction<string[]>>;
 	setIncludeAllRegions: Dispatch<SetStateAction<boolean>>;
 	handleRegionSelect: () => void;
@@ -53,11 +50,17 @@ interface UseIntegrationModal {
 	handleClose: () => void;
 	setActiveView: (view: ActiveViewEnum) => void;
 	allRegions: string[];
+	accountId?: string;
 	selectedDeploymentRegion: string | undefined;
 	handleRegionChange: (value: string) => void;
 	connectionParams?: CloudintegrationtypesCredentialsDTO;
 	isConnectionParamsLoading: boolean;
-	checkConnectionAgain: () => void;
+	handleConnectionSuccess: (payload: {
+		cloudAccountId: string;
+		status?: unknown;
+	}) => void;
+	handleConnectionTimeout: (payload: { id?: string }) => void;
+	handleConnectionError: () => void;
 }
 
 export function useIntegrationModal({
@@ -70,9 +73,6 @@ export function useIntegrationModal({
 	);
 	const [isLoading, setIsLoading] = useState(false);
 	const [accountId, setAccountId] = useState<string | undefined>();
-	const [connectionCommand, setConnectionCommand] = useState<string | null>(
-		null,
-	);
 	const [activeView, setActiveView] = useState<ActiveViewEnum>(
 		ActiveViewEnum.FORM,
 	);
@@ -103,15 +103,14 @@ export function useIntegrationModal({
 		setSelectedRegions([]);
 		setIncludeAllRegions(false);
 		setModalState(ModalStateEnum.FORM);
-		setConnectionCommand(null);
 		onClose();
 	}, [onClose]);
 
 	const handleConnectionSuccess = useCallback(
-		(account: CloudintegrationtypesAccountDTO): void => {
+		(payload: { cloudAccountId: string; status?: unknown }): void => {
 			void logEvent('AWS Integration: Account connected', {
-				cloudAccountId: account.providerAccountId ?? account.id,
-				status: account.agentReport,
+				cloudAccountId: payload.cloudAccountId,
+				status: payload.status,
 			});
 			toast.success('AWS account connected successfully', {
 				position: 'bottom-right',
@@ -124,32 +123,21 @@ export function useIntegrationModal({
 		[handleClose, queryClient],
 	);
 
-	const handleConnectionTimeout = useCallback((): void => {
-		setModalState(ModalStateEnum.ERROR);
-		void logEvent('AWS Integration: Account connection attempt timed out', {
-			id: accountId,
-		});
-	}, [accountId]);
+	const handleConnectionTimeout = useCallback(
+		(payload: { id?: string }): void => {
+			setModalState(ModalStateEnum.ERROR);
+			void logEvent('AWS Integration: Account connection attempt timed out', {
+				id: payload.id,
+			});
+		},
+		[],
+	);
 
 	const handleConnectionError = useCallback((): void => {
 		setModalState(ModalStateEnum.ERROR);
 	}, []);
 
-	const checkConnectionAgain = useCallback((): void => {
-		setModalState(ModalStateEnum.WAITING);
-	}, []);
-
-	useAgentConnectionPolling({
-		cloudProvider: INTEGRATION_TYPES.AWS,
-		accountId: accountId ?? '',
-		enabled: modalState === ModalStateEnum.WAITING && accountId !== undefined,
-		onConnected: handleConnectionSuccess,
-		onTimeout: handleConnectionTimeout,
-		onError: handleConnectionError,
-	});
-
-	const { mutate: createAccount, isLoading: isGeneratingCommand } =
-		useCreateAccount();
+	const { mutate: generateUrl, isLoading: isGeneratingUrl } = useCreateAccount();
 
 	const handleError = useAxiosError();
 	const { data: connectionParams, isLoading: isConnectionParamsLoading } =
@@ -164,9 +152,9 @@ export function useIntegrationModal({
 			},
 		);
 
-	const handleGenerateCommand = useCallback(
+	const handleGenerateUrl = useCallback(
 		(payload: CloudintegrationtypesPostableAccountDTO): void => {
-			createAccount(
+			generateUrl(
 				{
 					pathParams: { cloudProvider: INTEGRATION_TYPES.AWS },
 					data: payload,
@@ -174,19 +162,17 @@ export function useIntegrationModal({
 				{
 					onSuccess: (response: CreateAccountMutationResult) => {
 						const accountId = response.data.id;
-						const command = response.data.connectionArtifact.aws?.cliCommand;
-						if (!command) {
-							setModalState(ModalStateEnum.ERROR);
-							toast.error('Failed to generate the AWS setup command', {
-								position: 'bottom-right',
-							});
-							return;
-						}
+						const connectionUrl =
+							response.data.connectionArtifact.aws?.connectionUrl ?? '';
 
-						void logEvent('AWS Integration: Account connection command generated', {
-							id: accountId,
-						});
-						setConnectionCommand(command);
+						void logEvent(
+							'AWS Integration: Account connection attempt redirected to AWS',
+							{
+								id: accountId,
+							},
+						);
+						// oxlint-disable-next-line signoz/no-raw-absolute-path -- connectionUrl is an external AWS console URL, not an internal path
+						window.open(connectionUrl, '_blank');
 						setModalState(ModalStateEnum.WAITING);
 						setAccountId(accountId);
 					},
@@ -199,7 +185,7 @@ export function useIntegrationModal({
 				},
 			);
 		},
-		[createAccount],
+		[generateUrl],
 	);
 
 	const handleSubmit = useCallback(async (): Promise<void> => {
@@ -222,13 +208,13 @@ export function useIntegrationModal({
 				},
 			};
 
-			handleGenerateCommand(payload);
+			handleGenerateUrl(payload);
 		} catch (error) {
 			console.error('Form submission failed:', error);
 		} finally {
 			setIsLoading(false);
 		}
-	}, [form, selectedRegions, handleGenerateCommand, connectionParams]);
+	}, [form, selectedRegions, handleGenerateUrl, connectionParams]);
 
 	return {
 		form,
@@ -237,8 +223,7 @@ export function useIntegrationModal({
 		activeView,
 		selectedRegions,
 		includeAllRegions,
-		isGeneratingCommand,
-		connectionCommand,
+		isGeneratingUrl,
 		setSelectedRegions,
 		setIncludeAllRegions,
 		handleRegionSelect,
@@ -246,6 +231,7 @@ export function useIntegrationModal({
 		handleClose,
 		setActiveView,
 		allRegions,
+		accountId,
 		setModalState,
 		selectedDeploymentRegion,
 		handleRegionChange,
@@ -253,6 +239,8 @@ export function useIntegrationModal({
 			| CloudintegrationtypesCredentialsDTO
 			| undefined,
 		isConnectionParamsLoading,
-		checkConnectionAgain,
+		handleConnectionSuccess,
+		handleConnectionTimeout,
+		handleConnectionError,
 	};
 }

frontend/src/hooks/integration/azure/useIntegrationModal.ts

@@ -10,7 +10,6 @@ import {
 	useGetConnectionCredentials,
 } from 'api/generated/services/cloudintegration';
 import {
-	CloudintegrationtypesAccountDTO,
 	CloudintegrationtypesCredentialsDTO,
 	CloudintegrationtypesPostableAccountDTO,
 } from 'api/generated/services/sigNoz.schemas';
@@ -19,7 +18,6 @@ import { ModalStateEnum } from 'container/Integrations/HeroSection/types';
 import useAxiosError from 'hooks/useAxiosError';
 
 import logEvent from '../../../api/common/logEvent';
-import { useAgentConnectionPolling } from '../useAgentConnectionPolling';
 
 interface UseIntegrationModalProps {
 	onClose: () => void;
@@ -29,13 +27,22 @@ interface UseAzureIntegrationModal {
 	form: FormInstance;
 	modalState: ModalStateEnum;
 	isLoading: boolean;
-	connectionCommand: string | null;
+	accountId?: string;
+	connectionCommands: {
+		cliCommand: string;
+		cloudPowerShellCommand: string;
+	} | null;
 	setModalState: Dispatch<SetStateAction<ModalStateEnum>>;
 	handleSubmit: () => Promise<void>;
 	handleClose: () => void;
 	connectionParams?: CloudintegrationtypesCredentialsDTO;
 	isConnectionParamsLoading: boolean;
-	checkConnectionAgain: () => void;
+	handleConnectionSuccess: (payload: {
+		cloudAccountId: string;
+		status?: unknown;
+	}) => void;
+	handleConnectionTimeout: (payload: { id?: string }) => void;
+	handleConnectionError: () => void;
 }
 
 export function useIntegrationModal({
@@ -48,21 +55,22 @@ export function useIntegrationModal({
 	);
 	const [isLoading, setIsLoading] = useState(false);
 	const [accountId, setAccountId] = useState<string | undefined>(undefined);
-	const [connectionCommand, setConnectionCommand] = useState<string | null>(
-		null,
-	);
+	const [connectionCommands, setConnectionCommands] = useState<{
+		cliCommand: string;
+		cloudPowerShellCommand: string;
+	} | null>(null);
 
 	const handleClose = useCallback((): void => {
 		setModalState(ModalStateEnum.FORM);
-		setConnectionCommand(null);
+		setConnectionCommands(null);
 		onClose();
 	}, [onClose]);
 
 	const handleConnectionSuccess = useCallback(
-		(account: CloudintegrationtypesAccountDTO): void => {
-			void logEvent('Azure Integration: Account connected', {
-				cloudAccountId: account.providerAccountId ?? account.id,
-				status: account.agentReport,
+		(payload: { cloudAccountId: string; status?: unknown }): void => {
+			logEvent('Azure Integration: Account connected', {
+				cloudAccountId: payload.cloudAccountId,
+				status: payload.status,
 			});
 			toast.success('Azure account connected successfully', {
 				position: 'bottom-right',
@@ -75,30 +83,20 @@ export function useIntegrationModal({
 		[handleClose, queryClient],
 	);
 
-	const handleConnectionTimeout = useCallback((): void => {
-		setModalState(ModalStateEnum.ERROR);
-		void logEvent('Azure Integration: Account connection attempt timed out', {
-			id: accountId,
-		});
-	}, [accountId]);
+	const handleConnectionTimeout = useCallback(
+		(payload: { id?: string }): void => {
+			setModalState(ModalStateEnum.ERROR);
+			logEvent('Azure Integration: Account connection attempt timed out', {
+				id: payload.id,
+			});
+		},
+		[],
+	);
 
 	const handleConnectionError = useCallback((): void => {
 		setModalState(ModalStateEnum.ERROR);
 	}, []);
 
-	const checkConnectionAgain = useCallback((): void => {
-		setModalState(ModalStateEnum.WAITING);
-	}, []);
-
-	useAgentConnectionPolling({
-		cloudProvider: INTEGRATION_TYPES.AZURE,
-		accountId: accountId ?? '',
-		enabled: modalState === ModalStateEnum.WAITING && accountId !== undefined,
-		onConnected: handleConnectionSuccess,
-		onTimeout: handleConnectionTimeout,
-		onError: handleConnectionError,
-	});
-
 	const { mutate: createAccount } = useCreateAccount();
 	const handleError = useAxiosError();
 
@@ -142,20 +140,16 @@ export function useIntegrationModal({
 				{
 					onSuccess: (response: CreateAccountMutationResult) => {
 						const nextAccountId = response.data.id;
-						const command = response.data.connectionArtifact.azure?.cliCommand;
-						if (!command) {
-							setModalState(ModalStateEnum.ERROR);
-							toast.error('Failed to generate the Azure setup command', {
-								position: 'bottom-right',
-							});
-							return;
-						}
+						const artifact = response.data.connectionArtifact.azure;
 
-						void logEvent('Azure Integration: Account connection command generated', {
+						logEvent('Azure Integration: Account connection commands generated', {
 							id: nextAccountId,
 						});
 
-						setConnectionCommand(command);
+						setConnectionCommands({
+							cliCommand: artifact?.cliCommand || '',
+							cloudPowerShellCommand: artifact?.cloudPowerShellCommand || '',
+						});
 						setModalState(ModalStateEnum.WAITING);
 						setAccountId(nextAccountId);
 					},
@@ -178,7 +172,8 @@ export function useIntegrationModal({
 		form,
 		modalState,
 		isLoading,
-		connectionCommand,
+		accountId,
+		connectionCommands,
 		setModalState,
 		handleSubmit,
 		handleClose,
@@ -186,6 +181,8 @@ export function useIntegrationModal({
 			| CloudintegrationtypesCredentialsDTO
 			| undefined,
 		isConnectionParamsLoading,
-		checkConnectionAgain,
+		handleConnectionSuccess,
+		handleConnectionTimeout,
+		handleConnectionError,
 	};
 }

frontend/src/hooks/integration/gcp/__tests__/useAgentConnectionPolling.test.tsx

@@ -22,7 +22,6 @@ const renderPolling = (): void => {
 	renderHook(
 		() =>
 			useAgentConnectionPolling({
-				cloudProvider: 'gcp',
 				accountId: ACCOUNT_ID,
 				enabled: true,
 				...callbacks,

frontend/src/hooks/integration/gcp/__tests__/useAgentConnectionPollingWindow.test.tsx

@@ -21,7 +21,6 @@ const renderPolling = (
 	const { rerender } = renderHook(
 		({ enabled }: { enabled: boolean }) =>
 			useAgentConnectionPolling({
-				cloudProvider: 'gcp',
 				accountId: ACCOUNT_ID,
 				enabled,
 				...callbacks,

frontend/src/hooks/integration/gcp/useAgentAccountSetup.ts

@@ -5,11 +5,10 @@ import {
 	CloudintegrationtypesGCPConnectionMethodDTO,
 } from 'api/generated/services/sigNoz.schemas';
 import { GcpSetupFormValues } from 'container/Integrations/CloudIntegration/GoogleCloudPlatform/AddNewAccount/types';
-import { INTEGRATION_TYPES } from 'container/Integrations/constants';
 import { ModalStateEnum } from 'container/Integrations/HeroSection/types';
 
 import logEvent from '../../../api/common/logEvent';
-import { useAgentConnectionPolling } from '../useAgentConnectionPolling';
+import { useAgentConnectionPolling } from './useAgentConnectionPolling';
 import { useGcpAccountSetup } from './useGcpAccountSetup';
 
 const GENERATE_COMMAND_ERROR = 'Failed to generate the GCP setup command';
@@ -117,7 +116,6 @@ export function useAgentAccountSetup({
 	}, []);
 
 	useAgentConnectionPolling({
-		cloudProvider: INTEGRATION_TYPES.GCP,
 		accountId: accountId ?? '',
 		enabled: modalState === ModalStateEnum.WAITING && accountId !== null,
 		onConnected: handleAgentConnected,

frontend/src/hooks/integration/gcp/useAgentConnectionPolling.ts

@@ -1,12 +1,12 @@
 import { useEffect, useRef } from 'react';
 import { useGetAccount } from 'api/generated/services/cloudintegration';
 import { CloudintegrationtypesAccountDTO } from 'api/generated/services/sigNoz.schemas';
+import { INTEGRATION_TYPES } from 'container/Integrations/constants';
 
 export const POLL_INTERVAL_MS = 10 * 1000;
 export const CONNECTION_TIMEOUT_MS = 10 * 60 * 1000;
 
 interface UseAgentConnectionPollingProps {
-	cloudProvider: string;
 	accountId: string;
 	/** Polls exactly while true; the caller decides when there is an account to poll. */
 	enabled: boolean;
@@ -16,11 +16,10 @@ interface UseAgentConnectionPollingProps {
 }
 
 /**
- * Polls a cloud integration account until its agent checks in. The timeout is
- * measured from when polling gets enabled, so re-enabling it starts a fresh window.
+ * Polls a GCP agent account until the agent checks in. The timeout is measured
+ * from when polling gets enabled, so re-enabling it starts a fresh window.
  */
 export function useAgentConnectionPolling({
-	cloudProvider,
 	accountId,
 	enabled,
 	onConnected,
@@ -34,7 +33,7 @@ export function useAgentConnectionPolling({
 	}, [enabled]);
 
 	useGetAccount(
-		{ cloudProvider, id: accountId },
+		{ cloudProvider: INTEGRATION_TYPES.GCP, id: accountId },
 		{
 			query: {
 				enabled,

frontend/src/hooks/useCloseOnOutsidePress.ts

@@ -1,51 +0,0 @@
-import {
-	PointerEvent as ReactPointerEvent,
-	useCallback,
-	useEffect,
-	useRef,
-} from 'react';
-
-/**
- * Calls `onClose` on any press outside the elements given the returned handler as
- * `onPointerDownCapture`. Menus and dialogs rendered in portals still count as
- * inside: React events follow the component tree.
- *
- * The document listener runs in the capture phase, so an outside element that
- * stops propagation still closes. It runs before React marks the press, so the
- * check waits for the dispatch to finish.
- */
-export function useCloseOnOutsidePress(
-	enabled: boolean,
-	onClose: () => void,
-): (event: ReactPointerEvent) => void {
-	const insidePress = useRef<Event | null>(null);
-	const onCloseRef = useRef(onClose);
-	onCloseRef.current = onClose;
-
-	useEffect(() => {
-		if (!enabled) {
-			return undefined;
-		}
-		const timeouts = new Set<ReturnType<typeof setTimeout>>();
-
-		const handlePointerDown = (event: PointerEvent): void => {
-			const timeout = setTimeout(() => {
-				timeouts.delete(timeout);
-				if (insidePress.current !== event) {
-					onCloseRef.current();
-				}
-			});
-			timeouts.add(timeout);
-		};
-
-		document.addEventListener('pointerdown', handlePointerDown, true);
-		return (): void => {
-			document.removeEventListener('pointerdown', handlePointerDown, true);
-			timeouts.forEach(clearTimeout);
-		};
-	}, [enabled]);
-
-	return useCallback((event: ReactPointerEvent): void => {
-		insidePress.current = event.nativeEvent;
-	}, []);
-}

frontend/src/hooks/useDebouncedFunction.ts

@@ -1,4 +1,4 @@
-import { useEffect, useMemo, useRef } from 'react';
+import { useMemo, useRef } from 'react';
 import debounce from 'lodash-es/debounce';
 
 export interface DebouncedFunc<T extends (...args: unknown[]) => unknown> {
@@ -28,19 +28,10 @@ const useDebouncedFn = <T extends (...args: Array<unknown>) => unknown>(
 	const fnRef = useRef(fn);
 	fnRef.current = fn;
 
-	const debounced = useMemo(
+	return useMemo(
 		() => debounce(((...args) => fnRef.current(...args)) as T, wait, options),
 		[options, wait],
 	);
-
-	useEffect(
-		() => (): void => {
-			debounced.cancel();
-		},
-		[debounced],
-	);
-
-	return debounced;
 };
 
 export default useDebouncedFn;

frontend/src/pages/AlertList/PlannedDowntime/stories/PlannedDowntime.stories.tsx

@@ -111,7 +111,7 @@ export const NewDowntimeRecurring: Story = {
 			await screen.findByRole('combobox', { name: 'Repeats every' }),
 		);
 		await userEvent.click(await screen.findByText('Weekly'));
-		await within(await screen.findByRole('dialog')).findByText('Duration');
+		await screen.findByText('Duration');
 	},
 };