SigNoz/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2026-02-03 08:33:26 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

feat: add abs value function in formula (#9315)

Browse Source 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
This commit is contained in:
Niladri Adhikary
2025-10-12 16:45:59 +05:30
committed by GitHub
parent 5005cae2ad
commit 43a6c7dcd6
4 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/query-service/app/queryBuilder/query_builder.go
View File

@@ -13,6 +13,7 @@ import (
)
var SupportedFunctions = []string{
"abs",
"exp",
"log",
"ln",

6
pkg/query-service/postprocess/formula.go
View File

@@ -197,10 +197,14 @@ func processResults(
}, nil
}
var SupportedFunctions = []string{"exp", "log", "ln", "exp2", "log2", "exp10", "log10", "sqrt", "cbrt", "erf", "erfc", "lgamma", "tgamma", "sin", "cos", "tan", "asin", "acos", "atan", "degrees", "radians", "now", "toUnixTimestamp"}
var SupportedFunctions = []string{"abs", "exp", "log", "ln", "exp2", "log2", "exp10", "log10", "sqrt", "cbrt", "erf", "erfc", "lgamma", "tgamma", "sin", "cos", "tan", "asin", "acos", "atan", "degrees", "radians", "now", "toUnixTimestamp"}
func EvalFuncs() map[string]govaluate.ExpressionFunction {
GoValuateFuncs := make(map[string]govaluate.ExpressionFunction)
// Returns the absolute value of the given argument.
GoValuateFuncs["abs"] = func(args ...interface{}) (interface{}, error) {
return math.Abs(args[0].(float64)), nil
}
// Returns e to the power of the given argument.
GoValuateFuncs["exp"] = func(args ...interface{}) (interface{}, error) {
return math.Exp(args[0].(float64)), nil

5
pkg/types/querybuildertypes/querybuildertypesv5/formula.go
View File

@@ -545,6 +545,9 @@ func EvalFuncs() map[string]govaluate.ExpressionFunction {
rad180 := 180 / math.Pi
// Mathematical functions
funcs["abs"] = func(args ...any) (any, error) {
return math.Abs(args[0].(float64)), nil
}
funcs["exp"] = func(args ...any) (any, error) {
return math.Exp(args[0].(float64)), nil
}
@@ -623,7 +626,7 @@ func EvalFuncs() map[string]govaluate.ExpressionFunction {
// GetSupportedFunctions returns the list of supported function names
func GetSupportedFunctions() []string {
return []string{
"exp", "log", "ln", "exp2", "log2", "exp10", "log10",
"abs", "exp", "log", "ln", "exp2", "log2", "exp10", "log10",
"sqrt", "cbrt", "erf", "erfc", "lgamma", "tgamma",
"sin", "cos", "tan", "asin", "acos", "atan",
"degrees", "radians", "now",

36
pkg/types/querybuildertypes/querybuildertypesv5/formula_test.go
View File

@@ -863,3 +863,39 @@ func TestComplexExpression(t *testing.T) {
}
}
}
func TestAbsValueExpression(t *testing.T) {
tsData := map[string]*TimeSeriesData{
"A": createFormulaTestTimeSeriesData("A", []*TimeSeries{
{
Labels: createLabels(map[string]string{"service_name": "frontend"}),
Values: createValues(map[int64]float64{
1: -10,
2: 20,
}),
},
}),
"B": createFormulaTestTimeSeriesData("B", []*TimeSeries{
{
Labels: createLabels(map[string]string{"service_name": "frontend"}),
Values: createValues(map[int64]float64{
1: 5,
2: -4,
}),
},
}),
}
evaluator, err := NewFormulaEvaluator("abs(A) + abs(B)", map[string]bool{"A": true, "B": true})
require.NoError(t, err)
result, err := evaluator.EvaluateFormula(tsData)
require.NoError(t, err)
require.NotNil(t, result)
require.Equal(t, 1, len(result))
series := result[0]
require.Equal(t, 2, len(series.Values))
assert.Equal(t, 15.0, series.Values[0].Value) // |−10| + |5| = 15
assert.Equal(t, 24.0, series.Values[1].Value) // |20| + |−4| = 24
}