usnistgov/macos_security
1
0
Fork 0
mirror of https://github.com/usnistgov/macos_security.git synced 2026-02-03 05:53:24 +00:00
Code Issues 21 Actions Packages Projects Releases Wiki Activity

compliance_count function in generated guidance script does not correctly count findings #276

New Issue
Closed
opened 2026-01-19 18:29:54 +00:00 by michael · 2 comments
michael commented 2026-01-19 18:29:54 +00:00
Owner
Copy Link

Originally created by @bernstei on GitHub.

From what I can tell, compliance_count tries to count the number of findings, but it just looks through the output of PlistBuddy -c looking for true or false, without checking if those are for the finding or exempt fields:
932a51f3e8/scripts/generate_guidance.py (L671)
As a result, it will miscount findings.

Originally created by @bernstei on GitHub. From what I can tell, `compliance_count` tries to count the number of findings, but it just looks through the output of `PlistBuddy -c` looking for true or false, without checking if those are for the `finding` or `exempt` fields: https://github.com/usnistgov/macos_security/blob/932a51f3e819dd3e02ebfcf3ef433cfffafbe28b/scripts/generate_guidance.py#L671 As a result, it will miscount findings.
michael commented 2026-01-19 18:29:54 +00:00
Author
Owner
Copy Link

@golbiga commented on GitHub:

Thanks again, it's now checking for "finding = false" so it will no longer count the exempt fields.

@golbiga commented on GitHub: Thanks again, it's now checking for `"finding = false"` so it will no longer count the `exempt` fields.
michael commented 2026-01-19 18:29:54 +00:00
Author
Owner
Copy Link

@bernstei commented on GitHub:

Thanks for the quick response.

@bernstei commented on GitHub: Thanks for the quick response.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
michael
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: usnistgov/macos_security#276
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?