usnistgov/macos_security
1
0
Fork 0
mirror of https://github.com/usnistgov/macos_security.git synced 2026-02-03 14:03:24 +00:00
Code Issues 21 Actions Packages Projects Releases Wiki Activity

JXA Checks are causing the generated baseline_compliance.sh to break #261

New Issue
Closed
opened 2026-01-19 18:29:51 +00:00 by michael · 2 comments
michael commented 2026-01-19 18:29:51 +00:00
Owner
Copy Link

Originally created by @jordanburnette on GitHub.

Summary

When running generate_guidance.py on dev_cis_moneterey branch for cis_lvl1 rules, the newly updated checks that leverage javascript are preventing the created to break. See Screenshot below of an example from the generated script:

Steps to reproduce

  • Pull dev_cis_monterey and run generate_guidance.py baselines/cis_lvl1.yaml -s to generate the compliance script
  • Attempts to run the cis_lvl1_compliance.sh return parse errors
  • Viewing the script in VSCode shows where things start to get a little wonky (see picture in the screenshots section)

Operating System version

macOS Monterey 12.X

What is the current bug behavior?

When running the script on a targeted machine, parse errors show

What is the expected correct behavior?

The compliance script should be able to run properly without giving parse error, allowing one to run

Relevant logs and/or screenshots

(contents of cis_lvl1_compliance.sh created from generate_guidance.py at the point of the first jxa check @ Line 1003)
Screen Shot 2022-02-10 at 3 37 54 PM

Output of checks

(line items will vary on your testing since I am not using all the rules)
cis_lvl1_compliance.sh:5089: parse error
cis_lvl1_compliance.sh:5275: parse error near 'result_value=$(/usr/...'

Possible fixes

Not sure TBH. May require some work on the generate_guidance.py script to allow the compiled script to maintain the Javascript checks when they are being used.

Originally created by @jordanburnette on GitHub. <!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate. ---> ### Summary When running `generate_guidance.py` on dev_cis_moneterey branch for cis_lvl1 rules, the newly updated checks that leverage javascript are preventing the created to break. See Screenshot below of an example from the generated script: ### Steps to reproduce - Pull dev_cis_monterey and run `generate_guidance.py baselines/cis_lvl1.yaml -s` to generate the compliance script - Attempts to run the cis_lvl1_compliance.sh return parse errors - Viewing the script in VSCode shows where things start to get a little wonky (see picture in the screenshots section) ### Operating System version macOS Monterey 12.X ### What is the current *bug* behavior? When running the script on a targeted machine, parse errors show ### What is the expected *correct* behavior? The compliance script should be able to run properly without giving parse error, allowing one to run ### Relevant logs and/or screenshots (contents of cis_lvl1_compliance.sh created from generate_guidance.py at the point of the first jxa check @ Line 1003) ![Screen Shot 2022-02-10 at 3 37 54 PM](https://user-images.githubusercontent.com/65682475/153495197-6125df5d-cf1a-4566-9265-101b68461293.png) ### Output of checks (line items will vary on your testing since I am not using all the rules) `cis_lvl1_compliance.sh:5089: parse error` `cis_lvl1_compliance.sh:5275: parse error near 'result_value=$(/usr/...'` ### Possible fixes Not sure TBH. May require some work on the `generate_guidance.py` script to allow the compiled script to maintain the Javascript checks when they are being used.
michael commented 2026-01-19 18:29:51 +00:00
Author
Owner
Copy Link

@robertgendler commented on GitHub:

Fixed in dev_monterey!

1 rule had
check: not check:|

@robertgendler commented on GitHub: Fixed in dev_monterey! 1 rule had check: not check:|
michael commented 2026-01-19 18:29:51 +00:00
Author
Owner
Copy Link

@jordanburnette commented on GitHub:

Confirmed to be fixed.

@jordanburnette commented on GitHub: Confirmed to be fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
michael
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: usnistgov/macos_security#261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?