mirror of
https://github.com/usnistgov/macos_security.git
synced 2026-02-03 05:53:24 +00:00
Compliance percentage incorrect when exempted rules pass #267 “best practice!!! #160
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BrendaHubbell on GitHub.
Apologies for the mistake. Let's recalculate the compliance percentage considering the exempted rules as passed tests:
Total tests attempted = Number of tests passed + Number of tests failed + Number of exempt rules
= 55 + 69 + 13
= 137
Number of compliant tests = Number of tests passed + Number of exempt rules
= 55 + 13
= 68
Compliance percentage = (Number of compliant tests / Total tests attempted) * 100
= (68 / 137) * 100
≈ 49.64%
Therefore, the correct compliance percentage is approximately 49.64%.
@bernstei commented on GitHub:
This math makes some assumptions about which tests are in which category, and those are not explicitly specified here. I think the logic in the
compliance_countfunction created bygenerate_guidance.pyis not consistent with the assumptions made here.@brodjieski commented on GitHub:
Closing this issue, as it's a continued discussion of the open issue #267.