mirror of
https://github.com/webmin/webmin.git
synced 2026-02-17 20:22:15 +00:00
All $err type error messages in HTML are safely escaped now.
URL-encoding in links:
I have implemented urlize() in all places where user input ($in{'device'}, $in{'slice'}, $in{'part'}) was included in the URL (footer/redirect/other link), e.g. edit_slice.cgi?device=...&slice=....
Affected files include: create_part.cgi, create_slice.cgi, delete_part.cgi, delete_slice.cgi, change_slice_label.cgi, part_form.cgi, slice_form.cgi, edit_slice.cgi, edit_part.cgi, fsck.cgi, newfs.cgi, newfs_form.cgi, save_part.cgi, save_slice.cgi, save_slice_label.cgi, zfs_create.cgi, zvol_create.cgi.
45 lines
1.6 KiB
Perl
Executable File
45 lines
1.6 KiB
Perl
Executable File
#!/usr/local/bin/perl
|
|
# Change the type of a partition
|
|
|
|
use strict;
|
|
use warnings;
|
|
no warnings 'redefine';
|
|
no warnings 'uninitialized';
|
|
require './bsdfdisk-lib.pl';
|
|
our ( %in, %text, $module_name );
|
|
&ReadParse();
|
|
&error_setup( $text{'part_err'} );
|
|
|
|
# Get the disk and slice
|
|
my @disks = &list_disks_partitions();
|
|
$in{'device'} =~ /^[a-zA-Z0-9_\/.-]+$/
|
|
or &error( $text{'disk_edevice'} || 'Invalid device' );
|
|
$in{'device'} !~ /\.\./ or &error( $text{'disk_edevice'} || 'Invalid device' );
|
|
$in{'slice'} =~ /^\d+$/ or &error( $text{'slice_egone'} );
|
|
$in{'part'} =~ /^[a-z]$/ or &error( $text{'part_egone'} );
|
|
my ($disk) = grep { $_->{'device'} eq $in{'device'} } @disks;
|
|
$disk || &error( $text{'disk_egone'} );
|
|
my ($slice) = grep { $_->{'number'} eq $in{'slice'} } @{ $disk->{'slices'} };
|
|
$slice || &error( $text{'slice_egone'} );
|
|
my ($part) = grep { $_->{'letter'} eq $in{'part'} } @{ $slice->{'parts'} };
|
|
$part || &error( $text{'part_egone'} );
|
|
|
|
# Check if in use
|
|
my @st = &fdisk::device_status( $part->{'device'} );
|
|
my $use = &fdisk::device_status_link(@st);
|
|
if ( @st && $st[2] ) {
|
|
&error( &text( 'part_esave', &html_escape($use) ) );
|
|
}
|
|
|
|
# Make the change
|
|
$in{'type'} =~ /^[a-zA-Z0-9._-]+$/
|
|
or &error( $text{'part_etype'} || 'Invalid partition type' );
|
|
$part->{'type'} = $in{'type'};
|
|
my $err = &save_partition( $disk, $slice, $part );
|
|
&error( &html_escape($err) ) if ($err);
|
|
|
|
&webmin_log( "modify", "part", $part->{'device'}, $part );
|
|
my $url_device = &urlize( $in{'device'} );
|
|
my $url_slice = &urlize( $in{'slice'} );
|
|
&redirect("edit_slice.cgi?device=$url_device&slice=$url_slice");
|