mirror of
https://github.com/webmin/webmin.git
synced 2026-02-09 00:39:57 +00:00
b593501cff
All $err type error messages in HTML are safely escaped now.
URL-encoding in links:
I have implemented urlize() in all places where user input ($in{'device'}, $in{'slice'}, $in{'part'}) was included in the URL (footer/redirect/other link), e.g. edit_slice.cgi?device=...&slice=....
Affected files include: create_part.cgi, create_slice.cgi, delete_part.cgi, delete_slice.cgi, change_slice_label.cgi, part_form.cgi, slice_form.cgi, edit_slice.cgi, edit_part.cgi, fsck.cgi, newfs.cgi, newfs_form.cgi, save_part.cgi, save_slice.cgi, save_slice_label.cgi, zfs_create.cgi, zvol_create.cgi.
59 lines
2.0 KiB
Perl
Executable File
59 lines
2.0 KiB
Perl
Executable File
#!/usr/local/bin/perl
|
|
# Change the type of a slice
|
|
|
|
use strict;
|
|
use warnings;
|
|
no warnings 'redefine';
|
|
no warnings 'uninitialized';
|
|
require './bsdfdisk-lib.pl';
|
|
our ( %in, %text, $module_name );
|
|
&ReadParse();
|
|
&error_setup( $text{'slice_err'} );
|
|
|
|
# Get the disk and slice
|
|
my @disks = &list_disks_partitions();
|
|
$in{'device'} =~ /^[a-zA-Z0-9_\/.-]+$/
|
|
or &error( $text{'disk_edevice'} || 'Invalid device' );
|
|
$in{'device'} !~ /\.\./ or &error( $text{'disk_edevice'} || 'Invalid device' );
|
|
$in{'slice'} =~ /^\d+$/ or &error( $text{'slice_egone'} );
|
|
my ($disk) = grep { $_->{'device'} eq $in{'device'} } @disks;
|
|
$disk || &error( $text{'disk_egone'} );
|
|
my ($slice) = grep { $_->{'number'} eq $in{'slice'} } @{ $disk->{'slices'} };
|
|
$slice || &error( $text{'slice_egone'} );
|
|
|
|
# Apply changes
|
|
my $oldslice = {%$slice};
|
|
$in{'type'} =~ /^[a-zA-Z0-9._-]+$/
|
|
or &error( $text{'nslice_etype'} || 'Invalid slice type' );
|
|
$slice->{'type'} = $in{'type'};
|
|
$slice->{'active'} = $in{'active'} if ( defined $in{'active'} );
|
|
|
|
# Apply active flag for MBR disks via gpart set/unset when it changed
|
|
my $base = $disk->{'device'};
|
|
$base =~ s{^/dev/}{};
|
|
my $ds = get_disk_structure($base);
|
|
if ( is_using_gpart() && $ds && $ds->{'scheme'} && $ds->{'scheme'} !~ /GPT/i ) {
|
|
my $idx = _safe_uint( slice_number($slice) );
|
|
&error( $text{'slice_egone'} ) unless defined $idx;
|
|
if ( defined $oldslice->{'active'}
|
|
&& defined $slice->{'active'}
|
|
&& $oldslice->{'active'} != $slice->{'active'} )
|
|
{
|
|
my $cmd =
|
|
$slice->{'active'}
|
|
? "gpart set -a active -i $idx " . quote_path($base)
|
|
: "gpart unset -a active -i $idx " . quote_path($base);
|
|
my $out = backquote_command("$cmd 2>&1");
|
|
if ( $? != 0 ) {
|
|
&error( "Failed to change active flag: " . &html_escape($out) );
|
|
}
|
|
}
|
|
}
|
|
|
|
my $err = &modify_slice( $disk, $oldslice, $slice );
|
|
&error( &html_escape($err) ) if ($err);
|
|
|
|
&webmin_log( "modify", "slice", $slice->{'device'}, $slice );
|
|
my $url_device = &urlize( $in{'device'} );
|
|
&redirect("edit_disk.cgi?device=$url_device");
|