mirror of
https://github.com/webmin/webmin.git
synced 2026-10-29 06:31:04 +00:00
18d5344043
This patch fixes blank sections in action details when multiple actions are logged in one process.
74 lines
3.2 KiB
Perl
74 lines
3.2 KiB
Perl
#!/usr/bin/perl
|
|
# Check Webmin action details across consecutive audit entries.
|
|
use strict;
|
|
use warnings;
|
|
no warnings 'once';
|
|
use Test::More;
|
|
use File::Temp qw(tempdir);
|
|
use File::Path qw(make_path);
|
|
use File::Basename qw(dirname);
|
|
use Cwd qw(abs_path);
|
|
|
|
my $root = abs_path(dirname(__FILE__).'/..');
|
|
require "$root/web-lib-funcs.pl";
|
|
require "$root/t/test-lib.pl";
|
|
|
|
# Load the real log reader without initializing a host Webmin installation.
|
|
{
|
|
local $INC{'WebminCore.pm'} = 1;
|
|
no warnings 'redefine';
|
|
local *main::init_config = sub { };
|
|
local *main::get_module_acl = sub { return (); };
|
|
require "$root/webminlog/webminlog-lib.pl";
|
|
}
|
|
|
|
my $tmp = tempdir('webmin-audit-XXXXXX', DIR => '/tmp', CLEANUP => 1);
|
|
local $ENV{'WEBMIN_VAR'} = $tmp;
|
|
local $main::webmin_logfile = "$tmp/webmin.log";
|
|
local %main::gconfig = (log => 1, logfiles => 1);
|
|
local @main::locked_file_diff;
|
|
local $main::action_id_count = 0;
|
|
local $main::remote_user = 'fixture';
|
|
local $main::scriptname = 'fixture.cgi';
|
|
|
|
# Only host/module metadata is stubbed; serialization and parsing stay real.
|
|
no warnings 'redefine';
|
|
local *main::is_readonly_mode = sub { return 0; };
|
|
local *main::get_module_name = sub { return 'fixture'; };
|
|
local *main::get_module_variable = sub { return undef; };
|
|
local *main::get_module_info = sub { return (desc => 'Fixture'); };
|
|
|
|
# A submission with no details must leave no placeholder for completion.
|
|
main::webmin_log('submit', 'vm', 'fixture', {});
|
|
is(scalar(@main::locked_file_diff), 0, 'first action leaves an empty detail queue');
|
|
main::additional_log('exec', undef, 'libvirt API: fixture', 'safe input');
|
|
main::webmin_log('complete', 'vm', 'fixture', {});
|
|
is(scalar(@main::locked_file_diff), 0, 'completion clears all queued details');
|
|
main::webmin_log('another', 'vm', 'fixture', {});
|
|
my @lines = split(/\n/, read_text($main::webmin_logfile));
|
|
is(scalar(@lines), 3, 'all three action entries remain present');
|
|
my @actions = map { { id => (split(/\s+/, $_))[0] } } @lines;
|
|
is_deeply([main::list_diffs($actions[0])], [], 'submission has no details');
|
|
my @diffs = main::list_diffs($actions[1]);
|
|
is(scalar(@diffs), 1, 'completion has exactly one command detail');
|
|
is($diffs[0]->{'type'}, 'exec', 'the detail is the real command');
|
|
is($diffs[0]->{'diff'}, 'libvirt API: fixture', 'command data is preserved');
|
|
is($diffs[0]->{'input'}, 'safe input', 'command input remains attached');
|
|
is_deeply([main::list_diffs($actions[2])], [], 'later actions inherit no blank record');
|
|
|
|
# Existing empty records are ignored in both supported directory layouts.
|
|
for my $layout ('old', 'new') {
|
|
my $id = '1700000000.123.'.($layout eq 'old' ? '0' : '1');
|
|
my $base = $layout eq 'old' ? "$tmp/diffs/17000/$id" : "$tmp/diffs/$id";
|
|
make_path($base);
|
|
write_text("$base/0", " \n");
|
|
write_text("$base/1", "");
|
|
write_text("$base/2", "create /fixture/empty-file\n");
|
|
write_text("$base/3", "exec \nreal command");
|
|
my @records = main::list_diffs({id => $id});
|
|
is_deeply([map { $_->{'type'} } @records], [qw(create exec)],
|
|
"$layout layout skips invalid records but keeps empty file creation");
|
|
is($records[-1]->{'diff'}, 'real command', "$layout layout preserves following details");
|
|
}
|
|
done_testing();
|