33 Commits

Author SHA1 Message Date
Ilia Ross
0eaf0ef80d Fix redirect ports and linked-server WebSocket routing
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ Follow up on #2794 by making `redirect_port` work even when `redirect_host` is not set. Keep existing host precedence and correctly handle proxy headers, IPv6 addresses, default ports, and invalid port values.

ⓘ Fix linked-server by keeping the child URL recognizable to the parent, then generating the final WebSocket URL on the same host and port the browser is using. This keeps the connection working with the current Webmin session.
2026-07-15 20:38:41 +02:00
Ilia Ross
2fb4eb1721 Fix linked-server uploads over partial TLS writes
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
ⓘ Stream linked-server request bodies in bounded chunks, retry partial SSL writes with byte-safe offsets, detect incomplete forwarding, and add regression coverage.

https://github.com/webmin/webmin/issues/2784
2026-07-10 14:48:47 +02:00
Ilia Ross
6a1200bc03 Fix to pass request with header if required 2026-06-24 00:30:06 +02:00
Ilia Ross
7878ef466f Fix to expire abandoned linked websocket routes
ⓘ Use the existing scheduled websocket cleanup path for linked-server ws-link routes and expire unopened temporary routes after five minutes.

This limits how long credential-bearing proxy routes can remain in `miniserv.conf` while leaving active and normal websocket cleanup behavior unchanged.
2026-06-23 02:24:17 +02:00
Ilia Ross
c72d232e2f Fix to restrict Basic auth for websocket routes
ⓘ Require websocket routes to opt in with allow_basic_ws before Basic auth is accepted in session mode. Mark linked ws-link routes and no-cookie backend-session routes as allowed, while leaving normal session-backed routes unmarked.
2026-06-23 01:09:43 +02:00
Ilia Ross
6091f08e37 Fix comment 2026-06-22 23:01:58 +02:00
Ilia Ross
d42a6dc725 Fix parent-prefixed linked websocket rewrites
ⓘ Correct linked-server WebSocket proxy registration for parent-prefixed URLs, rebuild backend Host/Origin from the child server, and prevent duplicate rewrites from invalidating tokens.
2026-06-22 23:01:46 +02:00
Ilia Ross
45ca170c20 Add support to proxy linked-server WebSockets
This PR adds general WebSocket proxying for linked Webmin servers, allowing modules such as `xterm` to work when opened through `servers/link.cgi`.

As requested in https://github.com/webmin/webmin/issues/1866.
2026-06-22 16:19:33 +02:00
Ilia Ross
da18a16c84 Fix to require 2FA for RPC basic auth
Some checks failed
webmin.dev: webmin/webmin / build (push) Has been cancelled
+ improve remote auth errors
2026-04-15 22:36:40 +02:00
iliajie
d0ed6f944e Fix pointless warnings flooding error log 2022-06-30 13:08:38 +03:00
Ilia Rostovtsev
f69fa81e59 Fix to get safely using wrapper sub 2/2 2021-09-28 16:30:05 +03:00
Jamie Cameron
d6e50e7f41 Replace some old hard-coded 1024 byte buffers with the new function 2021-03-27 12:24:54 -07:00
Jamie Cameron
4f21870885 Fix perl warning 2020-10-17 13:58:48 -07:00
Jamie Cameron
85c9233298 Webmin-servers should also include webprefix 2019-02-04 11:25:25 -08:00
Jamie Cameron
132803dbcb Include webprefix in webmin paths 2019-02-04 11:11:07 -08:00
Jamie Cameron
3ff670abe1 Pass original webmin URL in via complete-webmin-path header 2019-02-03 14:13:59 -08:00
Jamie Cameron
7dfa97c6ca Pass original URL to remote server 2017-12-19 14:53:31 -08:00
Jamie Cameron
6243d45f3f Respect check-SSL setting 2017-05-16 12:25:24 -07:00
Jamie Cameron
49aa15c138 Use correct hostname in SNI for SSL requests https://virtualmin.com/node/51969 2017-04-29 14:59:03 -07:00
Jamie Cameron
7d42268b80 Properly pass through the referrer header http://virtualmin.com/node/36327 2015-02-27 18:20:18 -08:00
Jamie Cameron
c1ddc59034 Prevent double-adding of prefix https://sourceforge.net/p/webadmin/bugs/4465/ 2014-09-02 16:20:43 -07:00
Jamie Cameron
39c21f7429 Fixes need to allow access to file.jar with correct cookie http://sourceforge.net/p/webadmin/bugs/4437/ 2014-06-28 17:49:34 -07:00
Jamie Cameron
69f1bb1906 Fix validation errors
https://www.virtualmin.com/node/18939
2011-07-24 17:09:48 -07:00
Jamie Cameron
ab7d3796a2 Make webmin servers index module strict and warnings compliant 2011-04-28 13:39:59 -07:00
Jamie Cameron
748d8d8c86 Fixes for file manager access via webmin servers index 2010-05-20 23:18:35 -07:00
Jamie Cameron
f318ee575f Fix webprefix in form 2009-11-11 00:40:00 -08:00
Jamie Cameron
a82e5c8905 Handle systems with IP specified 2009-09-14 17:04:01 -07:00
Jamie Cameron
cbdc321cce Qualify remote_pass 2009-03-15 18:23:48 +00:00
Jamie Cameron
d85c542390 ui-lib conversion 2008-09-05 22:14:37 +00:00
Jamie Cameron
3ba0120186 Use Webmin port instead of always 80 when working out back link 2008-09-05 16:46:05 +00:00
Jamie Cameron
b76fbc2541 Fix up CSS when forwarding 2007-10-02 17:51:49 +00:00
Jamie Cameron
7ce51b0d11 Fixed up file manager module config link 2007-05-06 17:58:04 +00:00
Jamie Cameron
fc1c1b243f Initial checkin of Webmin 2007-04-12 20:24:50 +00:00