Ilia Ross
95cb100e8b
Merge pull request #2795 from macmon/fix/net-virtual-iface-deletion
...
MM-12032 Fix bond/VLAN/bridge not removed from active list on delete
2026-08-10 23:00:45 +02:00
Jamie Cameron
1031b59b9c
Ensure that option names or values that would break the config are never written
2026-08-04 10:08:46 -07:00
Mike Steinmetz
b050127ded
MM-12032 Fix bond/VLAN/bridge not removed from active list on delete
...
delete_bifcs.cgi and save_bifc.cgi only called deactivate_interface()
which brings the link down but never removes the virtual device.
Added destroy_interface_device() that does ip link delete for these.
Also had to add bridge creation (ip link add type bridge) because unlike
bond (81d44f8 ) and VLAN (7761066 ) that was still missing.
Other fixes in this commit:
debian-linux-lib.pl: bonding opts were single-element arrays causing
trailing spaces in /etc/network/interfaces on every save.
linux-lib.pl: ip link set up/down was gated behind a
bond/vlan/no-ifconfig check but ip addr add runs unconditionally - so
interfaces got an IP but stayed DOWN. Dropped the unnecessary guard.
2026-07-16 15:01:51 +02:00
Ilia Ross
0dbb5d2f89
Fix to share ifupdown parser with network detection
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
2026-06-23 15:00:32 +02:00
Jamie Cameron
9ba9bfd524
Merge branch 'master' of github.com:webmin/webmin
2025-03-06 19:03:47 -08:00
Jamie Cameron
6c5c5fa225
No need for modprobe since IPv6 is always in the kernel these days
...
https://github.com/webmin/webmin/issues/2432
2025-03-06 18:51:14 -08:00
Ilia Ross
495a196b2f
Fix type when adding addr
2025-03-06 14:22:49 +02:00
Jamie Cameron
50eb61b89e
Use the ip command instead of ifconfig
2025-03-05 20:56:42 -08:00
Jamie Cameron
919601d1c6
Preserve all post-up directives https://github.com/webmin/webmin/issues/2080
2024-01-28 16:26:32 -08:00
Ilia Ross
8665c5a725
Fix to include directory name, as glob result isn't readdir
...
https://forum.virtualmin.com/t/re-i-think-i-found-another-issue/123981/13
2023-12-17 15:37:19 +02:00
Ilia Ross
28e55d6774
Revert "What if /etc/network/interfaces is a directory https://forum.virtualmin.com/t/re-i-think-i-found-another-issue/123981 "
...
This reverts commit f2476e0a6d .
2023-12-17 15:35:09 +02:00
Jamie Cameron
f2476e0a6d
What if /etc/network/interfaces is a directory https://forum.virtualmin.com/t/re-i-think-i-found-another-issue/123981
2023-12-16 17:46:00 -08:00
Ilia Ross
18f3e1273f
Fix to use a new param to clear cache
2023-08-27 01:27:05 +03:00
Ilia Ross
8ced23d027
Fix to use a new way for clearing hostname cache
2023-08-26 21:26:03 +03:00
Jamie Cameron
2d900e88c8
Fix setting of default gateway https://github.com/webmin/webmin/issues/1960
2023-07-21 17:58:05 -07:00
Jamie Cameron
47043a41c5
Bridge support in Netplan
2023-04-16 20:29:19 -07:00
iliajie
286c5c6c51
Fix to revert incorrect fix beed9af645 (commitcomment-97277268)
2023-01-19 01:10:05 +02:00
Jamie Cameron
40bf45ae42
Fix variable name
2023-01-18 13:38:28 -08:00
Jamie Cameron
ed042f3a53
Include all debian config files in backups
2023-01-17 20:10:46 -08:00
iliajie
beed9af645
Fix to make sure that interface file is read only once
2023-01-16 22:42:43 +02:00
iliajie
087f1e7776
Fix to stop reading file on error
2023-01-16 22:07:00 +02:00
Jamie Cameron
c80eb8b6ae
Limit files in source-directory to same pattern debian uses
2023-01-16 11:01:20 -08:00
Jamie Cameron
3bdc75bb15
Track files already included to avoid include loops
2023-01-15 16:48:56 -08:00
Jamie Cameron
4fcb99b89a
source-directory may refer to a directory, not a pattern
2023-01-15 16:45:02 -08:00
iliajie
335136be14
Fix the loop bug when sourcing other configs ; remove stderr print
2023-01-16 00:22:22 +02:00
Jamie Cameron
be9b67de40
Fix editing and creation of IPv6 addresses
2022-12-03 22:07:02 -08:00
Jamie Cameron
b05a55e8c2
Complete support for editing interfaces in include files
2022-12-03 21:46:25 -08:00
Jamie Cameron
6673b314b2
Return line number and filename
2022-11-27 09:25:35 -08:00
iliajie
7c301848cb
Fix setting hostname for Debian and Ubuntu using hostnamectl
2022-10-05 22:32:29 +03:00
Jamie Cameron
2d5175d160
Ignore empty auto lines https://forum.virtualmin.com/t/ipv6-allocation-problem-on-debian-11/116723/7
2022-09-04 16:34:02 -07:00
luz paz
3e6142f098
Fix user and non-user facing typos
2022-06-29 07:17:11 -04:00
Jamie Cameron
9607b8e7d4
More code cleanups
2021-05-29 15:39:24 -07:00
Jamie Cameron
6d9d8dbe6a
Remove dependency on file::copy
2020-11-20 17:04:05 -08:00
Jamie Cameron
6dd4ff5dd0
Don't crash out if network config file is missing https://www.virtualmin.com/node/70222
2020-11-20 17:02:00 -08:00
Jamie Cameron
b593551c5f
For systems that don't need the broadcast address to be set in the config file, don't force it to be set https://github.com/webmin/webmin/pull/1278
2020-08-29 17:27:29 -07:00
Mike Steinmetz
edb9a43a89
MM-5521 escape inputs for some error messages
2020-04-23 15:19:44 +02:00
Ilia Rostovtsev
552264b2e6
Fix to use full hostname d12c69eee6 (commitcomment-37760661)
2020-03-11 12:39:12 +03:00
Jamie Cameron
3a84169fbe
Only new debian versions support vlan-raw-device
2019-04-27 11:59:15 -07:00
Jamie Cameron
64a344d98f
Add missing vlan-raw-device field https://github.com/webmin/webmin/issues/1047
2019-04-20 21:58:48 -07:00
Jamie Cameron
a9038e5076
Feedback system has been deleted, so remove special functions for it
2018-06-24 19:14:51 -07:00
Jamie Cameron
3e6231ea8f
Preserve bootup activation of firewall
2017-10-21 17:59:56 -07:00
Jamie Cameron
9dc7367dd6
Don't set bridge options that aren't defined
2017-06-24 15:39:12 -07:00
Jamie Cameron
cbec150213
Handle allow-hotplug lnine https://www.virtualmin.com/node/43038
2017-03-07 20:00:14 -08:00
Jamie Cameron
2a65b999ca
source line is not part of an interface https://www.virtualmin.com/node/43038
2016-10-16 15:22:59 -07:00
Jamie Cameron
c22919849e
Handle case where there are no nameservers https://sourceforge.net/p/webadmin/bugs/4761/
2016-05-26 16:14:30 -07:00
casparsmit
07772b29f6
Add common spanning tree tunables for bridges
2016-04-12 14:33:28 +02:00
casparsmit
1e95673391
Add common spanning tree tunables for bridges
2016-04-12 14:31:40 +02:00
Jamie Cameron
9189c1446a
Support configure a primary teaming interface, thanks to Caspar Smit
2016-04-05 21:40:44 -07:00
Jamie Cameron
f5ccedfe5b
Only save one file
2016-02-29 20:27:21 -08:00
Jamie Cameron
9d55206c69
Preserve IPv6 gateway http://virtualmin.com/node/38147
2015-10-02 22:39:00 -07:00