Ilia Ross
0d4c65ec04
Fix to create custom temp dirs after validation
2026-06-08 18:53:57 +02:00
Ilia Ross
d788bbe9c2
Fix to add a placeholder to tempdir field
2026-06-06 22:49:37 +02:00
Ilia Ross
9577737aeb
Fix to harden Webmin temp directory validation
...
https://github.com/webmin/webmin/pull/2749#discussion_r3368028469
2026-06-06 22:40:52 +02:00
Ilia Ross
501bddabc8
Fix to make temp dir perms message translatable
2026-06-05 22:13:48 +02:00
Ilia Ross
e434d0b138
Fix to use a variable for default perms
2026-06-05 22:06:49 +02:00
Ilia Ross
80da8d1915
Fix Webmin temp directory setup in Advanced Options
...
This fixes saving a custom Webmin temp directory from Webmin Configuration → Advanced Options.
Previously, setting a path like /var/webmin/tmp failed if the directory did not already exist. Users had to create it manually, and it was easy to end up with a bad parent directory such as /var/webmin with 0700, which made the saved temp path unusable.
This change makes Webmin handle the safe parts automatically:
- Creates missing temp directories and parents as 0755
- Validates existing parent directories are traversable by group/other
- Requires the final Webmin temp directory to be root-owned with mode 0755
- Allows shared temp dirs like /var/tmp when root-owned and 1777
- Shows a clear error when existing permissions must be fixed manually
2026-06-04 01:44:32 +02:00
Ilia Ross
f7b8ef379f
Fix terminal mode handling
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
ⓘ Avoid forcing xterm shell PTYs into IO::Stty raw/noecho mode, which can leave interactive shells with broken echo, line editing, and control-key behavior. Keep the existing stty logic for other PTY callers, but add an opt-out flag so xterm can let the shell manage terminal mode normally.
https://github.com/webmin/webmin/issues/2452
2026-06-03 18:43:53 +02:00
Jamie Cameron
758aa4a9f7
Merge pull request #2744 from webmin/dev/fix-stale-mb
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Fix stale mailbox entries after deleted or moved
2026-06-02 21:37:54 -07:00
Jamie Cameron
b2dc27c063
Merge pull request #2747 from webmin/dev/deb-nm
...
Fix to detect NetworkManager networking on Debian
2026-06-02 21:04:04 -07:00
Ilia Ross
8dfee31542
Fix not to hardcode colors
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-06-02 20:32:26 +02:00
Ilia Ross
a113309310
Add form grouped buttons API for responsive button
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-06-02 13:34:31 +02:00
Ilia Ross
6574373761
Fix to detect NetworkManager networking on Debian
...
ⓘ Prefer Netplan when Debian has Netplan YAML config, otherwise select the existing NetworkManager backend for Debian systems with saved NM connection profiles, with regression tests for backend selection.
https://github.com/webmin/webmin/issues/2559
2026-06-02 01:33:59 +02:00
Ilia Ross
b33b9fb0a0
Fix NetworkManager IPv6 DNS nameserver saving
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
https://github.com/webmin/webmin/issues/2559
2026-06-02 01:12:24 +02:00
Ilia Ross
8ef12b66d7
Add Lucky Mobile SMS carrier #2738
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
2026-06-01 01:00:11 +02:00
Ilia Ross
8df083b054
Fix Bell Canada SMS gateway domain #2739
2026-06-01 00:58:41 +02:00
Ilia Ross
435d2db4c6
Fix to use stronger defaults for generated keys
...
https://github.com/webmin/webmin/issues/2728
2026-05-31 20:42:33 +02:00
Ilia Ross
57b1ae3b18
Fix PHP-FPM monitor for EL /etc/php.ini
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
* Note: Map the shared EL PHP configuration file /etc/php.ini to the php-fpm boot action when that service exists, so the PHP-FPM status monitor can resolve current status on Rocky/RHEL systems.
root@rocky9-pro:~# php-fpm -i | grep "Loaded Configuration File"
Loaded Configuration File => /etc/php.ini
https://github.com/webmin/webmin/issues/2599
2026-05-31 16:14:38 +02:00
Ilia Ross
1eb4eb85a7
Fix to check empty mail files before opening
2026-05-30 21:22:38 +02:00
Jamie Cameron
fd79acd840
Properly quote and escape commands
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
2026-05-30 10:22:17 -07:00
Ilia Ross
034d0a09ce
Fix to skip unusable Maildir entries
...
* Note: Ignore zero-byte or unreadable Maildir files when listing messages, log skipped entries, and treat cached zero-byte reads as missing to avoid blank rows and inflated counts.
2026-05-30 16:13:55 +02:00
Ilia Ross
184887d365
Fix to use direct ACL checks in Kea DHCP module
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
*Note: Removes Kea-specific ACL wrapper helpers and switches ACL editor/runtime checks to standard Webmin handling with direct supplied ACL values and get_module_acl checks.
2026-05-30 02:53:48 +02:00
Ilia Ross
111dcb5f21
Fix to preserve submodule context in Virtualmin flows
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
https://forum.virtualmin.com/t/editing-server-block-configure-nginx-website-does-not-reload-nginx/137282/16?u=ilia
2026-05-30 02:29:04 +02:00
Ilia Ross
7cf7d14f53
Fix module desc
2026-05-29 22:25:42 +02:00
Ilia Ross
c68d03b211
Fix stale mailbox entries after deleted or moved
...
Refresh stale Maildir and sorted mailbox indexes when messages disappear, avoid rendering missing messages, and keep IMAP sort indexes in sync with mailbox count changes.
2026-05-29 21:12:58 +02:00
Ilia Ross
35a7459950
Fix temp file delete path validation
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
2026-05-29 16:59:05 +02:00
Jamie Cameron
5a9d2a2ca5
Merge pull request #2743 from webmin/dev/grub2
...
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Add GRUB 2 boot loader module
2026-05-28 13:17:00 -07:00
Ilia Ross
3bc901fcb1
Remove pull request code review workflow [no-build]
2026-05-28 21:57:16 +02:00
Ilia Ross
8d09b0724c
Fix to replace raw octal mode literals
2026-05-28 21:34:16 +02:00
Ilia Ross
7e8366bcb8
Fix to use direct ACL checks in GRUB 2 module
...
https://github.com/webmin/webmin/pull/2743#discussion_r3319948219
2026-05-28 21:21:56 +02:00
Ilia Ross
1335d05f7c
Fix to harden GRUB manual editor allowlist
2026-05-28 14:50:00 +02:00
Ilia Ross
010f15c2a5
Fix Perl critic
2026-05-28 14:33:09 +02:00
Ilia Ross
e10acfa3bb
Fix index page to implement view ACL better
2026-05-28 14:27:27 +02:00
Ilia Ross
440ddabef1
Fix ACL page sections
2026-05-28 14:26:45 +02:00
Ilia Ross
5232c07332
Fix to improve help text
2026-05-28 14:23:50 +02:00
Ilia Ross
53d0d053cf
Fix comment clarity
2026-05-28 12:42:57 +02:00
Ilia Ross
1d369dcddf
Revert "Fix theme"
...
This reverts commit 04efe99340 .
2026-05-28 12:19:24 +02:00
Ilia Ross
270e26172b
Fix theme
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
2026-05-28 02:21:57 +02:00
Ilia Ross
523d68c67a
Add GRUB 2 boot loader module
...
Adds a Webmin GRUB 2 module for inspecting boot entries, editing defaults, custom entries, themes, password protection, BLS-aware kernel options, safe menu regeneration, boot loader installation, manual config editing, status reporting, ACLs, backups, logging, and tests.
2026-05-28 02:20:53 +02:00
Ilia Ross
04efe99340
Fix theme
2026-05-28 01:39:07 +02:00
Jamie Cameron
5b58330071
Improve wording
...
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2726
2026-05-25 21:19:18 -07:00
Jamie Cameron
292d0d5a1f
Quote new DB name so that case is preserved
...
Close inactive / close-inactive (push) Has been cancelled
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
https://github.com/webmin/webmin/issues/2727
2026-05-24 13:43:53 -07:00
Jamie Cameron
c9ce2ed6d8
Merge branch 'master' of github.com:webmin/webmin
2026-05-24 13:15:34 -07:00
Jamie Cameron
9b404f8feb
Merge pull request #2741 from webmin/dev/postfix-tests-and-perlcritic
...
Postfix tests, perlcritic, strict/warnings, bugfixes
2026-05-24 13:10:38 -07:00
Jamie Cameron
197df80055
Merge branch 'master' of github.com:webmin/webmin
2026-05-24 13:09:03 -07:00
Jamie Cameron
6f4f85d33c
Add UI option to control when update email is sent
...
https://github.com/webmin/webmin/issues/2726
2026-05-24 13:08:58 -07:00
Jamie Cameron
73821b72b0
Merge pull request #2729 from swelljoe/web-lib-funcs-test-data-transforms
...
Tests / prove (push) Has been cancelled
Build / build (push) Has been cancelled
Close inactive / close-inactive (push) Has been cancelled
Add web-lib-funcs data transform tests
2026-05-23 19:25:00 -07:00
Joe Cooper
2d21c31ce2
Fix fatal 500 due to strict
2026-05-23 19:32:55 -05:00
Joe Cooper
afffe48e01
Fix double declarations from mechanical conversion
2026-05-23 18:58:15 -05:00
Joe Cooper
3ea7135cb2
s/$a/$alias/
2026-05-23 18:11:30 -05:00
Joe Cooper
e6eb1c4983
s/$a/$alias/
2026-05-23 18:10:58 -05:00