michael/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2026-06-09 22:40:23 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
25,180 Commits 6 Branches 91 Tags
dev/init-systemd-upgrade
Commit Graph

25180 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ilia Ross
14f90afb89 Fix to cache init mode for menu title selection 2026-06-07 16:55:20 +02:00
Ilia Ross
4e929b5fa2 Update module description and language files 2026-06-05 21:17:12 +02:00
Ilia Ross
5499d1c051 Fix to modernize init module configuration by boot system 2026-06-05 20:49:53 +02:00
Ilia Ross
750940e2f5 Fix to respect Unix user identity for systemd user unit defaults 2026-06-04 12:11:35 +02:00
Ilia Ross
d590fafd6c Fix indent and comment 2026-06-03 19:01:17 +02:00
Ilia Ross
a83db9f57d Add advanced systemd unit and user unit management 
This PR expands the "Bootup and Shutdown" module’s systemd support with creation and management for services, timers, sockets, paths and targets. It also adds user-scoped systemd units, linger controls, status and log actions, tabbed unit listings by type, and contextual help for the new options.

For user-scoped units, the implementation includes several safety guards because unit files live under user-controlled home directories:

- User accounts are validated with system account data before any user-unit operation is attempted.
- User unit names are restricted to known systemd unit suffixes and safe filename characters.
- User unit files are limited to direct children of `~/.config/systemd/user`.
- Symlinked `.config`, `.config/systemd`, and `.config/systemd/user` paths are rejected.
- User unit reads, writes, directory creation, and deletes are performed after dropping privileges to the target Unix user.
- File operations re-check paths close to the actual read/write/delete operation to reduce symlink race exposure.
- User unit create failures roll back half-created files when daemon reload fails.
- User-provided unit names, owners, paths, command output, and logs are HTML-escaped before display.
- systemctl, journalctl, and loginctl command arguments are shell-quoted before execution.
- User services omit `User=` and `Group=` directives because they already run under the selected user’s systemd manager.

Together, all these changes will allow Webmin admin to manage both system and user systemd units while keeping user-controlled home-directory paths from becoming root-level file read/write/delete exploits.

Implemented in response to these two issue requests  https://github.com/webmin/webmin/issues/2733 and https://github.com/webmin/webmin/issues/2734
 2026-06-02 20:32:03 +02:00
Ilia Ross
a113309310 Add form grouped buttons API for responsive button
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
2026-06-02 13:34:31 +02:00
Ilia Ross
b33b9fb0a0 Fix NetworkManager IPv6 DNS nameserver saving
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
https://github.com/webmin/webmin/issues/2559
 2026-06-02 01:12:24 +02:00
Ilia Ross
8ef12b66d7 Add Lucky Mobile SMS carrier #2738
Some checks failed
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
Tests / prove (push) Has been cancelled
Details
2026-06-01 01:00:11 +02:00
Ilia Ross
8df083b054 Fix Bell Canada SMS gateway domain #2739 2026-06-01 00:58:41 +02:00
Ilia Ross
435d2db4c6 Fix to use stronger defaults for generated keys 
https://github.com/webmin/webmin/issues/2728
 2026-05-31 20:42:33 +02:00
Ilia Ross
57b1ae3b18 Fix PHP-FPM monitor for EL /etc/php.ini
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
* Note: Map the shared EL PHP configuration file /etc/php.ini to the php-fpm boot action when that service exists, so the PHP-FPM status monitor can resolve current status on Rocky/RHEL systems.

root@rocky9-pro:~# php-fpm -i | grep "Loaded Configuration File"
Loaded Configuration File => /etc/php.ini

https://github.com/webmin/webmin/issues/2599
 2026-05-31 16:14:38 +02:00
Jamie Cameron
fd79acd840 Properly quote and escape commands
Some checks failed
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
Tests / prove (push) Has been cancelled
Details
2026-05-30 10:22:17 -07:00
Ilia Ross
184887d365 Fix to use direct ACL checks in Kea DHCP module
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
*Note: Removes Kea-specific ACL wrapper helpers and switches ACL editor/runtime checks to standard Webmin handling with direct supplied ACL values and get_module_acl checks.
 2026-05-30 02:53:48 +02:00
Ilia Ross
111dcb5f21 Fix to preserve submodule context in Virtualmin flows
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
https://forum.virtualmin.com/t/editing-server-block-configure-nginx-website-does-not-reload-nginx/137282/16?u=ilia
 2026-05-30 02:29:04 +02:00
Ilia Ross
7cf7d14f53 Fix module desc 2026-05-29 22:25:42 +02:00
Ilia Ross
35a7459950 Fix temp file delete path validation
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
2026-05-29 16:59:05 +02:00
Jamie Cameron
5a9d2a2ca5 Merge pull request #2743 from webmin/dev/grub2
Some checks failed
Close inactive / close-inactive (push) Has been cancelled
Details
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
Add GRUB 2 boot loader module
 2026-05-28 13:17:00 -07:00
Ilia Ross
3bc901fcb1 Remove pull request code review workflow [no-build] 2026-05-28 21:57:16 +02:00
Ilia Ross
8d09b0724c Fix to replace raw octal mode literals 2026-05-28 21:34:16 +02:00
Ilia Ross
7e8366bcb8 Fix to use direct ACL checks in GRUB 2 module 
https://github.com/webmin/webmin/pull/2743#discussion_r3319948219
 2026-05-28 21:21:56 +02:00
Ilia Ross
1335d05f7c Fix to harden GRUB manual editor allowlist 2026-05-28 14:50:00 +02:00
Ilia Ross
010f15c2a5 Fix Perl critic 2026-05-28 14:33:09 +02:00
Ilia Ross
e10acfa3bb Fix index page to implement view ACL better 2026-05-28 14:27:27 +02:00
Ilia Ross
440ddabef1 Fix ACL page sections 2026-05-28 14:26:45 +02:00
Ilia Ross
5232c07332 Fix to improve help text 2026-05-28 14:23:50 +02:00
Ilia Ross
53d0d053cf Fix comment clarity 2026-05-28 12:42:57 +02:00
Ilia Ross
1d369dcddf Revert "Fix theme" 
This reverts commit 04efe99340.
 2026-05-28 12:19:24 +02:00
Ilia Ross
270e26172b Fix theme
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details
2026-05-28 02:21:57 +02:00
Ilia Ross
523d68c67a Add GRUB 2 boot loader module 
Adds a Webmin GRUB 2 module for inspecting boot entries, editing defaults, custom entries, themes, password protection, BLS-aware kernel options, safe menu regeneration, boot loader installation, manual config editing, status reporting, ACLs, backups, logging, and tests.
 2026-05-28 02:20:53 +02:00
Ilia Ross
04efe99340 Fix theme 2026-05-28 01:39:07 +02:00
Jamie Cameron
5b58330071 Improve wording
Some checks failed
Close inactive / close-inactive (push) Has been cancelled
Details
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
https://github.com/webmin/webmin/issues/2726
 2026-05-25 21:19:18 -07:00
Jamie Cameron
292d0d5a1f Quote new DB name so that case is preserved
Some checks failed
Close inactive / close-inactive (push) Has been cancelled
Details
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
https://github.com/webmin/webmin/issues/2727
 2026-05-24 13:43:53 -07:00
Jamie Cameron
c9ce2ed6d8 Merge branch 'master' of github.com:webmin/webmin 2026-05-24 13:15:34 -07:00
Jamie Cameron
9b404f8feb Merge pull request #2741 from webmin/dev/postfix-tests-and-perlcritic 
Postfix tests, perlcritic, strict/warnings, bugfixes
 2026-05-24 13:10:38 -07:00
Jamie Cameron
197df80055 Merge branch 'master' of github.com:webmin/webmin 2026-05-24 13:09:03 -07:00
Jamie Cameron
6f4f85d33c Add UI option to control when update email is sent 
https://github.com/webmin/webmin/issues/2726
 2026-05-24 13:08:58 -07:00
Jamie Cameron
73821b72b0 Merge pull request #2729 from swelljoe/web-lib-funcs-test-data-transforms
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Close inactive / close-inactive (push) Has been cancelled
Details 
Add web-lib-funcs data transform tests
 2026-05-23 19:25:00 -07:00
Joe Cooper
2d21c31ce2 Fix fatal 500 due to strict 2026-05-23 19:32:55 -05:00
Joe Cooper
afffe48e01 Fix double declarations from mechanical conversion 2026-05-23 18:58:15 -05:00
Joe Cooper
3ea7135cb2 s/$a/$alias/ 2026-05-23 18:11:30 -05:00
Joe Cooper
e6eb1c4983 s/$a/$alias/ 2026-05-23 18:10:58 -05:00
Jamie Cameron
3780c1a9b5 Merge pull request #2730 from swelljoe/xterm-tests 
xterm unit tests and minor refactor for testing
 2026-05-23 16:05:54 -07:00
Joe Cooper
675c830e84 Postfix tests, perlcritic, bugfixes 2026-05-23 17:15:31 -05:00
Jamie Cameron
74393cd312 Merge pull request #2737 from webmin/dev/bind8-tests-and-perlcritic
Some checks failed
Tests / prove (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details 
Add bind8 tests, perlcritic, minor fixes
 2026-05-23 08:43:32 -07:00
Joe Cooper
09bdd71c8c Fix the opendir fix for list context 2026-05-23 01:15:14 -05:00
Joe Cooper
1e77343482 Don't use temp var for eval result, not idiomatic 2026-05-23 01:04:05 -05:00
Joe Cooper
4b33d8bc3f catch failed dnssec-tools import 2026-05-23 00:59:53 -05:00
Joe Cooper
4bb0cda0b5 Fix missing error check on opendir 2026-05-23 00:49:41 -05:00
Joe Cooper
87536b42a1 Fix date_serial race in test 2026-05-23 00:18:57 -05:00