Commit Graph

26 Commits

Author SHA1 Message Date
Ilia Ross
9bad05a55d Fix XSS across MySQL database pages 2026-10-22 19:31:58 +02:00
Jamie Cameron
c76255be5f Escape DB name in cron command 2026-10-18 11:32:37 -07:00
Ilia Ross
0843de05cb Fix MySQL backup privilege boundary bypasses
This PR fixes privilege boundary bypasses in MySQL database backups.

It restricts custom dump parameters and shared backup settings to users with unrestricted root backup access.

It also prevents database names, table names, and compatibility values from being interpreted as dump options.

The changes include focused tests and passed live regression testing with MySQL and MariaDB.
2026-10-16 03:08:07 +02:00
Jamie Cameron
1c7781299d Merge branch 'master' of github.com:webmin/webmin 2026-10-14 20:41:34 -07:00
Jamie Cameron
6c674def60 Use standard function to split commands 2026-10-14 20:41:28 -07:00
Ilia Ross
b5ce991eb3 Fix non-root MySQL backup hooks
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
This patch addresses non-root MySQL backup hooks remaining unreachable after original patch https://github.com/webmin/webmin/commit/6873c65.

Now it makes before and after commands available when backups run as a configured non-root Unix user.

Root hook execution remains limited to cron-eligible Webmin users, and Usermin remains excluded from backup hooks.
2026-10-13 16:40:45 +02:00
Jamie Cameron
384913506f Add function to get the DB character set 2023-10-11 21:02:17 -07:00
Scott Lucas
ea91c26d70 Add custom mysql backup parameters option 2021-08-12 09:29:02 +01:00
Ilia Rostovtsev
0585f34fec Set default charset if possible 2020-03-01 02:58:11 +03:00
Jamie Cameron
8de9921320 Fix display and date subs in prefix field https://sourceforge.net/p/webadmin/bugs/5325/ 2019-11-27 13:12:11 -08:00
Jamie Cameron
04603f1604 Handle DB prefix properly https://github.com/webmin/webmin/issues/1044 2019-04-12 16:27:57 -07:00
Jamie Cameron
eededaf844 Include full version in msql_version, and actually do version comparisons properly 2019-02-18 16:44:21 -08:00
Jamie Cameron
e37b56f8ee Don't show option that can't be used 2018-12-24 12:48:03 -08:00
yangfl
0f9fb77369 Fix typo 2017-11-08 16:43:37 +08:00
Jamie Cameron
36048fe4cd Option to download mysql backup 2016-08-20 18:46:34 -07:00
Jamie Cameron
31060b6d06 Allow mysqldump command to have args http://virtualmin.com/node/35318 2014-11-19 22:06:52 -08:00
Jamie Cameron
74ddbdc631 Fix UI when there are no tables 2014-05-12 09:20:45 -07:00
Jamie Cameron
204590630a Some conversions to new cron times API 2014-02-02 11:04:03 -08:00
Jamie Cameron
07e337a11e Make all backlinks to DB list go to Virtualmin 2012-07-28 17:27:22 -07:00
Jamie Cameron
bdefd98b3c Add backup option for --quick flag 2012-01-13 14:00:10 -08:00
Jamie Cameron
892c95b056 Option to send backup via email 2011-11-29 15:49:33 -08:00
Jamie Cameron
8b63c04ac9 Single-transaction backup option 2010-02-01 15:44:43 -08:00
Jamie Cameron
4003ce6203 Fix spacing 2009-02-26 19:26:19 +00:00
Jamie Cameron
e38d8596d6 Fixed small typos 2007-09-29 22:35:14 +00:00
Jamie Cameron
bc57854285 Added option to create destination directory, re-designed backup form 2007-09-29 22:16:17 +00:00
Jamie Cameron
fc1c1b243f Initial checkin of Webmin 2007-04-12 20:24:50 +00:00