Commit Graph

29 Commits

Author SHA1 Message Date
Ilia Ross
9bad05a55d Fix XSS across MySQL database pages 2026-10-22 19:31:58 +02:00
Ilia Ross
aa82e2ebd5 Fix escaping too when updating MySQL backup schedules
c76255be5f
2026-10-19 15:44:25 +02:00
Jamie Cameron
c76255be5f Escape DB name in cron command 2026-10-18 11:32:37 -07:00
Ilia Ross
0843de05cb Fix MySQL backup privilege boundary bypasses
This PR fixes privilege boundary bypasses in MySQL database backups.

It restricts custom dump parameters and shared backup settings to users with unrestricted root backup access.

It also prevents database names, table names, and compatibility values from being interpreted as dump options.

The changes include focused tests and passed live regression testing with MySQL and MariaDB.
2026-10-16 03:08:07 +02:00
Ilia Ross
b5ce991eb3 Fix non-root MySQL backup hooks
Some checks failed
Tests / prove (push) Has been cancelled
Package and upload artifacts / build (push) Has been cancelled
This patch addresses non-root MySQL backup hooks remaining unreachable after original patch https://github.com/webmin/webmin/commit/6873c65.

Now it makes before and after commands available when backups run as a configured non-root Unix user.

Root hook execution remains limited to cron-eligible Webmin users, and Usermin remains excluded from backup hooks.
2026-10-13 16:40:45 +02:00
Jamie Cameron
6873c65c42 If MySQL backups are being done as a non-root user, also run pre and post backup commands as that user 2026-10-10 15:37:12 -07:00
Ilia Rostovtsev
6c9a24a826 Use undef instead of 0 #1513 2021-08-23 18:38:04 +03:00
Scott Lucas
480c81f272 Fix Virtualmin breaking mysql backup_database force parameter 2021-08-23 14:40:24 +01:00
Scott Lucas
ea91c26d70 Add custom mysql backup parameters option 2021-08-12 09:29:02 +01:00
Jamie Cameron
a2dc3f7124 Switch all calls to open() to explicitly open for read 2020-03-14 17:20:54 -07:00
Jamie Cameron
8de9921320 Fix display and date subs in prefix field https://sourceforge.net/p/webadmin/bugs/5325/ 2019-11-27 13:12:11 -08:00
Jamie Cameron
04603f1604 Handle DB prefix properly https://github.com/webmin/webmin/issues/1044 2019-04-12 16:27:57 -07:00
Jamie Cameron
2643b754ac Set the correct MIME type and filename https://github.com/webmin/webmin/issues/726 2017-12-21 16:48:05 -08:00
Jamie Cameron
68ad6e6e12 Add check for backup to a directory https://www.virtualmin.com/node/53291 2017-08-27 15:57:26 -07:00
Jamie Cameron
2ba05ab405 Don't delete temp file for download if it was pre-created in /tmp/.webmin https://virtualmin.com/node/52315 2017-06-02 15:31:51 -07:00
Jamie Cameron
837d98d6bc Fix case where a non-root user is downloading in the browser https://virtualmin.com/node/44972 2016-12-22 21:36:36 -08:00
Jamie Cameron
9af0e28e02 Suppress message when backing up to browser https://www.virtualmin.com/node/43291 2016-11-02 22:09:52 -07:00
Jamie Cameron
36048fe4cd Option to download mysql backup 2016-08-20 18:46:34 -07:00
Jamie Cameron
c2c8c2a5f3 Backup button should not save scheduled config 2015-10-18 21:55:06 -07:00
Jamie Cameron
60f498345a remove useles library 2014-09-06 10:58:52 -07:00
Jamie Cameron
a07f139802 Fix backlinks in PostgreSQL module to go to Webmin 2012-07-28 17:45:15 -07:00
Jamie Cameron
bdefd98b3c Add backup option for --quick flag 2012-01-13 14:00:10 -08:00
Jamie Cameron
892c95b056 Option to send backup via email 2011-11-29 15:49:33 -08:00
Jamie Cameron
c0a31c3bd0 Long line fixes 2011-03-27 18:46:03 -07:00
Jamie Cameron
8b63c04ac9 Single-transaction backup option 2010-02-01 15:44:43 -08:00
Jamie Cameron
049cc39b0d Exclude information_schema from all-DB backups 2009-10-07 12:04:44 -07:00
Jamie Cameron
bd2b2424c4 Remove useless code 2009-07-02 23:20:04 +00:00
Jamie Cameron
bc57854285 Added option to create destination directory, re-designed backup form 2007-09-29 22:16:17 +00:00
Jamie Cameron
fc1c1b243f Initial checkin of Webmin 2007-04-12 20:24:50 +00:00