diff --git a/squid/always.cgi b/squid/always.cgi index f2fd3b6d0..3cf55d660 100755 --- a/squid/always.cgi +++ b/squid/always.cgi @@ -2,11 +2,15 @@ # always.cgi # A form for editing or creating http_access directives +use strict; +use warnings; +our (%text, %in, %access, $squid_version, %config); require './squid-lib.pl'; $access{'othercaches'} || &error($text{'eicp_ecannot'}); &ReadParse(); -$conf = &get_config(); +my $conf = &get_config(); +my @always; if (!defined($in{'index'})) { &ui_print_header(undef, $text{'always_create'}, "", undef, 0, 0, 0, &restart_button()); @@ -17,47 +21,46 @@ else { @always = @{$conf->[$in{'index'}]->{'values'}}; } -print "
\n"; +print &ui_table_end(); +print &ui_form_end([ [ undef, $text{'buttsave'} ], + @always ? ( [ 'delete', $text{'buttdel'} ] ) : ( ) ]); -&ui_print_footer("edit_acl.cgi", $text{'ahttp_return'}); +&ui_print_footer("edit_icp.cgi", $text{'ahttp_return'}); diff --git a/squid/always_save.cgi b/squid/always_save.cgi index 2ec1a2822..4e201bf22 100755 --- a/squid/always_save.cgi +++ b/squid/always_save.cgi @@ -2,13 +2,17 @@ # always_save.cgi # Save or delete an always_direct directive +use strict; +use warnings; +our (%text, %in, %access, $squid_version, %config); require './squid-lib.pl'; $access{'othercaches'} || &error($text{'eicp_ecannot'}); &ReadParse(); &lock_file($config{'squid_conf'}); -$conf = &get_config(); +my $conf = &get_config(); -@always = &find_config("always_direct", $conf); +my @always = &find_config("always_direct", $conf); +my $always; if (defined($in{'index'})) { $always = $conf->[$in{'index'}]; } @@ -18,10 +22,10 @@ if ($in{'delete'}) { } else { # update or create - @vals = ( $in{'action'} ); - foreach $y (split(/\0/, $in{'yes'})) { push(@vals, $y); } - foreach $n (split(/\0/, $in{'no'})) { push(@vals, "!$n"); } - $newalways = { 'name' => 'always_direct', 'values' => \@vals }; + my @vals = ( $in{'action'} ); + foreach my $y (split(/\0/, $in{'yes'})) { push(@vals, $y); } + foreach my $n (split(/\0/, $in{'no'})) { push(@vals, "!$n"); } + my $newalways = { 'name' => 'always_direct', 'values' => \@vals }; if ($always) { splice(@always, &indexof($always, @always), 1, $newalways); } else { push(@always, $newalways); } @@ -29,6 +33,6 @@ else { &save_directive($conf, "always_direct", \@always); &flush_file_lines(); &unlock_file($config{'squid_conf'}); -&webmin_log($in{'delete'} ? 'delete' : $always ? 'modify' : 'create', "always"); +&webmin_log($in{'delete'} ? 'delete' : $always ? 'modify' : 'create', 'always'); &redirect("edit_icp.cgi"); diff --git a/squid/never.cgi b/squid/never.cgi index 0f7ed1d88..224b62b4f 100755 --- a/squid/never.cgi +++ b/squid/never.cgi @@ -2,11 +2,15 @@ # never.cgi # A form for editing or creating http_access directives +use strict; +use warnings; +our (%text, %in, %access, $squid_version, %config); require './squid-lib.pl'; $access{'othercaches'} || &error($text{'eicp_ecannot'}); &ReadParse(); -$conf = &get_config(); +my $conf = &get_config(); +my @never; if (!defined($in{'index'})) { &ui_print_header(undef, $text{'never_create'}, "", undef, 0, 0, 0, &restart_button()); @@ -17,47 +21,46 @@ else { @never = @{$conf->[$in{'index'}]->{'values'}}; } -print "\n"; +print &ui_table_end(); +print &ui_form_end([ [ undef, $text{'buttsave'} ], + @never ? ( [ 'delete', $text{'buttdel'} ] ) : ( ) ]); -&ui_print_footer("edit_acl.cgi", $text{'ahttp_return'}); +&ui_print_footer("edit_icp.cgi", $text{'ahttp_return'}); diff --git a/squid/never_save.cgi b/squid/never_save.cgi index 76b22b508..77b06402b 100755 --- a/squid/never_save.cgi +++ b/squid/never_save.cgi @@ -2,13 +2,17 @@ # never_save.cgi # Save or delete an never_direct directive +use strict; +use warnings; +our (%text, %in, %access, $squid_version, %config); require './squid-lib.pl'; $access{'othercaches'} || &error($text{'eicp_ecannot'}); &ReadParse(); &lock_file($config{'squid_conf'}); -$conf = &get_config(); +my $conf = &get_config(); -@never = &find_config("never_direct", $conf); +my @never = &find_config("never_direct", $conf); +my $never; if (defined($in{'index'})) { $never = $conf->[$in{'index'}]; } @@ -18,10 +22,10 @@ if ($in{'delete'}) { } else { # update or create - @vals = ( $in{'action'} ); - foreach $y (split(/\0/, $in{'yes'})) { push(@vals, $y); } - foreach $n (split(/\0/, $in{'no'})) { push(@vals, "!$n"); } - $newnever = { 'name' => 'never_direct', 'values' => \@vals }; + my @vals = ( $in{'action'} ); + foreach my $y (split(/\0/, $in{'yes'})) { push(@vals, $y); } + foreach my $n (split(/\0/, $in{'no'})) { push(@vals, "!$n"); } + my $newnever = { 'name' => 'never_direct', 'values' => \@vals }; if ($never) { splice(@never, &indexof($never, @never), 1, $newnever); } else { push(@never, $newnever); } @@ -29,6 +33,6 @@ else { &save_directive($conf, "never_direct", \@never); &flush_file_lines(); &unlock_file($config{'squid_conf'}); -&webmin_log($in{'delete'} ? 'delete' : $never ? 'modify' : 'create', "never"); +&webmin_log($in{'delete'} ? 'delete' : $never ? 'modify' : 'create', 'never'); &redirect("edit_icp.cgi");