From d54c1a22e0696595e5fcffae3fd2975c104ad2a5 Mon Sep 17 00:00:00 2001
From: Joe Cooper <joe@virtualmin.com>
Date: Wed, 1 Jun 2016 17:07:48 -0700
Subject: [PATCH] strict/warn

---
 bind8/hint_form.cgi | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/bind8/hint_form.cgi b/bind8/hint_form.cgi
index 5907a21d1..ee68077ec 100755
--- a/bind8/hint_form.cgi
+++ b/bind8/hint_form.cgi
@@ -1,6 +1,9 @@
 #!/usr/local/bin/perl
 # hint_form.cgi
 # Display options for creating a new root zone
+use strict;
+use warnings;
+our (%access, %text, %config);
 
 require './bind8-lib.pl';
 $access{'master'} || &error($text{'hcreate_ecannot'});
@@ -8,16 +11,20 @@ $access{'ro'} && &error($text{'master_ero'});
 &ui_print_header(undef, $text{'hcreate_title'}, "",
 		 undef, undef, undef, undef, &restart_links());
 
-$conf = &get_config();
-@views = &find("view", $conf);
-foreach $v (@views) {
-	local @vz = &find("zone", $v->{'members'});
+my $conf = &get_config();
+my @views = &find("view", $conf);
+my %view;
+my @zones;
+foreach my $v (@views) {
+	my @vz = &find("zone", $v->{'members'});
 	map { $view{$_} = $v } @vz;
 	push(@zones, @vz);
 	}
 push(@zones, &find("zone", $conf));
-foreach $z (@zones) {
-	$tv = &find_value("type", $z->{'members'});
+my $file;
+my %hashint;
+foreach my $z (@zones) {
+	my $tv = &find_value("type", $z->{'members'});
 	if ($tv eq 'hint') {
 		$file = &find_value("file", $z->{'members'});
 		$hashint{$view{$z}}++;
@@ -43,7 +50,7 @@ print &ui_table_row($text{'hcreate_real'},
 # Create in view
 @views = grep { &can_edit_view($_) && !$hashint{$_} } @views;
 if (@views) {
-	($defview) = grep { lc($_->{'values'}->[0]) eq
+	my ($defview) = grep { lc($_->{'values'}->[0]) eq
 			    lc($config{'default_view'}) } @views;
 	print &ui_table_row($text{'mcreate_view'},
 		&ui_select("view", $defview ? $defview->{'index'} : undef,