From acdc65c5d72a2934cb373863a44e199b980709d5 Mon Sep 17 00:00:00 2001
From: Jamie Cameron <jcameron@webmin.com>
Date: Thu, 10 Apr 2025 21:39:48 -0700
Subject: [PATCH] Code cleanups

---
 acl/index.cgi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/acl/index.cgi b/acl/index.cgi
index a69377a75..ff55b443e 100755
--- a/acl/index.cgi
+++ b/acl/index.cgi
@@ -280,16 +280,18 @@ print &ui_links_row(\@rowlinks);
 }
 
 # user_link(user, cgi, param)
+# Return HTML for a link to edit one user
 sub user_link
 {
-my $lck = $_[0]->{'pass'} =~ /^\!/ ? 1 : 0;
-my $ro = $_[0]->{'readonly'};
-return &ui_checkbox("d", $_[0]->{'name'}, "", 0).
+my ($user, $cgi, $param) = @_;
+my $lck = $user->{'pass'} =~ /^\!/ ? 1 : 0;
+my $ro = $user->{'readonly'};
+return &ui_checkbox("d", $user->{'name'}, "", 0).
        ($lck ? "<i>" : "").
        ($ro ? "<b>" : "").
-       ui_link("$_[1]?$_[2]=".&urlize($_[0]->{'name'}),
-	           $_[0]->{'name'}).
-       ($_[0]->{'twofactor_id'} ? "*" : "").
+       &ui_link("$cgi?$param=".&urlize($user->{'name'}),
+	        $user->{'name'}).
+       ($user->{'twofactor_id'} ? "*" : "").
        ($ro ? "</b>" : "").
        ($lck ? "</i>" : "");
 }