From 89bc90d3a74a9a2c5363ee80f5aece3b710e4182 Mon Sep 17 00:00:00 2001 From: Jamie Cameron Date: Thu, 23 Feb 2023 18:36:12 -0800 Subject: [PATCH] Don't re-create record if already OK --- webmin/letsencrypt-dns.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/webmin/letsencrypt-dns.pl b/webmin/letsencrypt-dns.pl index 95d0cd302..8ba8e3bb1 100755 --- a/webmin/letsencrypt-dns.pl +++ b/webmin/letsencrypt-dns.pl @@ -45,10 +45,14 @@ else { die "No DNS zone named $dname found"; } -# Remove any existing record +# Remove any existing record, if different my ($r) = grep { $_->{'name'} eq "_acme-challenge.".$dname."." } @$recs; if ($r) { - if ($wapi) { + if ($r->{'values'}->[0] eq $val) { + # Record is already fine! + exit(0); + } + elsif ($wapi) { &virtual_server::delete_dns_record($recs, $file, $r); } else {