From 4f9cba0b3378be57299de4a9fe8a986430e5a5ce Mon Sep 17 00:00:00 2001 From: Ilia Rostovtsev Date: Tue, 1 Feb 2022 22:44:00 +0300 Subject: [PATCH] Fix to drop beloved line separators for Apache config formatter --- apache/apache-lib.pl | 56 -------------------------------------------- 1 file changed, 56 deletions(-) diff --git a/apache/apache-lib.pl b/apache/apache-lib.pl index 9b8ccf671..2863b90b2 100755 --- a/apache/apache-lib.pl +++ b/apache/apache-lib.pl @@ -2168,23 +2168,6 @@ foreach my $l (@{$conf_lref}) { if ($conf_block_opening == $conf_block_closing) { my $conf_lvl = 0; - my $conf_prev_line; - my $conf_curr_line; - my $conf_virthost; - my @confs_separate = - ( - 'Protocols', - 'SuexecUserGroup', - 'ServerName', - 'ScriptAlias', - 'DocumentRoot', - 'ErrorLog', - 'DirectoryIndex', - 'Alias', - 'RewriteEngine', - 'Fcgid', - 'SSL', - ); foreach my $l (@{$conf_lref}) { my $indent_current = $indent x $conf_lvl; @@ -2194,59 +2177,20 @@ if ($conf_block_opening == $conf_block_closing) { # Indent up next line if a new block if ($l =~ /(<[a-zA-Z]+).*>/) { $conf_lvl++; - if ($l =~ /(/) { - $conf_virthost++; - } } # Indent down next line if a closing block if ($l =~ /(<\/[a-zA-Z]+).*>/) { $conf_lvl--; - if ($l =~ /(<\/VirtualHost).*>/) { - $conf_virthost--; - } - # Change current indent right now as it is a closing block $indent_current = $indent x $conf_lvl; } } - # Store previous and current lines - $conf_prev_line = &trim($conf_curr_line); - $conf_curr_line = &trim($l); - # Replace beginning spaces with needed indent $l =~ s/^\s*/$indent_current/ if($l); - - - # Check if current line needs to be prepended - # with a new line for better readability - if (!$config{'format_config_lines'}) { - # Allow new line insertion only inside of VirtualHost block - if ($conf_virthost) { - # If current line is not part of a commented block - if ($conf_curr_line !~ /^\s*#/) { - # If previous line is not already an empty line - if (length($conf_prev_line)) { - # If the previous line was something - # we want to take a break before and after match - if (grep {$conf_curr_line =~ /^$_/} @confs_separate && - grep {$conf_prev_line !~ /^$_/} @confs_separate) { - # If not the first directive in VirtualHost - if($conf_prev_line !~ /(^/) { - $l = "\n$l" - } - } - # If current is opening block - elsif ($conf_curr_line =~ /(^<[a-zA-Z]+).*>/) { - $l = "\n$l"; - } - } - } - } - } } } }