diff --git a/exports/CHANGELOG b/exports/CHANGELOG index dc49803d8..1ce0ddb31 100644 --- a/exports/CHANGELOG +++ b/exports/CHANGELOG @@ -3,3 +3,6 @@ Added an option to determine if NFS writes to an export are immediately written Added support for NFS version 4, thanks to code contributed by Frederic Jolly. ---- Changes since 1.270 ---- Added checkboxes and a button for deleting, disabling and enabling multiple exports at once. +---- Changes since 1.690 ---- +Re-wrote the UI to use the standard Webmin UI library for a consistent look, and converted all code to be Perl strict and warnings compliant. +Separated the pages for creating NFSv3 and v4 exports, to simplify the UI and make security options more understandable. diff --git a/exports/edit_export.cgi b/exports/edit_export.cgi index caadb0e06..af8bd625c 100755 --- a/exports/edit_export.cgi +++ b/exports/edit_export.cgi @@ -1,7 +1,6 @@ #!/usr/local/bin/perl # edit_export.cgi # Allow editing of one export to a client -# XXX security options use strict; use warnings; @@ -9,14 +8,14 @@ require './exports-lib.pl'; our (%text, %in, %gconfig); &ReadParse(); -my $via_pfs = 0; my $nfsv = $in{'ver'} || &nfs_max_version("localhost"); my ($exp, %opts); if ($in{'new'}) { &ui_print_header(undef, $text{'create_title'}, "", "create_export"); - $via_pfs = $nfsv == 4 ? 1 : 0; - $exp->{"pfs"} = "/export"; + if ($nfsv >= 4) { + $exp->{"pfs"} = "/export"; + } $exp->{'active'} = 1; } else { @@ -42,24 +41,21 @@ print &ui_hidden("idx", $in{'idx'}); print &ui_hidden("ver", $in{'ver'}); print &ui_table_start($text{'edit_details'}, "width=100%", 2); -# Show NFS pseudofilesystem (NFSv4) -if ($nfsv == 4) { - print "