From 3eb49c27ed79af58b6839773312d8ac0d2de5c78 Mon Sep 17 00:00:00 2001 From: Joe Cooper Date: Fri, 3 Jun 2016 00:58:01 -0700 Subject: [PATCH] strict/warn --- bind8/save_slave.cgi | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/bind8/save_slave.cgi b/bind8/save_slave.cgi index 70d1273e1..9912c1a2c 100755 --- a/bind8/save_slave.cgi +++ b/bind8/save_slave.cgi @@ -1,18 +1,22 @@ #!/usr/local/bin/perl # save_slave.cgi # Save changes to slave zone options in named.conf +use strict; +use warnings; +our (%access, %text, %in); require './bind8-lib.pl'; &ReadParse(); &error_setup($text{'slave_err'}); -$zone = &get_zone_name_or_error($in{'zone'}, $in{'view'}); -$z = &zone_to_config($zone); -$zconf = $z->{'members'}; -$dom = $zone->{'name'}; +my $zone = &get_zone_name_or_error($in{'zone'}, $in{'view'}); +my $z = &zone_to_config($zone); +my $zconf = $z->{'members'}; +my $dom = $zone->{'name'}; +my $conf = &get_config(); &can_edit_zone($zone) || &error($text{'master_ecannot'}); -$indent = $zone->{'view'} ? 2 : 1; +my $indent = $zone->{'view'} ? 2 : 1; $access{'ro'} && &error($text{'master_ero'}); $access{'opts'} || &error($text{'master_eoptscannot'}); @@ -40,7 +44,7 @@ return $_[0] =~ /^\d+$/ ? undef : &text('slave_emax', $_[0]); sub file_check { return $text{'slave_efile'} if ($_[0] !~ /\S/); -local $file = $_[0]; +my $file = $_[0]; if ($_[0] !~ /^\//) { $file = &base_directory($conf)."/".$file; }